Enable support for both Lua 5.1 and 5.2 by let user specify the Lua
pkg-config package name. By default it will use 'lua' and try figure
out which version it is.
Signed-off-by: Natanael Copa
---
configure.ac| 36 +++-
src/lua-lxc/Makefile.am | 4 ++--
So we avoid running os.execute
Signed-off-by: Natanael Copa
---
src/lua-lxc/core.c | 9 +
src/lxc/lxc-top| 12 ++--
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/src/lua-lxc/core.c b/src/lua-lxc/core.c
index d404707..504e147 100644
--- a/src/lua-lxc/core.c
Hi Dwight,
do you have time to review/ack these (3, so far) lua patches?
(I probably don't know enough to do so)
thanks,
-serge
Quoting Natanael Copa (nc...@alpinelinux.org):
> Adjust code for Lua 5.2 and keep compatibility with Lua 5.1.
>
> We also fix a bug in the parsing of /proc/mounts whi
Instead of popen and run external executable dirname we implement a
dirname in C in the core module.
We also remove the unused basename function.
Signed-off-by: Natanael Copa
---
src/lua-lxc/core.c | 8
src/lua-lxc/lxc.lua | 18 +-
2 files changed, 9 insertions(+), 17
On Thu, 5 Sep 2013 08:11:57 -0500
Serge Hallyn wrote:
> Hi Dwight,
>
> do you have time to review/ack these (3, so far) lua patches?
>
> (I probably don't know enough to do so)
Yeah I've taken a look. I had already done an update similar to the
first two and was just getting ready to post afte
On Thu, 5 Sep 2013 08:11:57 -0500
Serge Hallyn wrote:
> Hi Dwight,
>
> do you have time to review/ack these (3, so far) lua patches?
I send 2 more patches, to get rid of fork/exec. (os.execute and io.popen)
They should all be available from https://github.com/ncopa/lxc
Thanks!
-nc
-
fix a bug in the parsing of /proc/mounts (from Natanael Copa
)
remove lxc subdir in cgroup paths
remove extraneous debug printfs
remove extra call to stats_clear
Tested lxc-top, and apitest.lua on both lua 5.1 and 5.2
Signed-off-by: Dwight Engen
---
configure.ac| 10 +-
s
On Thu, 5 Sep 2013 14:33:28 +0200
Natanael Copa wrote:
> So we avoid running os.execute
>
> Signed-off-by: Natanael Copa
This is very nice, thanks. Note this patch is on top of Natanael's
5.1 -> 5.2 patch, it will need to be updated if we apply my 5.1 -> 5.2
instead. Either way, this is much
On Thu, 5 Sep 2013 09:34:14 -0400
Dwight Engen wrote:
> On Thu, 5 Sep 2013 08:11:57 -0500
> Serge Hallyn wrote:
>
> > Hi Dwight,
> >
> > do you have time to review/ack these (3, so far) lua patches?
> >
> > (I probably don't know enough to do so)
>
> Yeah I've taken a look. I had already don
On Thu, 5 Sep 2013 15:29:20 +0200
Natanael Copa wrote:
> Instead of popen and run external executable dirname we implement a
> dirname in C in the core module.
>
> We also remove the unused basename function.
>
> Signed-off-by: Natanael Copa
Acked-by: Dwight Engen
This is also on top of Na
On Thu, 5 Sep 2013 15:55:16 +0200
Natanael Copa wrote:
> On Thu, 5 Sep 2013 09:34:14 -0400
> Dwight Engen wrote:
>
> > On Thu, 5 Sep 2013 08:11:57 -0500
> > Serge Hallyn wrote:
> >
> > > Hi Dwight,
> > >
> > > do you have time to review/ack these (3, so far) lua patches?
> > >
> > > (I prob
On Thu, 5 Sep 2013 09:41:12 -0400
Dwight Engen wrote:
> fix a bug in the parsing of /proc/mounts (from Natanael Copa
> )
>
> remove lxc subdir in cgroup paths
>
> remove extraneous debug printfs
>
> remove extra call to stats_clear
>
> Tested lxc-top, and apitest.lua on both lua 5.1 and 5.2
>
Quoting Stéphane Graber (stgra...@ubuntu.com):
> On Wed, Sep 04, 2013 at 05:14:49PM -0500, Serge Hallyn wrote:
> > Quoting Stéphane Graber (stgra...@ubuntu.com):
> > > On Wed, Sep 04, 2013 at 11:05:02AM -0500, Serge Hallyn wrote:
> > > > Hi,
> > > >
> > > > before I go on with the snapshots-in-api
Branch: refs/heads/staging
Home: https://github.com/lxc/lxc
Commit: 41c3b7c7ac9b33bc562ebad9ea124912577f2ba5
https://github.com/lxc/lxc/commit/41c3b7c7ac9b33bc562ebad9ea124912577f2ba5
Author: Dwight Engen
Date: 2013-09-05 (Thu, 05 Sep 2013)
Changed paths:
M src/lxc/lxclo
Branch: refs/heads/staging
Home: https://github.com/lxc/lxc
Commit: 1fb86a7cdc22d22b14d03eb0cbd1aa6702862dd4
https://github.com/lxc/lxc/commit/1fb86a7cdc22d22b14d03eb0cbd1aa6702862dd4
Author: Serge Hallyn
Date: 2013-09-05 (Thu, 05 Sep 2013)
Changed paths:
M doc/lxc.conf.
Branch: refs/heads/staging
Home: https://github.com/lxc/lxc
Commit: 59d66af29da6ca8c5fa8cb63a5bbfc443811bb81
https://github.com/lxc/lxc/commit/59d66af29da6ca8c5fa8cb63a5bbfc443811bb81
Author: Serge Hallyn
Date: 2013-09-05 (Thu, 05 Sep 2013)
Changed paths:
M src/lxc/conf.
Branch: refs/heads/staging
Home: https://github.com/lxc/lxc
Commit: 2a2d36a42512160e7771b2472cb7922423523048
https://github.com/lxc/lxc/commit/2a2d36a42512160e7771b2472cb7922423523048
Author: Serge Hallyn
Date: 2013-09-05 (Thu, 05 Sep 2013)
Changed paths:
M src/lxc/lxcco
Branch: refs/heads/staging
Home: https://github.com/lxc/lxc
Commit: eee59f9408398849e9b7fc58dbe68ec176de4d50
https://github.com/lxc/lxc/commit/eee59f9408398849e9b7fc58dbe68ec176de4d50
Author: Serge Hallyn
Date: 2013-09-05 (Thu, 05 Sep 2013)
Changed paths:
M src/lxc/lxcco
On Thu, 5 Sep 2013 12:52:34 -0500
Serge Hallyn wrote:
> Quoting Dwight Engen (dwight.en...@oracle.com):
> > On Thu, 5 Sep 2013 08:45:33 +0200
> > Natanael Copa wrote:
> >
> > > Adjust code for Lua 5.2 and keep compatibility with Lua 5.1.
> > >
> > > We also fix a bug in the parsing of /proc/m
Branch: refs/heads/staging
Home: https://github.com/lxc/lxc
Commit: 2698b46924ab861b1f39fb11560c852d080e7b02
https://github.com/lxc/lxc/commit/2698b46924ab861b1f39fb11560c852d080e7b02
Author: Natanael Copa
Date: 2013-09-05 (Thu, 05 Sep 2013)
Changed paths:
M src/lua-lxc/
Hi,
It looks like this patch changed the default behavior and configure started
to enable Lua even when it gets called without --enable-lua parameter.
./configure --prefix=/usr --sysconfdir=/etc --bindir=/usr/bin
--libdir=/usr/lib/x86_64-linux-gnu/ --localstatedir=/var
--includedir=/usr/include -
Quoting Dwight Engen (dwight.en...@oracle.com):
> Signed-off-by: Dwight Engen
Acked-by: Serge E. Hallyn
> ---
> src/lxc/lxclock.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/src/lxc/lxclock.c b/src/lxc/lxclock.c
> index dea6941..79ebf84 100644
> --- a/sr
Quoting Dwight Engen (dwight.en...@oracle.com):
> On Thu, 5 Sep 2013 08:45:33 +0200
> Natanael Copa wrote:
>
> > Adjust code for Lua 5.2 and keep compatibility with Lua 5.1.
> >
> > We also fix a bug in the parsing of /proc/mounts while here.
>
> After some discussion on IRC, we decided the bu
Enable support for both Lua 5.1 and 5.2 by let user specify the Lua
pkg-config package name. By default it will use 'lua' and try figure
out which version it is.
Signed-off-by: Natanael Copa
---
Changes v1 -> v2:
- define PKG_CHECK_VAR which was introduced in pkg-config 0.28. Ubuntu
ships 0.2
On Thu, 5 Sep 2013 08:45:33 +0200
Natanael Copa wrote:
> Adjust code for Lua 5.2 and keep compatibility with Lua 5.1.
>
> We also fix a bug in the parsing of /proc/mounts while here.
After some discussion on IRC, we decided the bug fix should be split
out. There is also one more change needed
Branch: refs/heads/staging
Home: https://github.com/lxc/lxc
Commit: 2caf9a97d90a61e5eaf9d7c218e5bcc35dfbfbb3
https://github.com/lxc/lxc/commit/2caf9a97d90a61e5eaf9d7c218e5bcc35dfbfbb3
Author: Serge Hallyn
Date: 2013-09-05 (Thu, 05 Sep 2013)
Changed paths:
M src/lxc/conf.
Right, same thing showed up in the latest daily build.
As that's quite problematic for all of us who don't have lua, I'll
revert the lua commits if we don't get this fixed tomorrow.
Sorry for not spotting this when testing the commits, unfortunately my
dev machine did have the lua headers install
Hey Stéphane,
I realized that Go bindings are licensed as GPLv2. I've no objection to
re-licensing them with LGPL v2.1 but wanted to clarify it with you first.
Should I go ahead and change the license or is it ok to stay with GPLv2?
Best,
On Fri, Aug 30, 2013 at 3:42 PM, Stéphane Graber wrote:
Hi,
Well since they're currently shipped out of tree, you're free to do
whatever you want. GPLv2 code is allowed to link with an LGPLv2.1+
library so your code isn't in violation of LXC's license.
However this very likely means that any software using your Go bindings
will have to be GPLv2 in ord
Hi,
On Fri, Sep 6, 2013 at 12:10 AM, Stéphane Graber wrote:
> Hi,
>
> Well since they're currently shipped out of tree, you're free to do
> whatever you want. GPLv2 code is allowed to link with an LGPLv2.1+
> library so your code isn't in violation of LXC's license.
>
> However this very likely m
On Thu, 5 Sep 2013 21:46:00 -0400
Stéphane Graber wrote:
> Right, same thing showed up in the latest daily build.
>
> As that's quite problematic for all of us who don't have lua, I'll
> revert the lua commits if we don't get this fixed tomorrow.
it should be enough to revert:
commit 12e93188d
31 matches
Mail list logo
