On Thu, 5 Sep 2013 15:55:16 +0200 Natanael Copa <nc...@alpinelinux.org> wrote:
> On Thu, 5 Sep 2013 09:34:14 -0400 > Dwight Engen <dwight.en...@oracle.com> wrote: > > > On Thu, 5 Sep 2013 08:11:57 -0500 > > Serge Hallyn <serge.hal...@ubuntu.com> wrote: > > > > > Hi Dwight, > > > > > > do you have time to review/ack these (3, so far) lua patches? > > > > > > (I probably don't know enough to do so) > > > > Yeah I've taken a look. I had already done an update similar to the > > first two and was just getting ready to post after some more > > testing. > > > > Natanael, would you mind taking a look at how I did the update and > > see if it works for you? I've integrated the fixes you've done into > > what I had, but I did the autoconf stuff a bit different (the > > INSTALL_[CL]MOD pkg-config variables don't exist on Fedora/Oracle > > so I did it more like lua-filesystem does) and also had to fix up > > that there is no lxc subdir in cgroup anymore. > > Yes, but i verified that fedora has the V variable. The patch I sent > should fall back to $libdir/lua/$LUA_VERSION and > $datadir/lua/$LUA_VERSION if INSTALL_[CL]MOD is missing. I tested on > my local workstation to remove the INSTALL_[CL]MOD from the lua.pc > file. Yeah I looked at doing it that way at first too, it does have both V and R, but then I looked at how lua-filesystem did it and I think its simpler and cleaner. Also, lua5.1.pc on Ubuntu does not have V, so what you have wouldn't work there. > Getting Lua correct is tricky... :-/ Indeed, especially cross distro > -nc ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk _______________________________________________ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
