Re: [lxc-devel] [PATCH 2/2] lxc-attach: Implement --clear-env and --keep-env

2013-04-01 Thread Michael H. Warfield
On Sun, 2013-03-31 at 22:50 -0500, Serge Hallyn wrote: > Quoting Christian Seiler (christ...@iwakd.de): > > This patch introduces the --clear-env and --keep-env options for > > lxc-attach, that allows the user to specify whether the environment > > should be passed on inside the container or not. >

Re: [lxc-devel] [PATCH] templates: abort if name is not specified

2013-04-01 Thread Stéphane Graber
On 04/01/2013 12:41 AM, Ryota Ozaki wrote: > Hi Serge, > > On Mon, Apr 1, 2013 at 12:32 PM, Serge Hallyn wrote: >> Quoting Ryota Ozaki (ozaki.ry...@gmail.com): >>> Most scripts don't check if required parameter 'name' is >>> specified and proceed without it, which results in using an >>> unexpect

Re: [lxc-devel] [PATCH 1/1] lxc-create: require absolute path for non-standard templates

2013-04-01 Thread Stéphane Graber
On 03/31/2013 06:00 PM, Serge Hallyn wrote: > Otherwise, as an example, if doing 'lxc-create -t debian' while > there is a 'debian' directory, lxc-create will fail to do the > right thing. > > Signed-off-by: Serge Hallyn Acked-by: Stéphane Graber > --- > src/lxc/lxc-create.in | 2 +- > 1 file

Re: [lxc-devel] [PATCH 2/2] lxc-attach: Implement --clear-env and --keep-env

2013-04-01 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > On Sun, 2013-03-31 at 22:50 -0500, Serge Hallyn wrote: > > Quoting Christian Seiler (christ...@iwakd.de): > > > This patch introduces the --clear-env and --keep-env options for > > > lxc-attach, that allows the user to specify whether the environme

[lxc-devel] Staging branch now frozen for release

2013-04-01 Thread Stéphane Graber
Hello everyone, I think I went through all the patches that were submitted over the weekend and that were bugfixes or small enough improvements that I felt would be alright for 0.9. https://github.com/lxc/lxc should contain them all, if not, please shout ASAP! I'm now going to do my usual batch

Re: [lxc-devel] [PATCH 2/2] lxc-attach: Implement --clear-env and --keep-env

2013-04-01 Thread Christian Seiler
Hi Serge, > Right I'm not objecting to the arguments being passed, but I'm > wondering > why he specifically has: > >> > > +(void) extra_env; >> > > +(void) extra_keep; > > in the function there. In order to suppress warnings from the compiler about unused arguments. These lines

Re: [lxc-devel] [PATCH 2/2] lxc-attach: Implement --clear-env and --keep-env

2013-04-01 Thread Ward, David - 0663 - MITLL
On 03/30/2013 10:45 AM, Christian Seiler wrote: This patch introduces the --clear-env and --keep-env options for lxc-attach, that allows the user to specify whether the environment should be passed on inside the container or not. This is to be expanded upon in later versions, this patch only int

Re: [lxc-devel] [PATCH 2/2] lxc-attach: Implement --clear-env and --keep-env

2013-04-01 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi Serge, > > >Right I'm not objecting to the arguments being passed, but I'm > >wondering > >why he specifically has: > > > >>> > + (void) extra_env; > >>> > + (void) extra_keep; > > > >in the function there. > > In order to suppress w

[lxc-devel] [PATCH] gitignore doc/legacy/lxc-ls.1

2013-04-01 Thread Dwight Engen
Signed-off-by: Dwight Engen --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 6bf0348..905a2dc 100644 --- a/.gitignore +++ b/.gitignore @@ -92,6 +92,7 @@ config/lt*.m4 doc/*.1 doc/*.5 doc/*.7 +doc/legacy/*.1 doc/manpage.links doc/manpage.refs

Re: [lxc-devel] [PATCH] gitignore doc/legacy/lxc-ls.1

2013-04-01 Thread Stéphane Graber
On 04/01/2013 02:19 PM, Dwight Engen wrote: > Signed-off-by: Dwight Engen Good catch, applied, thanks. > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 6bf0348..905a2dc 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -92,6 +92,7 @@ c

Re: [lxc-devel] [PATCH 2/2] lxc-attach: Implement --clear-env and --keep-env

2013-04-01 Thread Serge Hallyn
Quoting Ward, David - 0663 - MITLL (david.w...@ll.mit.edu): > On 03/30/2013 10:45 AM, Christian Seiler wrote: > >This patch introduces the --clear-env and --keep-env options for > >lxc-attach, that allows the user to specify whether the environment > >should be passed on inside the container or not

[lxc-devel] LXC 0.9 final pull request

2013-04-01 Thread Stéphane Graber
Hi Daniel, You'll find the 0.9 pull request below. Based on what you did last time, the following should do the trick: - Review the pull request - Use "git pull --edit --no-ff --stat git://github.com/lxc/lxc.git", that should do a real merge, letting you do a proper Sign-off of the change