Re: [lxc-devel] Please make "-f" mandatory in lxc-create

2012-05-29 Thread Aristeu Rozanski
On Tue, May 29, 2012 at 10:47:47AM +0200, richard -rw- weinberger wrote: > diff --git a/src/lxc/lxc-create.in b/src/lxc/lxc-create.in > index bd9a438..89f0889 100644 > --- a/src/lxc/lxc-create.in > +++ b/src/lxc/lxc-create.in > @@ -136,6 +136,12 @@ while true; do > esac > done > > +if [

Re: [lxc-devel] Please make "-f" mandatory in lxc-create

2012-05-29 Thread Serge Hallyn
Quoting richard -rw- weinberger (richard.weinber...@gmail.com): > On Tue, May 29, 2012 at 10:36 AM, richard -rw- weinberger > wrote: > > Found the problem, patch is in the way! > > > > *grr*, forgot that this list is moderated. > > -- > > Using this patch is it possible to catch usage errors li

Re: [lxc-devel] Please make "-f" mandatory in lxc-create

2012-05-29 Thread richard -rw- weinberger
On Tue, May 29, 2012 at 10:36 AM, richard -rw- weinberger wrote: > Found the problem, patch is in the way! > *grr*, forgot that this list is moderated. -- Using this patch is it possible to catch usage errors like: lxc-create -n foo foo.cfg Signed-off-by: Richard Weinberger --- src/lxc/lxc-c

Re: [lxc-devel] Please make "-f" mandatory in lxc-create

2012-05-29 Thread richard -rw- weinberger
On Tue, May 29, 2012 at 6:56 AM, Michael Tokarev wrote: >> Yesterday I've wasted a few hours with finding out why LXC set up a >> broken container. >> Then I found out that I've created it using "lxc-create -n foo >> foo.cfg" instead of "lxc-create -n foo -f foo.cfg". > > Shouldn't it complain abo

Re: [lxc-devel] Please make "-f" mandatory in lxc-create

2012-05-28 Thread Michael Tokarev
On 29.05.2012 02:02, richard -rw- weinberger wrote: > Hi! > > Is there any use case where a user wants to omit "-f"? In my case I didn't use -f, but later resorted to using -f /dev/null to be sure. So this is yet another "me too", I guess. Maybe there should be more well-defined behavour about

Re: [lxc-devel] Please make "-f" mandatory in lxc-create

2012-05-28 Thread richard -rw- weinberger
On Tue, May 29, 2012 at 12:36 AM, Stéphane Graber wrote: > On 05/28/2012 06:29 PM, richard -rw- weinberger wrote: >> On Tue, May 29, 2012 at 12:06 AM, Stéphane Graber >> wrote: >>> At least in Ubuntu -f isn't mandatory because calling lxc-create without >>> it will simply default to a system wid

Re: [lxc-devel] Please make "-f" mandatory in lxc-create

2012-05-28 Thread Stéphane Graber
On 05/28/2012 06:29 PM, richard -rw- weinberger wrote: > On Tue, May 29, 2012 at 12:06 AM, Stéphane Graber wrote: >> At least in Ubuntu -f isn't mandatory because calling lxc-create without >> it will simply default to a system wide configuration in /etc/lxc/lxc.conf. > > Is this really useful? >

Re: [lxc-devel] Please make "-f" mandatory in lxc-create

2012-05-28 Thread richard -rw- weinberger
On Tue, May 29, 2012 at 12:06 AM, Stéphane Graber wrote: > At least in Ubuntu -f isn't mandatory because calling lxc-create without > it will simply default to a system wide configuration in /etc/lxc/lxc.conf. Is this really useful? My openSUSE system does not have /etc/lxc/lxc.conf, so lxc-creat

Re: [lxc-devel] Please make "-f" mandatory in lxc-create

2012-05-28 Thread Stéphane Graber
On 05/28/2012 06:02 PM, richard -rw- weinberger wrote: > Hi! > > Is there any use case where a user wants to omit "-f"? > Yesterday I've wasted a few hours with finding out why LXC set up a > broken container. > Then I found out that I've created it using "lxc-create -n foo > foo.cfg" instead of "