Re: [lxc-devel] Change rootfs pinning mechnism

2013-09-22 Thread Rob Landley
On 09/13/2013 10:28:25 AM, Serge Hallyn wrote: > Quoting Michael H. Warfield (m...@wittsend.com): > > On Fri, 2013-09-13 at 07:56 -0500, Serge Hallyn wrote: > > > Quoting Jäkel, Guido (g.jae...@dnb.de): > > > > Hello, > > > > > > > > I'm late but I just want to mention that I expect that all this

Re: [lxc-devel] Change rootfs pinning mechnism

2013-09-16 Thread Jäkel , Guido
Serge: > Will it use the same name every time? Will it eventually go away? I don’t' know but I expect it will get some ID which represents the file reference on the NFS server. And it "disappear" (, i.e. it will be deleted in the normal way), if the filehandle is closed. Other NFS clients will

Re: [lxc-devel] Change rootfs pinning mechnism

2013-09-13 Thread Stéphane Graber
On Fri, Sep 13, 2013 at 05:11:37PM +0100, Christian Seiler wrote: > Hi there, > > > Concur on the revert. > > > > What is really gained by deleting that file? I agree with the basic > > idea of moving and renaming that file to hold the mount open but, are > > we > > really that worried that some

Re: [lxc-devel] Change rootfs pinning mechnism

2013-09-13 Thread Christian Seiler
Hi there, > Concur on the revert. > > What is really gained by deleting that file? I agree with the basic > idea of moving and renaming that file to hold the mount open but, are > we > really that worried that someone will inadvertently delete that file? > It shouldn't be a security issue and I

Re: [lxc-devel] Change rootfs pinning mechnism

2013-09-13 Thread Michael H. Warfield
On Fri, 2013-09-13 at 12:18 -0400, Stéphane Graber wrote: > On Fri, Sep 13, 2013 at 05:11:37PM +0100, Christian Seiler wrote: > > Hi there, > > > > > Concur on the revert. > > > > > > What is really gained by deleting that file? I agree with the basic > > > idea of moving and renaming that file

Re: [lxc-devel] Change rootfs pinning mechnism

2013-09-13 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > On Fri, 2013-09-13 at 07:56 -0500, Serge Hallyn wrote: > > Quoting Jäkel, Guido (g.jae...@dnb.de): > > > Hello, > > > > > > I'm late but I just want to mention that I expect that all this kind > > of "unlinking" on a NFS will show up as a stale N

Re: [lxc-devel] Change rootfs pinning mechnism

2013-09-13 Thread Michael H. Warfield
On Fri, 2013-09-13 at 10:28 -0500, Serge Hallyn wrote: > Quoting Michael H. Warfield (m...@wittsend.com): > > On Fri, 2013-09-13 at 07:56 -0500, Serge Hallyn wrote: > > > Quoting Jäkel, Guido (g.jae...@dnb.de): > > > > Hello, > > > > > > > > I'm late but I just want to mention that I expect that

Re: [lxc-devel] Change rootfs pinning mechnism

2013-09-13 Thread Michael H. Warfield
On Fri, 2013-09-13 at 07:56 -0500, Serge Hallyn wrote: > Quoting Jäkel, Guido (g.jae...@dnb.de): > > Hello, > > > > I'm late but I just want to mention that I expect that all this kind > of "unlinking" on a NFS will show up as a stale NFS handle, i.e. a > still visible hidden directory entry (.nf

Re: [lxc-devel] Change rootfs pinning mechnism

2013-09-13 Thread Serge Hallyn
Quoting Jäkel, Guido (g.jae...@dnb.de): > Hello, > > I'm late but I just want to mention that I expect that all this kind of > "unlinking" on a NFS will show up as a stale NFS handle, i.e. a still visible > hidden directory entry (.nfs00??). Therefore, one have to > take car

Re: [lxc-devel] Change rootfs pinning mechnism

2013-09-13 Thread Jäkel , Guido
Dear Christian, >It was, but there was/is no O_EXCL in the open() command, so a >pre-existing .hold file was never a reason for the container >startup to fail. (Which was necessary because they were never >removed on shutdown previously.) So in that sense, this behavior >hasn't changed. I'm sorry

Re: [lxc-devel] Change rootfs pinning mechnism

2013-09-13 Thread Jäkel , Guido
Hello, I'm late but I just want to mention that I expect that all this kind of "unlinking" on a NFS will show up as a stale NFS handle, i.e. a still visible hidden directory entry (.nfs00??). Therefore, one have to take care of this (i.e. exclude) if he make a copy of such (

Re: [lxc-devel] Change rootfs pinning mechnism

2013-09-13 Thread Christian Seiler
Hi there, > I would suggest to add a config switch to choose between early > unlinking and removing at shutdown. Because I'm using a setup where > the rootfs are shared between several hosts and an container may be > run on any of it. For this usecase, the rootfs pinmarker is a (not > perfect but)