Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-28 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi there, > > > Can we easily move the clearenv() to an lxc-attach argument? > > If so, I'd prefer we make it an option rather than remove it > > entirely. > > Well, in my list that I posted earlier, I suggested adding an option to > clear the env

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-28 Thread Christian Seiler
Hi Serge, > So for now we would introduce -c for clearenv, which we could always > continue to support after introducing Christian's proposed semantics. > That sounds good. See my other mail, I had a similar idea, but a tiny bit more expansive. Just a minor point: I wouldn't add a short option j

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-28 Thread Christian Seiler
Hi there, > Can we easily move the clearenv() to an lxc-attach argument? > If so, I'd prefer we make it an option rather than remove it > entirely. Well, in my list that I posted earlier, I suggested adding an option to clear the environment anyway, even if the (for post 0.9 more complicated) de

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-28 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On 03/28/2013 11:52 AM, Serge Hallyn wrote: > > Quoting Christian Seiler (christ...@iwakd.de): > >> Hi there, > >> > In light of the fact that 0.9 is going to be here soon, any > comments on > this? > >>> > >>> Sorry, I was waiting to

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-28 Thread Stéphane Graber
On 03/28/2013 11:52 AM, Serge Hallyn wrote: > Quoting Christian Seiler (christ...@iwakd.de): >> Hi there, >> In light of the fact that 0.9 is going to be here soon, any comments on this? >>> >>> Sorry, I was waiting to see if anyone else would comment. Note this >>> kind of change i

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-28 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi there, > > >>In light of the fact that 0.9 is going to be here soon, any > >>comments on > >>this? > > > >Sorry, I was waiting to see if anyone else would comment. Note this > >kind of change is not going to be non-trivial, so it's definately >

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-28 Thread Christian Seiler
Hi there, >> In light of the fact that 0.9 is going to be here soon, any comments >> on >> this? > > Sorry, I was waiting to see if anyone else would comment. Note this > kind of change is not going to be non-trivial, so it's definately > (imo) > 1.0 material My problem is that the current pat

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-28 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi again, > > > - lxc-attach with shell > > clear env + container=lxc only > > when doing getent lookup logic, > > default PATH just for getent call > > BUT don't pass it to shell because it will

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-28 Thread Christian Seiler
Hi again, > - lxc-attach with shell > clear env + container=lxc only > when doing getent lookup logic, > default PATH just for getent call > BUT don't pass it to shell because it will > probably read some defaults anyway >

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-26 Thread Christian Seiler
Hi, > It doesn't come across as negative - it comes across as suggesting > we need a list or matrix of use cases and to decide what to do in > each case. Ok, then I might want to start with some ideas thrown in: - lxc-attach with shell clear env + container=lxc only when doing

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-26 Thread Serge Hallyn
Quoting Christian Seiler (christ...@iwakd.de): > Hi, > > > The child process's environment should be manipulated the same way > > by lxc-attach as it would be by lxc-start or lxc-execute. > > Just a short question: don't you at least want to set PATH to some > sane default such as /usr/local/bin:

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-26 Thread Christian Seiler
Hi, > The child process's environment should be manipulated the same way > by lxc-attach as it would be by lxc-start or lxc-execute. Just a short question: don't you at least want to set PATH to some sane default such as /usr/local/bin:/usr/bin:/bin or so? For example, my getent logic introduced

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-21 Thread Stéphane Graber
On 03/20/2013 01:31 PM, Serge Hallyn wrote: > Quoting David Ward (david.w...@ll.mit.edu): >> The child process's environment should be manipulated the same way >> by lxc-attach as it would be by lxc-start or lxc-execute. >> >> Signed-off-by: David Ward > > Acked-by: Serge E. Hallyn And pushed t

Re: [lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-20 Thread Serge Hallyn
Quoting David Ward (david.w...@ll.mit.edu): > The child process's environment should be manipulated the same way > by lxc-attach as it would be by lxc-start or lxc-execute. > > Signed-off-by: David Ward Acked-by: Serge E. Hallyn > --- > src/lxc/attach.c | 15 +++ > src/lxc/a

[lxc-devel] [PATCH] lxc-attach: Clear environment and set container=lxc

2013-03-20 Thread David Ward
The child process's environment should be manipulated the same way by lxc-attach as it would be by lxc-start or lxc-execute. Signed-off-by: David Ward --- src/lxc/attach.c | 15 +++ src/lxc/attach.h |1 + src/lxc/lxc_attach.c |5 + 3 files changed, 21 insertions