Quoting Christian Seiler (christ...@iwakd.de):
> Hi again,
>
> I was just looking at how to best implement the cgroup mount hook.
> Problem now is that the easiest way would be just to create the cgroup
> before the clone() (enter is done afterwards anyway) so that the client
> has access to handl
Hi Serge,
>> cgroups and have a separate function for the ns cgroup entries? Then
>
> Makes perfect sense to me to do so, yes.
Since you didn't respond and I was in the mood to finish it,
I assumed that you'd be OK with that, see my other set of
patches for automatic cgroup mounting.
-- Christia
Hi again,
I was just looking at how to best implement the cgroup mount hook.
Problem now is that the easiest way would be just to create the cgroup
before the clone() (enter is done afterwards anyway) so that the client
has access to handler->pid. Unfortunately, handler->pid is needed for
the ns c
On Wed, Sep 11, 2013 at 11:50:54AM -0500, Serge Hallyn wrote:
> If a cgroup hierarchy has ns cgroup composed, then we need to treat
> that differently:
>
> 1. The container init will have already been switched to a new cgroup
> called after its pid.
> 2. We can't move the container init to new dee
Quoting Christian Seiler (christ...@iwakd.de):
> Hi Serge,
>
> Sorry about 'ns' support in my rewrite, I completely forgot that it's
> removal was not so long ago.
>
> I have a two very minor nit-picky comments:
>
> > +static char *cgroup_rename_nsgroup(char *mountpath, const char *oldname,
> >
Hi Serge,
Sorry about 'ns' support in my rewrite, I completely forgot that it's
removal was not so long ago.
I have a two very minor nit-picky comments:
> +static char *cgroup_rename_nsgroup(char *mountpath, const char *oldname, int
> pid, const char *name)
> +lxc_cgroup_create(..., int pid)
p
If a cgroup hierarchy has ns cgroup composed, then we need to treat
that differently:
1. The container init will have already been switched to a new cgroup
called after its pid.
2. We can't move the container init to new deeper cgroup directories.
So, if we detect an ns cgroup, don't bother tryin
