Hi Serge, Sorry about 'ns' support in my rewrite, I completely forgot that it's removal was not so long ago.
I have a two very minor nit-picky comments: > +static char *cgroup_rename_nsgroup(char *mountpath, const char *oldname, int > pid, const char *name) > +lxc_cgroup_create(..., int pid) pid_t instead of int would be a better idea for pid. Also, mountpath in the first function should probably be const to indicate it's contents won't be modified. > + fulloldpath = alloca(strlen(oldname) + strlen(mountpath) + 22); > + sprintf(fulloldpath, "%s/%s/%d", mountpath, oldname, pid); Even though you allocated a correctly-sized buffer, I'd personally prefer to always use snprintf to be on the safe side... -- Christian ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk _______________________________________________ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
