Re: [lxc-devel] [PATCH] add process_lock()/unlock() in save_config()

2013-11-12 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Tue, 12 Nov 2013 14:42:54 -0600 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > This is likely unnecessary, but is consistent with other uses of > > > fopen()/fclose() in lxc. > > > > > > Signed-off-by: Dwight

Re: [lxc-devel] [PATCH] add process_lock()/unlock() in save_config()

2013-11-12 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Tue, 12 Nov 2013 14:42:54 -0600 > Serge Hallyn wrote: > > > Quoting Dwight Engen (dwight.en...@oracle.com): > > > This is likely unnecessary, but is consistent with other uses of > > > fopen()/fclose() in lxc. > > > > > > Signed-off-by: Dwight

Re: [lxc-devel] [PATCH] add process_lock()/unlock() in save_config()

2013-11-12 Thread Dwight Engen
On Tue, 12 Nov 2013 14:42:54 -0600 Serge Hallyn wrote: > Quoting Dwight Engen (dwight.en...@oracle.com): > > This is likely unnecessary, but is consistent with other uses of > > fopen()/fclose() in lxc. > > > > Signed-off-by: Dwight Engen > > Do you think, regardless of your other fix, that it

Re: [lxc-devel] [PATCH] add process_lock()/unlock() in save_config()

2013-11-12 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > This is likely unnecessary, but is consistent with other uses of > fopen()/fclose() in lxc. > > Signed-off-by: Dwight Engen Do you think, regardless of your other fix, that it would still be worth adding an fsync? Acked-by: Serge E. Hallyn > -

Re: [lxc-devel] [PATCH] add process_lock()/unlock() in save_config()

2013-11-12 Thread S . Çağlar Onur
On Tue, Nov 12, 2013 at 2:04 PM, Dwight Engen wrote: > This is likely unnecessary, but is consistent with other uses of > fopen()/fclose() in lxc. > > Signed-off-by: Dwight Engen Acked-by: S.Çağlar Onur > --- > src/lxc/lxccontainer.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

[lxc-devel] [PATCH] add process_lock()/unlock() in save_config()

2013-11-12 Thread Dwight Engen
This is likely unnecessary, but is consistent with other uses of fopen()/fclose() in lxc. Signed-off-by: Dwight Engen --- src/lxc/lxccontainer.c | 4 1 file changed, 4 insertions(+) diff --git a/src/lxc/lxccontainer.c b/src/lxc/lxccontainer.c index ede0113..c7b2f5e 100644 --- a/src/lxc/lxc