Re: [lxc-devel] [PATCH 1/1] ubuntu templates: send logs to /var/log/lxc/$name.log by default

2013-01-14 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Mon, 14 Jan 2013 17:36:00 -0600 > Serge Hallyn wrote: > > > Quoting Stéphane Graber (stgra...@ubuntu.com): > > > On 01/14/2013 03:24 PM, Serge Hallyn wrote: > > > > (leave the level at the current default) > > > > > > > > Is there a better way

Re: [lxc-devel] [PATCH 1/1] ubuntu templates: send logs to /var/log/lxc/$name.log by default

2013-01-14 Thread Dwight Engen
On Mon, 14 Jan 2013 17:36:00 -0600 Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > On 01/14/2013 03:24 PM, Serge Hallyn wrote: > > > (leave the level at the current default) > > > > > > Is there a better way to go about this? Should we set a default > > > directory in /

[lxc-devel] [PATCH 1/1] Implement userid mappings (enable user namespaces)

2013-01-14 Thread Serge Hallyn
The 3.8 kernel now supporst uid mappings, so I believe it's appropriate to proceed with this patchset. The container config supports new entries of the form: lxc.id_map = U 10 0 1 lxc.id_map = G 10 0 1 meaning map 'virtual' uids (in the container) 0-1 to uids 10-11 on

Re: [lxc-devel] [PATCH 1/1] ubuntu templates: send logs to /var/log/lxc/$name.log by default

2013-01-14 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On 01/14/2013 03:24 PM, Serge Hallyn wrote: > > (leave the level at the current default) > > > > Is there a better way to go about this? Should we set a default directory > > in /etc/default/lxc or at build-time, and allways use > > ${LXC_LOG_PATH}

[lxc-devel] [PATCH 2/2] setup cgroups from parent

2013-01-14 Thread Serge Hallyn
This is a first step to enabling user namespaces. When starting a container in a new user namespace, the child will not have the rights to write to the cgroup fs. (We can give it that right, but don't always want to have to). At the parent, we don't want to setup_cgroups() before the child has s

[lxc-devel] [PATCH 1/2] clean up syncs

2013-01-14 Thread Serge Hallyn
Always unblock parent when child setup fails, rather than just exiting. Also remove a duplicate call to setup_cgroup(). We'll want it close to there for userns, but not right there - that's too late, and could happen after container init has done something bad without cgroup restrictions. Signed

Re: [lxc-devel] [PATCH 1/1] ubuntu templates: send logs to /var/log/lxc/$name.log by default

2013-01-14 Thread Stéphane Graber
On 01/14/2013 03:24 PM, Serge Hallyn wrote: > (leave the level at the current default) > > Is there a better way to go about this? Should we set a default directory > in /etc/default/lxc or at build-time, and allways use > ${LXC_LOG_PATH}/${name}.log? Should lxc-create do this for all containers

[lxc-devel] [PATCH 1/1] ubuntu templates: send logs to /var/log/lxc/$name.log by default

2013-01-14 Thread Serge Hallyn
(leave the level at the current default) Is there a better way to go about this? Should we set a default directory in /etc/default/lxc or at build-time, and allways use ${LXC_LOG_PATH}/${name}.log? Should lxc-create do this for all containers, or should we do it through the templates as I did he

Re: [lxc-devel] [Patch] Resubmit: MAKEDEV call, add autodev hooks, add environment variables for hook scripts.

2013-01-14 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > Ok... Here's the patch again. Since Serge is removing the loglevel > structure member, this patch no longer references that element. > > Signed-off-by: Michael H. Warfield Thanks, pushed to staging. ---

Re: [lxc-devel] [Patch] Resubmit: MAKEDEV call, add autodev hooks, add environment variables for hook scripts.

2013-01-14 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > Ok... Here's the patch again. Since Serge is removing the loglevel > structure member, this patch no longer references that element. > > Signed-off-by: Michael H. Warfield Thanks. I'll take a close look and push it to staging along with mine.

[lxc-devel] [Patch] Resubmit: MAKEDEV call, add autodev hooks, add environment variables for hook scripts.

2013-01-14 Thread Michael H. Warfield
Ok... Here's the patch again. Since Serge is removing the loglevel structure member, this patch no longer references that element. Signed-off-by: Michael H. Warfield Regards, Mike -- Michael H. Warfield (AI4NB) | (770) 985-6132 | m...@wittsend.com /\/\|=mhw=|\/\/ | (678) 463-0932

Re: [lxc-devel] [PATCH] Fix check for openpty

2013-01-14 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On 01/11/2013 11:17 PM, Serge Hallyn wrote: > > Quoting Stéphane Graber (stgra...@ubuntu.com): > >> The previous implementation of the openpty check was always returning > >> 'no' as openpty is typically defined in util. > >> > >> Signed-off-by: Stép

Re: [lxc-devel] FW: [PATCH] Add Dropbear SSH support for lxc-busybox template

2013-01-14 Thread Dwight Engen
On Mon, 14 Jan 2013 09:37:05 -0500 Stéphane Graber wrote: > Forwarding this from Bogdan as for some weird reason his e-mails are > put in the mailing-list moderation queue (even though he's > subscribed). > > Personally I think this change is good and would make the busybox > template behave sim

[lxc-devel] FW: [PATCH] Add Dropbear SSH support for lxc-busybox template

2013-01-14 Thread Stéphane Graber
Forwarding this from Bogdan as for some weird reason his e-mails are put in the mailing-list moderation queue (even though he's subscribed). Personally I think this change is good and would make the busybox template behave similarly than the others where SSH is usually automatically enabled. But