On 01/14/2013 03:24 PM, Serge Hallyn wrote:
> (leave the level at the current default)
>
> Is there a better way to go about this? Should we set a default directory
> in /etc/default/lxc or at build-time, and allways use
> ${LXC_LOG_PATH}/${name}.log? Should lxc-create do this for all containers,
> or should we do it through the templates as I did here?Assuming the various template maintainers agree, I think it'd be best to have a LXC_LOG_PATH defined in the configure, that should at least let you drop the mkdir call. I think it'd also be best to have lxc-start assume logging into /var/log/lxc/<container name>.log by default and only use lxc.logfile as an override of that. That way existing containers will also be logged at the right place without requiring the admin to update all the configs. The log level should still be kept to its current value as we don't want to end up creating a ton of big log files that nobody will read ;) We just want those to be useful when something goes wrong. > Signed-off-by: Serge Hallyn <serge.hal...@ubuntu.com> > --- > templates/lxc-ubuntu-cloud.in | 4 ++++ > templates/lxc-ubuntu.in | 4 ++++ > 2 files changed, 8 insertions(+) > > diff --git a/templates/lxc-ubuntu-cloud.in b/templates/lxc-ubuntu-cloud.in > index de9f3c3..bbdbf78 100644 > --- a/templates/lxc-ubuntu-cloud.in > +++ b/templates/lxc-ubuntu-cloud.in > @@ -47,9 +47,13 @@ EOF > fi > > grep -q "^lxc.rootfs" $path/config 2>/dev/null || echo "lxc.rootfs = > $rootfs" >> $path/config > + if [ ! -d /var/log/lxc ]; then > + mkdir /var/log/lxc > + fi > cat <<EOF >> $path/config > lxc.utsname = $name > > +lxc.logfile = /var/log/lxc/$name.log > lxc.tty = 4 > lxc.pts = 1024 > lxc.mount = $path/fstab > diff --git a/templates/lxc-ubuntu.in b/templates/lxc-ubuntu.in > index 0ed8808..3a6c21d 100644 > --- a/templates/lxc-ubuntu.in > +++ b/templates/lxc-ubuntu.in > @@ -325,9 +325,13 @@ EOF > fi > > grep -q "^lxc.rootfs" $path/config 2>/dev/null || echo "lxc.rootfs = > $rootfs" >> $path/config > + if [ ! -d /var/log/lxc ]; then > + mkdir /var/log/lxc > + fi > cat <<EOF >> $path/config > lxc.utsname = $name > > +lxc.logfile = /var/log/lxc/$name.log > lxc.devttydir =$ttydir > lxc.tty = 4 > lxc.pts = 1024 > -- Stéphane Graber Ubuntu developer http://www.ubuntu.com
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412
_______________________________________________ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
