On 01/02/2013 05:33 PM, Dwight Engen wrote:
> On Wed, 02 Jan 2013 13:37:29 -0500
> Stéphane Graber wrote:
>
>> On 12/27/2012 05:01 PM, Dwight Engen wrote:
>>> lxc-start -c makes the named file/device the container's console,
>>> but using this with a regular file in order to get a log of the
>>>
On Wed, 02 Jan 2013 13:37:29 -0500
Stéphane Graber wrote:
> On 12/27/2012 05:01 PM, Dwight Engen wrote:
> > lxc-start -c makes the named file/device the container's console,
> > but using this with a regular file in order to get a log of the
> > console output does not work very well if you also
Quoting Stéphane Graber (stgra...@ubuntu.com):
> On 12/27/2012 05:01 PM, Dwight Engen wrote:
> > lxc-start -c makes the named file/device the container's console, but using
> > this with a regular file in order to get a log of the console output does
> > not work very well if you also want to login
On 01/02/2013 01:00 PM, Stéphane Graber wrote:
> On 12/26/2012 04:31 PM, Natanael Copa wrote:
>> Use awk to parse the output pf 'ps' and the tasks files for the
>> containers.
>>
>> Use awk fields to find PID column rather than assume that the PID field
>> is exactly 5 chars wide and has a leading
On 12/27/2012 05:01 PM, Dwight Engen wrote:
> lxc-start -c makes the named file/device the container's console, but using
> this with a regular file in order to get a log of the console output does
> not work very well if you also want to login on the console. This change
> implements an additional
On 01/02/2013 12:57 PM, Stéphane Graber wrote:
> On 12/27/2012 03:52 AM, Natanael Copa wrote:
>> - avoid getopt --longoptions
>> - use 'which' instead of 'type' to detect existance of tools
>> - specify -s SIG with kill
>>
>> Signed-off-by: Natanael Copa
>
> Looks good. Pushed.
Turns out that no
On 12/31/2012 02:49 PM, Natanael Copa wrote:
> Signed-off-by: Natanael Copa
Looks good. Pushed.
Acked-by: Stéphane Graber
> ---
> templates/lxc-alpine.in | 28 ++--
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/templates/lxc-alpine.in b/template
On 12/31/2012 02:49 PM, Natanael Copa wrote:
> This allows us to lxc-create 32 bit guests on x86_64 hosts.
>
> Signed-off-by: Natanael Copa
Comment below, though good enough. Pushed.
Acked-by: Stéphane Graber
> ---
> templates/lxc-alpine.in | 28 ++--
> 1 file changed
On 12/31/2012 02:49 PM, Natanael Copa wrote:
> Make sure we actually install lxc-alpine
>
> Signed-off-by: Natanael Copa
Oops :)
Acked-by: Stéphane Graber
> ---
> templates/Makefile.am | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/templates/Makefile.am b/templat
On 12/31/2012 02:49 PM, Natanael Copa wrote:
> Let users append a list of packages they want install in the container
>
> Signed-off-by: Natanael Copa
Looks good. Pushed.
Acked-by: Stéphane Graber
> ---
> templates/lxc-alpine.in | 11 ---
> 1 file changed, 4 insertions(+), 7 deletion
On 12/31/2012 02:49 PM, Natanael Copa wrote:
> This allows specifying what repository to use for the container.
>
> Signed-off-by: Natanael Copa
Looks good. Pushed.
Acked-by: Stéphane Graber
> ---
> templates/lxc-alpine.in | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
On 12/26/2012 04:07 AM, Natanael Copa wrote:
> We cannot assume that the mount source name always starts with 'cgroup'
> so we check the filesystem type instead.
>
> Use 'awk' instead of 'grep -E' and as it is a better tool for this job.
>
> This fixes the tool on systems using openrc.
>
> Sign
On 12/27/2012 03:52 AM, Natanael Copa wrote:
> - avoid getopt --longoptions
> - use 'which' instead of 'type' to detect existance of tools
> - specify -s SIG with kill
>
> Signed-off-by: Natanael Copa
Looks good. Pushed.
Acked-by: Stéphane Graber
> ---
> dash didn't complain when I tested it,
On 12/28/2012 03:24 AM, Natanael Copa wrote:
> We now have the possibility to test for a given state. Use this feature
> instead of parsing output with grep or awk
>
> Signed-off-by: Natanael Copa
Looks like you didn't test the lxc-clone part as --status-is doesn't
exist, it's --state-is. Diff u
On 12/26/2012 04:31 PM, Natanael Copa wrote:
> Use awk to parse the output pf 'ps' and the tasks files for the
> containers.
>
> Use awk fields to find PID column rather than assume that the PID field
> is exactly 5 chars wide and has a leading space ' PID'. This works as
> long as the PID field i
On 12/31/2012 02:02 PM, Dwight Engen wrote:
> Signed-off-by: Dwight Engen
Looks good, thanks. Pushed.
Acked-by: Stéphane Graber
> ---
> src/lxc/console.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/lxc/console.c b/src/lxc/console.c
> index 73bec78..c3f892b 10
On 12/26/2012 04:07 AM, Natanael Copa wrote:
> We cannot assume that the mount source name always starts with 'cgroup'
> so we check the filesystem type instead.
>
> Use 'awk' instead of 'grep -E' and as it is a better tool for this job.
>
> This fixes the tool on systems using openrc.
>
> Sign
Hi,
Sorry for the delay.
I didn't test the change myself but the diff looks reasonable and
simplifies that template quite a bit.
Acked-by: Stéphane Graber
Pushed to staging. Thanks
On 12/13/2012 03:00 AM, Alexander Vladimirov wrote:
> ---
> templates/lxc-archlinux.in | 359
> +++
Hey everyone and an happy new year!
To avoid duplicating efforts, I thought it'd be worth mentioning that I
intend on reviewing all currently pending patches while on my flight
back from Europe.
So please consider all patches up until:
[PATCH 5/5] lxc-alpine: add support for installing optional p
19 matches
Mail list logo
