Re: [lttng-dev] cds_lfht_count_nodes always returns -1 for before/after counts

2015-04-25 Thread Jeff Layton
On Sat, 25 Apr 2015 17:29:02 -0400 Jeff Layton wrote: > Hi, I have some code using the cds_lfht infrastructure, and recently > added a function to check to see if the table was empty using > cds_lfht_count_nodes. That function just does this: > > rcu_read_lock(); > cds_lfht_count

Re: [lttng-dev] [BUG] lttng-sessiond

2015-04-25 Thread Hannes Weisbach
>> However, loading multiple probes with >> either --kmod-probes or --extra-kmod-probes still does not work: >> $ sudo lttng-sessiond -vvv --extra-kmod-probes=sched,napi >> [...] >> DEBUG1 - 11:42:18.492870 [5358/5358]: Modprobe successfully lttng-probe-napi >> (in modprobe_lttng() at modprobe.c:28

Re: [lttng-dev] [BUG] lttng-sessiond

2015-04-25 Thread Hannes Weisbach
> > Why do you need to load those explicitly ? They should be > already loaded by default. I don't get those errors here. > Which shell are you using (sh symlink) ? Can you reproduce > using bash ? Ok. Found the bug. In append_list_to_probes() index is used to get the current index into the prob

[lttng-dev] cds_lfht_count_nodes always returns -1 for before/after counts

2015-04-25 Thread Jeff Layton
Hi, I have some code using the cds_lfht infrastructure, and recently added a function to check to see if the table was empty using cds_lfht_count_nodes. That function just does this: rcu_read_lock(); cds_lfht_count_nodes(ht, &before, &count, &after); rcu_read_unlock(); Wha

Re: [lttng-dev] [PATCH] Fix: deadlock when thread join is issued in read-side C.S. (v2)

2015-04-25 Thread Mathieu Desnoyers
Merged into master, stable-0.8, stable-0.7, thanks ! Mathieu - Original Message - > On Sat, Apr 25, 2015 at 11:52:29AM -0400, Mathieu Desnoyers wrote: > > The transitive dependency between: > > > > RCU read-side C.S. -> synchronize_rcu -> rcu_gp_lock -> rcu_register_thread > > > > and t

Re: [lttng-dev] [PATCH] Fix: deadlock when thread join is issued in read-side C.S. (v2)

2015-04-25 Thread Paul E. McKenney
On Sat, Apr 25, 2015 at 11:52:29AM -0400, Mathieu Desnoyers wrote: > The transitive dependency between: > > RCU read-side C.S. -> synchronize_rcu -> rcu_gp_lock -> rcu_register_thread > > and the dependency: > > pthread_join -> awaiting for thread completion > > Can block a thread on join, and

[lttng-dev] [PATCH] Fix: deadlock when thread join is issued in read-side C.S. (v2)

2015-04-25 Thread Mathieu Desnoyers
The transitive dependency between: RCU read-side C.S. -> synchronize_rcu -> rcu_gp_lock -> rcu_register_thread and the dependency: pthread_join -> awaiting for thread completion Can block a thread on join, and thus have the side-effect of deadlocking a thread doing a pthread_join while within a

Re: [lttng-dev] [BUG] lttng-sessiond

2015-04-25 Thread Mathieu Desnoyers
- Original Message - > > > > Why do you need to load those explicitly ? They should be > > already loaded by default. I don't get those errors here. > > Which shell are you using (sh symlink) ? Can you reproduce > > using bash ? > Ok. Found the bug. In append_list_to_probes() index is us