----- Original Message ----- > > > > Why do you need to load those explicitly ? They should be > > already loaded by default. I don't get those errors here. > > Which shell are you using (sh symlink) ? Can you reproduce > > using bash ? > Ok. Found the bug. In append_list_to_probes() index is used to get > the current index into the probes array. However in the loop, index > is never incremented. Therefore, the first entry of probes is > overwritten, but nr_probes is incremented, and later those "empty" > entries are referenced. > > There is also a memory leak in append_list_to_probes(): > > tmp_list = strdup(list); // uses malloc() > next = strtok(tmp_list, ","); // tmp_list needs to be NULL except in the > first iteration > tmp_list = NULL; // so set it NULL > free(tmp_list); // good intention, does not work.
Thanks for spotting those issues! I'm CCing the author of this code. Mathieu > > Best regards, > Hannes > -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list lttng-dev@lists.lttng.org http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
