> Add skeletal code to increase the alignment of loads and stores when
> we can infer it. This will eventually help stuff, though it doesn't
> do much right now because all fixed FI's have an alignment of 1.
By the way, I've always assumed that alignment 0 is not used by the
code generators, i.e.
Hi Devang, what is this test testing? A compiler crash?
It doesn't crash here without your fix.
> +// RUN: %llvmgcc %s -S -o -
> +
> +// This struct is not 4 byte aligned becaues bit-field
> +// type does not influence struct alignment.
> +struct U { char a; short b; int c:25; char d; } u;
Ciao
Hi Devang,
> Fix 2008-01-24-StructAlignAndBitFields.c test case.
> Bit-field type does not influence struct alignment.
I don't see the point of trying to get the LLVM type to have the same
alignment as the gcc type. I think all the code that tries to obtain
equal alignment should just be dropped
Author: resistor
Date: Fri Jan 25 04:10:33 2008
New Revision: 46351
URL: http://llvm.org/viewvc/llvm-project?rev=46351&view=rev
Log:
DeadStoreElimination can treat byval parameters as if there were alloca's for
the purpose of removing end-of-function stores.
Added:
llvm/trunk/test/Transforms
Author: baldrick
Date: Fri Jan 25 04:20:53 2008
New Revision: 46352
URL: http://llvm.org/viewvc/llvm-project?rev=46352&view=rev
Log:
Add more assertions to catch accesses outside of
arrays. Also, as a convenience, don't barf, just
return false, if someone calls isTruncStoreLegal
or isLoadXLegal w
PS: Does an alignment of 0 mean the ABI alignment or the preferred
alignment? I'm guessing that it means ABI for globals and
preferred for allocas.
___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-comm
On Jan 25, 2008, at 1:01 AM, Duncan Sands wrote:
> Hi Devang,
>
>> Fix 2008-01-24-StructAlignAndBitFields.c test case.
>> Bit-field type does not influence struct alignment.
>
> I don't see the point of trying to get the LLVM type to have the same
> alignment as the gcc type. I think all the cod
On Jan 25, 2008, at 12:53 AM, Duncan Sands wrote:
>> Add skeletal code to increase the alignment of loads and stores when
>> we can infer it. This will eventually help stuff, though it doesn't
>> do much right now because all fixed FI's have an alignment of 1.
>
> By the way, I've always assumed
Author: lattner
Date: Fri Jan 25 11:49:41 2008
New Revision: 46360
URL: http://llvm.org/viewvc/llvm-project?rev=46360&view=rev
Log:
Reorder a field to reduce the size of StackObject. Note that this
may require a clean rebuild on leopard. :(
Modified:
llvm/trunk/include/llvm/CodeGen/MachineFr
Author: baldrick
Date: Fri Jan 25 11:45:31 2008
New Revision: 46359
URL: http://llvm.org/viewvc/llvm-project?rev=46359&view=rev
Log:
Fix PR1942. When returning an aggregate result,
create a temporary to hold the result, and copy
it out when returning.
Modified:
llvm-gcc-4.0/trunk/gcc/llvm-co
How would this test case pass if the target does not pass structs byval?
Evan
On Jan 25, 2008, at 2:36 PM, Chris Lattner wrote:
> Author: lattner
> Date: Fri Jan 25 16:36:24 2008
> New Revision: 46372
>
> URL: http://llvm.org/viewvc/llvm-project?rev=46372&view=rev
> Log:
> add a testcase for a b
Author: void
Date: Fri Jan 25 19:43:44 2008
New Revision: 46387
URL: http://llvm.org/viewvc/llvm-project?rev=46387&view=rev
Log:
If we have a function like this:
void bork() {
int *address = 0;
*address = 0;
}
It's compiled into LLVM code that looks like this:
define void @bork() noreturn n
On Jan 25, 2008, at 5:43 PM, Bill Wendling wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=46387&view=rev
> Log:
> If we have a function like this:
>
> This is bad on some platforms (like PPC) because it will generate
> the label for
> the function but no body. The label could end up being
Author: baldrick
Date: Fri Jan 25 23:33:48 2008
New Revision: 46391
URL: http://llvm.org/viewvc/llvm-project?rev=46391&view=rev
Log:
Correct spelling.
Modified:
llvm-gcc-4.2/trunk/gcc/llvm-abi.h
Modified: llvm-gcc-4.2/trunk/gcc/llvm-abi.h
URL:
http://llvm.org/viewvc/llvm-project/llvm-gcc-4.
> If a function takes a byval parameter, it can't be readnone, we
> have to mark it readonly instead. This fixes
> test/CFrontend/2008-01-25-ByValReadNone.c
Thanks for doing this!
Duncan.
___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://l
Author: void
Date: Sat Jan 26 00:53:06 2008
New Revision: 46395
URL: http://llvm.org/viewvc/llvm-project?rev=46395&view=rev
Log:
Move testcase to the code gen directory.
Added:
llvm/trunk/test/CodeGen/PowerPC/2008-01-25-EmptyFunction.c
- copied unchanged from r46390,
llvm/trunk/test/CF
Author: void
Date: Sat Jan 26 00:53:40 2008
New Revision: 46396
URL: http://llvm.org/viewvc/llvm-project?rev=46396&view=rev
Log:
Rename the .c to .ll
Added:
llvm/trunk/test/CodeGen/PowerPC/2008-01-25-EmptyFunction.ll
- copied unchanged from r46395,
llvm/trunk/test/CodeGen/PowerPC/2008-
Author: void
Date: Sat Jan 26 00:56:08 2008
New Revision: 46397
URL: http://llvm.org/viewvc/llvm-project?rev=46397&view=rev
Log:
Need to convert to LLVM code and not C.
Modified:
llvm/trunk/test/CodeGen/PowerPC/2008-01-25-EmptyFunction.ll
Modified: llvm/trunk/test/CodeGen/PowerPC/2008-01-25-
Hi Evan, dropping zero sized aggregates from types
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20080121/057570.html
broke the Ada build. A zero-sized aggregate is used in a COMPONENT_REF, so
llvm-convert barfs because it can't find the corresponding LLVM field. All gcc
fields shou
On Jan 25, 2008, at 4:35 PM, Evan Cheng wrote:
> How would this test case pass if the target does not pass structs
> byval?
That's why I picked a big struct. :)
-Chris
>
> Evan
>
> On Jan 25, 2008, at 2:36 PM, Chris Lattner wrote:
>
>> Author: lattner
>> Date: Fri Jan 25 16:36:24 2008
>> New
Author: lattner
Date: Fri Jan 25 19:09:19 2008
New Revision: 46384
URL: http://llvm.org/viewvc/llvm-project?rev=46384&view=rev
Log:
Fix some bugs in SimplifyNodeWithTwoResults where it would call deletenode to
delete a node even if it was not dead in some cases. Instead, just add it to
the workl
Author: lattner
Date: Fri Jan 25 19:05:42 2008
New Revision: 46383
URL: http://llvm.org/viewvc/llvm-project?rev=46383&view=rev
Log:
don't bother making x&-1 only to simplify it in dag combine. This commonly
occurs expanding i64 ops.
Modified:
llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG
Author: evancheng
Date: Fri Jan 25 18:35:43 2008
New Revision: 46382
URL: http://llvm.org/viewvc/llvm-project?rev=46382&view=rev
Log:
New test case.
Added:
llvm/trunk/test/CFrontend/2008-01-25-ZeroSizedAggregate.c
Added: llvm/trunk/test/CFrontend/2008-01-25-ZeroSizedAggregate.c
URL:
http://
Author: evancheng
Date: Fri Jan 25 18:17:32 2008
New Revision: 46381
URL: http://llvm.org/viewvc/llvm-project?rev=46381&view=rev
Log:
Also drop zero-sized aggregates during type conversion.
Modified:
llvm-gcc-4.2/trunk/gcc/llvm-abi.h
llvm-gcc-4.2/trunk/gcc/llvm-internal.h
llvm-gcc-4.2
Author: lattner
Date: Fri Jan 25 17:34:24 2008
New Revision: 46377
URL: http://llvm.org/viewvc/llvm-project?rev=46377&view=rev
Log:
reduce indentation
Modified:
llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
URL:
http://llvm
Author: void
Date: Sat Jan 26 00:51:24 2008
New Revision: 46394
URL: http://llvm.org/viewvc/llvm-project?rev=46394&view=rev
Log:
If there are no machine instructions emitted for a function, then insert
a "nop" instruction so that we don't have the function's label associated
with something that it
Author: baldrick
Date: Sat Jan 26 00:03:12 2008
New Revision: 46392
URL: http://llvm.org/viewvc/llvm-project?rev=46392&view=rev
Log:
Silence a warning.
Modified:
llvm-gcc-4.2/trunk/gcc/llvm-types.cpp
Modified: llvm-gcc-4.2/trunk/gcc/llvm-types.cpp
URL:
http://llvm.org/viewvc/llvm-project/ll
On Jan 25, 2008, at 2:05 PM, Dale Johannesen wrote:
>
> On Jan 25, 2008, at 9:49 AM, Chris Lattner wrote:
>
>> Author: lattner
>> Date: Fri Jan 25 11:49:41 2008
>> New Revision: 46360
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=46360&view=rev
>> Log:
>> Reorder a field to reduce the size o
Author: lattner
Date: Fri Jan 25 16:37:31 2008
New Revision: 46373
URL: http://llvm.org/viewvc/llvm-project?rev=46373&view=rev
Log:
If a function takes a byval parameter, it can't be readnone, we
have to mark it readonly instead. This fixes
test/CFrontend/2008-01-25-ByValReadNone.c
Modified:
Author: baldrick
Date: Fri Jan 25 16:06:51 2008
New Revision: 46369
URL: http://llvm.org/viewvc/llvm-project?rev=46369&view=rev
Log:
Do this more neatly.
Modified:
llvm/trunk/lib/Transforms/Utils/InlineFunction.cpp
Modified: llvm/trunk/lib/Transforms/Utils/InlineFunction.cpp
URL:
http://llv
Hi Anton,
Here is a silly test case:
#include
struct ss {
int x;
int y;
};
void f(int a, struct ss b) {
=>printf("%d %d\n", a, b.x);
}
int main() {
struct ss S = {1, 2};
f(0, S);
return 0;
}
Problem 1:
(gdb) b main
Line number not known for symbol "main"
Explicitly setting a brea
Author: baldrick
Date: Fri Jan 25 11:36:44 2008
New Revision: 46357
URL: http://llvm.org/viewvc/llvm-project?rev=46357&view=rev
Log:
Test for PR1942.
Added:
llvm/trunk/test/C++Frontend/2008-01-25-ResultIsParam.cpp
Added: llvm/trunk/test/C++Frontend/2008-01-25-ResultIsParam.cpp
URL:
http://l
Author: lattner
Date: Fri Jan 25 11:24:52 2008
New Revision: 46355
URL: http://llvm.org/viewvc/llvm-project?rev=46355&view=rev
Log:
fix long lines.
Modified:
llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
URL:
http
On Jan 25, 2008, at 8:37 AM, Duncan Sands wrote:
>>> PS: Does an alignment of 0 mean the ABI alignment or the preferred
>>> alignment? I'm guessing that it means ABI for globals and
>>> preferred for allocas.
>>
>> In what context?
>
> In any context :) Basically I'm asking what it means if you
On Jan 24, 2008, at 11:53 PM, Evan Cheng wrote:
> Ugh, really??
Yep, I didn't have time to investigate, but will try to look into it
today.
-Chris
>
> Evan
> On Jan 24, 2008, at 11:29 PM, Chris Lattner wrote:
>
>> Author: lattner
>> Date: Fri Jan 25 01:29:34 2008
>> New Revision: 46350
>>
>> U
Author: baldrick
Date: Sat Jan 26 00:41:49 2008
New Revision: 46393
URL: http://llvm.org/viewvc/llvm-project?rev=46393&view=rev
Log:
Create an explicit copy for byval parameters even
when inlining a readonly function.
Added:
llvm/trunk/test/CFrontend/2008-01-26-ReadOnlyByVal.c
Modified:
l
Author: dpatel
Date: Fri Jan 25 19:21:48 2008
New Revision: 46385
URL: http://llvm.org/viewvc/llvm-project?rev=46385&view=rev
Log:
Add another testcase.
Modified:
llvm/trunk/test/CFrontend/2008-01-25-ZeroSizedAggregate.c
Modified: llvm/trunk/test/CFrontend/2008-01-25-ZeroSizedAggregate.c
URL
Hello, Evan
> Problem 1:
> (gdb) b main
> Line number not known for symbol "main"
> Explicitly setting a breakpoint on line 10 works.
That's strange. This definitely works for me. Could you please send me
the .bc and native gcc output with extra -dA option?
> Problem 2:
> In function f().
> (gdb)
Hello, Evan
> Problem 1:
> (gdb) b main
> Line number not known for symbol "main"
> Explicitly setting a breakpoint on line 10 works.
That's strange. This definitely works for me. Could you please send me
the .bc and native gcc output with extra -dA option?
> Problem 2:
> In function f().
> (gdb)
Author: lattner
Date: Fri Jan 25 10:41:09 2008
New Revision: 46354
URL: http://llvm.org/viewvc/llvm-project?rev=46354&view=rev
Log:
JITEmitter.cpp was trying to sync the icache for function stubs, but
was actually passing a completely incorrect size to sys_icache_invalidate.
Instead of having the
Hi Devang, this patch causes:
llvm-types.cpp: In member function ‘bool
TypeConverter::DecodeStructFields(tree_node*, StructTypeConversionInfo&)’:
llvm-types.cpp:1777: warning: comparison between signed and unsigned integer
expressions
Ciao,
Duncan.
On Jan 25, 2008, at 2:07 AM, Duncan Sands wrote:
> PS: Does an alignment of 0 mean the ABI alignment or the preferred
> alignment? I'm guessing that it means ABI for globals and
> preferred for allocas.
In what context?
-Chris
___
llvm-commits maili
> > PS: Does an alignment of 0 mean the ABI alignment or the preferred
> > alignment? I'm guessing that it means ABI for globals and
> > preferred for allocas.
>
> In what context?
In any context :) Basically I'm asking what it means if you pass an
alignment of 0 for an alloca (or a global). F
On Jan 25, 2008, at 6:11 AM, Duncan Sands wrote:
> Hi Devang, this patch causes:
>
> llvm-types.cpp: In member function ‘bool
> TypeConverter::DecodeStructFields(tree_node*,
> StructTypeConversionInfo&)’:
> llvm-types.cpp:1777: warning: comparison between signed and unsigned
> integer expre
On Jan 25, 2008, at 12:55 AM, Duncan Sands wrote:
> Hi Devang, what is this test testing? A compiler crash?
> It doesn't crash here without your fix.
Hmm.. did you try assertion enabled build ? What is the size and
alignment of this struct for you without this patch ?
-
Devang
>
>
>> +// RUN:
Author: baldrick
Date: Fri Jan 25 11:36:35 2008
New Revision: 46356
URL: http://llvm.org/viewvc/llvm-project?rev=46356&view=rev
Log:
Fix PR1942. When returning an aggregate result,
create a temporary to hold the result, and copy
it out when returning.
Modified:
llvm-gcc-4.2/trunk/gcc/llvm-co
Hi Duncan,
On Jan 25, 2008, at 1:01 AM, Duncan Sands wrote:
> Hi Devang,
>
>> Fix 2008-01-24-StructAlignAndBitFields.c test case.
>> Bit-field type does not influence struct alignment.
>
> I don't see the point of trying to get the LLVM type to have the same
> alignment as the gcc type.
This pat
On Jan 25, 2008, at 9:49 AM, Chris Lattner wrote:
> Author: lattner
> Date: Fri Jan 25 11:49:41 2008
> New Revision: 46360
>
> URL: http://llvm.org/viewvc/llvm-project?rev=46360&view=rev
> Log:
> Reorder a field to reduce the size of StackObject. Note that this
> may require a clean rebuild on l
Author: lattner
Date: Fri Jan 25 16:36:24 2008
New Revision: 46372
URL: http://llvm.org/viewvc/llvm-project?rev=46372&view=rev
Log:
add a testcase for a bug Duncan pointed out.
Added:
llvm/trunk/test/CFrontend/2008-01-25-ByValReadNone.c
Added: llvm/trunk/test/CFrontend/2008-01-25-ByValReadNo
Author: evancheng
Date: Fri Jan 25 17:02:28 2008
New Revision: 46375
URL: http://llvm.org/viewvc/llvm-project?rev=46375&view=rev
Log:
Drop zero-sized aggregate arguments.
Modified:
llvm-gcc-4.2/trunk/gcc/llvm-abi.h
Modified: llvm-gcc-4.2/trunk/gcc/llvm-abi.h
URL:
http://llvm.org/viewvc/llvm
Okay.
On Jan 25, 2008, at 7:26 PM, Chris Lattner wrote:
> On Jan 25, 2008, at 5:43 PM, Bill Wendling wrote:
>> URL: http://llvm.org/viewvc/llvm-project?rev=46387&view=rev
>> Log:
>> If we have a function like this:
>>
>> This is bad on some platforms (like PPC) because it will generate
>> the lab
Author: baldrick
Date: Fri Jan 25 23:27:18 2008
New Revision: 46390
URL: http://llvm.org/viewvc/llvm-project?rev=46390&view=rev
Log:
Correct comment.
Modified:
llvm-gcc-4.2/trunk/gcc/llvm-types.cpp
Modified: llvm-gcc-4.2/trunk/gcc/llvm-types.cpp
URL:
http://llvm.org/viewvc/llvm-project/llvm
52 matches
Mail list logo
