[llvm-commits] [llvm] r41167 - /llvm/trunk/include/llvm/Analysis/Dominators.h

2007-08-18 Thread Nick Lewycky
Author: nicholas Date: Sat Aug 18 09:46:55 2007 New Revision: 41167 URL: http://llvm.org/viewvc/llvm-project?rev=41167&view=rev Log: Simplify. Modified: llvm/trunk/include/llvm/Analysis/Dominators.h Modified: llvm/trunk/include/llvm/Analysis/Dominators.h URL: http://llvm.org/viewvc/llvm-pro

[llvm-commits] [llvm] r41168 - /llvm/trunk/lib/Transforms/Scalar/LICM.cpp

2007-08-18 Thread Nick Lewycky
Author: nicholas Date: Sat Aug 18 10:08:56 2007 New Revision: 41168 URL: http://llvm.org/viewvc/llvm-project?rev=41168&view=rev Log: Typo. Modified: llvm/trunk/lib/Transforms/Scalar/LICM.cpp Modified: llvm/trunk/lib/Transforms/Scalar/LICM.cpp URL: http://llvm.org/viewvc/llvm-project/llvm/tr

[llvm-commits] [llvm] r41170 - /llvm/trunk/lib/Transforms/Scalar/PredicateSimplifier.cpp

2007-08-18 Thread Nick Lewycky
Author: nicholas Date: Sat Aug 18 18:21:28 2007 New Revision: 41170 URL: http://llvm.org/viewvc/llvm-project?rev=41170&view=rev Log: Oops, remove assert that wasn't meant to be committed. Modified: llvm/trunk/lib/Transforms/Scalar/PredicateSimplifier.cpp Modified: llvm/trunk/lib/Transforms/S

[llvm-commits] [llvm] r41169 - /llvm/trunk/lib/Transforms/Scalar/PredicateSimplifier.cpp

2007-08-18 Thread Nick Lewycky
Author: nicholas Date: Sat Aug 18 18:18:03 2007 New Revision: 41169 URL: http://llvm.org/viewvc/llvm-project?rev=41169&view=rev Log: Never insert duplicate edges. Modified: llvm/trunk/lib/Transforms/Scalar/PredicateSimplifier.cpp Modified: llvm/trunk/lib/Transforms/Scalar/PredicateSimplifier

Re: [llvm-commits] PR1146 patch for llvm-gcc-4.0

2007-08-18 Thread Duncan Sands
Hi Reid, > + bool extend = false; it looks like extend is never assigned another value. Ciao, Duncan. ___ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

Re: [llvm-commits] PR1146 patch for llvm-gcc-4.0

2007-08-18 Thread Duncan Sands
Hi Reid, > - Attrs.push_back(ParamAttrsWithIndex::get(ArgTypes.size(), Attributes)); > + Client.addAttributes(ArgTypes.size(), Attributes); all users of addAttributes seem to be adding a new attribute at the back. Given this, your implementation of addAttributes looks inefficient. Als

Re: [llvm-commits] PR1146 patch for llvm-gcc-4.0

2007-08-18 Thread Duncan Sands
Hi Reid, in ConvertFunctionType: > + PAL = 0; so there is no need for callers to set PAL = 0 before calling ConvertFunctionType, as they all do right now. For that matter, it's not clear that this assignment is needed since it looks like PAL is always assigned elsewhere before ConvertFunctionTy

Re: [llvm-commits] PR1146 patch for llvm-gcc-4.0

2007-08-18 Thread Reid Spencer
On Thu, 2007-08-16 at 16:27 +0200, Duncan Sands wrote: > Hi Reid, > > > + bool extend = false; > > it looks like extend is never assigned another value. This doesn't exist in the current patch. > > Ciao, > > Duncan. ___ llvm-commits mailing li

Re: [llvm-commits] PR1146 patch for llvm-gcc-4.0

2007-08-18 Thread Reid Spencer
On Thu, 2007-08-16 at 16:32 +0200, Duncan Sands wrote: > Hi Reid, > > in ConvertFunctionType: > > > + PAL = 0; > > so there is no need for callers to set PAL = 0 before > calling ConvertFunctionType, as they all do right now. > For that matter, it's not clear that this assignment is > needed si

Re: [llvm-commits] PR1146 patch for llvm-gcc-4.0

2007-08-18 Thread Reid Spencer
On Thu, 2007-08-16 at 17:56 +0200, Duncan Sands wrote: > Hi Reid, > > > - Attrs.push_back(ParamAttrsWithIndex::get(ArgTypes.size(), > > Attributes)); > > + Client.addAttributes(ArgTypes.size(), Attributes); > > all users of addAttributes seem to be adding a new attribute at > the back.