Hi Reid, > - Attrs.push_back(ParamAttrsWithIndex::get(ArgTypes.size(), Attributes)); > + Client.addAttributes(ArgTypes.size(), Attributes);
all users of addAttributes seem to be adding a new attribute at the back. Given this, your implementation of addAttributes looks inefficient. Also, does it work correctly? - addAttributes doesn't add the attribute at all if there are no existing attributes for that index, which seems to be exactly the case for every use of it! Ciao, Duncan. _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
