Re: [llvm-commits] [llvm] r45850 - /llvm/trunk/lib/VMCore/Verifier.cpp

2008-01-16 Thread Chris Lattner
On Jan 16, 2008, at 2:58 PM, Duncan Sands wrote: > Hi Chris, > >>> try this example. Argpromotion deletes the zeroext attribute on the >>> call. >> >> Right, it deletes it because the attr is on the call not the >> function. I can make this work, but shouldn't the attr also be on >> the >> fu

Re: [llvm-commits] [llvm] r45850 - /llvm/trunk/lib/VMCore/Verifier.cpp

2008-01-16 Thread Chris Lattner
On Jan 16, 2008, at 12:07 AM, Duncan Sands wrote: > Hi Chris, >> ArgPromotion does do this, and I added a testcase to verify it. It >> looks like it recomputes the Function's param attrs perfectly and >> just >> applies that attr list to all calls. > > try this example. Argpromotion deletes the

Re: [llvm-commits] [llvm] r45850 - /llvm/trunk/lib/VMCore/Verifier.cpp

2008-01-15 Thread Chris Lattner
On Jan 13, 2008, at 12:18 AM, Duncan Sands wrote: >>> there are some issues that need to be fixed: >>> (1) the asm parser drops parameter attributes specified on the >>> varargs >>> part of a call/invoke; >>> (2) when the DAE pass drops varargs call arguments, the parameter >>> attributes need

Re: [llvm-commits] [llvm] r45850 - /llvm/trunk/lib/VMCore/Verifier.cpp

2008-01-13 Thread Duncan Sands
> > there are some issues that need to be fixed: > > (1) the asm parser drops parameter attributes specified on the varargs > > part of a call/invoke; > > (2) when the DAE pass drops varargs call arguments, the parameter > > attributes need to be trimmed, since otherwise you can have attributes > >

Re: [llvm-commits] [llvm] r45850 - /llvm/trunk/lib/VMCore/Verifier.cpp

2008-01-11 Thread Chris Lattner
On Jan 10, 2008, at 11:45 PM, Evan Cheng wrote: > > On Jan 10, 2008, at 10:43 PM, Duncan Sands wrote: > >> Hi Evan, >> >>> Allow parameter attributes on varargs function parameters. >> >> there are some issues that need to be fixed: >> (1) the asm parser drops parameter attributes specified on th

Re: [llvm-commits] [llvm] r45850 - /llvm/trunk/lib/VMCore/Verifier.cpp

2008-01-11 Thread Evan Cheng
One more. When llvm-extract remove a function with byval parameters, it also drops the attribute. Just in case you are interested. :-) If you don't get to it soon, I'll hack on it tomorrow. Thanks, Evan On Jan 10, 2008, at 10:43 PM, Duncan Sands wrote: > Hi Evan, > >> Allow parameter attri

Re: [llvm-commits] [llvm] r45850 - /llvm/trunk/lib/VMCore/Verifier.cpp

2008-01-10 Thread Evan Cheng
On Jan 10, 2008, at 10:43 PM, Duncan Sands wrote: > Hi Evan, > >> Allow parameter attributes on varargs function parameters. > > there are some issues that need to be fixed: > (1) the asm parser drops parameter attributes specified on the varargs > part of a call/invoke; > (2) when the DAE pass d

Re: [llvm-commits] [llvm] r45850 - /llvm/trunk/lib/VMCore/Verifier.cpp

2008-01-10 Thread Duncan Sands
Hi Evan, > Allow parameter attributes on varargs function parameters. there are some issues that need to be fixed: (1) the asm parser drops parameter attributes specified on the varargs part of a call/invoke; (2) when the DAE pass drops varargs call arguments, the parameter attributes need to be