On Jan 16, 2008, at 12:07 AM, Duncan Sands wrote: > Hi Chris, >> ArgPromotion does do this, and I added a testcase to verify it. It >> looks like it recomputes the Function's param attrs perfectly and >> just >> applies that attr list to all calls. > > try this example. Argpromotion deletes the zeroext attribute on the > call.
Right, it deletes it because the attr is on the call not the function. I can make this work, but shouldn't the attr also be on the function? -Chris > > ; RUN: llvm-as < %s | opt -argpromotion | llvm-dis | grep zeroext > > %struct.ss = type { i32, i64 } > > define internal void @f(%struct.ss* byval %b, i32* byval %X, i32 > %i) nounwind { > entry: > %tmp = getelementptr %struct.ss* %b, i32 0, i32 0 > %tmp1 = load i32* %tmp, align 4 > %tmp2 = add i32 %tmp1, 1 > store i32 %tmp2, i32* %tmp, align 4 > > store i32 0, i32* %X > ret void > } > > define i32 @test(i32* %X) { > entry: > %S = alloca %struct.ss ; <%struct.ss*> [#uses=4] > %tmp1 = getelementptr %struct.ss* %S, i32 0, i32 0 ; > <i32*> > [#uses=1] > store i32 1, i32* %tmp1, align 8 > %tmp4 = getelementptr %struct.ss* %S, i32 0, i32 1 ; > <i64*> > [#uses=1] > store i64 2, i64* %tmp4, align 4 > call void @f( %struct.ss* byval %S, i32* byval %X, i32 zeroext 0) > ret i32 0 > } _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits