Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-12 Thread Chris Lattner
On Dec 12, 2007, at 12:16 AM, Christopher Lamb wrote: >>> >>> >>> They don't. >> >> Ok. It would still be nicer to get to: > @foo = dllexport global i32 addrspace(1) 0 >> >> :) > > Yes. Bison ate its own head when I tried to do this though. Also > there are nasty side affects of allowing a

Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-12 Thread Christopher Lamb
On Dec 11, 2007, at 10:45 PM, Chris Lattner wrote: @foo = internal global i32 0 addrspace(1) @foo = weak global i32 0 addrspace(1) @foo = linkonce global i32 0 addrspace(1) @foo = appending global i32 0 addrspace(1) @foo = dllexport global i32 0 addrspace(1) I prefer that too, but I don't see

Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-11 Thread Chris Lattner
>>> @foo = internal global i32 0 addrspace(1) >>> @foo = weak global i32 0 addrspace(1) >>> @foo = linkonce global i32 0 addrspace(1) >>> @foo = appending global i32 0 addrspace(1) >>> @foo = dllexport global i32 0 addrspace(1) >> >> I prefer that too, but I don't see how you're going to get bison

Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-11 Thread Christopher Lamb
On Dec 11, 2007, at 10:30 PM, Chris Lattner wrote: How horrible would: @foo = addrspace(1) external global i32 be? I like that the order in the decl is the order in the type lots. These now work with the rules being adjusted. @foo = extern_weak global i32 addrspace(1) @foo = external gl

Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-11 Thread Chris Lattner
>>> How horrible would: >>> @foo = addrspace(1) external global i32 >>> >>> be? >> >> I like that the order in the decl is the order in the type lots. >> >> These now work with the rules being adjusted. >> >> @foo = extern_weak global i32 addrspace(1) >> @foo = external global i32 addrspace(1)

Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-11 Thread Christopher Lamb
On Dec 11, 2007, at 10:12 PM, Christopher Lamb wrote: On Dec 11, 2007, at 9:16 PM, Chris Lattner wrote: On Dec 11, 2007, at 9:08 PM, Christopher Lamb wrote: On Dec 11, 2007, at 8:50 PM, Chris Lattner wrote: That is a very strong argument to me, but it seems to argue even more strongly

Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-11 Thread Christopher Lamb
On Dec 11, 2007, at 9:16 PM, Chris Lattner wrote: > > On Dec 11, 2007, at 9:08 PM, Christopher Lamb wrote: > >> >> On Dec 11, 2007, at 8:50 PM, Chris Lattner wrote: >> > That is a very strong argument to me, but it seems to argue even > more > strongly for: > > @G = constant f

Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-11 Thread Chris Lattner
On Dec 11, 2007, at 9:08 PM, Christopher Lamb wrote: > > On Dec 11, 2007, at 8:50 PM, Chris Lattner wrote: > That is a very strong argument to me, but it seems to argue even more strongly for: @G = constant float addrspace(5) 1.0, section "foo", align 4 Your e

Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-11 Thread Christopher Lamb
On Dec 11, 2007, at 8:50 PM, Chris Lattner wrote: That is a very strong argument to me, but it seems to argue even more strongly for: @G = constant float addrspace(5) 1.0, section "foo", align 4 Your example above would then be: @foo = constant float addrspace(1)* addrspace(2) 1.0 which

Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-11 Thread Chris Lattner
>> That is a very strong argument to me, but it seems to argue even more >> strongly for: >> >> @G = constant float addrspace(5) 1.0, section "foo", align 4 >> >> Your example above would then be: >> >>> @foo = constant float addrspace(1)* addrspace(2) 1.0 >> >> which has type: >> >>> float addrspa

Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-11 Thread Christopher Lamb
On Dec 11, 2007, at 8:34 PM, Chris Lattner wrote: On Dec 11, 2007, at 5:56 PM, Christopher Lamb wrote: On Dec 11, 2007, at 3:54 PM, Chris Lattner wrote: On Dec 11, 2007, at 1:31 AM, Christopher Lamb wrote: Add information on address space qualifiers for pointer types and global declarati

Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-11 Thread Chris Lattner
On Dec 11, 2007, at 5:56 PM, Christopher Lamb wrote: > > On Dec 11, 2007, at 3:54 PM, Chris Lattner wrote: > >> On Dec 11, 2007, at 1:31 AM, Christopher Lamb wrote: >>> Add information on address space qualifiers for pointer types and >>> global >>> declarations to the LangRef. >> >> Nice! >> >>>

Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-11 Thread Christopher Lamb
On Dec 11, 2007, at 3:54 PM, Chris Lattner wrote: On Dec 11, 2007, at 1:31 AM, Christopher Lamb wrote: Add information on address space qualifiers for pointer types and global declarations to the LangRef. Nice! [EMAIL PROTECTED] = constant float 1.0 addrspace(5), section "foo", align 4

Re: [llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-11 Thread Chris Lattner
On Dec 11, 2007, at 1:31 AM, Christopher Lamb wrote: > Add information on address space qualifiers for pointer types and > global > declarations to the LangRef. Nice! > > > [EMAIL PROTECTED] = constant float 1.0 addrspace(5), section "foo", align 4 Is there a comma after 1.0? -Chris _

[llvm-commits] [llvm] r44860 - /llvm/trunk/docs/LangRef.html

2007-12-11 Thread Christopher Lamb
Author: clamb Date: Tue Dec 11 03:31:00 2007 New Revision: 44860 URL: http://llvm.org/viewvc/llvm-project?rev=44860&view=rev Log: Add information on address space qualifiers for pointer types and global declarations to the LangRef. Modified: llvm/trunk/docs/LangRef.html Modified: llvm/trunk