[llvm-branch-commits] [llvm] [CodeGen][NewPM] Port EarlyIfConversion pass to NPM. (PR #108508)

2024-09-12 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-backend-systemz Author: Christudasan Devadasan (cdevadas) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/108508.diff 18 Files Affected: - (added) llvm/include/llvm/CodeGen/EarlyIfConversion.h (+

[llvm-branch-commits] [llvm] [CodeGen][NewPM] Port EarlyIfConversion pass to NPM. (PR #108508)

2024-09-12 Thread Christudasan Devadasan via llvm-branch-commits
https://github.com/cdevadas ready_for_review https://github.com/llvm/llvm-project/pull/108508 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CodeGen][NewPM] Port machine trace metrics analysis to new pass manager. (PR #108507)

2024-09-12 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Christudasan Devadasan (cdevadas) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/108507.diff 9 Files Affected: - (modified) llvm/include/llvm/CodeGen/MachineTraceMetrics.h (+50-8) - (modified) llvm/include/

[llvm-branch-commits] [llvm] [CodeGen][NewPM] Port machine trace metrics analysis to new pass manager. (PR #108507)

2024-09-12 Thread Christudasan Devadasan via llvm-branch-commits
https://github.com/cdevadas ready_for_review https://github.com/llvm/llvm-project/pull/108507 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [CodeGen][NewPM] Port machine trace metrics analysis to new pass manager. (PR #108507)

2024-09-12 Thread Christudasan Devadasan via llvm-branch-commits
cdevadas wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/108507?utm_source=stack-comment-downstack-mergeability-warning"

[llvm-branch-commits] [llvm] [CodeGen][NewPM] Port EarlyIfConversion pass to NPM. (PR #108508)

2024-09-12 Thread Christudasan Devadasan via llvm-branch-commits
cdevadas wrote: > [!WARNING] > This pull request is not mergeable via GitHub because a downstack PR is > open. Once all requirements are satisfied, merge this PR as a stack href="https://app.graphite.dev/github/pr/llvm/llvm-project/108508?utm_source=stack-comment-downstack-mergeability-warning"

[llvm-branch-commits] [llvm] [CodeGen][NewPM] Port EarlyIfConversion pass to NPM. (PR #108508)

2024-09-12 Thread Christudasan Devadasan via llvm-branch-commits
https://github.com/cdevadas created https://github.com/llvm/llvm-project/pull/108508 None >From 8c819329488c087fce339d4fd65761bc986ed80e Mon Sep 17 00:00:00 2001 From: Christudasan Devadasan Date: Fri, 13 Sep 2024 12:22:03 +0530 Subject: [PATCH] [CodeGen][NewPM] Port EarlyIfConversion pass to

[llvm-branch-commits] [llvm] [CodeGen][NewPM] Port machine trace metrics analysis to new pass manager. (PR #108507)

2024-09-12 Thread Christudasan Devadasan via llvm-branch-commits
https://github.com/cdevadas created https://github.com/llvm/llvm-project/pull/108507 None >From b56e90fa59c0f5db905b94aa74c771e3f72cd81d Mon Sep 17 00:00:00 2001 From: Christudasan Devadasan Date: Thu, 12 Sep 2024 23:38:09 +0530 Subject: [PATCH] [CodeGen][NewPM] Port machine trace metrics anal

[llvm-branch-commits] [llvm] release/19.x: [RISCV] Don't outline pcrel_lo when the function has a section prefix (#107943) (PR #108288)

2024-09-12 Thread Pengcheng Wang via llvm-branch-commits
wangpc-pp wrote: > Hi, since we are wrapping up LLVM 19.1.0 we are very strict with the fixes we > pick at this point. Can you please respond to the following questions to help > me understand if this has to be included in the final release or not. > > Is this PR a fix for a regression or a cr

[llvm-branch-commits] [llvm] release/19.x: [DAGCombiner] cache negative result from getMergeStoreCandidates() (#106949) (PR #108397)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
tru wrote: Hi, since we are wrapping up LLVM 19.1.0 we are very strict with the fixes we pick at this point. Can you please respond to the following questions to help me understand if this has to be included in the final release or not. Is this PR a fix for a regression or a critical issue?

[llvm-branch-commits] [llvm] release/19.x: [RISCV] Don't outline pcrel_lo when the function has a section prefix (#107943) (PR #108288)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
tru wrote: Hi, since we are wrapping up LLVM 19.1.0 we are very strict with the fixes we pick at this point. Can you please respond to the following questions to help me understand if this has to be included in the final release or not. Is this PR a fix for a regression or a critical issue?

[llvm-branch-commits] [clang] release/19.x: [Clang] Fix crash due to invalid source location in __is_trivially_equality_comparable (#107815) (PR #108147)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
tru wrote: Hi, since we are wrapping up LLVM 19.1.0 we are very strict with the fixes we pick at this point. Can you please respond to the following questions to help me understand if this has to be included in the final release or not. Is this PR a fix for a regression or a critical issue?

[llvm-branch-commits] [llvm] release/19.x: [Windows SEH] Fix crash on empty seh block (#107031) (PR #107466)

2024-09-12 Thread via llvm-branch-commits
github-actions[bot] wrote: @jrtc27 (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. ht

[llvm-branch-commits] [llvm] release/19.x: [Windows SEH] Fix crash on empty seh block (#107031) (PR #107466)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru closed https://github.com/llvm/llvm-project/pull/107466 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] f0010d1 - [Windows SEH] Fix crash on empty seh block (#107031)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
Author: R-Goc Date: 2024-09-13T08:05:50+02:00 New Revision: f0010d131b79a1b401777aa32e96defc4a935c9d URL: https://github.com/llvm/llvm-project/commit/f0010d131b79a1b401777aa32e96defc4a935c9d DIFF: https://github.com/llvm/llvm-project/commit/f0010d131b79a1b401777aa32e96defc4a935c9d.diff LOG: [W

[llvm-branch-commits] [llvm] [AMDGPU] Fix sign confusion in performMulLoHiCombine (PR #106977)

2024-09-12 Thread via llvm-branch-commits
github-actions[bot] wrote: @jayfoad (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. h

[llvm-branch-commits] [llvm] release/19.x: [Windows SEH] Fix crash on empty seh block (#107031) (PR #107466)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru updated https://github.com/llvm/llvm-project/pull/107466 >From f0010d131b79a1b401777aa32e96defc4a935c9d Mon Sep 17 00:00:00 2001 From: R-Goc <131907007+r-...@users.noreply.github.com> Date: Wed, 4 Sep 2024 20:10:36 +0200 Subject: [PATCH] [Windows SEH] Fix crash on empty seh

[llvm-branch-commits] [llvm] [AMDGPU] Fix sign confusion in performMulLoHiCombine (PR #106977)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru closed https://github.com/llvm/llvm-project/pull/106977 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [AMDGPU] Fix sign confusion in performMulLoHiCombine (PR #106977)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru updated https://github.com/llvm/llvm-project/pull/106977 >From 93998aff7662d9b3f94d9627179dffe342e2b399 Mon Sep 17 00:00:00 2001 From: Jay Foad Date: Tue, 27 Aug 2024 17:09:40 +0100 Subject: [PATCH] [AMDGPU] Fix sign confusion in performMulLoHiCombine (#105831) SMUL_LOHI

[llvm-branch-commits] [llvm] 93998af - [AMDGPU] Fix sign confusion in performMulLoHiCombine (#105831)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
Author: Jay Foad Date: 2024-09-13T08:04:58+02:00 New Revision: 93998aff7662d9b3f94d9627179dffe342e2b399 URL: https://github.com/llvm/llvm-project/commit/93998aff7662d9b3f94d9627179dffe342e2b399 DIFF: https://github.com/llvm/llvm-project/commit/93998aff7662d9b3f94d9627179dffe342e2b399.diff LOG:

[llvm-branch-commits] [llvm] release/19.x: [LoongArch] Eliminate the redundant sign extension of division (#107971) (PR #107990)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
tru wrote: Just re-run the cherry-pick comment on the updated SHA. https://github.com/llvm/llvm-project/pull/107990 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-comm

[llvm-branch-commits] [llvm] release/19.x: [AVR] Fix 16-bit LDDs with immediate overflows (#104923) (PR #106993)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
tru wrote: Hi, since we are wrapping up LLVM 19.1.0 we are very strict with the fixes we pick at this point. Can you please respond to the following questions to help me understand if this has to be included in the final release or not. Is this PR a fix for a regression or a critical issue?

[llvm-branch-commits] [clang] release/19.x: [Clang][Concepts] Fix the constraint equivalence checking involving parameter packs (#102131) (PR #106043)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
tru wrote: Can this be reviewed @cor3ntin @mizvekov https://github.com/llvm/llvm-project/pull/106043 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [MIPS] Optimize sortRelocs for o32 (PR #106008)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
tru wrote: This will have to wait for LLVM 20. I know it's not optimal for zig, but getting it in this late and it being abi breaking is tricky. https://github.com/llvm/llvm-project/pull/106008 ___ llvm-branch-commits mailing list llvm-branch-commits@

[llvm-branch-commits] [llvm] release/19.x: [MIPS] Optimize sortRelocs for o32 (PR #106008)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru closed https://github.com/llvm/llvm-project/pull/106008 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [SLP]Fix PR104422: Wrong value truncation (PR #104747)

2024-09-12 Thread via llvm-branch-commits
github-actions[bot] wrote: @nikic (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. htt

[llvm-branch-commits] [llvm] release/19.x: [SLP]Fix PR104422: Wrong value truncation (PR #104747)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru closed https://github.com/llvm/llvm-project/pull/104747 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] 373180b - [SLP]Fix PR104422: Wrong value truncation

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
Author: Alexey Bataev Date: 2024-09-13T07:58:38+02:00 New Revision: 373180b440d04dc3cc0f6111b06684d18779d7c8 URL: https://github.com/llvm/llvm-project/commit/373180b440d04dc3cc0f6111b06684d18779d7c8 DIFF: https://github.com/llvm/llvm-project/commit/373180b440d04dc3cc0f6111b06684d18779d7c8.diff

[llvm-branch-commits] [llvm] release/19.x: [SLP]Fix PR104422: Wrong value truncation (PR #104747)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru updated https://github.com/llvm/llvm-project/pull/104747 >From 373180b440d04dc3cc0f6111b06684d18779d7c8 Mon Sep 17 00:00:00 2001 From: Alexey Bataev Date: Thu, 15 Aug 2024 07:21:10 -0700 Subject: [PATCH] [SLP]Fix PR104422: Wrong value truncation The minbitwidth restrictio

[llvm-branch-commits] [llvm] release/19.x: [SLP]Fix PR104422: Wrong value truncation (PR #104747)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru updated https://github.com/llvm/llvm-project/pull/104747 >From e475814473c5990a1409e24d4ecd56ce01546fd0 Mon Sep 17 00:00:00 2001 From: Alexey Bataev Date: Thu, 15 Aug 2024 07:21:10 -0700 Subject: [PATCH 1/2] [SLP][NFC]Add a test with incorrect minbitwidth analysis for red

[llvm-branch-commits] [llvm] release/19.x: workflows/release-binaries: Fix automatic upload (#107315) (PR #108422)

2024-09-12 Thread via llvm-branch-commits
github-actions[bot] wrote: @tstellar (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

[llvm-branch-commits] [llvm] release/19.x: workflows/release-binaries: Fix automatic upload (#107315) (PR #108422)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru closed https://github.com/llvm/llvm-project/pull/108422 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: workflows/release-binaries: Fix automatic upload (#107315) (PR #108422)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru updated https://github.com/llvm/llvm-project/pull/108422 >From 32a8b56bbf0a3c7678d44ba690427915446a9a72 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Thu, 12 Sep 2024 09:50:57 -0700 Subject: [PATCH] workflows/release-binaries: Fix automatic upload (#107315) (cherry pi

[llvm-branch-commits] [clang] [Clang] Fix handling of placeholder variables name in init captures (#107055) (PR #107214)

2024-09-12 Thread via llvm-branch-commits
github-actions[bot] wrote: @cor3ntin (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR.

[llvm-branch-commits] [clang] [Clang] Fix handling of placeholder variables name in init captures (#107055) (PR #107214)

2024-09-12 Thread Tobias Hieta via llvm-branch-commits
https://github.com/tru closed https://github.com/llvm/llvm-project/pull/107214 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [clang] 8290ce0 - [Clang] Fix handling of placeholder variables name in init captures (#107055)

2024-09-12 Thread Corentin Jabot via llvm-branch-commits
Author: cor3ntin Date: 2024-09-12T12:41:44+02:00 New Revision: 8290ce0998788b6a575ed7b4988b093f48c25b3d URL: https://github.com/llvm/llvm-project/commit/8290ce0998788b6a575ed7b4988b093f48c25b3d DIFF: https://github.com/llvm/llvm-project/commit/8290ce0998788b6a575ed7b4988b093f48c25b3d.diff LOG:

[llvm-branch-commits] [llvm] release/19.x: [DAGCombiner] cache negative result from getMergeStoreCandidates() (#106949) (PR #108397)

2024-09-12 Thread Matt Arsenault via llvm-branch-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/108397 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-12 Thread Pengcheng Wang via llvm-branch-commits
https://github.com/wangpc-pp updated https://github.com/llvm/llvm-project/pull/107548 >From f21cfcfc90330ee3856746b6315a81a00313b0e0 Mon Sep 17 00:00:00 2001 From: Wang Pengcheng Date: Fri, 6 Sep 2024 17:20:51 +0800 Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-12 Thread Pengcheng Wang via llvm-branch-commits
wangpc-pp wrote: > > > > The run just finished, I'm seeing a 0.75% improvement on > > > > 500.perlbench_r on the BPI F3 (-O3 -mcpu=spacemit-x60), no regressions > > > > or improvements on the other benchmarks as far as I can see. Seems to > > > > check out with the number of memcmps inlined re

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-12 Thread Luke Lau via llvm-branch-commits
lukel97 wrote: > > > The run just finished, I'm seeing a 0.75% improvement on 500.perlbench_r > > > on the BPI F3 (-O3 -mcpu=spacemit-x60), no regressions or improvements on > > > the other benchmarks as far as I can see. Seems to check out with the > > > number of memcmps inlined reported for

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-12 Thread Pengcheng Wang via llvm-branch-commits
wangpc-pp wrote: > > The run just finished, I'm seeing a 0.75% improvement on 500.perlbench_r on > > the BPI F3 (-O3 -mcpu=spacemit-x60), no regressions or improvements on the > > other benchmarks as far as I can see. Seems to check out with the number of > > memcmps inlined reported for perlb

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-12 Thread Craig Topper via llvm-branch-commits
topperc wrote: > The run just finished, I'm seeing a 0.75% improvement on 500.perlbench_r on > the BPI F3 (-O3 -mcpu=spacemit-x60), no regressions or improvements on the > other benchmarks as far as I can see. Seems to check out with the number of > memcmps inlined reported for perlbench! Doe

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-12 Thread Craig Topper via llvm-branch-commits
@@ -1144,42 +2872,116 @@ entry: define i32 @memcmp_size_4(ptr %s1, ptr %s2) nounwind { ; CHECK-ALIGNED-RV32-LABEL: memcmp_size_4: ; CHECK-ALIGNED-RV32: # %bb.0: # %entry -; CHECK-ALIGNED-RV32-NEXT:addi sp, sp, -16 -; CHECK-ALIGNED-RV32-NEXT:sw ra, 12(sp) # 4-byte

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-12 Thread Craig Topper via llvm-branch-commits
https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/107548 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-12 Thread Craig Topper via llvm-branch-commits
@@ -2113,3 +2113,17 @@ bool RISCVTTIImpl::shouldConsiderAddressTypePromotion( } return Considerable; } + +RISCVTTIImpl::TTI::MemCmpExpansionOptions +RISCVTTIImpl::enableMemCmpExpansion(bool OptSize, bool IsZeroCmp) const { + TTI::MemCmpExpansionOptions Options; + // FIXME

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-12 Thread Craig Topper via llvm-branch-commits
@@ -112,42 +104,46 @@ entry: define i32 @bcmp_size_2(ptr %s1, ptr %s2) nounwind optsize { ; CHECK-ALIGNED-RV32-LABEL: bcmp_size_2: ; CHECK-ALIGNED-RV32: # %bb.0: # %entry -; CHECK-ALIGNED-RV32-NEXT:addi sp, sp, -16 -; CHECK-ALIGNED-RV32-NEXT:sw ra, 12(sp) # 4-byte

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-12 Thread Craig Topper via llvm-branch-commits
@@ -1144,42 +2872,116 @@ entry: define i32 @memcmp_size_4(ptr %s1, ptr %s2) nounwind { ; CHECK-ALIGNED-RV32-LABEL: memcmp_size_4: ; CHECK-ALIGNED-RV32: # %bb.0: # %entry -; CHECK-ALIGNED-RV32-NEXT:addi sp, sp, -16 -; CHECK-ALIGNED-RV32-NEXT:sw ra, 12(sp) # 4-byte

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-12 Thread Pengcheng Wang via llvm-branch-commits
wangpc-pp wrote: > The run just finished, I'm seeing a 0.75% improvement on 500.perlbench_r on > the BPI F3 (-O3 -mcpu=spacemit-x60), no regressions or improvements on the > other benchmarks as far as I can see. Seems to check out with the number of > memcmps inlined reported for perlbench! T

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/107137 >From 50c021b09950cf7d6a8f25b1ac0dec246f2325f5 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 3 Sep 2024 11:38:04 -0700 Subject: [PATCH 1/6] update pseudoprobe-decoding-inline.test Created using spr 1.3.4

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/107137 >From 50c021b09950cf7d6a8f25b1ac0dec246f2325f5 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 3 Sep 2024 11:38:04 -0700 Subject: [PATCH 1/6] update pseudoprobe-decoding-inline.test Created using spr 1.3.4

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Amir Ayupov via llvm-branch-commits
aaupov wrote: Thanks for a review, @wlei-llvm, @rafaelauler, @WenleiHe! https://github.com/llvm/llvm-project/pull/107137 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Lei Wang via llvm-branch-commits
https://github.com/wlei-llvm approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/107137 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Amir Ayupov via llvm-branch-commits
aaupov wrote: > Not an expert but looks good. Why is operator== in struct InlineTreeInfo > always returning false? Is this intentional? It's a quirk of YAML: `BinaryFunctionProfile` has `std::vector InlineTree` as optional field. Optional fields compare against the default value using `operat

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Rafael Auler via llvm-branch-commits
rafaelauler wrote: Sorry, didn't see lei was already reviewing this. Go ahead with his expert's opinion, please. https://github.com/llvm/llvm-project/pull/107137 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llv

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Rafael Auler via llvm-branch-commits
https://github.com/rafaelauler approved this pull request. Not an expert but looks good. Why is operator== in struct InlineTreeInfo always returning false? Is this intentional? https://github.com/llvm/llvm-project/pull/107137 ___ llvm-branch-commits

[llvm-branch-commits] [CIR] Add .clang-tidy files to agree with our style convention (PR #108444)

2024-09-12 Thread Nathan Lanza via llvm-branch-commits
https://github.com/lanza closed https://github.com/llvm/llvm-project/pull/108444 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [CIR] Add .clang-tidy files to agree with our style convention (PR #108444)

2024-09-12 Thread Nathan Lanza via llvm-branch-commits
https://github.com/lanza created https://github.com/llvm/llvm-project/pull/108444 https://llvm.github.io/clangir/GettingStarted/coding-guideline.html ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread Tavian Barnes via llvm-branch-commits
tavianator wrote: I guess the bug there is that the memcpy() interceptor literally copies the dynamic type from `node->next` to `list->head`. Then `list->head` is accessed but tysan thinks the memory has type `struct node::next` which doesn't match. https://github.com/llvm/llvm-project/pull/1

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Amir Ayupov via llvm-branch-commits
@@ -14,29 +14,31 @@ # RUN: FileCheck --input-file %t.yaml2 %s --check-prefix CHECK-YAML # CHECK-YAML: name: bar # CHECK-YAML: - bid: 0 -# CHECK-YAML: pseudo_probes: [ { guid: 0xE413754A191DB537, id: 1, type: 0 }, { guid: 0xE413754A191DB537, id: 4, type: 0 } ] -# CHECK-YAML:

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/107137 >From 50c021b09950cf7d6a8f25b1ac0dec246f2325f5 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 3 Sep 2024 11:38:04 -0700 Subject: [PATCH 1/6] update pseudoprobe-decoding-inline.test Created using spr 1.3.4

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/107137 >From 50c021b09950cf7d6a8f25b1ac0dec246f2325f5 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Tue, 3 Sep 2024 11:38:04 -0700 Subject: [PATCH 1/6] update pseudoprobe-decoding-inline.test Created using spr 1.3.4

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread Tavian Barnes via llvm-branch-commits
tavianator wrote: Here's the new testcase. Not sure if this bug is related or not. It has to do with `memcpy()`; if you replace the call with the commented-out line above it, it works. ```c struct node { struct node *next; }; struct list { struct node *head, **tail; }; int

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Amir Ayupov via llvm-branch-commits
@@ -58,8 +59,158 @@ const BinaryFunction *YAMLProfileWriter::setCSIDestination( return nullptr; } +std::vector +YAMLProfileWriter::collectInlineTree( +const MCPseudoProbeDecoder &Decoder, +const MCDecodedPseudoProbeInlineTree &Root) { + auto getHash = [&](const MCDe

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Lei Wang via llvm-branch-commits
@@ -2421,11 +2433,14 @@ std::error_code DataAggregator::writeBATYAML(BinaryContext &BC, const uint32_t InputOffset = BAT->translate( FuncAddr, OutputAddress - FuncAddr, /*IsBranchSrc=*/true); const unsigned BlockIndex = getBlock(InputOff

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Lei Wang via llvm-branch-commits
@@ -14,29 +14,31 @@ # RUN: FileCheck --input-file %t.yaml2 %s --check-prefix CHECK-YAML # CHECK-YAML: name: bar # CHECK-YAML: - bid: 0 -# CHECK-YAML: pseudo_probes: [ { guid: 0xE413754A191DB537, id: 1, type: 0 }, { guid: 0xE413754A191DB537, id: 4, type: 0 } ] -# CHECK-YAML:

[llvm-branch-commits] [llvm] [BOLT] Add pseudo probe inline tree to YAML profile (PR #107137)

2024-09-12 Thread Lei Wang via llvm-branch-commits
@@ -58,8 +59,158 @@ const BinaryFunction *YAMLProfileWriter::setCSIDestination( return nullptr; } +std::vector +YAMLProfileWriter::collectInlineTree( +const MCPseudoProbeDecoder &Decoder, +const MCDecodedPseudoProbeInlineTree &Root) { + auto getHash = [&](const MCDe

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-09-12 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/99891 >From 36197b175681d07b4704e576fb008cec3cc1e05e Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 28 Aug 2024 21:10:25 +0200 Subject: [PATCH 1/2] Reworked block probe matching Use new probe ifaces Get all func

[llvm-branch-commits] [llvm] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-09-12 Thread Amir Ayupov via llvm-branch-commits
https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/99891 >From 36197b175681d07b4704e576fb008cec3cc1e05e Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 28 Aug 2024 21:10:25 +0200 Subject: [PATCH 1/2] Reworked block probe matching Use new probe ifaces Get all func

[llvm-branch-commits] [sanitizer] Test for __sanitizer_get_dtls_size (PR #108349)

2024-09-12 Thread Vitaly Buka via llvm-branch-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/108349 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [sanitizer] Allow to override GetDTLSRange (PR #108348)

2024-09-12 Thread Vitaly Buka via llvm-branch-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/108348 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [sanitizer] Test for __sanitizer_get_dtls_size (PR #108349)

2024-09-12 Thread Vitaly Buka via llvm-branch-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/108349 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [sanitizer] Allow to override GetDTLSRange (PR #108348)

2024-09-12 Thread Vitaly Buka via llvm-branch-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/108348 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [sanitizer] Test for __sanitizer_get_dtls_size (PR #108349)

2024-09-12 Thread Vitaly Buka via llvm-branch-commits
vitalybuka wrote: > Maybe improve the message a bit so people don't have to look at another pull > request to understand what this is about? done https://github.com/llvm/llvm-project/pull/108349 ___ llvm-branch-commits mailing list llvm-branch-commit

[llvm-branch-commits] [sanitizer] Test for __sanitizer_get_dtls_size (PR #108349)

2024-09-12 Thread Vitaly Buka via llvm-branch-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/108349 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [sanitizer] Test for __sanitizer_get_dtls_size (PR #108349)

2024-09-12 Thread Vitaly Buka via llvm-branch-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/108349 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: workflows/release-binaries: Fix automatic upload (#107315) (PR #108422)

2024-09-12 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-github-workflow Author: None (llvmbot) Changes Backport ab96409180aaad5417030f06a386253722a99d71 Requested by: @tstellar --- Full diff: https://github.com/llvm/llvm-project/pull/108422.diff 1 Files Affected: - (modified) .github/workflows/release-bi

[llvm-branch-commits] [llvm] release/19.x: workflows/release-binaries: Fix automatic upload (#107315) (PR #108422)

2024-09-12 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/108422 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: workflows/release-binaries: Fix automatic upload (#107315) (PR #108422)

2024-09-12 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/108422 Backport ab96409180aaad5417030f06a386253722a99d71 Requested by: @tstellar >From 5ec4f6033e5ad37f3a6f30ca48b74305770e5796 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Thu, 12 Sep 2024 09:50:57 -0700 Subjec

[llvm-branch-commits] [sanitizer] Test for #108348 (PR #108349)

2024-09-12 Thread Florian Mayer via llvm-branch-commits
fmayer wrote: Maybe improve the message a bit so people don't have to look at another pull request to understand what this is about? https://github.com/llvm/llvm-project/pull/108349 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.o

[llvm-branch-commits] [sanitizer] Test for #108348 (PR #108349)

2024-09-12 Thread Thurston Dang via llvm-branch-commits
https://github.com/thurstond approved this pull request. https://github.com/llvm/llvm-project/pull/108349 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [sanitizer] Allow to override GetDTLSRange (PR #108348)

2024-09-12 Thread Thurston Dang via llvm-branch-commits
https://github.com/thurstond approved this pull request. https://github.com/llvm/llvm-project/pull/108348 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [RISCV] Add initial support of memcmp expansion (PR #107548)

2024-09-12 Thread Luke Lau via llvm-branch-commits
lukel97 wrote: The run just finished, I'm seeing a 0.75% improvement on 500.perlbench_r, no regressions or improvements on the other benchmarks as far as I can see. Seems to check out with the number of memcmps inlined reported for perlbench! https://github.com/llvm/llvm-project/pull/107548 __

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread Tavian Barnes via llvm-branch-commits
https://github.com/tavianator edited https://github.com/llvm/llvm-project/pull/108385 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread Tavian Barnes via llvm-branch-commits
https://github.com/tavianator commented: This fixes my reduced testcase but not the unreduced one. I'll try to make a new reduction. https://github.com/llvm/llvm-project/pull/108385 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread Tavian Barnes via llvm-branch-commits
@@ -128,6 +128,10 @@ static bool isAliasingLegalUp(tysan_type_descriptor *TDA, break; } + //You can't have negative offset, you must be partially inside the last type + if (TDA->Struct.Members[Idx].Offset > OffsetA) +Idx -=1; + --

[llvm-branch-commits] [clang] [Serialization] Code cleanups and polish 83233 (PR #83237)

2024-09-12 Thread Ilya Biryukov via llvm-branch-commits
ilya-biryukov wrote: I got to a small reproducer that only uses STL, but it only produces an error in our environment and if I try it with this patch, the error goes away. I am probably missing something subtle, will dig deeper tomorrow. Sorry for another delay. https://github.com/llvm/llvm-pr

[llvm-branch-commits] [mlir] [mlir][Transforms] Dialect conversion: Unify materialization of value replacements (PR #108381)

2024-09-12 Thread Jakub Kuderski via llvm-branch-commits
@@ -2546,87 +2522,61 @@ static Operation *findLiveUserOfReplaced( return nullptr; } -LogicalResult OperationConverter::legalizeConvertedOpResultTypes( -ConversionPatternRewriter &rewriter, -ConversionPatternRewriterImpl &rewriterImpl, -DenseMap> &inverseMapping)

[llvm-branch-commits] [mlir] [mlir][Transforms] Dialect conversion: Unify materialization of value replacements (PR #108381)

2024-09-12 Thread Jakub Kuderski via llvm-branch-commits
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/108381 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][Transforms] Dialect conversion: Unify materialization of value replacements (PR #108381)

2024-09-12 Thread Jakub Kuderski via llvm-branch-commits
@@ -2546,87 +2522,61 @@ static Operation *findLiveUserOfReplaced( return nullptr; } -LogicalResult OperationConverter::legalizeConvertedOpResultTypes( -ConversionPatternRewriter &rewriter, -ConversionPatternRewriterImpl &rewriterImpl, -DenseMap> &inverseMapping)

[llvm-branch-commits] [llvm] release/19.x: [DAGCombiner] cache negative result from getMergeStoreCandidates() (#106949) (PR #108397)

2024-09-12 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-selectiondag Author: None (llvmbot) Changes Backport 8f77d37f256809766fd83a09c6d144b785e9165a Requested by: @nikic --- Full diff: https://github.com/llvm/llvm-project/pull/108397.diff 1 Files Affected: - (modified) llvm/lib/CodeGen/SelectionDAG

[llvm-branch-commits] [llvm] release/19.x: [DAGCombiner] cache negative result from getMergeStoreCandidates() (#106949) (PR #108397)

2024-09-12 Thread via llvm-branch-commits
https://github.com/llvmbot created https://github.com/llvm/llvm-project/pull/108397 Backport 8f77d37f256809766fd83a09c6d144b785e9165a Requested by: @nikic >From 3d14aafa9c51b816d9bc1792898de9df84cc2fd6 Mon Sep 17 00:00:00 2001 From: Princeton Ferro Date: Wed, 4 Sep 2024 07:18:53 -0700 Subject

[llvm-branch-commits] [llvm] release/19.x: [DAGCombiner] cache negative result from getMergeStoreCandidates() (#106949) (PR #108397)

2024-09-12 Thread via llvm-branch-commits
https://github.com/llvmbot milestoned https://github.com/llvm/llvm-project/pull/108397 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] release/19.x: [DAGCombiner] cache negative result from getMergeStoreCandidates() (#106949) (PR #108397)

2024-09-12 Thread via llvm-branch-commits
llvmbot wrote: @arsenm What do you think about merging this PR to the release branch? https://github.com/llvm/llvm-project/pull/108397 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[llvm-branch-commits] [mlir] [mlir][Transforms] Dialect conversion: Unify materialization of value replacements (PR #108381)

2024-09-12 Thread Matthias Springer via llvm-branch-commits
https://github.com/matthias-springer updated https://github.com/llvm/llvm-project/pull/108381 >From 0fd4cb81dbf6e9c2766a086e2e3fdffd3cf67510 Mon Sep 17 00:00:00 2001 From: Matthias Springer Date: Thu, 12 Sep 2024 14:49:23 +0200 Subject: [PATCH] [mlir][Transforms] Dialect conversion: Unify mater

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread via llvm-branch-commits
https://github.com/gbMattN updated https://github.com/llvm/llvm-project/pull/108385 >From 65f1e1fce67bfc9ae60f83abe6d3b487a174c6b1 Mon Sep 17 00:00:00 2001 From: Matthew Nagy Date: Thu, 12 Sep 2024 12:36:57 + Subject: [PATCH] [TySan] Fix struct access with different bases --- compiler-rt/

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread via llvm-branch-commits
https://github.com/gbMattN updated https://github.com/llvm/llvm-project/pull/108385 >From 91f560d69a6dd21cf177f8969422b478cd4e5f5e Mon Sep 17 00:00:00 2001 From: Matthew Nagy Date: Thu, 12 Sep 2024 12:36:57 + Subject: [PATCH] [TySan] Fix struct access with different bases --- compiler-rt/

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread via llvm-branch-commits
gbMattN wrote: (Manually pinging potential reviewers) @tavianator @fhahn https://github.com/llvm/llvm-project/pull/108385 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bran

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread via llvm-branch-commits
https://github.com/gbMattN updated https://github.com/llvm/llvm-project/pull/108385 >From d312bd99486dc7fbff79b880026512e949e7d212 Mon Sep 17 00:00:00 2001 From: Matthew Nagy Date: Thu, 12 Sep 2024 12:36:57 + Subject: [PATCH] [TySan] Fix struct access with different bases --- compiler-rt/

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread via llvm-branch-commits
llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: None (gbMattN) Changes Fixes issue #105960 If a member in a struct is also a struct, accessing a member partway through this inner struct currently causes a false positive. This is because when checking aliasing, the acce

[llvm-branch-commits] [compiler-rt] [TySan] Fix struct access with different bases (PR #108385)

2024-09-12 Thread via llvm-branch-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

  1   2   >