Re: [lldb-dev] clang::VersionTuple

+1 for limiting the scope of a variable as much as possible On Mon, Jun 18, 2018 at 7:57 AM Pavel Labath via lldb-dev < lldb-dev@lists.llvm.org> wrote: > Thanks. I am going to submit the patch then. > > On Fri, 15 Jun 2018 at 19:56, Jim Ingham wrote: > > > On Jun 15, 2018, at 3:44 AM, Pavel Labat

Re: [lldb-dev] clang::VersionTuple

Thanks. I am going to submit the patch then. On Fri, 15 Jun 2018 at 19:56, Jim Ingham wrote: > > On Jun 15, 2018, at 3:44 AM, Pavel Labath via lldb-dev > > wrote: > > > > Hello again, > > > > Just a quick update on the state of this. > > > > I've managed to move VersionTuple from clang to llvm.

Re: [lldb-dev] clang::VersionTuple

> On Jun 15, 2018, at 3:44 AM, Pavel Labath via lldb-dev > wrote: > > Hello again, > > Just a quick update on the state of this. > > I've managed to move VersionTuple from clang to llvm. I've also > created to switch over our version > handling to that class

Re: [lldb-dev] clang::VersionTuple

Hello again, Just a quick update on the state of this. I've managed to move VersionTuple from clang to llvm. I've also created to switch over our version handling to that class. Could I interest anyone in taking a quick look at the patch? pl On Wed, 9 May 201

Re: [lldb-dev] clang::VersionTuple

Thank you all for the feedback. I'll get on with this when I find some spare time. I will send a patch which will show the final look of the code, before I start moving VersionTuple into llvm. cheers, pl On Tue, 8 May 2018 at 19:46, Frédéric Riss via lldb-dev < lldb-dev@lists.llvm.org> wrote: >

Re: [lldb-dev] clang::VersionTuple

> On May 8, 2018, at 11:37 AM, Greg Clayton wrote: > > I was referring to the Swift and Apple internal branches. They tend to lock > down against older llvm and clang repositories so when we put changes in llvm > or clang that are required for LLDB, it makes merging a bit tougher in those >

Re: [lldb-dev] clang::VersionTuple

I was referring to the Swift and Apple internal branches. They tend to lock down against older llvm and clang repositories so when we put changes in llvm or clang that are required for LLDB, it makes merging a bit tougher in those cases. Again, I am not affected by this, just trying to watch out

Re: [lldb-dev] clang::VersionTuple

I'm good if Apple is good. > On May 8, 2018, at 11:31 AM, Frédéric Riss wrote: > > > >> On May 8, 2018, at 10:04 AM, Greg Clayton via lldb-dev >> mailto:lldb-dev@lists.llvm.org>> wrote: >> >> >> >>> On May 8, 2018, at 9:47 AM, Zachary Turner >> > wrote: >>> >>>

Re: [lldb-dev] clang::VersionTuple

> On May 8, 2018, at 10:04 AM, Greg Clayton via lldb-dev > wrote: > > > >> On May 8, 2018, at 9:47 AM, Zachary Turner > > wrote: >> >> We don’t want the lowest levels of lldb to depend on clang. If this is >> useful we should move it from clang to llvm and use ll

Re: [lldb-dev] clang::VersionTuple

Fred is probably the person who can answer this question On Tue, May 8, 2018 at 11:06 AM, Zachary Turner wrote: > +davide, +aprantl for the Apple perspective. > > > On Tue, May 8, 2018 at 10:04 AM Greg Clayton wrote: >> >> >> On May 8, 2018, at 9:47 AM, Zachary Turner wrote: >> >> We don’t wa

Re: [lldb-dev] clang::VersionTuple

+davide, +aprantl for the Apple perspective. On Tue, May 8, 2018 at 10:04 AM Greg Clayton wrote: > > On May 8, 2018, at 9:47 AM, Zachary Turner wrote: > > We don’t want the lowest levels of lldb to depend on clang. If this is > useful we should move it from clang to llvm and use llvm::VersionTu

Re: [lldb-dev] clang::VersionTuple

> On May 8, 2018, at 9:47 AM, Zachary Turner wrote: > > We don’t want the lowest levels of lldb to depend on clang. If this is useful > we should move it from clang to llvm and use llvm::VersionTuple I agree, though this move will cause merging issues for many that have repositories that lin

Re: [lldb-dev] clang::VersionTuple

We don’t want the lowest levels of lldb to depend on clang. If this is useful we should move it from clang to llvm and use llvm::VersionTuple On Tue, May 8, 2018 at 9:26 AM Greg Clayton via lldb-dev < lldb-dev@lists.llvm.org> wrote: > No issues from me. > > > On May 8, 2018, at 9:11 AM, Pavel Laba

Re: [lldb-dev] clang::VersionTuple

No issues from me. > On May 8, 2018, at 9:11 AM, Pavel Labath via lldb-dev > wrote: > > While moving Args around, I noticed that we have a bunch of > functions/classes that pass/store version numbers as a triplet of integers > (e.g. Platform::GetOSVersion). I got halfway into creating a wrapper

[lldb-dev] clang::VersionTuple

While moving Args around, I noticed that we have a bunch of functions/classes that pass/store version numbers as a triplet of integers (e.g. Platform::GetOSVersion). I got halfway into creating a wrapper class for that when I noticed clang::VersionTuple, which is pretty much what I wanted out of th