[Lldb-commits] [PATCH] D89283: [trace][intel-pt] Implement the basic decoding functionality

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfd96f057ba4: [trace][intel-pt] Implement the basic decoding functionality (authored by Walter Erquinigo , committed by wallace). R

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

wallace updated this revision to Diff 303313. wallace marked 5 inline comments as done. wallace added a comment. Address all comments, specially improved the documentation requested by @clayborg. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90490/

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:183 + /// llvm::Error::success() otherwise. + virtual llvm::Error StopTracingThread(const Thread &thread) { +return llvm::make_error(); clayborg wrote: > We need to have StartTr

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace updated this revision to Diff 303614. wallace marked 14 inline comments as done. wallace added a comment. address all comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90729/new/ https://reviews.llvm.org/D90729 Files: lldb/include/l

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

wallace updated this revision to Diff 304232. wallace added a comment. Added a test that accounts for a custom error message from the gdb-server. I decided to follow @labath's approach of using the existing error code format (;AAA). It works well and the GDBClient classes already have good su

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace updated this revision to Diff 304267. wallace added a comment. Address comments - I didn't move the caching to Process.h, as creating the start command requires an Interpreter, which I don't know if I can assume as unique. Btw, I'm using weak pointers instead. - I added an IsLiveDebugSe

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace updated this revision to Diff 304317. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90729/new/ https://reviews.llvm.org/D90729 Files: lldb/include/lldb/Core/PluginManager.h lldb/include/lldb/Interpreter/Com

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace planned changes to this revision. wallace added a comment. - After taking a second look I realized I don't need caching. For some reason I thought that autocompletion would be triggered with every keystroke, and that's why caching would be useful. But I was wrong all along! These queries

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21555fff4de8: [intel-pt][trace] Implement a "get supported trace type" packet (authored by wallace). Changed prior to commit: https://reviews.llvm

[Lldb-commits] [PATCH] D90490: [intel-pt][trace] Implement a "get supported trace type" packet

wallace added a comment. @stella.stamenova I'm working on a fix right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90490/new/ https://reviews.llvm.org/D90490 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace updated this revision to Diff 304651. wallace added a comment. Address comments: - Don't cache the command delegate. It was overcomplicating the code for little gain. - Create a RecordedProcess base class for trace and coredump processes, so that we can put the IsLiveDebugSession method

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace marked 10 inline comments as done. wallace added inline comments. Comment at: lldb/include/lldb/Target/ProcessTrace.h:1 //===-- ProcessTrace.h --*- C++ -*-===// // clayborg wrote: > Should ProcessTrace and Thread

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace updated this revision to Diff 304692. wallace added a comment. - Use CommandObjectProxy and delete the Delegate that I created - I had to add a few methods to the proxy to match with that I need. In any case, the implementation is not more complete. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace updated this revision to Diff 304867. wallace added a comment. improve error messages The diff is ready for review again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90729/new/ https://reviews.llvm.org/D90729 Files: lldb/include/lldb/C

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

wallace created this revision. wallace added a reviewer: clayborg. Herald added subscribers: lldb-commits, dang. Herald added a project: LLDB. wallace requested review of this revision. Herald added a subscriber: JDevlieghere. This implements the interactive trace start and stop methods. There's

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

wallace updated this revision to Diff 306177. wallace marked 5 inline comments as done. wallace added a comment. Renamed to SavedProcess Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90729/new/ https://reviews.llvm.org/D90729 Files: lldb/include

[Lldb-commits] [PATCH] D90729: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb19f11ef47b: [trace][intel-pt] Scaffold the 'thread trace start | stop' commands (authored by wallace). Changed prior to commit: https://reviews.

[Lldb-commits] [PATCH] D93744: [lldb-vscode] Support processId returned by the IDE in the runInTerminal request

wallace created this revision. wallace added reviewers: kusmour, clayborg. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently, the runInTerminal is implemented by using --wait-for underneath, which is error prone as it often

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace created this revision. wallace added reviewers: clayborg, jingham. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On Linux, unlike Darwin, after a process performs exec, the thread id doesn't change. This causes any living

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace updated this revision to Diff 313904. wallace added a comment. improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93874/new/ https://reviews.llvm.org/D93874 Files: lldb/include/lldb/Target/Process.h lldb/source/Plugins/Process/

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace updated this revision to Diff 313997. wallace added a comment. Updated the description of the diff. It was actually very easy to find a deterministic reproduction of the failure. And the diff is actually minimal now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace updated this revision to Diff 314035. wallace added a comment. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93874/new/ https://reviews.llvm.org/D93874 Files: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/test/AP

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace created this revision. wallace added reviewers: clayborg, kusmour, aadsm. Herald added a subscriber: dang. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Depends on D93874 . runInTerminal w

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace updated this revision to Diff 314151. wallace added a comment. Herald added a subscriber: JDevlieghere. nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93951/new/ https://reviews.llvm.org/D93951 Files: lldb/test/API/tools/lldb-vscode/r

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace added inline comments. Comment at: lldb/test/API/functionalities/exec/TestExec.py:91-93 +# Single step to create a thread plan. We have to make sure that after exec +# we clear all existing thread plans. +thread.StepInstruction(False)

[Lldb-commits] [PATCH] D94033: [lldb-vscode] improve modules request

wallace created this revision. wallace added reviewers: clayborg, kusmour, aadsm. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb-vsdode was communicating the list of modules to the IDE with events, which in practice ended up

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace added inline comments. Comment at: lldb/test/API/functionalities/exec/TestExec.py:96 # Run and we should stop due to exec process.Continue() clayborg wrote: > Do we need this continue if we did the step above? How does this test still

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace updated this revision to Diff 315015. wallace marked 10 inline comments as done. wallace added a comment. Herald added a subscriber: mgorny. Address all comments. - Moved all the communication logic between the debug adaptor and the launcher to classes, simplifying the code in lldb-vscod

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace added a comment. I'll follow your recommendations. Regarding Windows, mkfifo can be replaced with CreateNamedPipe and should lead to the same behavior. Sadly, I don't have a Windows machine where I could even compile it... So this should be left for someone else or for when I can get my

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace marked an inline comment as done. wallace added a comment. I'll think about just writing this as tcp sockets. That would for sure be cross platform Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93951/new/ https://reviews.llvm.org/D93951 _

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace marked 5 inline comments as done. wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2994 + // signal to prevent being paused forever. + const char *timeout_env_var = getenv("LLDB_VSCODE_RIT_TIMEOUT_IN_MS"); + int timeout_in_ms =

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace updated this revision to Diff 315527. wallace added a comment. Followed all the suggestions: - This is POSIX-only, but making it work for windows should only require deleting a few #ifdef blocks and using the CreateNamedPipe API instead of mkfifo. I'll do it later in another diff. - Add

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace updated this revision to Diff 315652. wallace added a comment. Addressed all comments: - Now using a single file for all the communication. Did indeed simplified a lot of code - Now adding timeouts to Send operations. This will help prevent the adaptor from undefinitely waiting for the

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace updated this revision to Diff 315655. wallace added a comment. improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93951/new/ https://reviews.llvm.org/D93951 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace added a comment. @jingham, friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93874/new/ https://reviews.llvm.org/D93874 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace added a comment. I've done a lightweight test and it seems that the BaseThreadPlan is being asked for the stop reason when the exec happens, but it holds a reference to the thread whose destructor has been called, which causes the crash. On Darwin, as Greg said, the BaseThreadPlan is de

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace added a comment. Sorry for returning late to this diff, but I have some additional information. This is what's happening: - Before the exec, the base thread plan holds a reference to the thread pointer - During the exec, the original thread is destroyed in ProcessGDBRemote::SetLastStopP

[Lldb-commits] [PATCH] D94033: [lldb-vscode] improve modules request

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39239f9b5666: [lldb-vscode] improve modules request (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace added a comment. Jim, thanks for the pointers! I think we are getting close to the issue. After doing what you asked, I found out the following: - I set up the state of the lldb debugging the program that will exec right before it execs - Then I do "continue" - ThreadPlan::WillResume is

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace updated this revision to Diff 318640. wallace added a comment. Herald added a subscriber: emaste. Updated based on @jingham's idea, and added an independent test for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93874/new/ https://rev

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace added inline comments. Comment at: lldb/test/API/functionalities/exec/TestExec.py:133-158 +exe = self.getBuildArtifact("a.out") +secondprog = self.getBuildArtifact("secondprog") + +# Create the target +target = self.dbg.CreateTarget(exe) +

[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

wallace updated this revision to Diff 319069. wallace added a comment. apply suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93874/new/ https://reviews.llvm.org/D93874 Files: lldb/include/lldb/Target/Process.h lldb/include/lldb/Target

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f0462cacf34: [vscode] Improve runInTerminal and support linux (authored by wallace). Changed prior to commit: https://reviews.llvm.org/D93951?vs=

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace added a comment. @stella.stamenova , is that build a Debug or Release build? I think that will help me determine why it's failing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93951/new/ https://reviews.llvm.org/D93951 ___

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace added a comment. I'll send a diff tomorrow morning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93951/new/ https://reviews.llvm.org/D93951 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:278 +// "tids": [], +// "variant": "specificThreads" | "currentAndFutureThreads" | "process", +// "params": { clayborg wrote: > Seems like we don't need the "variant" here. If we

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

wallace added a comment. @stella.stamenova , I've just pushed a fix. Let me know if it actually works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93951/new/ https://reviews.llvm.org/D93951 ___ lldb-co

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

wallace created this revision. wallace added reviewers: mstorsjo, stella.stamenova. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. @mstorsjo found a mistake that I made when trying to fix some Windows compilation errors encountered

[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36496cc2992d: [lldb-vscode] correctly use Windows macros (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D77878: [lldb] Fix a typo in a test name

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Removing the Test prefix from the file name and its usages. The standard is using only Test as a suffix. This was correctly pointed out in https:

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 256716. wallace added a comment. remove blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77452/new/ https://reviews.llvm.org/D77452 Files: lldb/packages/Python/lldbsuite/test/configuration.py lldb/

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 256715. wallace edited the summary of this revision. wallace removed a reviewer: JDevlieghere. wallace removed a subscriber: JDevlieghere. wallace added a comment. Herald added a subscriber: mgorny. Addressed comments. The diff description now reflects the lat

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

wallace updated this revision to Diff 257450. wallace added a comment. move the skipping logic to the actual test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77452/new/ https://reviews.llvm.org/D77452 Files: lldb/packages/Python/lldbsuite/test

[Lldb-commits] [PATCH] D78839: [lldb-vscode] Add an option for loading core files

wallace created this revision. wallace added reviewers: labath, clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently loading core files on lldb-vscode is broken because there's a check in the attach workflow that asserts that the PID is valid, which of course

[Lldb-commits] [PATCH] D78839: [lldb-vscode] Add an option for loading core files

wallace updated this revision to Diff 260501. wallace added a comment. Added a test, which was easier than I thought! I tested it on mac as well, so I hope it'll work well on the buildbots. I also removed that bad use of auto. It seems that all StringRefs gotten from the JSON object are null-ter

[Lldb-commits] [PATCH] D78839: [lldb-vscode] Add an option for loading core files

wallace updated this revision to Diff 260731. wallace added a comment. added the test suggested by @labath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78839/new/ https://reviews.llvm.org/D78839 Files: lldb/packages/Python/lldbsuite/test/tools/

[Lldb-commits] [PATCH] D79726: Add terminateCommands to lldb-vscode protocol

wallace added a comment. I don't know if terminate is the best name, as it could seem related to the inferior. What about finalize? It reminds me of the try/catch/finalize words, and it's harder to associate it with the inferior's own exit event. Comment at: lldb/test/API/too

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

wallace created this revision. wallace added reviewers: clayborg, labath, aadsm. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. wallace added a reviewer: kusmour. Recently I've noticed that VSCode sometimes doesn't send the terminateDebuggee flag within the disconnectReque

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

wallace marked 2 inline comments as done. wallace added a comment. Well, the problem that i've seen happens mostly with long running processes like services that just don't die. So this fixes those issues anyway because those processes are not dying when they should. I tried an older version of

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

wallace updated this revision to Diff 270038. wallace added a comment. I updated the tests and did some minor changes. @clayborg, after some testing, I noticed that this doesn't fix the problem of lldb-vscode instances not dying, however it solves the problem of long-running inferiors not dying.

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

wallace marked an inline comment as done. wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:796 +if (!error.Success()) + response.try_emplace("error", error.GetCString()); g_vsc.debugger.SetAsync(true); clayborg wrote

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

wallace updated this revision to Diff 270804. wallace edited the summary of this revision. wallace removed a reviewer: kusmour. wallace added a comment. The tests were weird indeed, I think I had to revisit them after making some changes. Anyway, I've updated the tests and they do make sense now.

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

wallace added a comment. @labath , does this look better now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81200/new/ https://reviews.llvm.org/D81200 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

wallace updated this revision to Diff 271224. wallace edited the summary of this revision. wallace added a comment. remove unwanted changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81200/new/ https://reviews.llvm.org/D81200 Files: lldb/pack

[Lldb-commits] [PATCH] D81978: Redo of Add terminateCommands to lldb-vscode protocol

wallace created this revision. wallace added reviewers: clayborg, aadsm, kusmour, labath. wallace added a project: LLDB. wallace edited the summary of this revision. wallace added a parent revision: D81200: [vscode] set default values for terminateDebuggee for the disconnect request. This redoes

[Lldb-commits] [PATCH] D81978: Redo of Add terminateCommands to lldb-vscode protocol

wallace updated this revision to Diff 271542. wallace added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81978/new/ https://reviews.llvm.org/D81978 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py

[Lldb-commits] [PATCH] D81978: Redo of Add terminateCommands to lldb-vscode protocol

wallace updated this revision to Diff 271541. wallace added a comment. remove unwanted changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81978/new/ https://reviews.llvm.org/D81978 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/

[Lldb-commits] [PATCH] D83306: [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83306/new/ https://reviews.llvm.org/D83306 __

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Please include a test case Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:351-362 + char debug_info_size[10]; + if (debug_info < 1024) { +spri

[Lldb-commits] [PATCH] D83900: [intel-pt] Fix building due to CMake + python changes

wallace created this revision. wallace added reviewers: clayborg, aadsm. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Python is now handled in CMake with different variables, thus the intel plugin needs a corresponding update. Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D83900: [intel-pt] Fix building due to CMake + python changes

wallace closed this revision. wallace added a comment. Committed as 4c5d52397e8c8015046ff5541fd0abc738953870 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83900/new/ https://rev

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:333-335 + if (section_name.startswith(".debug") || section_name.startswith("__debug")) +debug_info_size += section.GetFileByteSize(); + if (section_name.startswith(".apple") || section_name.star

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace added a comment. @clayborg, the tests will fail on linux because the Makefile is expecting a .dsym file. I think it's okay if she does it just for Darwin and then I update the test to cover also linux, as I have my linux already well set up. Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. The logic looks very good, just some final comments and the code will be high quality Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:66

[Lldb-commits] [PATCH] D83731: Add Debug Info Size to Symbol Status

wallace accepted this revision. wallace added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:65 +@skipIfWindows +@ skipUnlessDarwin +@skipIfRemote remove this whitespace Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D73506: Bug fix

wallace added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:960 +int commit_points_index = -1; +for (uint32_t breakpoint_index = 0; breakpoint_index < commit_points.size(); breakpoint_index++) { + int breakpoint_position = match.rfind(commit_po

<    5   6   7   8   9   10