wallace marked an inline comment as done.
wallace added inline comments.
================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:796
+ if (!error.Success())
+ response.try_emplace("error", error.GetCString());
g_vsc.debugger.SetAsync(true);
----------------
clayborg wrote:
> I am not sure what returning an error to disconnect will do other than hosing
> the IDE in some way. It really doesn't matter if we succeeded, we should
> probably just not mess with the return value. Thoughts?
This is actually quite useful when analyzing logs, as we could know if any
disconnection ended up in an internal failure.
This is safe, as I've tried returning a hardcoded error in this case and the
IDE terminated the debug session gracefully anyway. The error field is accepted
by the protocol, btw.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81200/new/
https://reviews.llvm.org/D81200
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
