[Lldb-commits] [lldb] [LLDB][OSX] Add a fallback support exe directory (PR #103458)

2024-08-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes LLDB on OSX is looking at a `bin` directory sibling to the `lib` one that contains liblldb for its supporting executables. This works well for CMake, however, for other build systems like bazel,

[Lldb-commits] [lldb] [lldb-dap] Expose log path in extension settings (PR #103482)

2024-08-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes lldb-dap already supports a log file which can be enabled by setting the `LLDBDAP_LOG` environment variable. With this commit, the log location can be set directly through the VS-Code extension se

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-13 Thread via lldb-commits
@@ -0,0 +1,77 @@ +//===-- RealpathPrefixes.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-08-13 Thread via lldb-commits
jeffreytan81 wrote: Thanks for sharing. I have written a shell script to run `TestSingleThreadStepTimeout.py` in a loop infinitely until failing. Unfortunately, it has been running for 127 iterations (more than 7 hours) on my CentOS9 machine, haven't seen a single failure/timeout yet. I am not

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-13 Thread via lldb-commits
xusheng6 wrote: > Just to be clear, if I'm understanding the packet we'll be getting back, we > have no indication that we hit the breakpoint, we only show that we are > stopped at an address which has a breakpoint. Current lldb stepping behavior > will work -- because the rule is, when we sto

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-08-14 Thread via lldb-commits
@@ -0,0 +1,459 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Claim to support swbreak and hwbreak packets when debugging a gdbremote (PR #102873)

2024-08-14 Thread via lldb-commits
xusheng6 wrote: > > > Just to be clear, if I'm understanding the packet we'll be getting back, > > > we have no indication that we hit the breakpoint, we only show that we > > > are stopped at an address which has a breakpoint. Current lldb stepping > > > behavior will work -- because the rule

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-08-14 Thread via lldb-commits
@@ -0,0 +1,560 @@ +//===-- DILAST.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-08-14 Thread via lldb-commits
cmtice wrote: > Even though you've removed the smart pointer checking function (the most > obvious example of language-specific behavior), I'm still worried about > whether the overall design of this code will allow you to avoid it. > I believe I have fixed all the code to avoid any need to to

[Lldb-commits] [lldb] Reapply "[lldb] Tolerate multiple compile units with the same DWO ID (#100577)" (PR #104041)

2024-08-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The only change vs. the first version of the patch is that I've made DWARFUnit linking thread-safe/unit. This was necessary because, during the indexing step, two skeleton units could attempt to associate themse

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-14 Thread via lldb-commits
@@ -0,0 +1,158 @@ +""" +Test lldb breakpoint with symlinks/realpath and source-map. +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil, lldbplatformutil + + +class BreakpointTestCase(TestBase): +

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-14 Thread via lldb-commits
@@ -0,0 +1,158 @@ +""" +Test lldb breakpoint with symlinks/realpath and source-map. +""" + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil, lldbplatformutil + + +class BreakpointTestCase(TestBase): +

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-14 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/102223 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-14 Thread via lldb-commits
royitaqi wrote: Hi @jimingham and @labath , Could you do a final pass and see if everything looks good? I'm hoping to merge this today/tomorrow if possible. Thanks, Roy https://github.com/llvm/llvm-project/pull/102223 ___ lldb-commits mailing li

[Lldb-commits] [lldb] cce2271 - [LLDB][OSX] Add a fallback support exe directory (#103458)

2024-08-14 Thread via lldb-commits
Author: Walter Erquinigo Date: 2024-08-14T12:41:19-04:00 New Revision: cce2271eab8173f5c27c1e99863a056a9430c252 URL: https://github.com/llvm/llvm-project/commit/cce2271eab8173f5c27c1e99863a056a9430c252 DIFF: https://github.com/llvm/llvm-project/commit/cce2271eab8173f5c27c1e99863a056a9430c252.di

[Lldb-commits] [lldb] [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (PR #104109)

2024-08-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Fred Grim (feg208) Changes To create elf core files there are multiple notes in the core file that contain these structs as the note. These populate methods take a Process and produce fully specified structures that can be used to fill the

[Lldb-commits] [lldb] Fix single thread stepping timeout race condition (PR #104195)

2024-08-14 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/104195 This PR fixes a potential race condition in https://github.com/llvm/llvm-project/pull/90930. This race can happen because the original code set `m_info->m_isAlive = true` **after** the timer thread is cr

[Lldb-commits] [lldb] Fix single thread stepping timeout race condition (PR #104195)

2024-08-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes This PR fixes a potential race condition in https://github.com/llvm/llvm-project/pull/90930. This race can happen because the original code set `m_info->m_isAlive = true` **after** the timer thread is created.

[Lldb-commits] [lldb] Fix single thread stepping timeout race condition (PR #104195)

2024-08-14 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/104195 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-08-14 Thread via lldb-commits
jeffreytan81 wrote: The GDB packet log is very useful (especially with a good run log at the top to compare). I read with @clayborg . The log indicates that "self.thread.StepOver(lldb.eOnlyThisThread)" sent a "$vCont;c:p1a24.1a24" to continue single thread at the end but lacking a "\x03" asy

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes Listen to gdbserver-port, accept the connection and run `lldb-server gdbserver --fd` on all platforms. Added acceptor_gdb and gdb_thread to lldb-platform.cpp SharedSocket has been moved to ConnectionFileD

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-08-14 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d550ada5ab6cd6e49de71ac4c9aa27ced4c11de0 46808aacc7f79cd5220651ff5976780e3aec3d3e --e

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes Adds support for the `readMemory` request which allows VS-Code to inspect memory. Also, add `memoryReference` to variablesa and `evaluate` responses, such that the binary view can be opened from t

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-14 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 82ee31f75ac1316006fa9e21dddfddec37cf7072 e01ea18961bbae0fb747b312670946bd768c5d73 --e

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-08-14 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 82ee31f75ac1316006fa9e21dddfddec37cf7072...e01ea18961bbae0fb747b312670946bd768c5d73 lldb/

[Lldb-commits] [lldb] [LLDB][OSX] Removed semi colon generating a warning during build (PR #104398)

2024-08-14 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [LLDB][OSX] Removed semi colon generating a warning during build (PR #104398)

2024-08-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Daniel Wedzicha (boredhuman) Changes Singular warning I noticed when compiling lldb. --- Full diff: https://github.com/llvm/llvm-project/pull/104398.diff 1 Files Affected: - (modified) lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm (+1

[Lldb-commits] [lldb] b4dc986 - [LLDB][OSX] Removed semi colon generating a warning during build (#104398)

2024-08-14 Thread via lldb-commits
Author: Daniel Wedzicha Date: 2024-08-15T00:23:40-04:00 New Revision: b4dc9869381f91af419ec170837ac324d09525e5 URL: https://github.com/llvm/llvm-project/commit/b4dc9869381f91af419ec170837ac324d09525e5 DIFF: https://github.com/llvm/llvm-project/commit/b4dc9869381f91af419ec170837ac324d09525e5.dif

[Lldb-commits] [lldb] [LLDB][OSX] Removed semi colon generating a warning during build (PR #104398)

2024-08-14 Thread via lldb-commits
github-actions[bot] wrote: @boredhuman Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bui

[Lldb-commits] [lldb] 3d06de5 - [lldb] Remove Phabricator usernames from Code Owners file (#102590)

2024-08-15 Thread via lldb-commits
Author: David Spickett Date: 2024-08-15T09:07:02+01:00 New Revision: 3d06de544b8397a6b93a4fdb52650579237b77fa URL: https://github.com/llvm/llvm-project/commit/3d06de544b8397a6b93a4fdb52650579237b77fa DIFF: https://github.com/llvm/llvm-project/commit/3d06de544b8397a6b93a4fdb52650579237b77fa.diff

[Lldb-commits] [lldb] 7898866 - [lldb-dap] Expose log path in extension settings (#103482)

2024-08-15 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-08-15T13:19:32+02:00 New Revision: 7898866065f6c9b72b5fa3e45e565baf8a5e7609 URL: https://github.com/llvm/llvm-project/commit/7898866065f6c9b72b5fa3e45e565baf8a5e7609 DIFF: https://github.com/llvm/llvm-project/commit/7898866065f6c9b72b5fa3e45e565baf8a5e7609

[Lldb-commits] [lldb] 57a19ac - Reapply "[lldb] Tolerate multiple compile units with the same DWO ID (#100577)" (#104041)

2024-08-15 Thread via lldb-commits
Author: Pavel Labath Date: 2024-08-15T13:34:03+02:00 New Revision: 57a19ac3365f1dc255e6f24fcb7afcde2ccef8f9 URL: https://github.com/llvm/llvm-project/commit/57a19ac3365f1dc255e6f24fcb7afcde2ccef8f9 DIFF: https://github.com/llvm/llvm-project/commit/57a19ac3365f1dc255e6f24fcb7afcde2ccef8f9.diff

[Lldb-commits] [lldb] [WIP] memory find speedup+bugfix (PR #104193)

2024-08-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 20b2c9f10fe09f2c5cbd3da7f0af8df24f62e899...a537a48c444e9dec3a85241d9726d6f3187a43cf lldb/

[Lldb-commits] [lldb] [lldb][NFC] Moved FindSchemeByProtocol() from Acceptor to Socket (PR #104439)

2024-08-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes This is the prerequisite for #104238. --- Full diff: https://github.com/llvm/llvm-project/pull/104439.diff 3 Files Affected: - (modified) lldb/include/lldb/Host/Socket.h (+4) - (modified) lldb/source/H

[Lldb-commits] [lldb] Fix single thread stepping timeout race condition (PR #104195)

2024-08-15 Thread via lldb-commits
jeffreytan81 wrote: @labath, thanks. I am able to reproduce the failure after adding the sleep and running tests in a loop for 4 iterations. I will take a look after landing this race condition fix. https://github.com/llvm/llvm-project/pull/104195 __

[Lldb-commits] [lldb] 54154f9 - Fix single thread stepping timeout race condition (#104195)

2024-08-15 Thread via lldb-commits
Author: jeffreytan81 Date: 2024-08-15T09:57:01-07:00 New Revision: 54154f9f06e08b7ab3c7294352601ca4c6e5e160 URL: https://github.com/llvm/llvm-project/commit/54154f9f06e08b7ab3c7294352601ca4c6e5e160 DIFF: https://github.com/llvm/llvm-project/commit/54154f9f06e08b7ab3c7294352601ca4c6e5e160.diff

[Lldb-commits] [lldb] Fix single thread stepping timeout race condition (PR #104195)

2024-08-15 Thread via lldb-commits
https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/104195 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/102223 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 47721d4 - [lldb] Realpath symlinks for breakpoints (#102223)

2024-08-15 Thread via lldb-commits
Author: royitaqi Date: 2024-08-15T11:26:24-07:00 New Revision: 47721d46187f89c12a13d07b5857496301cf5d6e URL: https://github.com/llvm/llvm-project/commit/47721d46187f89c12a13d07b5857496301cf5d6e DIFF: https://github.com/llvm/llvm-project/commit/47721d46187f89c12a13d07b5857496301cf5d6e.diff LOG:

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/102223 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-15 Thread via lldb-commits
royitaqi wrote: I'm looking at this build break with `PATH_MAX`. Trying to figure out what to use instead. If anyone knows what to use, please LMK. https://github.com/llvm/llvm-project/pull/102223 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [lldb] Fix PATH_MAX for Windows (PR #104493)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/104493 Fix build break for Windows, caused by a [previous patch](https://github.com/llvm/llvm-project/pull/102223) using `PATH_MAX` which is undefined in Windows. The fix is to `#include "lldb/Host/PosixApi.h"` in t

[Lldb-commits] [lldb] Fix PATH_MAX for Windows (PR #104493)

2024-08-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (royitaqi) Changes Fix build break for Windows, caused by a [previous patch](https://github.com/llvm/llvm-project/pull/102223) using `PATH_MAX` which is undefined in Windows. The fix is to `#include "lldb/Host/PosixApi.h"` in the sou

[Lldb-commits] [lldb] (lldb) Fix PATH_MAX for Windows (PR #104493)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/104493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] (lldb) Fix PATH_MAX for Windows (PR #104493)

2024-08-15 Thread via lldb-commits
royitaqi wrote: I don't have a Windows machine to test this build on. So I'm merging this blindfolded, in the hope of fixing the build break so that less folks who are working on Windows will get affected by the break. https://github.com/llvm/llvm-project/pull/104493 __

[Lldb-commits] [lldb] (lldb) Fix build break for Windows (`PATH_MAX`) (PR #104493)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/104493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] (lldb) Fix build break for Windows (`PATH_MAX`) (PR #104493)

2024-08-15 Thread via lldb-commits
royitaqi wrote: I'm waiting for the "buildkite/github-pull-requests" job to finish (so that this "fix" won't break more things). LMK if I don't need to wait for it. https://github.com/llvm/llvm-project/pull/104493 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [lldb] f377edb - (lldb) Fix PATH_MAX for Windows (#104493)

2024-08-15 Thread via lldb-commits
Author: royitaqi Date: 2024-08-15T13:14:26-07:00 New Revision: f377edb96abe9fd6fa458415f07b0f411e59cf24 URL: https://github.com/llvm/llvm-project/commit/f377edb96abe9fd6fa458415f07b0f411e59cf24 DIFF: https://github.com/llvm/llvm-project/commit/f377edb96abe9fd6fa458415f07b0f411e59cf24.diff LOG:

[Lldb-commits] [lldb] (lldb) Fix build break for Windows (`PATH_MAX`) (PR #104493)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/104493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Reapply #100443 SBSaveCore Thread list (PR #104497)

2024-08-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Reapply #100443 and #101770. These were originally reverted due to a test failure and an MSAN failure. I changed the test attribute to restrict to x86 (following the other existing tests). I could not reprod

[Lldb-commits] [lldb] [LLDB] Reapply #100443 SBSaveCore Thread list (PR #104497)

2024-08-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 2ef553c05ffe274d6910e3d11f52ed6417cc5061...c22b85a11ccb024b3f56112fad3e8d96ed7be041 lldb

[Lldb-commits] [lldb] [LLDB] Reapply #100443 SBSaveCore Thread list (PR #104497)

2024-08-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2ef553c05ffe274d6910e3d11f52ed6417cc5061 c22b85a11ccb024b3f56112fad3e8d96ed7be041 --e

[Lldb-commits] [lldb] (lldb) (minor) Correctly fix a usage of `PATH_MAX` (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/104502 https://github.com/llvm/llvm-project/pull/102223 broke Windows build by using `PATH_MAX` without defining it. https://github.com/llvm/llvm-project/pull/104493 fixed it by including a header file which defines

[Lldb-commits] [lldb] (lldb) (minor) Correctly fix a usage of `PATH_MAX` (PR #104502)

2024-08-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (royitaqi) Changes https://github.com/llvm/llvm-project/pull/102223 broke Windows build by using `PATH_MAX` without defining it. https://github.com/llvm/llvm-project/pull/104493 fixed it by including a header file which defines it.

[Lldb-commits] [lldb] (lldb) (minor) Correctly fix a usage of `PATH_MAX` (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/104502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] (lldb) (minor) Correctly fix a usage of `PATH_MAX` (PR #104502)

2024-08-15 Thread via lldb-commits
@@ -54,7 +53,7 @@ RealpathPrefixes::ResolveSymlinks(const FileSpec &file_spec) { LLDB_LOGF(log, "Realpath'ing support file %s", file_spec_path.c_str()); // One prefix matched. Try to realpath. - llvm::SmallString buff; + llvm::SmallString<1024> buff;

[Lldb-commits] [lldb] (lldb) (minor) Correctly fix a usage of `PATH_MAX` (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/104502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] (lldb) (minor) Correctly fix a usage of `PATH_MAX` (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/104502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][dotest] Add an arg to add DLL search paths. (PR #104514)

2024-08-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kendal Harland (kendalharland) Changes In python 3.8 PATH is no longer used to search for DLLs on Windows. When building Swift's patched version of LLDB this prevents LLDB from starting up, because it cannot find DLLs like swiftCore.dll, c

[Lldb-commits] [lldb] (lldb) Fix build break for Windows (`PATH_MAX`) (PR #104493)

2024-08-15 Thread via lldb-commits
royitaqi wrote: After fixing the build break, this now shows a test failure in windows. ``` C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\unittests\Utility\FileSpecListTest.cpp(174): error: Expected equality of these values: ret Which is: 4294967295 (size_t)0 Whic

[Lldb-commits] [lldb] (lldb) (minor) Correctly fix a usage of `PATH_MAX` (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/104502 >From 1e0e766530acffc29fef0b0b2cd909a943a92599 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 15 Aug 2024 13:34:53 -0700 Subject: [PATCH 1/2] (lldb) (minor) Correctly fix a usage of PATH_MAX --- lldb/sourc

[Lldb-commits] [lldb] (lldb) (minor) Correctly fix a usage of `PATH_MAX` (PR #104502)

2024-08-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c19326cb84e871e1dd77408c2911c7d1651ba34b 3813cf592c64f5ed3202fb76032c7f2d1ac91b83 --e

[Lldb-commits] [lldb] (lldb) (minor) Correctly fix a usage of `PATH_MAX` (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/104502 >From 1e0e766530acffc29fef0b0b2cd909a943a92599 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 15 Aug 2024 13:34:53 -0700 Subject: [PATCH 1/3] (lldb) (minor) Correctly fix a usage of PATH_MAX --- lldb/sourc

[Lldb-commits] [lldb] (lldb) (minor) Correctly fix a usage of `PATH_MAX` (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/104502 >From 1e0e766530acffc29fef0b0b2cd909a943a92599 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 15 Aug 2024 13:34:53 -0700 Subject: [PATCH 1/4] (lldb) (minor) Correctly fix a usage of PATH_MAX --- lldb/sourc

[Lldb-commits] [lldb] (lldb) Correctly fix a usage of `PATH_MAX` and unit tests (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/104502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] (lldb) Correctly fix a usage of `PATH_MAX` and unit tests (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/104502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] (lldb) Correctly fix a usage of `PATH_MAX` and unit tests (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/104502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] (lldb) Correctly fix a usage of `PATH_MAX` and unit tests (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/104502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] (lldb) Correctly fix a usage of `PATH_MAX` and unit tests (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/104502 >From 1e0e766530acffc29fef0b0b2cd909a943a92599 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 15 Aug 2024 13:34:53 -0700 Subject: [PATCH 1/5] (lldb) (minor) Correctly fix a usage of PATH_MAX --- lldb/sourc

[Lldb-commits] [lldb] (lldb) Correctly fix a usage of `PATH_MAX` and unit tests (PR #104502)

2024-08-15 Thread via lldb-commits
royitaqi wrote: Two changes made: 1. Add typedef `lldb_private::PathSmallString` with initial size 256. Use it in `RealpathPrefixes.cpp`. 2. Fix test errors in Windows (caused by by not specify WindowsSpec vs. PosixSpec). https://github.com/llvm/llvm-project/pull/104502 ___

[Lldb-commits] [lldb] (lldb) Correctly fix a usage of `PATH_MAX` and unit tests (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/104502 >From 1e0e766530acffc29fef0b0b2cd909a943a92599 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 15 Aug 2024 13:34:53 -0700 Subject: [PATCH 1/6] (lldb) (minor) Correctly fix a usage of PATH_MAX --- lldb/sourc

[Lldb-commits] [lldb] (lldb) Correctly fix a usage of `PATH_MAX`, and fix unit tests (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/104502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 572943e - [LLDB] Reapply #100443 SBSaveCore Thread list (#104497)

2024-08-15 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-08-15T16:29:59-07:00 New Revision: 572943e79080962cd70d30fe58a17a8bd0579fd7 URL: https://github.com/llvm/llvm-project/commit/572943e79080962cd70d30fe58a17a8bd0579fd7 DIFF: https://github.com/llvm/llvm-project/commit/572943e79080962cd70d30fe58a17a8bd0579fd7.diff

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes Compilers and language runtimes often use helper functions that are fundamentally uninteresting when debugging anything but the compiler/runtime itself. This patch introduces a user-extensible mechanis

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ae059a1f9f1e501b08a99cb636ec0869ec204c6f 6289b797e6699c356c03caf32a4b74a5e2ee3278 --e

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r ae059a1f9f1e501b08a99cb636ec0869ec204c6f...6289b797e6699c356c03caf32a4b74a5e2ee3278 lldb/

[Lldb-commits] [lldb] [LLDB][Minidump] Fix ProcessMinidump::GetMemoryRegions to include 64b regions when /proc/pid maps are missing. (PR #101086)

2024-08-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4e078e3797098daa40d254447c499bcf61415308 aab60b78229a26114a2e919039b6eb89fa56c352 --e

[Lldb-commits] [lldb] 26670e7 - [lldb] Correctly fix a usage of `PATH_MAX`, and fix unit tests (#104502)

2024-08-15 Thread via lldb-commits
Author: royitaqi Date: 2024-08-15T17:24:39-07:00 New Revision: 26670e7fa4f032a019d23d56c6a02926e854e8af URL: https://github.com/llvm/llvm-project/commit/26670e7fa4f032a019d23d56c6a02926e854e8af DIFF: https://github.com/llvm/llvm-project/commit/26670e7fa4f032a019d23d56c6a02926e854e8af.diff LOG:

[Lldb-commits] [lldb] (lldb) Correctly fix a usage of `PATH_MAX`, and fix unit tests (PR #104502)

2024-08-15 Thread via lldb-commits
https://github.com/royitaqi closed https://github.com/llvm/llvm-project/pull/104502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Disable ThreadPlanSingleThreadTimeout during step over breakpoint (PR #104532)

2024-08-15 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/104532 This PR fixes another potential race condition in https://github.com/llvm/llvm-project/pull/90930. The failure is found by @labath with this log: https://paste.debian.net/hidden/30235a5c/. The investigati

[Lldb-commits] [lldb] Disable ThreadPlanSingleThreadTimeout during step over breakpoint (PR #104532)

2024-08-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes This PR fixes another potential race condition in https://github.com/llvm/llvm-project/pull/90930. The failure is found by @labath with this log: https://paste.debian.net/hidden/30235a5c/. The investigation show

[Lldb-commits] [lldb] Fix single thread stepping timeout race condition (PR #104195)

2024-08-15 Thread via lldb-commits
jeffreytan81 wrote: https://github.com/llvm/llvm-project/pull/104532 should fix it. The test runs under it for more than 10 iterations without failing. (It used to fail under 4 iterations). Sorry I wish I can find these issues before landing but we did not have any infrastructure like buildbo

[Lldb-commits] [lldb] Disable ThreadPlanSingleThreadTimeout during step over breakpoint (PR #104532)

2024-08-15 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/104532 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RISCV] Support optionally disabled FPR (PR #104547)

2024-08-15 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alexey Merzlyakov (AlexeyMerzlyakov) Changes The PR adds the support optionally enabled/disabled FP-registers to LLDB `RegisterInfoPOSIX_riscv64`. This situation might take place for RISC-V builds have no FP-registers, like RV64IMAC or RV6

[Lldb-commits] [lldb] [lldb][RISCV] Support optionally disabled FPR (PR #104547)

2024-08-15 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 43ffe2eed0d9f73789dbe213023733d164999306 f0dcd28876e3815454be3c9b2ae19cab26dede1e --e

[Lldb-commits] [lldb] 899a3df - [lldb][NFC] Moved FindSchemeByProtocol() from Acceptor to Socket (#104439)

2024-08-16 Thread via lldb-commits
Author: Dmitry Vasilyev Date: 2024-08-16T13:46:45+04:00 New Revision: 899a3df02427086f365e1308fd11ca8ab981e9df URL: https://github.com/llvm/llvm-project/commit/899a3df02427086f365e1308fd11ca8ab981e9df DIFF: https://github.com/llvm/llvm-project/commit/899a3df02427086f365e1308fd11ca8ab981e9df.dif

[Lldb-commits] [lldb] [lldb-dap] Provide `declarationLocation` for variables (PR #102928)

2024-08-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes This commit implements support for the "declaration location" recently added by microsoft/debug-adapter-protocol#494 to the debug adapter protocol. For the `declarationLocationReference` we need a

[Lldb-commits] [lldb] [lldb-dap] Provide `declarationLocation` for variables (PR #102928)

2024-08-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 82ee31f75ac1316006fa9e21dddfddec37cf7072...a740c6918fd4c0e47b6d266fbb2b217112405a4f lldb/

[Lldb-commits] [lldb] [lldb-dap] Provide `declarationLocation` for variables (PR #102928)

2024-08-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 82ee31f75ac1316006fa9e21dddfddec37cf7072 a740c6918fd4c0e47b6d266fbb2b217112405a4f --e

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-08-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes Note to reviewers: This commit builds on top of the not-yet-merged PR #102928. When reviewing, ignore the first commit, it is part of the over PR. I will rebase and turn this into a non-draft PR af

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-08-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 82ee31f75ac1316006fa9e21dddfddec37cf7072...b0fee0c0c32001064aeab1ebca209fef02c6cb98 lldb/

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-08-16 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 82ee31f75ac1316006fa9e21dddfddec37cf7072 b0fee0c0c32001064aeab1ebca209fef02c6cb98 --e

[Lldb-commits] [lldb] a434cac - [lldb] Add Populate Methods for ELFLinuxPrPsInfo and ELFLinuxPrStatus (#104109)

2024-08-16 Thread via lldb-commits
Author: Fred Grim Date: 2024-08-16T08:53:15-07:00 New Revision: a434cac523da6db542350fd747967520aaae8fbb URL: https://github.com/llvm/llvm-project/commit/a434cac523da6db542350fd747967520aaae8fbb DIFF: https://github.com/llvm/llvm-project/commit/a434cac523da6db542350fd747967520aaae8fbb.diff LOG

[Lldb-commits] [lldb] [lldb] PopulatePrpsInfoTest can fail due to hardcoded priority value (PR #104617)

2024-08-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Fred Grim (feg208) Changes In implementing this test one of the assertions assumes that the priority is the default in linux (0) but, evidently, some of the build runners prioritize the test to, at least, 5. This ensures that regardless of

[Lldb-commits] [lldb] Disable ThreadPlanSingleThreadTimeout during step over breakpoint (PR #104532)

2024-08-16 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/104532 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Disable ThreadPlanSingleThreadTimeout during step over breakpoint (PR #104532)

2024-08-16 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/104532 >From e86454235bf3bd20be1ddc394683d3f475fad218 Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Thu, 15 Aug 2024 18:12:04 -0700 Subject: [PATCH 1/2] Fix async interrupt for step over breakpoint --- lldb/

[Lldb-commits] [lldb] Disable ThreadPlanSingleThreadTimeout during step over breakpoint (PR #104532)

2024-08-16 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/104532 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-16 Thread via lldb-commits
jimingham wrote: When we were talking about this originally I thought that StackFrames would get an "ImplementationFrame" property, and we would use that to determine whether to hide the frame in bt (when not passing --unfiltered). Then the frame recognizers when they are run on the frame in

[Lldb-commits] [lldb] [lldb] Extend frame recognizers to hide frames from backtraces (PR #104523)

2024-08-16 Thread via lldb-commits
jimingham wrote: BTW, we should definitely get StepOut to step out past hidden frames. That should be pretty easy to do. https://github.com/llvm/llvm-project/pull/104523 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [lldb] Disable ThreadPlanSingleThreadTimeout during step over breakpoint (PR #104532)

2024-08-16 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/104532 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    13   14   15   16   17   18   19   20   21   22   >