jimingham wrote:

When we were talking about this originally I thought that StackFrames would get 
an "ImplementationFrame" property, and we would use that to determine whether 
to hide the frame in bt (when not passing --unfiltered).  Then the frame 
recognizers when they are run on the frame in the ordinary course of things (we 
do this to determine recognized args anyway) they would set the property on the 
StackFrame.  Then StackFrameList could just check that property.
RecognizeFrame might be expensive, and we don't currently have any machinery in 
place to make sure it caches the results per stop.  Most of the 
RecognizeFrame's just do the work every time.
I also think for structural reasons we shouldn't force FrameRecognizers to be 
the only entity that can mark frames as "should be hidden."

https://github.com/llvm/llvm-project/pull/104523
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to