[Lldb-commits] [PATCH] D155256: Add fs_base/gs_base support for Linux

yinghuitan updated this revision to Diff 541272. yinghuitan edited the summary of this revision. yinghuitan added a comment. Revert x86_64 changes to reduce amount of changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155256/new/ https://review

[Lldb-commits] [PATCH] D155256: Add fs_base/gs_base support for Linux

yinghuitan updated this revision to Diff 541597. yinghuitan added a comment. Address review comments: - clang-format - Add coredump tests - Add test against gs_base register Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155256/new/ https://reviews

[Lldb-commits] [PATCH] D155256: [lldb][x86_64] Add fs_base/gs_base support for Linux

yinghuitan updated this revision to Diff 542292. yinghuitan added a comment. Use coredump fs_base/gs_base values from thread_crash test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155256/new/ https://reviews.llvm.org/D155256 Files: lldb/sourc

[Lldb-commits] [PATCH] D155256: [lldb][x86_64] Add fs_base/gs_base support for Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG49b3c3355f9c: [lldb][x86_64] Support fs_base/gs_base register in Linux (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D156375: Fix lldb-vscode frame id integer overflow

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch fix

[Lldb-commits] [PATCH] D156375: Fix lldb-vscode frame id integer overflow

This revision was automatically updated to reflect the committed changes. Closed by commit rGca849352936d: Fix lldb-vscode frame id integer overflow (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156375/new/ https://reviews.

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

yinghuitan added a comment. Can you add a testcase for this? Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:768 +// hex string. +frame_name.clear(); +llvm::raw_string_ostream os(frame_name); I do not think this is needed? Comme

[Lldb-commits] [PATCH] D159542: Lazy deference underlying object for shared/weak/unique_ptr synthetic provider

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. We noti

[Lldb-commits] [PATCH] D159542: Lazy deference underlying object for shared/weak/unique_ptr synthetic provider

yinghuitan abandoned this revision. yinghuitan added a comment. Abandon to use the github workflow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159542/new/ https://reviews.llvm.org/D159542 ___ lldb-comm

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:545 + } + const useconds_t usleep_interval = 250 * 1; // 250 ms internal + const useconds_t count = (seconds * 1000 * 1000)/usleep_interval; Is this a typo? It should be 1000 i

[Lldb-commits] [PATCH] D120755: Fix race condition when launching and attaching.This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797This version only wait

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:532-533 +lldb::SBError VSCode::WaitForProcessToStop(uint32_t seconds) { + // Wait for the process hit a stopped state. When running a launch (with or + // without "launchCommands") or attach (with o

[Lldb-commits] [PATCH] D120948: Disable LLDB index cache for .o files with no UUID.

yinghuitan accepted this revision. yinghuitan added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Core/DataFileCache.h:127 + /// unique idenifier like the UUID being valid. + bool IsValid() const { return m_uuid.hasValue(); }

[Lldb-commits] [PATCH] D120948: Disable LLDB index cache for .o files with no UUID.

yinghuitan added inline comments. Comment at: lldb/include/lldb/Core/DataFileCache.h:127 + /// unique idenifier like the UUID being valid. + bool IsValid() const { return m_uuid.hasValue(); } yinghuitan wrote: > Do we plan to ship with this design (no caching

[Lldb-commits] [PATCH] D120948: Disable LLDB index cache for .o files with no UUID.

yinghuitan added inline comments. Comment at: lldb/include/lldb/Core/DataFileCache.h:130-138 + bool operator==(const CacheSignature &rhs) const { if (m_uuid != rhs.m_uuid) - return true; + return false; if (m_mod_time != rhs.m_mod_time) - return true; +

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan created this revision. yinghuitan added reviewers: clayborg, aadsm, jingham. Herald added subscribers: arphaman, mgorny. Herald added a project: All. yinghuitan requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 415183. yinghuitan added a comment. Herald added a subscriber: JDevlieghere. Fix tests line number change after formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 415252. yinghuitan added a comment. Remove duplicate file and fix wrapping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files: lldb/include/lldb/Core/ModuleL

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added a comment. @cmtice, are you sure the failure is caused by/related with this patch? This is a pure lldb-vscode change which is not used by normal lldb. Also, no mention of code in this patch in the error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Some build system (li

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan updated this revision to Diff 442973. yinghuitan added a comment. Remove unnecessary format changes caused by IDE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129307/new/ https://reviews.llvm.org/D129307 Files: lldb/include/lldb/Bre

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan added a comment. @jingham, thanks for sharing the thoughts. > Setting the breakpoint search to only check base names will of course make > all your file and line breakpoints work, but they will also pick up extra > hits. In command line lldb that doesn't look nearly as weird as click

[Lldb-commits] [PATCH] D129528: Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo.

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1939-1950 + uint32_t addr_size = frame.GetThread().GetProcess().GetAddressByteSize(); + const uint32_t num_reg_sets = g_vsc.variables.registers.GetSize(); + for (uint32_t reg_set_idx=0; reg_se

[Lldb-commits] [PATCH] D129521: Add the ability to run expressions that call fork() or vfork().

yinghuitan added a comment. Change looks good to me. I will let @jingham take a second look before accepting. I do wonder if there will be more unexpected signals (like SIGCHILD, SIGPIPE etc...) causing expression evaluation to pause? Should we maybe default to not stop on signals?

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

yinghuitan added a comment. > From Jim, First off, I am supportive of your project, this is a pain point > for some folks for sure. I am in favor of trying to automate "I built my > binaries with sources in one location but locally they are in another" > scenario. Great to hear that! Seems all

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan marked 2 inline comments as done. yinghuitan added a comment. Jim, Pavel, thanks for the comment! I am happy to start a strategy discussion for this feature. @clayborg will chrime in later to suggest the approach how we can discuss. I would like to answer some of the questions here t

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. Re @labath > How many tests/bugs are we talking about here? Were there more than say ten > distinct bugs caught there? It found 2~3 bugs, like source regex breakpoint (breakpoint set -p "source"), regex breakpoint filter by language (breakpoint set -r -L c++) etc.

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan marked 19 inline comments as done. yinghuitan added inline comments. Comment at: lldb/source/Symbol/SymbolFileOnDemand.cpp:28 + +uint32_t SymbolFileOnDemand::CalculateAbilities() { + if (!this->m_debug_info_enabled) { clayborg wrote: > We might consid

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 416333. yinghuitan marked 4 inline comments as done. yinghuitan added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files:

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. I will remove ondemand test flavor/category and add more new testcases next. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 ___ lld

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 417048. yinghuitan added a comment. Remove ondemand test category/flavor Add new testcases: - source text regex breakpoint - regex breakpoint filter by language - global variable symbol table match hydration Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 417049. yinghuitan added a comment. Remove last ondemand test flavor testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files: lldb/include/lldb/Core/Modu

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 418632. yinghuitan added a comment. Add documentation for the feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files: lldb/docs/use/ondemand.rst lldb/i

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 418708. yinghuitan added a comment. Fix log channel typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files: lldb/docs/use/ondemand.rst lldb/include/lldb/Co

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan marked an inline comment as done. yinghuitan added inline comments. Comment at: lldb/test/Shell/SymbolFile/OnDemand/shared-lib-globals-hydration.test:4 + +# REQUIRES: system-linux + labath wrote: > Is this here because there is no portable way to crea

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added inline comments. Comment at: lldb/test/Shell/SymbolFile/OnDemand/shared-lib-globals-hydration.test:4 + +# REQUIRES: system-linux + labath wrote: > yinghuitan wrote: > > labath wrote: > > > Is this here because there is no portable way to create

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 419226. yinghuitan added a comment. Support debug map dwarf mode. Use zero symbol ability to skip SymbolFileOnDemand wrapping. Add new API tests for symbol on-demand which support multi-platform. Remove linux-only shell tests. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. > Does this by any chance have something to do with the fact that there are now > two compile unit lists (one in the actual symbol file, and one in the > wrapping ondemand class? Yes, that's the major reason. We also need make SymbolFileOnDemand friend in SymbolFile

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. Thanks for clarifying. The friendship declaration in SymbolFile is required not only for `SetCompileUnitAtIndex` but also for other protected virtual methods in `SymbolFile` like `CalculateNumCompileUnits` and `ParseCompileUnitAtIndex` which are pure virtual and requ

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, JDevlieghere. Herald added a subscriber: mgorny. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a prep

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 423974. yinghuitan added a comment. Rebase on top of https://reviews.llvm.org/D124110 Rename test file name to avoid conflict Added a new totalModuleCountHasDebugInfo statistics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

yinghuitan added a comment. Sounds good. Here are the changes I plan to do: 1. Rename SymbolFileActual => SymbolFileCommon. 2. Inline SymbolFileCommon.h content into SymbolFile.h, 3. Move all remaining member fields of SymbolFile class into SymbolFileCommon. Comment at: lldb/

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

yinghuitan updated this revision to Diff 424317. yinghuitan added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124110/new/ https://reviews.llvm.org/D124110 Files: lldb/include/lldb/Symbol/SymbolFile.h lldb/

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 424318. yinghuitan added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files: lldb/docs/use/ondemand.rst lldb/include/lldb/Core/ModuleList.

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 424360. yinghuitan added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files: lldb/docs/use/ondemand.rst lldb/include/lldb/Core/ModuleList.

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

yinghuitan updated this revision to Diff 424794. yinghuitan added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124110/new/ https://reviews.llvm.org/D124110 Files: lldb/include/lldb/Symbol/SymbolFile.h lldb/s

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan marked 8 inline comments as done. yinghuitan added a comment. Thanks for all the feedback. I will address the comments and add @clayborg's follow-up suggestions into summary. Comment at: lldb/source/Symbol/SymbolFileOnDemand.cpp:47 +lldb::LanguageType SymbolFileOnDe

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 424808. yinghuitan marked 3 inline comments as done. yinghuitan added a comment. Incorporate feedback and update summary with follow-up todos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https:

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5cbf516cb79f: Refactor protected virtual functions from SymbolFile into new SymbolFileCommon… (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b81192d462b: Introduce new symbol on-demand for debug info (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D124471: Disable symbol on-demand feature for Windows

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, JDevlieghere, jdoerfert, DavidSpickett. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Symbol on-demand featu

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. @stella.stamenova, thanks for the heads-up. I am fixing this in https://reviews.llvm.org/D124471. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 _

[Lldb-commits] [PATCH] D124471: Disable symbol on-demand feature for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGd738d4717f6d: Disable symbol on-demand feature for Windows (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124471/new/ https://revie

[Lldb-commits] [PATCH] D124479: Fix missing import for test

yinghuitan created this revision. yinghuitan added reviewers: clayborg, JDevlieghere, labath, jingham. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The last fix missed an import in one test file ca

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. Another patch to fix the missing import: https://reviews.llvm.org/D124479 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 ___ lldb-c

[Lldb-commits] [PATCH] D124479: Fix missing import for test

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ffcec418e45: Fix missing import for test (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124479/new/ https://reviews.llvm.org/D1244

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. @jasonmolenda, thanks, I discovered a bit late that testcases can't have duplicate names; I fixed one case in the patch but missed these two. Will add a follow-up patch. I would be great if we have a linter/script to detect/warn duplications, not sure how hard to add

[Lldb-commits] [PATCH] D124499: Rename conflict testcase

yinghuitan created this revision. yinghuitan added reviewers: jasonmolenda, clayborg, JDevlieghere, labath, jdoerfert, jingham. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This diff solves the fo

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. Thanks for the context. Fixed in https://reviews.llvm.org/D124499. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 ___ lldb-commits

[Lldb-commits] [PATCH] D124471: Disable symbol on-demand feature for Windows

yinghuitan added a comment. @labath, that's a good point. If I remember correctly, exported function symbols will be included in Windows COFF export address table (which I assume will be parsed by lldb symtab). So in theory, if we change the tests (or add new tests) to set symbolic function bre

[Lldb-commits] [PATCH] D124572: Fix the encoding and decoding of UniqueCStringMap objects when saved to cache files.

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. This is a great finding! The change looks good. Some questions though: - Do you have any theory why we only see this issue on Mac not Linux? (For anyone else reading this, I found this

[Lldb-commits] [PATCH] D124572: Fix the encoding and decoding of UniqueCStringMap objects when saved to cache files.

yinghuitan added a comment. Also, to help diagnostics this kind of issue in future, it may worth to add an extra debug mode check in in `UniqueCStringMap` to ensure they are sorted. For example, in debug mode, add a `m_isSorted` flag which is set by `UniqueCStringMap::Sort()` method. All the bi

[Lldb-commits] [PATCH] D125253: Add the ability to debug through an exec into ld

yinghuitan added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:312 BreakpointSP dyld_break; - if (m_rendezvous.IsValid()) { + if (m_rendezvous.IsValid() && m_rendezvous.GetBreakAddress() != 0) { break_addr = m_rend

[Lldb-commits] [PATCH] D125347: Add "indexedVariables" to variables with lots of children.

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:1035 + // or if we have a synthetic child provider. We don't want to call + // "v.GetNumChildren()" on all objects as class, struct and union types don't + // need to be completed if they are ne

[Lldb-commits] [PATCH] D124499: Rename conflict testcase

yinghuitan abandoned this revision. yinghuitan added a comment. Seems that this is a duplication to Pavel Labath's commit f513b5fc47df5c040a257ab6f4643942828fa610 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. To help user identify optimized code T

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, aadsm. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes an issue t

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:762 + } else { +EmplaceSafeString(object, "name", frame.GetFunctionName()); + } clayborg wrote: > We should probably get the function name with "const char *func_name = > fr

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

yinghuitan updated this revision to Diff 431008. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126013/new/ https://reviews.llvm.org/D126013 Files: lldb/test/API/tools/lldb-vscode/optimized/Make

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rG46c1f77e160a: Add [opt] suffix to optimized stack frame in lldb-vscode (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126013/new/ h

[Lldb-commits] [PATCH] D126014: Show error message for optimized variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0fe220a33179: Show error message for optimized variables (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D126225: Fix lldb-vscode frame test failure

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, kusmour, aadsm. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previous patch (https://reviews.llvm.org/D12601

[Lldb-commits] [PATCH] D126225: Fix lldb-vscode frame test failure

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1d490319a9e: Fix lldb-vscode frame test failure (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126225/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch implements

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added inline comments. Herald added a subscriber: Michael137. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_logpoints.py:60 +[loop_line, after_loop_line], +[{'logMessage': logMessage}, {}] +) claybor

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan updated this revision to Diff 438448. yinghuitan added a comment. Using a single structured LogMessagePart per suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702 Files: lldb/packages

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c6e138aa893: Support logpoints in lldb-vscode (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added a comment. Sorry, I was fooled by the buildbot which says everything is green. Working on a fix for the build break now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702 _

[Lldb-commits] [PATCH] D128234: Fix build break introduced by https://reviews.llvm.org/D127702

yinghuitan created this revision. yinghuitan added reviewers: clayborg, thakis, kazu. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix build break introduced by https://reviews.llvm.org/D127702 R

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

yinghuitan added a comment. Fixed in https://reviews.llvm.org/D128234 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D128234: Fix build break introduced by https://reviews.llvm.org/D127702

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5109de2da2e2: Fix build break introduced by https://reviews.llvm.org/D127702 (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adding a new S

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

yinghuitan updated this revision to Diff 497133. yinghuitan added a comment. Address review comments by using the same type for internal and public callbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143520/new/ https://reviews.llvm.org/D1435

[Lldb-commits] [PATCH] D145203: Add HitCount into Breakpoint statistics

yinghuitan created this revision. yinghuitan added reviewers: clayborg, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Turns out breakpoint statistics is missing hitCount. This

[Lldb-commits] [PATCH] D145203: Add HitCount into Breakpoint statistics

This revision was automatically updated to reflect the committed changes. Closed by commit rG83263aeceb8e: Add HitCount into Breakpoint statistics (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145203/new/ https://reviews.ll

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

yinghuitan updated this revision to Diff 502897. yinghuitan added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143520/new/ https://reviews.llvm.org/D143520 Files: lldb/bindings/python/python-typemaps.swig l

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

This revision was automatically updated to reflect the committed changes. Closed by commit rGb461398f1ce3: Add a new SBDebugger::SetDestroyCallback() API (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143520/new/ https://rev

[Lldb-commits] [PATCH] D145955: Refactor ObjectFilePlaceholder for sharing

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch ref

[Lldb-commits] [PATCH] D145955: Refactor ObjectFilePlaceholder for sharing

This revision was automatically updated to reflect the committed changes. Closed by commit rG46c2e4c4f347: Refactor ObjectFilePlaceholder for sharing (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145955/new/ https://reviews

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

yinghuitan added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:376-386 +bool handled = llvm::any_of(m_processes, [&](NativeProcessLinux *process) { + return process->TryHandleWaitStatus(pid, status); +}); +if (!handled) { +

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. LGTM. I have patched and verified this diff indeed fixed the performance issue in our internal service with 3000~4000 threads. Thanks for fixing it! Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D150313: Fix libstdc++ data formatter for reference/pointer to std::string

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch fix

[Lldb-commits] [PATCH] D150313: Fix libstdc++ data formatter for reference/pointer to std::string

This revision was automatically updated to reflect the committed changes. Closed by commit rG25159ee3af5c: Fix libstdc++ data formatter for reference/pointer to std::string (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15031

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

yinghuitan accepted this revision. yinghuitan added a comment. Can we wrap this as a helper function and shared to avoid duplication? Otherwise looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712

[Lldb-commits] [PATCH] D133038: Add GetSourceMap public API

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new SBTarget::GetSourceMap() API which

[Lldb-commits] [PATCH] D133038: Add GetSourceMap public API

yinghuitan updated this revision to Diff 457046. yinghuitan added a comment. Herald added a subscriber: JDevlieghere. Re-diff with clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files: lld

[Lldb-commits] [PATCH] D133042: Add auto deduce source map setting

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new

[Lldb-commits] [PATCH] D133038: Add GetSourceMap public API

yinghuitan updated this revision to Diff 458809. yinghuitan added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files: lldb/bindings/interface/SBDebugger.i lldb/i

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting()/GetSettings() public APIs

yinghuitan updated this revision to Diff 458932. yinghuitan marked 11 inline comments as done. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133038/new/ https://reviews.llvm.org/D133038 Files:

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan marked an inline comment as done. yinghuitan added a comment. @jingham , @clayborg, thanks for the feedback. Seems like the major concern is creating a general GetSettings() API instead of API for each setting. I like and agree with this idea. Per the reading, Comm

[Lldb-commits] [PATCH] D133038: Add SBDebugger::GetSetting() public API

yinghuitan added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionValueChar.h:34-37 +if (m_current_value != '\0') + return m_current_value; +else + return "(null)"; clayborg wrote: > Since this is actually a character, it should

  1   2   >