tberghammer added a comment.
Instead of duplicating the test can you just change the existing one to remove
the watchpoint in case we are running on mips?
Repository:
rL LLVM
http://reviews.llvm.org/D14944
___
lldb-commits mailing list
lldb-comm
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, emaste.
Create new "platform process connect" command
The standard remote debugging workflow with gdb is to st
tberghammer accepted this revision.
tberghammer added a comment.
If you want to get this in with using SetBytes I am fine with it but we should
keep an eye on it as I won't be surprised if it will break when somebody try to
read out the data from the RegisterValue object with GetUInt()
Reposit
tberghammer created this revision.
tberghammer added reviewers: labath, omjavaid.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, emaste, aemerson.
Add 64/128 bit arm neon register definitions on linux
http://reviews.llvm.org/D14985
Files:
source/Core/Scalar.c
tberghammer created this revision.
tberghammer added reviewers: omjavaid, labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
Make some of the tests in TestRegisters.py arm compatible
http://reviews.llvm.org/D15010
Files:
packages/Python/lldbsuit
tberghammer added a comment.
I made some of the tests in TestRegisters.py arm compatible (see
http://reviews.llvm.org/D15010) and we also test register read/write in some
extent with the gdb remote protocol tests (they caught several issues while I
was doing this patch)
Comme
tberghammer updated this revision to Diff 41228.
http://reviews.llvm.org/D14985
Files:
source/Core/Scalar.cpp
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm.cpp
source/Plugins/Process/Utility/RegisterContextFreeBSD_arm.cpp
source/Plugins/Process/Utility/RegisterContextLinux_a
Author: tberghammer
Date: Thu Nov 26 09:02:35 2015
New Revision: 254153
URL: http://llvm.org/viewvc/llvm-project?rev=254153&view=rev
Log:
Make some of the tests in TestRegisters.py arm compatible
Differential revision: http://reviews.llvm.org/D15010
Modified:
lldb/trunk/packages/Python/lldb
Author: tberghammer
Date: Thu Nov 26 09:02:31 2015
New Revision: 254152
URL: http://llvm.org/viewvc/llvm-project?rev=254152&view=rev
Log:
Add 64/128 bit arm neon register definitions on linux
Differential revision: http://reviews.llvm.org/D14985
Modified:
lldb/trunk/source/Core/Scalar.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254152: Add 64/128 bit arm neon register definitions on
linux (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D14985?vs=41228&id=41247#toc
Repository:
rL LLVM
http://revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254153: Make some of the tests in TestRegisters.py arm
compatible (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15010?vs=41225&id=41248#toc
Repository:
rL LLVM
http://
Author: tberghammer
Date: Thu Nov 26 10:11:57 2015
New Revision: 254163
URL: http://llvm.org/viewvc/llvm-project?rev=254163&view=rev
Log:
Remove some xfail-s fixed by r253026
These tests were fixed by r253026 but they was failing on the linux
build bot because of a system setup problem. Remove xf
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1014
@@ +1013,3 @@
+
+Error error;
+m_stdio_handle_up = m_mainloop.R
Author: tberghammer
Date: Thu Nov 26 11:43:24 2015
New Revision: 254166
URL: http://llvm.org/viewvc/llvm-project?rev=254166&view=rev
Log:
Fix TestRegisters.py on arm
Previously it tried to write a bit in the FPSCR register marked as
do not modify what failed on some device.
Modified:
lldb/t
tberghammer updated this revision to Diff 41266.
tberghammer added a comment.
Add test
http://reviews.llvm.org/D14952
Files:
include/lldb/Target/Platform.h
packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
packages/Python/lldbsuite/test/tools/lldb-server/platform-pro
tberghammer marked an inline comment as done.
Comment at: source/Commands/CommandObjectPlatform.cpp:2040-2041
@@ -1968,13 +2039,4 @@
"platform process",
"A set of commands to query, launch and attach
to platform pr
Author: tberghammer
Date: Fri Nov 27 04:50:33 2015
New Revision: 254194
URL: http://llvm.org/viewvc/llvm-project?rev=254194&view=rev
Log:
Re-add an xfail removed by r254163
The test is flakey but it fails too often with gcc 4.9.2 on x86_64 to
be marked only as expected flakey.
Modified:
lld
tberghammer added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:849-850
@@ -844,2 +848,4 @@
m_fpr_type = eFPRTypeFXSAVE;
+assert
(const_cast(this)->ReadFPR().Success() &&
+"ptrace APIs
tberghammer updated this revision to Diff 41312.
tberghammer marked 4 inline comments as done.
tberghammer added a comment.
Improve the test based on the comments
http://reviews.llvm.org/D14952
Files:
include/lldb/Target/Platform.h
packages/Python/lldbsuite/test/lldbtest.py
packages/Pytho
tberghammer added inline comments.
Comment at:
packages/Python/lldbsuite/test/tools/lldb-server/platform-process-connect/TestPlatformProcessConnect.py:13
@@ +12,3 @@
+def test_platform_process_connect(self):
+if not lldb.remote_platform:
+self.skipTest("On
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
Note: We will have to enable the same functionality for some variant of mips
also but I don't know the details so we should leave it for the mips guys.
http://reviews.llvm.org
tberghammer added a comment.
I decided to go with the "platform process connect" command as it connects to
both to a platform and to a process instances at the same time but I agree it
is not very clear.
We can make this the default functionality for "platform connect" but then we
have to add
tberghammer accepted this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
Looks good, and as it only effects Linux you can commit it just based on the
review from Pavel
http://reviews.llvm.org/D15042
___
lldb-commi
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 41490.
tberghammer added a comment.
Herald added a subscriber: emaste.
Address review comments
http://reviews.llvm.org/D11465
Files:
include/lldb/Target/Platform.h
include/lldb/Target/Process.h
pa
tberghammer updated this revision to Diff 41491.
http://reviews.llvm.org/D11465
Files:
include/lldb/Target/Platform.h
include/lldb/Target/Process.h
packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload.py
source/API/SBProcess.cpp
source/Commands/CommandObjectProcess.
tberghammer added inline comments.
Comment at: test/functionalities/load_unload/TestLoadUnload.py:201-204
@@ -205,7 +200,6 @@
-if lldb.remote_platform:
-dylibName = os.path.join(shlib_dir, 'libloadunload_a.so')
-elif self.platformIsDarwin():
+
tberghammer added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:853-854
@@ +852,4 @@
+{
+if (log)
+log->Printf("NativeRegisterContextLinux_x86_64::%s ptrace
APIs failed to read XSAV
Author: tberghammer
Date: Wed Dec 2 05:35:54 2015
New Revision: 254502
URL: http://llvm.org/viewvc/llvm-project?rev=254502&view=rev
Log:
Revert "Added support for -gmodule debugging when debug info is left in the .o
files on Darwin."
The commit caused a test failure on the linux buildbot in
Tes
Author: tberghammer
Date: Wed Dec 2 05:58:51 2015
New Revision: 254504
URL: http://llvm.org/viewvc/llvm-project?rev=254504&view=rev
Log:
Fix "process load/unload" on android
On android the symbols exposed by libdl (dlopen, dlclose, dlerror)
prefixed by "__dl_". This change moves the handling of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254504: Fix "process load/unload" on android (authored by
tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D11465?vs=41491&id=41608#toc
Repository:
rL LLVM
http://reviews.llvm.org/D114
Author: tberghammer
Date: Wed Dec 2 07:36:17 2015
New Revision: 254507
URL: http://llvm.org/viewvc/llvm-project?rev=254507&view=rev
Log:
XFAIL TestReturnValue for linux i386 clang 3.5-3.6
The test failing most likely because clang 3.5 and 3.6 uses an incorrect
ABI for returning small structs fro
Hi Abhishek,
After this change TestReturnValue.py is failing on Linux with i386 inferior
when compiling the inferior with clang-3.5 (it passes with gcc and with ToT
clang). I marked the test XFAIL for that specific configuration to get the
buildbot green but can you take a look?
My suspicion is t
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer, emaste.
Change Platform::LoadImage to copy the file to the remote platform
The new implementation mimic the behavior of
Author: tberghammer
Date: Thu Dec 3 05:02:10 2015
New Revision: 254602
URL: http://llvm.org/viewvc/llvm-project?rev=254602&view=rev
Log:
Fix TestLoadUnload for Windows -> POSIX remote debugging
Previously we used sys.os.path for appending target pathes what failed
when cased dlopen to fail on th
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D15172
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
tberghammer created this revision.
tberghammer added a reviewer: labath.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, emaste.
Remove some duplicated code from PlatformPOSIX/Android
The code was duplicated to handle the custom symbol name
tberghammer added a comment.
In http://reviews.llvm.org/D11465#300606, @labath wrote:
> In http://reviews.llvm.org/D11465#300581, @jingham wrote:
>
> > It seems like an awful lot of logic is duplicated between the POSIX &
> > Android versions of LoadImage when all that really changes is the name
tberghammer added a comment.
What is the opinion about adding just a boolean flag to specify if the path
provided is a local path or a remote path? In case it is a remote path (will be
the default to keep current behavior) then we don't do any copying and if it is
a local path then we copy the
Author: tberghammer
Date: Thu Dec 3 06:58:03 2015
New Revision: 254608
URL: http://llvm.org/viewvc/llvm-project?rev=254608&view=rev
Log:
Remove some duplicated code from PlatformPOSIX/Android
The code was duplicated to handle the custom symbol name for functions
in libdl.so for android. This cha
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254608: Remove some duplicated code from
PlatformPOSIX/Android (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15183?vs=41735&id=41742#toc
Repository:
rL LLVM
http://rev
tberghammer created this revision.
tberghammer added reviewers: clayborg, granata.enrico.
tberghammer added a subscriber: lldb-commits.
Improve the functionality of JSONNumber
* Add support for representing signed integers
* Add new constructors taking any signed or unsigned integer types
http:/
tberghammer added inline comments.
Comment at: include/lldb/Utility/JSON.h:102-104
@@ +101,5 @@
+
+template {} &&
+ std::is_unsigned{}>::type* =
nullptr>
+explicit JSONNumber (T u) :
clayborg wrote:
> What
tberghammer added a comment.
I would like to exposed the ability to specify if we want the specified file to
be copied over to the target or not both at the command line and on the SB API.
To do this without duplicating the logic what do the file installation into
CommandObjectProcess and SBPro
tberghammer added a comment.
Sounds reasonable. The only question is that currently only PlatformPOSIX
supports LoadImage. Do we want to add the DoLoadImage function now, or do we
want to wait until some other platform also want to implement image loading?
http://reviews.llvm.org/D15152
___
tberghammer retitled this revision from "Create new "platform process connect"
command" to "Modify "platform connect" to connect to processes as well".
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 41867.
http://reviews.llvm.org/D14952
Files:
docs
Author: tberghammer
Date: Fri Dec 4 07:23:35 2015
New Revision: 254715
URL: http://llvm.org/viewvc/llvm-project?rev=254715&view=rev
Log:
Improve the functionality of JSONNumber
* Add support for representing signed integers
* Add new constructors taking any signed or unsigned integer types
Diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254715: Improve the functionality of JSONNumber (authored by
tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15187?vs=41743&id=41868#toc
Repository:
rL LLVM
http://reviews.llvm.org/D
tberghammer retitled this revision from "Change Platform::LoadImage to copy the
file to the remote platform" to "Add a new option to Platform::LoadImage to
install the image".
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 41877.
tberghammer added a c
tberghammer updated this revision to Diff 42055.
tberghammer added a comment.
Update API documentation in SBProcess.h
http://reviews.llvm.org/D15152
Files:
include/lldb/API/SBProcess.h
include/lldb/Target/Platform.h
packages/Python/lldbsuite/test/functionalities/load_unload/TestLoadUnload
tberghammer added inline comments.
Comment at: include/lldb/API/SBProcess.h:301-307
@@ +300,9 @@
+
+// Load an image to the currently running process.
+// If both local and remote image is specified then copy the local image
to the remote image and
+// then load it fr
tberghammer updated this revision to Diff 42063.
http://reviews.llvm.org/D14952
Files:
docs/lldb-gdb-remote.txt
include/lldb/Target/Platform.h
packages/Python/lldbsuite/test/lldbtest.py
packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
packages/Python/lldbsuite/tes
tberghammer added a comment.
I can't move the functionality into Platform::ConnectRemote because to connect
to a process we need a debugger instance while Platform::ConnectRemote is
called in scenarios where we don't have access to it (from
SBPlatform::ConnectRemote). To clean up the API I adde
tberghammer added inline comments.
Comment at: source/Commands/CommandObjectPlatform.cpp:414-419
@@ -413,1 +413,8 @@
+
+
platform_sp->ConnectToWaitingProcesses(m_interpreter.GetDebugger(), error);
+if (error.Fail())
+{
+
tberghammer added a subscriber: tberghammer.
tberghammer added a comment.
Paul is not working on LLDB anymore so I added Siva who took over most of his
work.
Repository:
rL LLVM
http://reviews.llvm.org/D15312
___
lldb-commits mailing list
lldb-c
Author: tberghammer
Date: Tue Dec 8 07:43:59 2015
New Revision: 255014
URL: http://llvm.org/viewvc/llvm-project?rev=255014&view=rev
Log:
Add a new option to Platform::LoadImage to install the image
This change introduce 3 different working mode for Platform::LoadImage
depending on the file specs
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255014: Add a new option to Platform::LoadImage to install
the image (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15152?vs=42055&id=42166#toc
Repository:
rL LLVM
http
Author: tberghammer
Date: Tue Dec 8 08:08:19 2015
New Revision: 255016
URL: http://llvm.org/viewvc/llvm-project?rev=255016&view=rev
Log:
Modify "platform connect" to connect to processes as well
The standard remote debugging workflow with gdb is to start the
application on the remote host under
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255016: Modify "platform connect" to connect to processes as
well (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D14952?vs=42063&id=42170#toc
Repository:
rL LLVM
http://
Author: tberghammer
Date: Tue Dec 8 08:27:40 2015
New Revision: 255017
URL: http://llvm.org/viewvc/llvm-project?rev=255017&view=rev
Log:
Fix MSVC build after rL255016
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
Modified:
lldb/trunk/sourc
tberghammer added a comment.
I am not sure if doing all of the parsing lazily is the good approach because
of speed considerations.
The problem is that if we do everything lazily then in one side we are parsing
only the information what we need but on the other side it is very difficult
(or im
Author: tberghammer
Date: Wed Dec 9 04:16:05 2015
New Revision: 255104
URL: http://llvm.org/viewvc/llvm-project?rev=255104&view=rev
Log:
Fix a cleanup error in TestPlatformProcessConnect.py
Modified:
lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/platform-process-connect/TestPl
tberghammer requested changes to this revision.
tberghammer added a comment.
This revision now requires changes to proceed.
These GetAs{...} functions should never fail in their current implementation as
we have only 3 different data type and all of them are handled. The new
function signatures
tberghammer requested changes to this revision.
tberghammer added a comment.
This revision now requires changes to proceed.
We discussed the same change recently (http://reviews.llvm.org/D13866) and the
general opinion was that the original code have the right semantics and we
don't want to chan
tberghammer created this revision.
tberghammer added reviewers: labath, ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson.
Switch to gold linker on android x86, x86_64, arm
These architectures already using the gol
tberghammer added inline comments.
Comment at: cmake/platforms/Android.cmake:124
@@ -123,1 +123,3 @@
+# Use gold linker and enable safe ICF in case of x86, x86_64 and arm
+if ( ANDROID_ABI STREQUAL "x86"OR
ovyalov wrote:
> Just out of curiosity - you haven't
Author: tberghammer
Date: Thu Dec 10 05:02:51 2015
New Revision: 255240
URL: http://llvm.org/viewvc/llvm-project?rev=255240&view=rev
Log:
Switch to gold linker on android x86, x86_64, arm
These architectures already using the gold linker for the android
framework and switching to gold gives us th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255240: Switch to gold linker on android x86, x86_64, arm
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15379?vs=42295&id=42407#toc
Repository:
rL LLVM
http://reviews.
Hi Aidan,
Next time please add a commit message describing the change itself (next to
the review link). In general I think copying the review title and the
summary into the commit message is a good baseline. It will help us
understand your change when somebody looking at git logs as we don't have
tberghammer created this revision.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Add modules downloaded by ModuleCache to the global ModuleList
Adding the modules to the global module list eliminate issues in
Author: tberghammer
Date: Thu Dec 10 11:08:23 2015
New Revision: 255260
URL: http://llvm.org/viewvc/llvm-project?rev=255260&view=rev
Log:
Add modules downloaded by ModuleCache to the global ModuleList
Adding the modules to the global module list eleminate issues in the
case when a module is unloa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255260: Add modules downloaded by ModuleCache to the global
ModuleList (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D15415?vs=42422&id=42433#toc
Repository:
rL LLVM
ht
tberghammer added a comment.
The high level architecture looks reasonable but there are a few think I would
like you to clean up a bit:
- Several of your function uses a raw "new ...()" and then returns a pointer.
Please put the data into a smart pointer (usually std::unique_ptr) and return
th
Author: tberghammer
Date: Fri Dec 11 10:24:14 2015
New Revision: 255342
URL: http://llvm.org/viewvc/llvm-project?rev=255342&view=rev
Log:
Create test for llvm.org/pr25806
LLDB don't detect the loading of a shared object file linked against the
main executable before the static initializers are ex
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: packages/Python/lldbsuite/test/lldbtest.py:512
@@ -510,3 +511,3 @@
def add_test_categories(cat):
-"""Decorate an item with test categories"""
+
tberghammer accepted this revision.
tberghammer added a comment.
LGTM
http://reviews.llvm.org/D19927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: tberghammer
Date: Thu May 5 06:18:21 2016
New Revision: 268622
URL: http://llvm.org/viewvc/llvm-project?rev=268622&view=rev
Log:
Add support for displaying Java array types on Andorid
Differential revision: http://reviews.llvm.org/D19540
Modified:
lldb/trunk/include/lldb/Symbol/Java
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268622: Add support for displaying Java array types on
Andorid (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D19540?vs=55031&id=56263#toc
Repository:
rL LLVM
http://rev
Author: tberghammer
Date: Thu May 5 07:46:45 2016
New Revision: 268626
URL: http://llvm.org/viewvc/llvm-project?rev=268626&view=rev
Log:
Guard AddCXXSynthetic with LLDB_DISABLE_PYTHON
The function only avaibleble when python is enabled. Guard the new call
in the Java plugin with LLDB_DISABLE_PYT
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Very nice!
I don't know how we missed this optimization before. Finally the size of
lldb-server starts to became more reasonable (3.7 MB on arm32)
http://reviews.llvm.org/D20236
Author: tberghammer
Date: Tue May 17 07:42:25 2016
New Revision: 269759
URL: http://llvm.org/viewvc/llvm-project?rev=269759&view=rev
Log:
xfail TestTopLevelExprs for Android API 21-22 (llvm.org/pr27787)
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/top-level/TestTopL
Author: tberghammer
Date: Thu May 19 05:53:10 2016
New Revision: 270040
URL: http://llvm.org/viewvc/llvm-project?rev=270040&view=rev
Log:
Fix build after rL270009
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL:
http://llvm.o
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with 1 minor comment inline. Feel free to ignore/postpone it if you
want
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.cpp:2072-2073
@@ -21
Author: tberghammer
Date: Fri May 20 05:58:55 2016
New Revision: 270201
URL: http://llvm.org/viewvc/llvm-project?rev=270201&view=rev
Log:
Work around android-arm NDK bug exposed by rL269992
In the android-arm ndk there is a duplicated typedef in link.h
and in unwind.h causing build erros. This CL
tberghammer abandoned this revision.
tberghammer added a comment.
Abandoning. as http://reviews.llvm.org/rL270062 fixed the same issue before I
managed to add a test for this CL.
http://reviews.llvm.org/D19535
___
lldb-commits mailing list
lldb-com
Author: tberghammer
Date: Fri May 20 08:07:16 2016
New Revision: 270214
URL: http://llvm.org/viewvc/llvm-project?rev=270214&view=rev
Log:
Revert rL270207: "[LLDB][MIPS] Fix floating point handling in case of thread
step-out"
The CL causes a build breakage on platforms where sizeof(double) == siz
I had to revert this CL with rL270214 as it causes a build breakage (see
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-buildserver/builds/7282)
and makes a false assumption regarding host-target compatibility. Please
see my commit message in http://reviews.llvm.org/rL270214 for more de
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D20623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
looks good
Comment at: cmake/modules/LLDBConfig.cmake:432
@@ +431,3 @@
+message(WARNING
+"You appear to be using linking to libstdc++ version les
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good, thanks for fixing it (I seen strange issues caused by this so it
will help a lot).
http://reviews.llvm.org/D20875
___
lldb
Author: tberghammer
Date: Wed Jun 1 19:45:38 2016
New Revision: 271453
URL: http://llvm.org/viewvc/llvm-project?rev=271453&view=rev
Log:
Fix JavaArraySyntheticFrontEnd for non-reference ValueObject.
Summary: Fix missing return after checking that m_backend is not a pointer or
reference type.
R
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271453: Fix JavaArraySyntheticFrontEnd for non-reference
ValueObject. (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D20875?vs=59265&id=59321#toc
Repository:
rL LLVM
htt
Author: tberghammer
Date: Thu Jun 2 20:03:04 2016
New Revision: 271618
URL: http://llvm.org/viewvc/llvm-project?rev=271618&view=rev
Log:
Fix makefile for TestExternCSymbols
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/extern_c/Makefile
Modified: lldb/trunk/packages/Python/ll
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D21324
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Can you upload the patch to http://reviews.llvm.org/differential/ (we do
all of the code review there)?
On Fri, Jun 10, 2016 at 6:08 PM John Lindal via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> I never heard back on this. Should I file a ticket?
>
> Thanks,
> John
>
> On Thu, Apr 7, 2
tberghammer accepted this revision.
tberghammer added a reviewer: tberghammer.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good
http://reviews.llvm.org/D21516
___
lldb-commits mailing list
lldb-commits@lists.l
tberghammer created this revision.
tberghammer added reviewers: clayborg, granata.enrico, ovyalov.
tberghammer added a subscriber: lldb-commits.
Herald added subscribers: danalbert, tberghammer.
Fix the libc++ pretty printers for the android NDK
The libc++ shipped with the android NDK is shipped
Author: tberghammer
Date: Mon Jul 4 04:11:08 2016
New Revision: 274488
URL: http://llvm.org/viewvc/llvm-project?rev=274488&view=rev
Log:
Fix ClangASTContext after some clang API changes
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext
Author: tberghammer
Date: Mon Jul 4 04:13:10 2016
New Revision: 274489
URL: http://llvm.org/viewvc/llvm-project?rev=274489&view=rev
Log:
Fix the libc++ pretty printers for the android NDK
The libc++ shipped with the android NDK is shipped using a different
internal namespace then the upstream li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274489: Fix the libc++ pretty printers for the android NDK
(authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D21680?vs=61770&id=62655#toc
Repository:
rL LLVM
http://reviews
Author: tberghammer
Date: Mon Jul 4 08:31:57 2016
New Revision: 274500
URL: http://llvm.org/viewvc/llvm-project?rev=274500&view=rev
Log:
Ignore oatdata and oatexec symbols more widely
These are artifical symbols inside android oat files without any value
for the user while causing a significant
201 - 300 of 725 matches
Mail list logo
