tberghammer added a comment.

I can't move the functionality into Platform::ConnectRemote because to connect 
to a process we need a debugger instance while Platform::ConnectRemote is 
called in scenarios where we don't have access to it (from 
SBPlatform::ConnectRemote). To clean up the API I added a new method to the 
Platform class called ConnectToWaitingProcesses what is connecting to all 
process waiting for a new debugger connection. In case of remote debugging it 
can be based on the gdb protocol (what I implemented with this CL) but if 
somebody want to support an embedded system with 1 process for each core then 
ConnectToWaitingProcesses can create a process for each core instead of 
connecting over the gdb protocol and everything should just work.


================
Comment at: 
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp:184
@@ +183,3 @@
+    std::string hostname;
+    // TODO: /tmp/ should not be hardcoded. User might want to override /tmp
+    // with the TMPDIR environment variable
----------------
labath wrote:
> The TMPDIR and "sleep" comments seem to be obsolete...
Done


http://reviews.llvm.org/D14952



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to