Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

2018-10-12 Thread Stella Stamenova via lldb-commits
Those changes look reasonable, but I don't know how to test it either. I would be in favor of checking it in because the buildbots are currently broken and this can't make it worse, right? -Original Message- From: v...@apple.com Sent: Thursday, October 11, 2018 3:56 PM To: Stella Stame

[Lldb-commits] [lldb] r344386 - [lldbsuite] Fix the filecheck functionality to work with Python 3

2018-10-12 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Oct 12 10:56:01 2018 New Revision: 344386 URL: http://llvm.org/viewvc/llvm-project?rev=344386&view=rev Log: [lldbsuite] Fix the filecheck functionality to work with Python 3 Summary: This is another string/byte conversion issue between Python 2 and 3. In Python

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

2018-10-12 Thread Stella Stamenova via lldb-commits
Thanks, I’ve been monitoring the bots also and it looks like they haven’t picked up the zorg change yet. I don’t know if that’s supposed to just happen or if there’s something that needs to be done or if there’s a schedule for when they update. Thanks, -Stella From: v...@apple.com Sent: Frida

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

2018-10-12 Thread Stella Stamenova via lldb-commits
+ Galina, Galina, is there anything we need to do for the buildbots to pick up the change that Vedant made? Thanks, -Stella From: v...@apple.com Sent: Friday, October 12, 2018 12:34 PM To: Stella Stamenova Cc: Zachary Turner ; lldb-commits@lists.llvm.org; reviews+d53175+public+09519a8f992e0.

[Lldb-commits] [lldb] r344410 - Fix failure in get_filecheck_path when filecheck is None

2018-10-12 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Oct 12 13:00:20 2018 New Revision: 344410 URL: http://llvm.org/viewvc/llvm-project?rev=344410&view=rev Log: Fix failure in get_filecheck_path when filecheck is None If the path was not specified (and it's None), lexists throws an exception rather than returning

Re: [Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

2018-10-12 Thread Stella Stamenova via lldb-commits
Progress! The tests are running again and only a handful fail (some because of FileCheck, others for various other reasons). http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/29816 It looks like there a number of tests that have failures unrelated to FileCheck, so anyone w

[Lldb-commits] [lldb] r344543 - [lldbsuite] Disable Test128BitsInteger on Windows

2018-10-15 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Mon Oct 15 11:51:28 2018 New Revision: 344543 URL: http://llvm.org/viewvc/llvm-project?rev=344543&view=rev Log: [lldbsuite] Disable Test128BitsInteger on Windows Summary: This test is failing on Windows because lldb does not support JIT on Windows. Reviewers: davi

[Lldb-commits] [lldb] r344547 - [lldbsuite] Make the names of test classes unique

2018-10-15 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Mon Oct 15 12:51:21 2018 New Revision: 344547 URL: http://llvm.org/viewvc/llvm-project?rev=344547&view=rev Log: [lldbsuite] Make the names of test classes unique Summary: If the names are not unique, the tests overwrite each other's results and logs. This also caus

[Lldb-commits] [lldb] r344623 - [lldbsuite] Fix the mac version decorator to work on non-mac platforms

2018-10-16 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Tue Oct 16 10:13:45 2018 New Revision: 344623 URL: http://llvm.org/viewvc/llvm-project?rev=344623&view=rev Log: [lldbsuite] Fix the mac version decorator to work on non-mac platforms Summary: On non-mac platforms, mac_ver returns an empty string which when converte

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

2018-10-16 Thread Stella Stamenova via lldb-commits
The windows error is because the names are different, as you expected: AssertionError: 'void sink(void)' != 'sink()' You can probably update the test to look for a different name on Windows (though if I recall correctly, different versions of the DIA sdk provide different detail on the names, s

[Lldb-commits] [lldb] r344744 - [lldbsuite] Mark the TestScriptedResolver tests as XFAIL on Windows

2018-10-18 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Oct 18 08:30:31 2018 New Revision: 344744 URL: http://llvm.org/viewvc/llvm-project?rev=344744&view=rev Log: [lldbsuite] Mark the TestScriptedResolver tests as XFAIL on Windows Summary: They fail similarly to some of the other breakpoint tests on Windows, so I s

Re: [Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

2018-10-18 Thread Stella Stamenova via lldb-commits
Hey Vedant, I’ve attached the logs from Linux. Most of the tests now pass on Windows with the exception of TestSteppingOutWithArtificialFrames and TestTailCallFrameSBAPI. Both of these attempt to get a specific frame by calling GetFrameAtIndex which only works partially on Windows right now. I

[Lldb-commits] [lldb] r344788 - [lldbsuite, windows] Disable two tail call frames tests that fail on Windows

2018-10-19 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Oct 19 09:00:58 2018 New Revision: 344788 URL: http://llvm.org/viewvc/llvm-project?rev=344788&view=rev Log: [lldbsuite, windows] Disable two tail call frames tests that fail on Windows Summary: These tests fail on Windows because of known limitations (a.k.a. bug

Re: [Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

2018-11-13 Thread Stella Stamenova via lldb-commits
I took a brief look and I have a question about the usage of clang (rather than clang-cl). In general I would agree that we have an exact path of clang (or gcc) that we are trying to use and they’re specified by using %cc and %cxx in the test files, but there are a number of test files that sim

Re: [Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

2018-11-13 Thread Stella Stamenova via lldb-commits
I am not sure if that’s the right solution for a couple of reasons: 1. As far as I can tell only clang calls use_clang (and only lld calls use_lld), while the other projects such as lld and llvm rely on the environment to be setup correctly 2. Lld also has tests that invoke clang-cl and th

Re: [Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

2018-11-13 Thread Stella Stamenova via lldb-commits
Actually, I take 2) back. Lld doesn’t call use_clang, but it only references clang-cl, it doesn’t expect it to execute. From: Stella Stamenova Sent: Tuesday, November 13, 2018 3:47 PM To: 'Zachary Turner' Cc: reviews+d54009+public+0e164460da8f1...@reviews.llvm.org; pa...@labath.sk; chris.biene.

Re: [Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

2018-11-13 Thread Stella Stamenova via lldb-commits
The plan for the lit tests sounds reasonable to me. I would also remove LLDB_TEST_C/CXX_COMPILER entirely so that we can reduce confusion since they’re only used for the lit tests, right? My only concern is that I’ve been told that there are people who will build lldb with a different compiler

Re: [Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

2018-11-14 Thread Stella Stamenova via lldb-commits
Simplifying (and making things more robust in the process) sounds great to me. I think the current iteration of how parameters are passed to the tests is quite complicated and unclear, so this will be a step in the right direction and if there’s a need for gcc later, we can take the time to desi

[Lldb-commits] [lldb] r347243 - [lldbsuite] Invoke sed on Windows to determine the cache dir for clang

2018-11-19 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Mon Nov 19 10:41:33 2018 New Revision: 347243 URL: http://llvm.org/viewvc/llvm-project?rev=347243&view=rev Log: [lldbsuite] Invoke sed on Windows to determine the cache dir for clang Summary: In order to invoke sed on Windows, we need to quote the command correctly

[Lldb-commits] [lldb] r347321 - [lit] Disable the stop hook tests on Windows

2018-11-20 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Tue Nov 20 08:24:03 2018 New Revision: 347321 URL: http://llvm.org/viewvc/llvm-project?rev=347321&view=rev Log: [lit] Disable the stop hook tests on Windows These tests are not able to pass on Windows as written as they don't even build Modified: lldb/trunk/lit/

[Lldb-commits] [lldb] r347323 - [lit] Build and link TestIRMemoryMapWindows explicitly

2018-11-20 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Tue Nov 20 08:44:06 2018 New Revision: 347323 URL: http://llvm.org/viewvc/llvm-project?rev=347323&view=rev Log: [lit] Build and link TestIRMemoryMapWindows explicitly If we just invoke clang-cl without specifying the linker, the tests fail on Windows because they c

[Lldb-commits] [lldb] r347412 - [lit] Add pthread to the compilation of the tests on Linux

2018-11-21 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Nov 21 12:16:06 2018 New Revision: 347412 URL: http://llvm.org/viewvc/llvm-project?rev=347412&view=rev Log: [lit] Add pthread to the compilation of the tests on Linux Summary: Right now only some platforms add pthread to the compilation, however, at least one o

[Lldb-commits] [lldb] r347717 - [lldbsuite] Each lldb suite test must have a unique class name

2018-11-27 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Tue Nov 27 14:18:02 2018 New Revision: 347717 URL: http://llvm.org/viewvc/llvm-project?rev=347717&view=rev Log: [lldbsuite] Each lldb suite test must have a unique class name A couple of new tests have been added that use existing class names. This causes failures

[Lldb-commits] [lldb] r347796 - [unittests] Fix the File System Test on Windows

2018-11-28 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Nov 28 11:34:01 2018 New Revision: 347796 URL: http://llvm.org/viewvc/llvm-project?rev=347796&view=rev Log: [unittests] Fix the File System Test on Windows Two of the file system tests are failing on Windows - this updates them to expect the correct values afte

[Lldb-commits] [lldb] r347924 - [lldbsuite] Build with -gdwarf on Windows

2018-11-29 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Nov 29 14:15:23 2018 New Revision: 347924 URL: http://llvm.org/viewvc/llvm-project?rev=347924&view=rev Log: [lldbsuite] Build with -gdwarf on Windows Earlier this month there was a change in clang that defaulted to using codeview rather than dwarf on Windows. S

[Lldb-commits] [lldb] r348009 - Revert "[PDB] Support PDB-backed expressions evaluation"

2018-11-30 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Nov 30 09:29:54 2018 New Revision: 348009 URL: http://llvm.org/viewvc/llvm-project?rev=348009&view=rev Log: Revert "[PDB] Support PDB-backed expressions evaluation" This reverts commit dec87759523b2f22fcff3325bc2cd543e4cda0e7. This commit caused the tests on Wi

Re: [Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

2018-11-30 Thread Stella Stamenova via lldb-commits
I reverted it. Thanks. From: Aleksandr Urakov Sent: Friday, November 30, 2018 9:25 AM To: reviews+d53759+public+b214dcdd73261...@reviews.llvm.org Cc: Zachary Turner ; aaron.lee.smith ; Stella Stamenova ; llvm-comm...@lists.llvm.org; pa...@labath.sk; 15dacaoy...@gmail.com; apra...@apple.com; jd

[Lldb-commits] [lldb] r348055 - [windows] Fix two minor bugs on Windows

2018-11-30 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Nov 30 16:18:19 2018 New Revision: 348055 URL: http://llvm.org/viewvc/llvm-project?rev=348055&view=rev Log: [windows] Fix two minor bugs on Windows 1. In ProcessWindows if we fail to allocate memory, we need to return LLDB_INVALID_ADDRESS rather than 0 or nullp

Re: [Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

2018-12-03 Thread Stella Stamenova via lldb-commits
Are there no cases where you want all of the input files to be compiled into a single executable? From: Zachary Turner Sent: Monday, December 3, 2018 3:36 PM To: reviews+d55230+public+74273d963dffb...@reviews.llvm.org Cc: pa...@labath.sk; Stella Stamenova ; aleksandr.ura...@jetbrains.com; clayb

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

2018-12-05 Thread Stella Stamenova via lldb-commits
I think with all the tests running in parallel we should err on the side of having unique names for everything automatically generated. From: Aleksandr Urakov Sent: Wednesday, December 5, 2018 12:48 PM To: Zachary Turner Cc: reviews+d54942+public+2603ca548f36d...@reviews.llvm.org; Stella Stamen

[Lldb-commits] [lldb] r348435 - [lldbsuite] Disable TestStopPCs when there's no XML support

2018-12-05 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Dec 5 16:11:17 2018 New Revision: 348435 URL: http://llvm.org/viewvc/llvm-project?rev=348435&view=rev Log: [lldbsuite] Disable TestStopPCs when there's no XML support The test relies on xml support to setup the correct registers. If there's no XML support, the

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

2018-12-06 Thread Stella Stamenova via lldb-commits
I am in favor of unique filenames because it will guarantee we avoid any problems like this in the future, but in most cases, as long as the names are unique *in the test suite*, that should be sufficient. So I don’t have any objections to Zachary’s approach of making the filenames unique enough

[Lldb-commits] [lldb] r348542 - [pecoff] Use PATH_MAX instead of MAX_PATH

2018-12-06 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Dec 6 15:22:46 2018 New Revision: 348542 URL: http://llvm.org/viewvc/llvm-project?rev=348542&view=rev Log: [pecoff] Use PATH_MAX instead of MAX_PATH PATH_MAX is defined on all platforms while MAX_PATH is Windows-specific Modified: lldb/trunk/source/Plugins

[Lldb-commits] [lldb] r348544 - [lit] Use the build.py script in the case-insensitive test

2018-12-06 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Dec 6 15:25:37 2018 New Revision: 348544 URL: http://llvm.org/viewvc/llvm-project?rev=348544&view=rev Log: [lit] Use the build.py script in the case-insensitive test This makes the test build correctly regardless of whether we use VS or ninja to run the tests

[Lldb-commits] [lldb] r348664 - [lit] Fix case-insensitive test

2018-12-07 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Dec 7 15:30:38 2018 New Revision: 348664 URL: http://llvm.org/viewvc/llvm-project?rev=348664&view=rev Log: [lit] Fix case-insensitive test The test still only passes when not run from VS because the previous patch did not remove the original build commands

[Lldb-commits] [lldb] r348775 - Do not use PATH_MAX with SmallString

2018-12-10 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Mon Dec 10 09:23:28 2018 New Revision: 348775 URL: http://llvm.org/viewvc/llvm-project?rev=348775&view=rev Log: Do not use PATH_MAX with SmallString Summary: Instead use a more reasonable value to start and rely on the fact that SmallString will resize if necessary

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

2018-12-14 Thread Stella Stamenova via lldb-commits
It’s actually not green – the unexpected passes are counted as a failure. With Pavel’s change to add the gcc builder, most of those can now be enabled, so I am going to do that today, but there’s still a couple that are “unexpectedly passing” when they are in fact failing. We’ll need to fix that

Re: [Lldb-commits] [PATCH] D55575: [NativePDB] Support local variables

2018-12-14 Thread Stella Stamenova via lldb-commits
An unexpected pass makes the bot red. I might un-silence it despite the couple of issues left anyway, but it’s something to be aware of. Thanks, -Stella From: Zachary Turner Sent: Friday, December 14, 2018 11:04 AM To: Stella Stamenova Cc: reviews+d55575+public+5ea6161324294...@reviews.llvm.or

Re: [Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-14 Thread Stella Stamenova via lldb-commits
The verbose output is below. If I run the two commands on the command line, they both succeed, but when I run them through build.py, the link command is failing. I suspect that the process that gets created through python doesn't inherit the environment with the PATH set, so it can't find the li

Re: [Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

2018-12-14 Thread Stella Stamenova via lldb-commits
Ah, yes, it does. It looks like it does contain /usr/bin. Script Arguments: Arch: 64 Compiler: any Outdir: /vstsdrive/_work/42/b/LLVMBuild/tools/lldb/lit/tools/lldb-mi/exec/Output Output: /vstsdrive/_work/42/b/LLVMBuild/tools/lldb/lit/tools/lldb-mi/exec/Output/exec-next-instruction.test.

[Lldb-commits] [lldb] r349562 - [lit] Use the new build.py script in the lldb-mi tests

2018-12-18 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Tue Dec 18 14:54:17 2018 New Revision: 349562 URL: http://llvm.org/viewvc/llvm-project?rev=349562&view=rev Log: [lit] Use the new build.py script in the lldb-mi tests This allows the tests to pass on Windows as well Modified: lldb/trunk/lit/Driver/Inputs/hello.

[Lldb-commits] [lldb] r349573 - [lit] Rather than including stdio.h, forward-declare printf in TestConvenienceVariables.test

2018-12-18 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Tue Dec 18 15:36:35 2018 New Revision: 349573 URL: http://llvm.org/viewvc/llvm-project?rev=349573&view=rev Log: [lit] Rather than including stdio.h, forward-declare printf in TestConvenienceVariables.test Modified: lldb/trunk/lit/Driver/Inputs/hello.c Modified

[Lldb-commits] [lldb] r349665 - [lldbsuite] Un-xfail tests on Windows that are now passing

2018-12-19 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Dec 19 11:04:01 2018 New Revision: 349665 URL: http://llvm.org/viewvc/llvm-project?rev=349665&view=rev Log: [lldbsuite] Un-xfail tests on Windows that are now passing This is a set of tests that were all marked as failing becuse of pr24489. The bug is not fixed

[Lldb-commits] [lldb] r349668 - [lldbsuite] Un-xfail tests on Windows that are now passing (pt.2)

2018-12-19 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Dec 19 11:10:25 2018 New Revision: 349668 URL: http://llvm.org/viewvc/llvm-project?rev=349668&view=rev Log: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.2) This is a set of tests that were all marked as failing becuse of pr21765. The bug is no

[Lldb-commits] [lldb] r349711 - [lldbsuite] Un-xfail tests on Windows that are now passing (pt.3)

2018-12-19 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Dec 19 16:58:48 2018 New Revision: 349711 URL: http://llvm.org/viewvc/llvm-project?rev=349711&view=rev Log: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.3) This is a set of tests that were all marked as failing becuse of several different bugs

[Lldb-commits] [lldb] r349713 - [lldbsuite] Un-xfail tests on Windows that are now passing (pt.4)

2018-12-19 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Dec 19 17:25:35 2018 New Revision: 349713 URL: http://llvm.org/viewvc/llvm-project?rev=349713&view=rev Log: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.4) This is a set of tests that were all marked as failing becuse of several different bugs

[Lldb-commits] [lldb] r349719 - [lldbsuite] Un-xfail tests on Windows that are now passing (pt.5)

2018-12-19 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Dec 19 18:04:01 2018 New Revision: 349719 URL: http://llvm.org/viewvc/llvm-project?rev=349719&view=rev Log: [lldbsuite] Un-xfail tests on Windows that are now passing (pt.5) This is a set of tests that were all marked as failing becuse of pr24764. The bug is no

[Lldb-commits] [lldb] r349721 - [lldbsuite] Un-xfail TestDataFormatterSynthVal on Windows

2018-12-19 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Dec 19 18:22:09 2018 New Revision: 349721 URL: http://llvm.org/viewvc/llvm-project?rev=349721&view=rev Log: [lldbsuite] Un-xfail TestDataFormatterSynthVal on Windows Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-for

[Lldb-commits] [lldb] r349722 - [lldbsuite] Un-xfail TestRedefinitionsInInlines on Windows

2018-12-19 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Dec 19 19:04:14 2018 New Revision: 349722 URL: http://llvm.org/viewvc/llvm-project?rev=349722&view=rev Log: [lldbsuite] Un-xfail TestRedefinitionsInInlines on Windows Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/inlines/TestRedefinitionsInInli

[Lldb-commits] [lldb] r349775 - [lldbsuite] Skip TestConflictingSymbol (test_shadowed) on Windows

2018-12-20 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Dec 20 09:19:56 2018 New Revision: 349775 URL: http://llvm.org/viewvc/llvm-project?rev=349775&view=rev Log: [lldbsuite] Skip TestConflictingSymbol (test_shadowed) on Windows The test is "passing" on windows, but it is a false positive. Skip it on Windows until

[Lldb-commits] [lldb] r349781 - [lldbsuite] Un-xfail TestEvents on Windows

2018-12-20 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Dec 20 10:00:20 2018 New Revision: 349781 URL: http://llvm.org/viewvc/llvm-project?rev=349781&view=rev Log: [lldbsuite] Un-xfail TestEvents on Windows There are a couple of tests in TestEvents that are now passing. Modified: lldb/trunk/packages/Python/lldbs

[Lldb-commits] [lldb] r349783 - [lldbsuite] Un-xfail TestMiniDump and TestThreadJump

2018-12-20 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Dec 20 10:21:17 2018 New Revision: 349783 URL: http://llvm.org/viewvc/llvm-project?rev=349783&view=rev Log: [lldbsuite] Un-xfail TestMiniDump and TestThreadJump Both of these are now passing. I've resolved the bugs as well for verification. Modified: lldb/

[Lldb-commits] [lldb] r349784 - [lit] Skip stop-hook test on Windows

2018-12-20 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Dec 20 10:23:08 2018 New Revision: 349784 URL: http://llvm.org/viewvc/llvm-project?rev=349784&view=rev Log: [lit] Skip stop-hook test on Windows This test is now marked as unsupported on Windows - it is not technically "unsupported" on Windows, but it fails be

[Lldb-commits] [lldb] r349813 - [lldbsuite] Un-xfail several tests in TestInferiorCrashing on Windows

2018-12-20 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Dec 20 12:26:05 2018 New Revision: 349813 URL: http://llvm.org/viewvc/llvm-project?rev=349813&view=rev Log: [lldbsuite] Un-xfail several tests in TestInferiorCrashing on Windows Several of the tests are now passing. This change is enabling them. Modified:

[Lldb-commits] [lldb] r349946 - [lldbsuite] Skip flakey Windows tests

2018-12-21 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Dec 21 12:10:45 2018 New Revision: 349946 URL: http://llvm.org/viewvc/llvm-project?rev=349946&view=rev Log: [lldbsuite] Skip flakey Windows tests Skip a number of tests on Windows that are flakey and will pass/fail unexpectedly every dozen or so runs. Modified

[Lldb-commits] [lldb] r349977 - [cmake] Suppress 'warning C4201: nonstandard extension used: nameless struct/union' on Windows

2018-12-21 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Dec 21 15:59:24 2018 New Revision: 349977 URL: http://llvm.org/viewvc/llvm-project?rev=349977&view=rev Log: [cmake] Suppress 'warning C4201: nonstandard extension used: nameless struct/union' on Windows This warning comes up in the ObjC language plugin because

[Lldb-commits] [lldb] r331914 - [cmake, unittests] Fix the CMake file for the LLDB unittests to support multiple configurations

2018-05-09 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed May 9 12:58:51 2018 New Revision: 331914 URL: http://llvm.org/viewvc/llvm-project?rev=331914&view=rev Log: [cmake, unittests] Fix the CMake file for the LLDB unittests to support multiple configurations Summary: The current setup for the unit tests only works

[Lldb-commits] [lldb] r332293 - [lit] Fix several tests that fail when using Python 3 or on Windows

2018-05-14 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Mon May 14 14:04:24 2018 New Revision: 332293 URL: http://llvm.org/viewvc/llvm-project?rev=332293&view=rev Log: [lit] Fix several tests that fail when using Python 3 or on Windows Summary: 1) In logtest.cpp, the name of the file that is reported is not always capit

[Lldb-commits] [lldb] r332629 - [lit, lldbsuite] Disable tests that are failing because of pr21765 and pr24489

2018-05-17 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu May 17 09:58:00 2018 New Revision: 332629 URL: http://llvm.org/viewvc/llvm-project?rev=332629&view=rev Log: [lit, lldbsuite] Disable tests that are failing because of pr21765 and pr24489 Summary: These three tests are failing on Windows and looking into the fai

[Lldb-commits] [lldb] r332670 - [Windows, Process] Fix an issue in windows thread handling that was causing LLDB to hang

2018-05-17 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu May 17 14:34:24 2018 New Revision: 332670 URL: http://llvm.org/viewvc/llvm-project?rev=332670&view=rev Log: [Windows, Process] Fix an issue in windows thread handling that was causing LLDB to hang Summary: The function ResumeThread on Windows returns a DWORD wh

[Lldb-commits] [lldb] r332671 - [Windows, Process] LLDB reads wrong registers on 64bit Windows

2018-05-17 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu May 17 14:42:37 2018 New Revision: 332671 URL: http://llvm.org/viewvc/llvm-project?rev=332671&view=rev Log: [Windows, Process] LLDB reads wrong registers on 64bit Windows Summary: LLDB reads wrong registers on 64bit Windows because RegisterContextWindows_x64::G

[Lldb-commits] [lldb] r333781 - [lldb, process] Fix occasional hang when launching a process in LLDB

2018-06-01 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Jun 1 12:14:53 2018 New Revision: 333781 URL: http://llvm.org/viewvc/llvm-project?rev=333781&view=rev Log: [lldb, process] Fix occasional hang when launching a process in LLDB Summary: Occasionally, when launching a process in lldb (especially on windows, but n

[Lldb-commits] [lldb] r333789 - [lit, lldbmi] Skip the new break-insert test on Windows

2018-06-01 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Jun 1 14:29:43 2018 New Revision: 333789 URL: http://llvm.org/viewvc/llvm-project?rev=333789&view=rev Log: [lit, lldbmi] Skip the new break-insert test on Windows Summary: Skip the new break-insert test on Windows because it hangs and so the test suite never c

[Lldb-commits] [lldb] r333790 - [lit, pdb] Fix two failing PDB tests on Windows

2018-06-01 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Jun 1 14:33:27 2018 New Revision: 333790 URL: http://llvm.org/viewvc/llvm-project?rev=333790&view=rev Log: [lit, pdb] Fix two failing PDB tests on Windows Summary: One of the tests is failing to build because it needs GS-, the second test does not correctly ma

[Lldb-commits] [lldb] r334025 - [lit, pdb] Fix func-symbols.test (on Windows)

2018-06-05 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Tue Jun 5 09:20:36 2018 New Revision: 334025 URL: http://llvm.org/viewvc/llvm-project?rev=334025&view=rev Log: [lit, pdb] Fix func-symbols.test (on Windows) Summary: This test was failing sporadically on windows because the order in which the symbols are generated

[Lldb-commits] [lldb] r334210 - [lit, windows] Disable a number of tests that are failing on Windows

2018-06-07 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Jun 7 10:49:22 2018 New Revision: 334210 URL: http://llvm.org/viewvc/llvm-project?rev=334210&view=rev Log: [lit, windows] Disable a number of tests that are failing on Windows Summary: They all correspond to bugs that are already logged and I've added the appr

[Lldb-commits] [lldb] r334642 - [lit] Split test_set_working_dir TestProcessLaunch into two tests and fix it on Windows

2018-06-13 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Jun 13 12:02:44 2018 New Revision: 334642 URL: http://llvm.org/viewvc/llvm-project?rev=334642&view=rev Log: [lit] Split test_set_working_dir TestProcessLaunch into two tests and fix it on Windows Summary: test_set_working_dir was testing two scenario: failure t

Re: [Lldb-commits] [lldb] r334642 - [lit] Split test_set_working_dir TestProcessLaunch into two tests and fix it on Windows

2018-06-19 Thread Stella Stamenova via lldb-commits
45470302&sdata=HcSScsDUTELddsNkvDA4cdAqimL1gn9D3KmH9B6mAng%3D&reserved=0 It is a separate GDB remote server that was not built using any LLDB sources. It would be interesting to possibly port the windows changes over into LLDB's lldb-server. Let me know what you think, Greg Clayton > On Jun 13, 2018, at 12:02

[Lldb-commits] [lldb] r335906 - [lldbsuite] Fix TestBreakpointHitCount on Windows

2018-06-28 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Jun 28 12:42:30 2018 New Revision: 335906 URL: http://llvm.org/viewvc/llvm-project?rev=335906&view=rev Log: [lldbsuite] Fix TestBreakpointHitCount on Windows Summary: On Windows, the newer DIA SDKs end up producing function names that contain the return type as

[Lldb-commits] [lldb] r336147 - [lldbsuite, windows] Don't crash LLDB when we try to retrieve a register on Windows

2018-07-02 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Mon Jul 2 14:50:31 2018 New Revision: 336147 URL: http://llvm.org/viewvc/llvm-project?rev=336147&view=rev Log: [lldbsuite, windows] Don't crash LLDB when we try to retrieve a register on Windows Summary: 1) When ReadRegister is called with a null register into on

[Lldb-commits] [lldb] r336564 - Retrieve a function PDB symbol correctly from nested blocks

2018-07-09 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Mon Jul 9 10:36:33 2018 New Revision: 336564 URL: http://llvm.org/viewvc/llvm-project?rev=336564&view=rev Log: Retrieve a function PDB symbol correctly from nested blocks Summary: This patch fixes a problem with retrieving a function symbol by an address in a nest

[Lldb-commits] [lldb] r336732 - [windows] LLDB shows the wrong values when register read is executed at a frame other than zero

2018-07-10 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Tue Jul 10 15:05:33 2018 New Revision: 336732 URL: http://llvm.org/viewvc/llvm-project?rev=336732&view=rev Log: [windows] LLDB shows the wrong values when register read is executed at a frame other than zero Summary: This is a clean version of the change suggested

[Lldb-commits] [lldb] r336865 - [windows] Fix out-of-memory failure in some of the tests

2018-07-11 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Jul 11 15:47:35 2018 New Revision: 336865 URL: http://llvm.org/viewvc/llvm-project?rev=336865&view=rev Log: [windows] Fix out-of-memory failure in some of the tests Summary: When ReadProcessMemory fails, bytes_read is sometimes set to a large garbage value. In

[Lldb-commits] [lldb] r336948 - [process] Update the documentation for ReadMemory and DoReadMemory to include the error parameter

2018-07-12 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Jul 12 14:27:56 2018 New Revision: 336948 URL: http://llvm.org/viewvc/llvm-project?rev=336948&view=rev Log: [process] Update the documentation for ReadMemory and DoReadMemory to include the error parameter Summary: The current documentation does not include the

[Lldb-commits] [lldb] r336960 - [lldbsuite] The test inside TestOverloadedFunctions.py has the wrong class name

2018-07-12 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Jul 12 16:02:33 2018 New Revision: 336960 URL: http://llvm.org/viewvc/llvm-project?rev=336960&view=rev Log: [lldbsuite] The test inside TestOverloadedFunctions.py has the wrong class name Summary: It looks like the test file was copied from TestCPPStaticMethods.

[Lldb-commits] [lldb] r337393 - [lit, lldbsuite] Remove tests that are duplicated between lit and lldb-suite

2018-07-18 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Jul 18 08:16:54 2018 New Revision: 337393 URL: http://llvm.org/viewvc/llvm-project?rev=337393&view=rev Log: [lit, lldbsuite] Remove tests that are duplicated between lit and lldb-suite Summary: Several tests exist in both lit and lldbsuite. This removes the lit

[Lldb-commits] [lldb] r337395 - [windows] Use a well-known path for ComSpec if we fail to retrieve it

2018-07-18 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Jul 18 08:21:54 2018 New Revision: 337395 URL: http://llvm.org/viewvc/llvm-project?rev=337395&view=rev Log: [windows] Use a well-known path for ComSpec if we fail to retrieve it Summary: Right now we always try to retrieve ComSpec and if we fail, we give up. Th

[Lldb-commits] [lldb] r337397 - Fix variables.test after D49018

2018-07-18 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Jul 18 08:50:24 2018 New Revision: 337397 URL: http://llvm.org/viewvc/llvm-project?rev=337397&view=rev Log: Fix variables.test after D49018 Summary: This one fixes variables.test after D49018. The test was broken because D49018 adds a location information to va

[Lldb-commits] [lldb] r338769 - [lldbsuite, windows] Mark tests as XFAIL on Windows or skip them

2018-08-02 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Thu Aug 2 14:26:19 2018 New Revision: 338769 URL: http://llvm.org/viewvc/llvm-project?rev=338769&view=rev Log: [lldbsuite, windows] Mark tests as XFAIL on Windows or skip them Summary: 1) Several tests that are flakey on windows fail the run even if they are marke

[Lldb-commits] [lldb] r339076 - [lit, python] Always add quotes around the python path in lit

2018-08-06 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Mon Aug 6 15:37:53 2018 New Revision: 339076 URL: http://llvm.org/viewvc/llvm-project?rev=339076&view=rev Log: [lit, python] Always add quotes around the python path in lit Summary: The issue with the python path is that the path to python on Windows can contain s

[Lldb-commits] [lldb] r339180 - [lit, python] Change the order of the quotes in the lit cfg file

2018-08-07 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Tue Aug 7 13:58:02 2018 New Revision: 339180 URL: http://llvm.org/viewvc/llvm-project?rev=339180&view=rev Log: [lit, python] Change the order of the quotes in the lit cfg file Double quotes are always correct in paths on windows while single quotes only work someti

[Lldb-commits] [lldb] r339457 - [tests, libstdcxx] Add missing test category on the TestDataFormatterStdUniquePtr tests

2018-08-10 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Aug 10 10:52:45 2018 New Revision: 339457 URL: http://llvm.org/viewvc/llvm-project?rev=339457&view=rev Log: [tests, libstdcxx] Add missing test category on the TestDataFormatterStdUniquePtr tests Each test needs to be marked with the add_test_categories decorat

[Lldb-commits] [lldb] r340658 - [vscode] Skip some of the vscode tests on Linux and fix one

2018-08-24 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Aug 24 14:42:53 2018 New Revision: 340658 URL: http://llvm.org/viewvc/llvm-project?rev=340658&view=rev Log: [vscode] Skip some of the vscode tests on Linux and fix one Summary: These are already skipped on Darwin because they cause build bot failures. Both on t

[Lldb-commits] [lldb] r331679 - Test Commit: fix a comment to be grammatically correct

2018-05-07 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Mon May 7 14:19:14 2018 New Revision: 331679 URL: http://llvm.org/viewvc/llvm-project?rev=331679&view=rev Log: Test Commit: fix a comment to be grammatically correct Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py Modified: lldb/trunk/packages/Py

[Lldb-commits] [lldb] r331686 - [lit, lldbsuite] Fixes for several tests LLDB tests for Python 3 or Windows

2018-05-07 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Mon May 7 14:57:00 2018 New Revision: 331686 URL: http://llvm.org/viewvc/llvm-project?rev=331686&view=rev Log: [lit, lldbsuite] Fixes for several tests LLDB tests for Python 3 or Windows Summary: In decorators.py, when opening streams, open them in text mode. In Py

[Lldb-commits] [lldb] r331886 - [lit, lldbsuite] Add a bug reference to the failing TestLinuxCore and fix an undefined property in dotest.py

2018-05-09 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed May 9 08:35:19 2018 New Revision: 331886 URL: http://llvm.org/viewvc/llvm-project?rev=331886&view=rev Log: [lit, lldbsuite] Add a bug reference to the failing TestLinuxCore and fix an undefined property in dotest.py Summary: 1) In TestLinuxCore rather than ski

[Lldb-commits] [lldb] r350978 - [lldbsuite] Skip TestExitDuringStep on Windows

2019-01-11 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Jan 11 15:08:35 2019 New Revision: 350978 URL: http://llvm.org/viewvc/llvm-project?rev=350978&view=rev Log: [lldbsuite] Skip TestExitDuringStep on Windows This test is flaky on Windows and will occasionally hang or fail. Modified: lldb/trunk/packages/Pytho

[Lldb-commits] [lldb] r351080 - [lldbsuite] Skip two more flaky tests on Windows

2019-01-14 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Mon Jan 14 09:55:17 2019 New Revision: 351080 URL: http://llvm.org/viewvc/llvm-project?rev=351080&view=rev Log: [lldbsuite] Skip two more flaky tests on Windows TestNamespaceLookup occasionally passes unexpectedly and TestExitDuringStep occasionally fails unexpecte

[Lldb-commits] [lldb] r354172 - [win] Resolve the module only if there isn't one already

2019-02-15 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Fri Feb 15 13:40:59 2019 New Revision: 354172 URL: http://llvm.org/viewvc/llvm-project?rev=354172&view=rev Log: [win] Resolve the module only if there isn't one already Summary: This commit modifies the OnLoadModule method to resolve the module unless we already hav

Re: [Lldb-commits] [lldb] r355406 - Revert "Fix embedded Python initialization according to changes in version 3.7"

2019-03-05 Thread Stella Stamenova via lldb-commits
The bot is running 3.6.6 and it does not have python 3.7 installed (it does have python 2.7 which is needed to run Buildbot). The change that was pushed, though, did not only impact python 3.7: m_was_already_initialized == PyGILState_UNLOCKED ? "un" : ""); m_gil_s

Re: [Lldb-commits] [lldb] r355406 - Revert "Fix embedded Python initialization according to changes in version 3.7"

2019-03-05 Thread Stella Stamenova via lldb-commits
I ran the tests without that line on a machine that is equivalent to the Buildbot and they ran correctly, but I just noticed that while the Buildbot has had several runs that did not time out since the revert, there was also one that did time out. I am going to let the current build on the Buil

[Lldb-commits] [lldb] r355443 - [lldbsuite, windows] Skip the TestEvents tests on Windows

2019-03-05 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Tue Mar 5 13:03:36 2019 New Revision: 355443 URL: http://llvm.org/viewvc/llvm-project?rev=355443&view=rev Log: [lldbsuite, windows] Skip the TestEvents tests on Windows These tests are flakey on Windows and recently they have started failing AND also hanging the w

[Lldb-commits] [lldb] r355448 - [lit, windows] Disable stop-hook-threads on Windows

2019-03-05 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Tue Mar 5 13:43:04 2019 New Revision: 355448 URL: http://llvm.org/viewvc/llvm-project?rev=355448&view=rev Log: [lit, windows] Disable stop-hook-threads on Windows This test is also no longer reliably failing or passing on Windows and it is hanging every few runs.

Re: [Lldb-commits] [lldb] r355406 - Revert "Fix embedded Python initialization according to changes in version 3.7"

2019-03-05 Thread Stella Stamenova via lldb-commits
It should be safe to checkin the change now. It looks like at some point during the last couple of days the timing of some of the threads tests on Windows changed so now instead of behaving and passing or failing nicely, they are getting struck and never completing. This does not happen on every

[Lldb-commits] [lldb] r356065 - [lldbsuite] Un-xfail TestPyObjSynthProvider on Windows

2019-03-13 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Mar 13 09:53:53 2019 New Revision: 356065 URL: http://llvm.org/viewvc/llvm-project?rev=356065&view=rev Log: [lldbsuite] Un-xfail TestPyObjSynthProvider on Windows One of Davide's changes yesterday fixed the behavior on Windows, so the test is now passing. Modi

[Lldb-commits] [lldb] r357641 - Un-xfail one of the TestMiniDumpUUID tests on Windows

2019-04-03 Thread Stella Stamenova via lldb-commits
Author: stella.stamenova Date: Wed Apr 3 14:57:41 2019 New Revision: 357641 URL: http://llvm.org/viewvc/llvm-project?rev=357641&view=rev Log: Un-xfail one of the TestMiniDumpUUID tests on Windows The test is passing on Windows and the windows bot is failing because of the unexpected pass Modif

[Lldb-commits] [lldb] f4abf28 - [lldb] Update the PDB tests to pass with the VS2019 toolset

2021-12-14 Thread Stella Stamenova via lldb-commits
Author: Stella Stamenova Date: 2021-12-14T13:06:07-08:00 New Revision: f4abf28c0a0ba2226379a1b1926a7c36d75265e9 URL: https://github.com/llvm/llvm-project/commit/f4abf28c0a0ba2226379a1b1926a7c36d75265e9 DIFF: https://github.com/llvm/llvm-project/commit/f4abf28c0a0ba2226379a1b1926a7c36d75265e9.di

[Lldb-commits] [lldb] 9b5cf72 - [lldb] Disable several lldb tests that are flaky on Windows

2022-01-10 Thread Stella Stamenova via lldb-commits
Author: Stella Stamenova Date: 2022-01-10T10:21:12-08:00 New Revision: 9b5cf7267beb1e9c6f16402795890f0d02eb5145 URL: https://github.com/llvm/llvm-project/commit/9b5cf7267beb1e9c6f16402795890f0d02eb5145 DIFF: https://github.com/llvm/llvm-project/commit/9b5cf7267beb1e9c6f16402795890f0d02eb5145.di

[Lldb-commits] [lldb] 10bc336 - Revert "[LLDB][NativePDB] Add support for inlined functions"

2022-01-12 Thread Stella Stamenova via lldb-commits
Author: Stella Stamenova Date: 2022-01-12T08:53:19-08:00 New Revision: 10bc3362a1a8a3df2660bf65db0ec1ccab646e1b URL: https://github.com/llvm/llvm-project/commit/10bc3362a1a8a3df2660bf65db0ec1ccab646e1b DIFF: https://github.com/llvm/llvm-project/commit/10bc3362a1a8a3df2660bf65db0ec1ccab646e1b.di

[Lldb-commits] [lldb] 8fec756 - [lldb] Disable one more watchpoint test on Windows

2022-01-12 Thread Stella Stamenova via lldb-commits
Author: Stella Stamenova Date: 2022-01-12T08:55:48-08:00 New Revision: 8fec756c0b54f8720b746b103ac277b5a153dff7 URL: https://github.com/llvm/llvm-project/commit/8fec756c0b54f8720b746b103ac277b5a153dff7 DIFF: https://github.com/llvm/llvm-project/commit/8fec756c0b54f8720b746b103ac277b5a153dff7.di

  1   2   >