Those changes look reasonable, but I don't know how to test it either. I would be in favor of checking it in because the buildbots are currently broken and this can't make it worse, right?
-----Original Message----- From: v...@apple.com <v...@apple.com> Sent: Thursday, October 11, 2018 3:56 PM To: Stella Stamenova <sti...@microsoft.com> Cc: Zachary Turner <ztur...@google.com>; lldb-commits@lists.llvm.org; reviews+d53175+public+09519a8f992e0...@reviews.llvm.org Subject: Re: [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error Does this look reasonable to you? I'm not sure how to test this. diff --git a/zorg/buildbot/builders/LLDBBuilder.py b/zorg/buildbot/builders/LLDBBuilder.py index 5a1b2e87..62152924 100644 --- a/zorg/buildbot/builders/LLDBBuilder.py +++ b/zorg/buildbot/builders/LLDBBuilder.py @@ -270,6 +270,7 @@ def getLLDBTestSteps(f, compilerPath = compiler for arch in test_archs: DOTEST_OPTS=''.join(['--executable ' + bindir + '/lldb ', + '--filecheck ' + bindir + '/FileCheck + ', '-A %s ' % arch, '-C %s ' % compilerPath, '-s lldb-test-traces-%s-%s ' % (compiler, arch), @@ -819,6 +820,7 @@ def getLLDBxcodebuildFactory(use_cc=None, workdir=lldb_srcdir)) DOTEST_OPTS = ' '.join(['--executable', '%(lldb_bindir)s/lldb', + '%(lldb_bindir)s/FileCheck', '--framework', '%(lldb_bindir)s/LLDB.framework', '-A', 'x86_64', '-C', 'clang', vedant > On Oct 11, 2018, at 3:46 PM, Stella Stamenova via Phabricator > <revi...@reviews.llvm.org> wrote: > > stella.stamenova added a comment. > > The failing bots are not windows bots but Linux bots. It looks like you only > updated the configurations for xcode. > > I think the file that needs to be updated is: > > zorg\buildbot\builders\LLDBBuilder.py > > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Frevie > ws.llvm.org%2FD53175&data=02%7C01%7CSTILIS%40microsoft.com%7Cb8693 > c9edfa5449d97db08d62fccaacd%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0 > %7C636748953431151967&sdata=rdn7nntFECouzbw%2FPoQISVCGGrjLCqAygk8q > l0St%2B5o%3D&reserved=0 > > > _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits