[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

stella.stamenova added a comment. Looks like this change broke the windows lldb build: https://lab.llvm.org/buildbot/#/builders/83/builds/29801 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143104/new/ https://reviews.llvm.org/D143104 ___

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

stella.stamenova added a comment. Looks like either this change or D125241 broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/29800. Since it's been broken for a few days, if you can't address the failure soon, I'll go ahead and re

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

stella.stamenova added a comment. In D145242#4173592 , @Michael137 wrote: > In D145242#4173577 , > @stella.stamenova wrote: > >> Looks like either this change or D125241 >> br

[Lldb-commits] [PATCH] D146058: [lldb][gnustep] Add basic test and infrastructure for GNUstep ObjC runtime

stella.stamenova added a comment. > Oh I still saw that one running a few days back! @stella.stamenova in the > review you mention a second windows lldb bot, is it x86 as well? I don't see > it in https://lab.llvm.org/buildbot/#/console The one I was referring to is https://lab.llvm.org/buildbo

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

stella.stamenova added a comment. This broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/10836 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107585/new/ https://reviews.llvm.org/D107585 ___

[Lldb-commits] [PATCH] D111659: [lldb] Skip several lldb tests that are flaky on Windows

stella.stamenova created this revision. stella.stamenova added a reviewer: labath. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These tests fail every 10 or so runs on Windows causing both local failures as well as buil

[Lldb-commits] [PATCH] D111659: [lldb] Skip several lldb tests that are flaky on Windows

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG58917054c298: [lldb] Skip several lldb tests that are flaky on Windows (authored by stella.stamenova). Repository: rG L

[Lldb-commits] [PATCH] D112988: [lldb] fix --source-quietly

stella.stamenova added a comment. It looks like some of the tests need to be updated after this change (at least on Windows, the Windows LLDB bot is broken now): https://lab.llvm.org/buildbot/#/builders/83/builds/11623/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

stella.stamenova added inline comments. Comment at: lldb/test/Shell/Settings/TestEchoCommands.test:4 # RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false' -s %S/Inputs/EchoCommandsTest.in | FileCheck %S/Inputs/EchoCommandsNone.out -# RUN: %lldb -x -b --so

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

stella.stamenova added a comment. The Windows buildbot is still broken after this change: https://lab.llvm.org/buildbot/#/builders/83/builds/11630 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/ https://reviews.llvm.org/D113047

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

stella.stamenova added a comment. Windows buildbot is broken: https://lab.llvm.org/buildbot/#/builders/83/builds/11865 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112973/new/ https://reviews.llvm.org/D112973

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:413 +static const char GetInterpreterInfoScript[] = R"( +import os Does `sys.executable` not work for some reason? C

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:432 + elif os.name == 'posix': + exename = "python" + str(sys.version_info[0]) + info['executable'] = os.path.join(sys.prefix, 'bin', exename)

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

stella.stamenova added a comment. Can you please disable the test on Windows or back your change out until there's a fix? There are already other failures that are getting missed because the bot is red. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

stella.stamenova added a comment. This broke the build on Windows. The buildbot was, sadly, already red because of another test failure: https://lab.llvm.org/buildbot/#/builders/83/builds/11931 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104886/

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

stella.stamenova added a comment. I think this broke the windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/12036 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113821/new/ https://reviews.llvm.org/D113821

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

stella.stamenova added a comment. This broke the windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/12270 I'd like to get it back to green, so please address this ASAP or I'll follow up with a reverting change later today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

stella.stamenova added a comment. @zequanwu : It looks like the bot is still broken: https://lab.llvm.org/buildbot/#/builders/83/builds/12413 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114467/new/ https://reviews.llvm.org/D114467 _

[Lldb-commits] [PATCH] D114907: [lldb] Skip two lldb tests on Windows because they are flaky

stella.stamenova created this revision. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These tests work fine with VS2017, but become more flaky with VS2019 and the buildbot is about to get upgraded. Repository: rG LLV

[Lldb-commits] [PATCH] D114907: [lldb] Skip two lldb tests on Windows because they are flaky

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc24860118a7e: [lldb] Skip two lldb tests on Windows because they are flaky (authored by stella.stamenova). Repository:

[Lldb-commits] [PATCH] D135413: [lldb][CPlusPlusLanguage] Respect the step-avoid-regex for functions with auto return types

stella.stamenova added a comment. Looks like this change broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/24631 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135413/new/ https://reviews.llvm.org/D135413 _

[Lldb-commits] [PATCH] D135998: Make sure Target::EvaluateExpression() passes up an error instead of silently dropping it.

stella.stamenova added a comment. Herald added subscribers: Michael137, JDevlieghere. I think this change broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/24905 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135998/new/

[Lldb-commits] [PATCH] D136761: [lldb][CPlusPlus] Implement CPlusPlusLanguage::GetFunctionDisplayName

stella.stamenova added a comment. Looks like in addition to the Linux failure, this also broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25424/steps/7/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136761/ne

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

stella.stamenova added a comment. The newly added test is failing on the windows buildbot: https://lab.llvm.org/buildbot/#/builders/83/builds/25446 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135622/new/ https://reviews.llvm.org/D135622 ___

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

stella.stamenova added a comment. This broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25854 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

stella.stamenova added a comment. In D133366#3923291 , @kastiglione wrote: > Ugh, the test that is failing uses windows paths but runs on both windows and > non-windows machines. I will revert this and the two fix commits. You should be able to test fo

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

stella.stamenova added a comment. Looks like this broke the windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/26042 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136650/new/ https://reviews.llvm.org/D136650

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

stella.stamenova added a comment. Looks like the windows lldb bot is still broken: https://lab.llvm.org/buildbot/#/builders/83/builds/26083 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136650/new/ https://reviews.llvm.org/D136650 ___

[Lldb-commits] [PATCH] D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs

stella.stamenova created this revision. stella.stamenova added a reviewer: JDevlieghere. Herald added a subscriber: mgorny. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This workaround was necessary before the major chan

[Lldb-commits] [PATCH] D104047: [lldb, win] Remove obsolete workaround for MSVC and python libs

This revision was automatically updated to reflect the committed changes. Closed by commit rGca10add5dbe4: [lldb, win] Remove obsolete workaround for MSVC and python libs (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D103575: Allow signposts to take advantage of deferred string substitution

stella.stamenova added a comment. The Windows buildbot does not like signposts: https://lab.llvm.org/buildbot/#/builders/83/builds/7271 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103575/new/ https://reviews.llvm.org/D103575 ___

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

stella.stamenova added a comment. @wallace : Your most recent change to comment out ProgressEventThreadFunction is causing warnings to be generated when building with clang. Please have a look: /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

stella.stamenova added a comment. In D101128#2831098 , @wallace wrote: > I'm reverting it asap Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 _

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

stella.stamenova added a comment. This broke the windows lldb bot and the follow up changes did not fix it: https://lab.llvm.org/buildbot/#/builders/83/builds/7748 Can you have a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104488/new/ htt

[Lldb-commits] [PATCH] D105160: Create synthetic symbol names on demand to improve memory consumption and startup times.

stella.stamenova added a comment. In D105160#2848805 , @clayborg wrote: > @stella.stamenova all test suite failures should be fixed now. This is a redo > on https://reviews.llvm.org/D104488 which was reverted in less that a day... @clayborg : Thanks! We

[Lldb-commits] [PATCH] D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0

stella.stamenova added a comment. I think this change broke the Windows LLDB bot. More specifically the TestStructTypes test: https://lab.llvm.org/buildbot/#/builders/83/builds/8528 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105471/new/ https:

[Lldb-commits] [PATCH] D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0

stella.stamenova added a comment. In D105471#2896533 , @stella.stamenova wrote: > I think this change broke the Windows LLDB bot. More specifically the > TestStructTypes test: > > https://lab.llvm.org/buildbot/#/builders/83/builds/8528 Looks like you f

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

stella.stamenova added a comment. In D100299#2917598 , @jankratochvil wrote: > In D100299#2917467 , @Eric wrote: > >> Is arm hardware necessary to test this, > > In this case it is not as it does not require link

[Lldb-commits] [PATCH] D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance

stella.stamenova added a comment. This change is causing failures on the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/9098 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107475/new/ https://reviews.llvm.org/D107475

[Lldb-commits] [PATCH] D74243: [lldb] Introduce "RegInfoBasedABI"

stella.stamenova added a comment. Either this change or D74475 broke the windows bot and I suspect it's not D74475 : http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13719 Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

stella.stamenova added a comment. Either this change or D74243 broke the windows bot and I do suspect D74243 but have not confirmed it yet: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13719 Repository: r

[Lldb-commits] [PATCH] D74475: [lldb] Replace assertTrue(a == b, "msg") with assertEquals(a, b, "msg") in the test suite

stella.stamenova added a comment. In D74475#1875674 , @JDevlieghere wrote: > Yup, looks like that was it, the bot is green again: > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13740 Thanks for taking care of it! Repository: rG L

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

stella.stamenova added a comment. It looks like this broke the windows lldb bot: lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13902 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ ll

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

stella.stamenova added a comment. In D73534#1880790 , @stella.stamenova wrote: > I am not sure this was the cause of the failure, but other than your patches, > there was only one other change in the first failing build. I have not had > time to fully i

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

stella.stamenova added a comment. I am not sure this was the cause of the failure, but other than your patches, there was only one other change in the first failing build. I have not had time to fully investigate yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://re

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

stella.stamenova added a comment. It looks like this broke the Windows LLDB Buildbot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/14048/steps/build/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74727/new/ https://rev

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

stella.stamenova added a comment. It looks like this change resulted in a failing test on the Windows LLDB bot: http://lab.llvm.org:8011/#/builders/83/builds/3602 It seems like one of the tests is trying to re-use the same log names within a single run and they are still being used by the previ

[Lldb-commits] [PATCH] D93951: [vscode] Improve runInTerminal and support linux

stella.stamenova added inline comments. Comment at: lldb/tools/lldb-vscode/FifoFiles.cpp:9 + +#if !defined(WIN32) +#include mstorsjo wrote: > stella.stamenova wrote: > > Also, this is no good. It works if you are targeting windows on windows, > > but not if you

[Lldb-commits] [PATCH] D96427: Support multi-configuration generators correctly in several config files

stella.stamenova created this revision. Herald added subscribers: teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, mgorny. Herald added a reviewer: JDevlieghere. Heral

[Lldb-commits] [PATCH] D96427: Support multi-configuration generators correctly in several config files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed98676fa483: Support multi-configuration generators correctly in several config files (authored by stella.stamenova). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D96427: Support multi-configuration generators correctly in several config files

stella.stamenova updated this revision to Diff 323053. stella.stamenova edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96427/new/ https://reviews.llvm.org/D96427 Files: clang/test/Unit/lit.site.cfg.py.in lld/t

[Lldb-commits] [PATCH] D96779: [lldb] Fix shared library directory computation on windows

stella.stamenova accepted this revision. stella.stamenova added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96779/new/ https://reviews.llvm.org/D96779 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

stella.stamenova created this revision. Herald added subscribers: cota, teijeong, rdzhabarov, tatianashp, ThomasRaoux, AlexeySotkin, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini. Herald added a rev

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

stella.stamenova added a comment. In D96778#2594405 , @jankratochvil wrote: > @stella.stamenova It failed on a Windows box: > https://lab.llvm.org/buildbot/#/builders/83/builds/4202 > > $ "c:\buildbot\lldb-x64-windows-ninja\build\bin\clang.exe" > "--ta

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

stella.stamenova added a comment. Considering this broke two bots, you might want to commit a fix or revert soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96778/new/ https://reviews.llvm.org/D96778

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

stella.stamenova added a comment. In D96778#2595162 , @jankratochvil wrote: > In D96778#2595110 , > @stella.stamenova wrote: > >> What is the actual test requirement? > > It requires x86_64 (it is incompatible wit

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

stella.stamenova added a comment. This does not build on the Windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/4214 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95711/new/ https://reviews.llvm.org/D95711 ___

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

stella.stamenova added a comment. In D95711#2595566 , @mib wrote: > In D95711#2595458 , > @stella.stamenova wrote: > >> This does not build on the Windows bot: >> >> https://lab.llvm.org/buildbot/#/builders/83/buil

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG801067f4c09b: [mlir][lldb] Fix several gcc warnings in mlir and lldb (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D97586: [mlir][lldb] Fix several gcc warnings in mlir and lldb

stella.stamenova added inline comments. Comment at: lldb/source/Commands/CommandObjectTrace.cpp:119 lldb::TraceSP trace_sp = traceOrErr.get(); - if (m_options.m_verbose) + if (m_options.m_verbose && trace_sp) result.AppendMessageWithFormat("loading trace

[Lldb-commits] [PATCH] D98749: [lldb] [test] Fix TestGdbRemote_vContThreads.py logic

stella.stamenova added a comment. Herald added a subscriber: JDevlieghere. This broke the windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/4725 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98749/new/ https://reviews.llvm.org/D98749

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. Looks good as long as it doesn't break windows :O CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98842/new/ https://reviews.llvm.org/D98842 ___

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

stella.stamenova added a comment. In D98842#2634902 , @teemperor wrote: > Just gonna post a comment to point out that this apparently adds all tests > twice to `check-all` which makes the tests go kaputt (but I only messaged > Jonas directly about that,

[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

stella.stamenova added a comment. This did end up breaking the windows build bot... https://lab.llvm.org/buildbot/#/builders/83/builds/4808 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98842/new/ https://reviews.llvm.org/D98842 _

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

stella.stamenova added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:114 + create_python_package( +${swig_target} How is this different than the package on line 107? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

stella.stamenova added a comment. In D95713#2647548 , @teemperor wrote: > The tests are failing because Dave's bot is running without enabled Python. > The same is true for the Windows bot. Putting the plugin behind `#ifdef > LLDB_ENABLE_PYTHON` should f

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

stella.stamenova added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:69 + + StructuredData::ObjectSP object_sp = GetInterface().CreatePluginObject( + m_launch_info.GetClassName().c_str(), target_sp, This is where the

[Lldb-commits] [PATCH] D98482: [lldb] [server] Support for multiprocess extension

stella.stamenova added a comment. Looks like this broke the Windows lldb buildbot: https://lab.llvm.org/buildbot/#/builders/83/builds/5173 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98482/new/ https://reviews.llvm.org/D98482 __

[Lldb-commits] [PATCH] D99694: Add support for getting signed ObjC tagged pointer values

stella.stamenova added a comment. The latest change (commit be0ced03 ) issues the following warning: /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D

[Lldb-commits] [PATCH] D99694: Add support for getting signed ObjC tagged pointer values

stella.stamenova added a subscriber: teemperor. stella.stamenova added a comment. It looks like @teemperor fixed it already! In D99694#2671640 , @stella.stamenova wrote: > The latest change (commit be0ced03 >

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

stella.stamenova added a comment. This broke the windows LLDB bot. Please fix it soon or revert. https://lab.llvm.org/buildbot/#/builders/83/builds/5685 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97786/new/ https://reviews.llvm.org/D97786

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

stella.stamenova added a comment. Looks like this is failing on the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/6033 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100977/new/ https://reviews.llvm.org/D100977 _

[Lldb-commits] [PATCH] D101333: Also display the underlying error message when displaying a fixit

stella.stamenova added a comment. Herald added a subscriber: JDevlieghere. It looks like this broke the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/6085 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101333/new/ https://rev

[Lldb-commits] [PATCH] D102208: Remove Windows editline from LLDB

stella.stamenova added a comment. I don't have context into this either. Does this cause any test failures or is everything still green after the change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102208/new/ https://reviews.llvm.org/D102208 _

[Lldb-commits] [PATCH] D87466: [lldb, tests] Correctly configure the yaml2obj paths

stella.stamenova created this revision. stella.stamenova added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. stella.stamenova requested review of this revision. They are currently not being set correctly for the case of multi-config genera

[Lldb-commits] [PATCH] D87466: [lldb, tests] Correctly configure the yaml2obj paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc464f1d8f9a0: [lldb, tests] Correctly configure the yaml2obj paths (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

stella.stamenova added inline comments. Comment at: lldb/source/Commands/CommandObjectMemory.cpp:1701 } else { if (command.GetArgumentCount() == 1) { auto load_addr_str = command[0].ref(); Actually, I would change the logic here a littl

[Lldb-commits] [PATCH] D88229: Reland "[lldb] Don't send invalid region addresses to lldb server"

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88229/new/ https://reviews.llvm.org/D88229 _

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

stella.stamenova added a comment. It looks like this changed caused a failure on the windows bot and your follow up change to fix the test left it still broken. Can you have a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89124/new/ https://

[Lldb-commits] [PATCH] D68171: Remove unused "append" parameter from FindTypes API

stella.stamenova added a comment. This broke the windows bot. A couple of other issues have shown up and been fixed since, but this change is still causing a break: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9373 Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D68354: [platform process list] add a flag for showing the processes of all users

stella.stamenova added a comment. The windows LLDB bot also has the same failure: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9600 Please make sure your fix works for both. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68354/ne

[Lldb-commits] [PATCH] D67520: Add pretty printing of Clang "bitfield" enums

stella.stamenova added a comment. It looks like this broke one of the tests on the Windows LLDB bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9628/steps/test/logs/stdio The bot was already red because of a change from yesterday, so you probably didn't get a notification.

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

stella.stamenova added a comment. This is failing on the windows bot. There was already another failure, so you probably didn't get an email: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9727 http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9760 Repository:

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

stella.stamenova added a comment. It looks like this changed fixed at least one of the XFAILed tests on Windows: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9751 So now the test results would be red because of the unexpectedly passing test (if there wasn't another failure).

[Lldb-commits] [PATCH] D67347: [Windows] Use information from the PE32 exceptions directory to construct unwind plans

stella.stamenova added a comment. In D67347#1706405 , @stella.stamenova wrote: > It looks like this changed fixed at least one of the XFAILed tests on Windows: > > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9751 > > So now the test re

[Lldb-commits] [PATCH] D68738: update TestRunCommandInterpreterAPI to use SBFile

stella.stamenova added a comment. This is still failing on the Windows bot. Please fix it ASAP or revert it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68738/new/ https://reviews.llvm.org/D68738 ___

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

stella.stamenova added a comment. This change looks fine assuming all the tests continue to pass. I think it makes sense to update the script to allow more arguments and/or invoke clang-cl directly instead of using the script. I suspect that using clang-cl directly will not work though - the sc

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

stella.stamenova added a comment. In D68980#1709866 , @labath wrote: > In D68980#1709830 , > @stella.stamenova wrote: > > > I suspect that using clang-cl directly will not work though - the script > > does a lot o

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

stella.stamenova added a comment. In D68980#1709931 , @labath wrote: > In D68980#1709884 , > @stella.stamenova wrote: > > > The two things that come to mind are the path to clang-cl (which is > > sometimes a clang

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

stella.stamenova added a comment. In D68980#1709968 , @mstorsjo wrote: > In D68980#1709954 , > @stella.stamenova wrote: > > > Both. Again, it's been a long time, but when we use VS for building, the > > environmen

[Lldb-commits] [PATCH] D68980: [LLDB] [test] Pass --target=-windows-msvc to clang-cl

stella.stamenova added a comment. In D68980#1709967 , @mstorsjo wrote: > In D68980#1709931 , @labath wrote: > > > In D68980#1709884 , > > @stella.stamenova wrote: > > > > >

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

stella.stamenova added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp:6 +// RUN: %clang_cl --target=x86_64-windows-msvc -Od -Z7 -c /Fo%t.obj -- %s +// RUN: lld-link -debug:full -nodefaultlib -entry:main %t.obj -out:%t.exe -pdb:%t.pdb // RUN: e

[Lldb-commits] [PATCH] D68293: [android/process list] support showing process arguments

stella.stamenova added a comment. This is causing a failure on the Windows Bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9920 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68293/new/ https://reviews.llvm.org/D68293 __

[Lldb-commits] [PATCH] D69031: [LLDB] [test] Use %clang_cl instead of build.py in a few tests

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. The tests passed in my setup. After you commit this, please monitor the windows Buildbot (it currently has a couple of failures, so you will have to check it and not rely o

[Lldb-commits] [PATCH] D69114: Disable TestProcessList on windows

stella.stamenova requested changes to this revision. stella.stamenova added a comment. This revision now requires changes to proceed. Please also file a bug and reference it in the skip statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69114/

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

stella.stamenova added a comment. Unfortunately, this is failing on the windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9961 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68130/new/ https://reviews.llvm.org/D68130 _

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

stella.stamenova added a comment. In D68130#1713620 , @teemperor wrote: > Yeah, seems like constructing objects in expressions isn't implemented on > Windows. I'm not sure if there is a reliable way to test that constructors > aren't shadowed by these gl

[Lldb-commits] [PATCH] D68130: [lldb] Don't emit artificial constructor declarations as global functions

stella.stamenova added a comment. Oh, and TestCallOverridenMethod still has some failures on Windows: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9996/steps/test/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68130/new

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

stella.stamenova accepted this revision. stella.stamenova added a comment. Thanks @labath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69555/new/ https://reviews.llvm.org/D69555 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D68961: Add support for DW_AT_export_symbols for anonymous structs

stella.stamenova added a comment. This is broken on Windows. I moved the Buildbot to staging to resolve some of the issues with the move to the monorepo, so you can see the failures here: http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/0/steps/test/logs/stdio Repository: rG L

<    1   2   3   4   >