This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc24860118a7e: [lldb] Skip two lldb tests on Windows because they are flaky (authored by stella.stamenova).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114907/new/ https://reviews.llvm.org/D114907 Files: lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py Index: lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py =================================================================== --- lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py +++ lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py @@ -89,6 +89,7 @@ self.assertEqual(yours[i], mine[i], "ID of yours[{0}] and mine[{0}] matches".format(i)) + @skipIfWindows # This test is flaky on Windows def test_lldb_iter_frame(self): """Test iterator works correctly for SBProcess->SBThread->SBFrame.""" self.build() Index: lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py =================================================================== --- lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py +++ lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py @@ -20,6 +20,7 @@ # hits break in another thread in testrun @add_test_categories(['pyapi']) @expectedFlakeyNetBSD + @skipIfWindows # This test is flaky on Windows def test_python(self): """Test that we obey thread conditioned breakpoints.""" self.build()
Index: lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py =================================================================== --- lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py +++ lldb/test/API/python_api/lldbutil/iter/TestLLDBIterator.py @@ -89,6 +89,7 @@ self.assertEqual(yours[i], mine[i], "ID of yours[{0}] and mine[{0}] matches".format(i)) + @skipIfWindows # This test is flaky on Windows def test_lldb_iter_frame(self): """Test iterator works correctly for SBProcess->SBThread->SBFrame.""" self.build() Index: lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py =================================================================== --- lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py +++ lldb/test/API/functionalities/thread/thread_specific_break_plus_condition/TestThreadSpecificBpPlusCondition.py @@ -20,6 +20,7 @@ # hits break in another thread in testrun @add_test_categories(['pyapi']) @expectedFlakeyNetBSD + @skipIfWindows # This test is flaky on Windows def test_python(self): """Test that we obey thread conditioned breakpoints.""" self.build()
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits