[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz created this revision. sgraenitz added reviewers: clayborg, aprantl, jingham, jasonmolenda. Herald added subscribers: dexonsmith, JDevlieghere, mehdi_amini. So far SymbolFileDWARFDebugMap did only parse one compile unit per OSO entry. Thus, LLDB failed to resolve breakpoint locations in

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz updated this revision to Diff 166698. sgraenitz added a comment. Address Jonas' feedback + minor additions https://reviews.llvm.org/D52375 Files: include/lldb/Symbol/Symtab.h source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp sour

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz updated this revision to Diff 166699. sgraenitz added a comment. Address Jonas' feedback #2 https://reviews.llvm.org/D52375 Files: include/lldb/Symbol/Symtab.h source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp source/Plugins/Symb

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:431 const size_t num_ranges = -die->GetAttributeAddressRanges(dwarf, this, ranges, false); +die->GetAttributeAddressRanges(dwarf, this, ranges, check_hi_lo_pc); if

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz updated this revision to Diff 166985. sgraenitz added a comment. Revert check_hi_lo_pc and comment out call to AddOSOARanges() for now https://reviews.llvm.org/D52375 Files: include/lldb/Symbol/Symtab.h source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWAR

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:431 const size_t num_ranges = -die->GetAttributeAddressRanges(dwarf, this, ranges, false); +die->GetAttributeAddressRanges(dwarf, this, ranges, check_hi_lo_pc); if

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz updated this revision to Diff 167109. sgraenitz marked an inline comment as done. sgraenitz added a comment. Skip AddOSOARanges() if the OSO debug map entry has multiple compile units. https://reviews.llvm.org/D52375 Files: include/lldb/Symbol/Symtab.h source/Plugins/SymbolFile/DW

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:439 +die->GetAttributeAddressRanges(dwarf, this, ranges, check_hi_lo_pc); + if (num_ranges > 0) { clayborg wrote: > Empty CUs won't have any children. Easy to

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:1531 + if (m_compile_unit_infos.size() > 1) +return 0; + sgraenitz wrote: > Skipping AddOSOARanges() here. > Could you leave an in-source comment explain

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:468 // situation. Check the line tables and build the arange table from this. SymbolContext sc; sc.comp_unit = dwarf->GetCompUnitForDWARFCompUnit(this); @cla

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz updated this revision to Diff 167335. sgraenitz added a comment. Add test for breakpoint resolution in DWARF debug map, exercising different LTO and line-tables-only combinations https://reviews.llvm.org/D52375 Files: include/lldb/Symbol/Symtab.h packages/Python/lldbsuite/test/ma

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Symbol/Symtab.cpp:520 + return false; +} + clayborg wrote: > This function is still pretty specific. Any comments on my above inlined > comment? Yes absolutely, but the same holds for most functions around her

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:468 // situation. Check the line tables and build the arange table from this. SymbolContext sc; sc.comp_unit = dwarf->GetCompUnitForDWARFCompUnit(this); sgra

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz updated this revision to Diff 167593. sgraenitz marked 8 inline comments as done. sgraenitz added a comment. Address feedback from Adrian and Duncan https://reviews.llvm.org/D52375 Files: include/lldb/Symbol/Symtab.h packages/Python/lldbsuite/test/macosx/debug_map/Makefile packa

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:13 +# Set inputs empty, if not passed from the Python script. +CFLAGS ?= +LDFLAGS ?= aprantl wrote: > This is a noop. You can remove it without affecting anythin

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

sgraenitz created this revision. sgraenitz added reviewers: aprantl, jasonmolenda, JDevlieghere. sgraenitz added a subscriber: LLDB. Add settings to control command echoing: (lldb) settings set interpreter.echo-commands true (lldb) settings set interpreter.echo-comment-commands true Both set

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

sgraenitz updated this revision to Diff 167976. sgraenitz added a comment. Fix CommandInterpreterRunOptions::GetStopOnError() https://reviews.llvm.org/D52788 Files: include/lldb/API/SBCommandInterpreter.h include/lldb/Interpreter/CommandInterpreter.h source/API/SBCommandInterpreter.cpp

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

sgraenitz added inline comments. Comment at: include/lldb/Interpreter/CommandInterpreter.h:105 - bool GetStopOnError() const { return DefaultToNo(m_stop_on_continue); } + bool GetStopOnError() const { return DefaultToNo(m_stop_on_error); } Unrelated fix =

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

sgraenitz updated this revision to Diff 167995. sgraenitz added a comment. Add tests, address some of the feedback from Jim and Shafik https://reviews.llvm.org/D52788 Files: include/lldb/API/SBCommandInterpreter.h include/lldb/Interpreter/CommandInterpreter.h lit/Settings/Inputs/EchoComma

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: source/Interpreter/CommandInterpreter.cpp:2733 + + const char *k_space_characters = "\t\n\v\f\r "; + size_t first_non_space = line.find_first_not_of(k_space_characters); sh

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

sgraenitz added a comment. Is it ok to have so many TestEchoXY.test files? I tried to get them all in one, but so far it didn't work out. Comment at: source/Interpreter/CommandInterpreter.cpp:2733 + + const char *k_space_characters = "\t\n\v\f\r "; + size_t first_non_space =

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

sgraenitz updated this revision to Diff 168450. sgraenitz added a comment. Minor fixes https://reviews.llvm.org/D52788 Files: include/lldb/API/SBCommandInterpreter.h include/lldb/Interpreter/CommandInterpreter.h lit/Settings/Resources/EchoCommandsAll.out lit/Settings/Resources/EchoComma

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

sgraenitz updated this revision to Diff 168453. sgraenitz added a comment. Enable interpreter.echo-comment-commands in lit-lldb-init. All tests still passing. https://reviews.llvm.org/D52788 Files: include/lldb/API/SBCommandInterpreter.h include/lldb/Interpreter/CommandInterpreter.h lit/

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

sgraenitz marked an inline comment as done. sgraenitz added a comment. IMO Ready now. Comment at: source/Interpreter/CommandInterpreter.cpp:2417 flags |= eHandleCommandFlagPrintResult; } sgraenitz wrote: > Could reduce boilerplate in the code

[Lldb-commits] [PATCH] D52270: TestMultilineExpr: validate evaluation for expressions spread over multiple lines

sgraenitz updated this revision to Diff 168466. sgraenitz added a comment. Simplify test as proposed in review https://reviews.llvm.org/D52270 Files: lit/Expr/TestMultilineExpr.test packages/Python/lldbsuite/test/expression_command/multiline/Makefile packages/Python/lldbsuite/test/expres

[Lldb-commits] [PATCH] D52270: TestMultilineExpr: validate evaluation for expressions spread over multiple lines

sgraenitz marked an inline comment as done. sgraenitz added a comment. Requires: https://reviews.llvm.org/D52788 (Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings) https://reviews.llvm.org/D52270 ___

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

sgraenitz updated this revision to Diff 168478. sgraenitz marked an inline comment as done. sgraenitz added a comment. Rename folder lit/Settings/Resources to lit/Settings/Inputs https://reviews.llvm.org/D52788 Files: include/lldb/API/SBCommandInterpreter.h include/lldb/Interpreter/CommandI

[Lldb-commits] [PATCH] D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution

sgraenitz added a comment. Hi Pavel, thanks for working on this. The code looks really great. I have no actual concerns about landing it like this. Two minor remarks: - We still have no coverage for substitution failures in `CPlusPlusLanguageTest.cpp` test case `FindAlternateFunctionManglings`

[Lldb-commits] [PATCH] D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. Nice. For parameter lists of `reset` and `substitute` indentation could be fixed, but otherwise this looks really good to me. https://reviews.llvm.org/D54074

[Lldb-commits] [PATCH] D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution

sgraenitz added inline comments. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:337 +if (llvm::StringRef(First, Last - First).startswith(Search)) { + Result += llvm::StringRef(Written, First - Written); + Result += Replace; shaf

[Lldb-commits] [PATCH] D54333: [CMake] Allow version overrides with -DLLDB_VERSION_MAJOR/MINOR/PATCH/SUFFIX

sgraenitz created this revision. sgraenitz added reviewers: labath, xiaobai. Herald added a subscriber: mgorny. This follows the approach in Clang. If no overrides are given, LLDB_VERSION_* is inferred from LLVM_VERSION_*. This mimics the current behaviour (PACKAGE_VERSION itself is generated fr

[Lldb-commits] [PATCH] D54335: [CMake] Fix: add_host_subdirectory source/Host/macosx

sgraenitz created this revision. sgraenitz added a reviewer: teemperor. Herald added a subscriber: mgorny. Typo introduced with https://reviews.llvm.org/D47929 https://reviews.llvm.org/D54335 Files: source/Host/CMakeLists.txt Index: source/Host/CMakeLists.txt ===

[Lldb-commits] [PATCH] D54352: [CMake] Explicit lldb_codesign function with application in debugserver and lldb-server

sgraenitz created this revision. sgraenitz added reviewers: beanz, bogner, lanza, friss. Herald added a subscriber: mgorny. Add LLDB-specific utility function lldb_codesign. In contrast to llvm_codesign it must be invoked explicitly and allows to pass a target-specific entitlements file as well

[Lldb-commits] [PATCH] D54352: [CMake] Explicit lldb_codesign function with application in debugserver and lldb-server

sgraenitz added a comment. This would soon be used for other targets as well. llvm_codesign is here: https://reviews.llvm.org/D48797 Comment at: cmake/modules/AddLLDB.cmake:212 + set(pass_force "--force") +endif() + So far `--force` was used everywher

[Lldb-commits] [PATCH] D54352: [CMake] Explicit lldb_codesign function with application in debugserver and lldb-server

sgraenitz added a comment. Yes, considered it, but was not sure whether it's a good idea to bloat the general mechanism in LLVM to match the requirements for a single subproject. Do you think other projects would benefit from it? My reasoning was: Passing through target-specific parameters to l

[Lldb-commits] [PATCH] D54352: [CMake] Explicit lldb_codesign function with application in debugserver and lldb-server

sgraenitz added a comment. Ok, I will have a look and prepare a draft. https://reviews.llvm.org/D54352 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54443: [CMake] Accept ENTITLEMENTS in add_llvm_executable and llvm_codesign

sgraenitz created this revision. sgraenitz added reviewers: beanz, bogner. Herald added a subscriber: mgorny. Allow code-signing with entitlements. FORCE may be used to avoid an error when replacing existing signatures. Repository: rL LLVM https://reviews.llvm.org/D54443 Files: cmake/modu

[Lldb-commits] [PATCH] D54444: [CMake] Use extended llvm_codesign to pass entitlements for lldb-server

sgraenitz created this revision. sgraenitz added reviewers: beanz, bogner. Herald added a subscriber: mgorny. This is using the mechanism proposed in https://reviews.llvm.org/D54443 to pass the entitlements file for lldb-server to llvm_codesign. https://reviews.llvm.org/D5 Files: CMakeLi

[Lldb-commits] [PATCH] D54352: [CMake] Explicit lldb_codesign function with application in debugserver and lldb-server

sgraenitz added a comment. Please find the alternative proposal in https://reviews.llvm.org/D54443 (llvm) and https://reviews.llvm.org/D5 (lldb). https://reviews.llvm.org/D54352 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [PATCH] D54444: [CMake] Use extended llvm_codesign to pass entitlements for lldb-server

sgraenitz added a comment. `debugserver` was not that simple. For now only `lldb-server` as an example. Comment at: cmake/modules/AddLLDB.cmake:109 list(APPEND LLVM_LINK_COMPONENTS ${ARG_LINK_COMPONENTS}) - add_llvm_executable(${name} ${ARG_UNPARSED_ARGUMENTS}) + add_llvm_

[Lldb-commits] [PATCH] D54443: [CMake] Accept ENTITLEMENTS in add_llvm_executable and llvm_codesign

sgraenitz added inline comments. Comment at: cmake/modules/AddLLVM.cmake:795 - llvm_codesign(${name}) + llvm_codesign(TARGET ${name} ENTITLEMENTS ${ARG_ENTITLEMENTS} FORCE) endmacro(add_llvm_executable name) Would we want to pass `FORCE` to `add_llvm_executa

[Lldb-commits] [PATCH] D54443: [CMake] Accept ENTITLEMENTS in add_llvm_executable and llvm_codesign

sgraenitz added inline comments. Comment at: cmake/modules/AddLLVM.cmake:795 - llvm_codesign(${name}) + llvm_codesign(TARGET ${name} ENTITLEMENTS ${ARG_ENTITLEMENTS} FORCE) endmacro(add_llvm_executable name) beanz wrote: > sgraenitz wrote: > > Would we want

[Lldb-commits] [PATCH] D54444: [CMake] Use extended llvm_codesign to pass entitlements for lldb-server

sgraenitz added inline comments. Comment at: tools/lldb-server/CMakeLists.txt:50 + if(LLDB_USE_ENTITLEMENTS AND NOT IOS) +# Same entitlements file as used for lldb-server +set(entitlements ${LLDB_SOURCE_DIR}/resources/debugserver-macosx-entitlements.plist) -

[Lldb-commits] [PATCH] D54444: [CMake] Use extended llvm_codesign to pass entitlements for lldb-server

sgraenitz updated this revision to Diff 173849. sgraenitz added a comment. unset not necessary, fix comment, globally set LLVM_CODESIGNING_IDENTITY from LLDB_CODESIGN_IDENTITY https://reviews.llvm.org/D5 Files: CMakeLists.txt cmake/modules/AddLLDB.cmake tools/lldb-server/CMakeLists.t

[Lldb-commits] [PATCH] D54443: [CMake] Accept ENTITLEMENTS in add_llvm_executable and llvm_codesign

sgraenitz updated this revision to Diff 173851. sgraenitz added a comment. Remove FORCE parameter from llvm_codesign and instead add global option LLVM_CODESIGNING_FORCE Repository: rL LLVM https://reviews.llvm.org/D54443 Files: CMakeLists.txt cmake/modules/AddLLVM.cmake Index: cmake/

[Lldb-commits] [PATCH] D54443: [CMake] Accept ENTITLEMENTS in add_llvm_executable and llvm_codesign

sgraenitz added inline comments. Comment at: CMakeLists.txt:403 +set(LLVM_CODESIGNING_IDENTITY "" CACHE STRING + "Sign executables and dylibs with the given identity or skip if empty (Darwin Only)") + Identity should be a string right? Commen

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, beanz, vsk, JDevlieghere. Herald added a subscriber: mgorny. Use llvm_codesign to sign debugserver with entitlements. Make individual cases more explicit: - default: build debugserver and sign with entitlements - LLDB_NO_DEBUGS

[Lldb-commits] [PATCH] D54352: [CMake] Explicit lldb_codesign function with application in debugserver and lldb-server

sgraenitz abandoned this revision. sgraenitz added a comment. Finally, debugserver with llvm_codesign: https://reviews.llvm.org/D54476 https://reviews.llvm.org/D54352 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz added inline comments. Comment at: tools/debugserver/source/CMakeLists.txt:101 +option(LLDB_NO_DEBUGSERVER "Delete debugserver after building it, and don't try to codesign it" OFF) +option(LLDB_USE_SYSTEM_DEBUGSERVER "Neither build nor codesign debugserver. Use the sy

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz updated this revision to Diff 174053. sgraenitz marked 4 inline comments as done. sgraenitz added a comment. debugserver cannot be ad-hoc code signed; handle entitlements&identity also in standalone debugserver, add feasibility checks, polishing https://reviews.llvm.org/D54476 Files:

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz marked 2 inline comments as not done. sgraenitz added inline comments. Comment at: tools/debugserver/source/CMakeLists.txt:128-133 +# TODO: Following the old behavior, DEBUGSERVER_PATH still points to the +# original system binary, even if we copy it over. Keep

[Lldb-commits] [PATCH] D54443: [CMake] Accept ENTITLEMENTS in add_llvm_executable and llvm_codesign

sgraenitz updated this revision to Diff 174055. sgraenitz added a comment. Remove force option Repository: rL LLVM https://reviews.llvm.org/D54443 Files: CMakeLists.txt cmake/modules/AddLLVM.cmake Index: cmake/modules/AddLLVM.cmake ==

[Lldb-commits] [PATCH] D54443: [CMake] Accept ENTITLEMENTS in add_llvm_executable and llvm_codesign

sgraenitz added a comment. Two use-cases for executables: LLDB lldb-server https://reviews.llvm.org/D5 LLDB debugserver https://reviews.llvm.org/D54476 I have no use-case for shared libraries (yet), so I didn't add ENTITLEMENTS there. Is that ok? Repository: rL LLVM https://reviews.llvm

[Lldb-commits] [PATCH] D54444: [CMake] Use extended llvm_codesign to pass entitlements for lldb-server

sgraenitz added a comment. In Xcode we have ad-hoc signing when targeting iOS and signing with entitlements in case of macOS for lldb-server. https://reviews.llvm.org/D5 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llv

[Lldb-commits] [PATCH] D54444: [CMake] Use extended llvm_codesign to pass entitlements for lldb-server

sgraenitz added a comment. + LLDB.framework has lldb-server as a dependency there. Not sure if it's (really) necessary, though. https://reviews.llvm.org/D5 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz updated this revision to Diff 174253. sgraenitz marked an inline comment as not done. sgraenitz edited the summary of this revision. sgraenitz added a comment. Handle reconfigurations correctly; fix configuration messages; add note for generator expressions https://reviews.llvm.org/D5

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz updated this revision to Diff 174254. sgraenitz added a comment. Improve description for options LLDB_NO_DEBUGSERVER and LLDB_USE_SYSTEM_DEBUGSERVER https://reviews.llvm.org/D54476 Files: test/CMakeLists.txt tools/debugserver/CMakeLists.txt tools/debugserver/source/CMakeLists.t

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz added a comment. Last revision changed a lot, but I think support for reconfigurations is worth it. The current state would be acceptable from my side now -- if I didn't miss anything! :-) Comment at: tools/debugserver/source/CMakeLists.txt:101 +option(LLDB_NO_DEBUG

[Lldb-commits] [PATCH] D54616: [Reproducers] Improve reproducer API and add unit tests.

sgraenitz added a comment. Looks pretty good to me, but added my 2¢ on minor things. Comment at: include/lldb/Utility/Reproducer.h:169 + llvm::Error SetCapture(bool value, FileSpec root = {}); + llvm::Error SetReplay(bool value, FileSpec root = {}); Are the

[Lldb-commits] [PATCH] D54443: [CMake] Accept ENTITLEMENTS in add_llvm_executable and llvm_codesign

sgraenitz added a comment. Tested on macOS and Linux with the use-cases mentioned. Repository: rL LLVM https://reviews.llvm.org/D54443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz added a comment. Thanks. Waiting for https://reviews.llvm.org/D54443 https://reviews.llvm.org/D54476 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz updated this revision to Diff 174405. sgraenitz added a comment. Set global LLVM_CODESIGNING_IDENTITY from LLDB_CODESIGN_IDENTITY (if given). Pass through ENTITLEMENTS from add_lldb_executable to add_llvm_executable. https://reviews.llvm.org/D54476 Files: CMakeLists.txt cmake/modu

[Lldb-commits] [PATCH] D54444: [CMake] Use extended llvm_codesign to pass entitlements for lldb-server

sgraenitz abandoned this revision. sgraenitz added a comment. Ok, I will close this then. Added the remaining part of the patch to https://reviews.llvm.org/D54476 https://reviews.llvm.org/D5 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

sgraenitz added a comment. My change for lldb-server (https://reviews.llvm.org/D5) became obsolete, but two small pieces of it are required in general/here. Added them post-approval with the update above. It's the two additions to `cmake/modules/AddLLDB.cmake` and `CMakeLists.txt`. Will leav

[Lldb-commits] [PATCH] D55012: [CMake] Streamline code signing for debugserver #2

sgraenitz created this revision. Herald added subscribers: llvm-commits, mgorny. The first patch had to be reverted as I missed a few details. This review continues from https://reviews.llvm.org/D54476 and I will add the required fixes. Change log: - Use llvm_codesign to sign debugserver with

[Lldb-commits] [PATCH] D55012: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175725. sgraenitz added a comment. Fix target directory for debugserver: it must not be LLVM_TOOLS_BINARY_DIR but LLVM_RUNTIME_OUTPUT_INTDIR. It's a difference in standalone builds of LLDB. LLVM_TOOLS_BINARY_DIR was wrong here as it points to the binary di

[Lldb-commits] [PATCH] D55012: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175729. sgraenitz added a comment. The default identity for code signing must be lldb_codesign. Also remove the comment to deprecate LLDB_CODESIGN_IDENTITY in favor of LLVM_CODESIGNING_IDENTITY. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55012

[Lldb-commits] [PATCH] D55012: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175730. sgraenitz added a comment. Move code sign settings to LLDBConfig.cmake + polishing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55012/new/ https://reviews.llvm.org/D55012 Files: CMakeLists.txt cmake/modules/LLDBConfig.cmake tools/d

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz created this revision. Herald added a subscriber: mgorny. The first patch had to be reverted as I missed a few details. This review continues from D54476 and I will add the required fixes. Change log: - Use llvm_codesign to sign debugserver with enti

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175734. sgraenitz added a comment. Fix target directory for debugserver: it must not be LLVM_TOOLS_BINARY_DIR but LLVM_RUNTIME_OUTPUT_INTDIR. It's a difference in standalone builds of LLDB. LLVM_TOOLS_BINARY_DIR was wrong here as it points to the binary di

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175736. sgraenitz added a comment. Default identity for code signing must be lldb_codesign. Also remove the comment to deprecate LLDB_CODESIGN_IDENTITY in favor of LLVM_CODESIGNING_IDENTITY. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55013/new

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175739. sgraenitz added a comment. Move code sign settings to LLDBConfig.cmake CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55013/new/ https://reviews.llvm.org/D55013 Files: cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfig.cmake test/C

[Lldb-commits] [PATCH] D55032: [CMake] Fix standalone build for debugserver on macOS

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, beanz. Herald added a subscriber: mgorny. Quick-fix to avoid CMake config issue: CMake Error at /path/to/lldb/cmake/modules/AddLLDB.cmake:116 (add_dependencies): Cannot add target-level dependencies to non-existent target

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz marked an inline comment as done. sgraenitz added a comment. Thanks for having a look. Comment at: tools/debugserver/CMakeLists.txt:18 + + option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) + set(LLDB_CODESIGN_IDENTITY lldb_codesign

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz added a comment. In-tree builds look good now. I successfully built and tested with these configurations: green dragon: xcrun cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=On -DLLVM_ENABLE_MODULES=On ../llvm my default: xcrun cmake -GNinja -DCMAKE_BUILD_TYPE=Re

[Lldb-commits] [PATCH] D55032: [CMake] Fix standalone build for debugserver on macOS

sgraenitz added a comment. Thought about it, but yes, at the moment it looks like overkill. I'd go on duplicating options to debugserver for now and change the approach if it gets unpractical. There are some more changes to come. I want to upstream these first and see how it looks then. CHANG

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz added inline comments. Comment at: tools/debugserver/CMakeLists.txt:18 + + option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) + set(LLDB_CODESIGN_IDENTITY lldb_codesign CACHE STRING JDevlieghere wrote: > sgraenitz wro

[Lldb-commits] [PATCH] D55084: [CMake] Add RPATHS parameter to llvm_add_executable/library

sgraenitz created this revision. Herald added a subscriber: mgorny. This allows to set target-specific LC_RPATH load commands on macOS. It would be useful to locate LLDB.framework in LLDB tools. Repository: rL LLVM https://reviews.llvm.org/D55084 Files: cmake/modules/AddLLVM.cmake Index

[Lldb-commits] [PATCH] D55114: [CMake] Add LLVM_EXTERNALIZE_DEBUGINFO_OUTPUT_DIR for custom dSYM target directory on Darwin

sgraenitz created this revision. sgraenitz added a reviewer: beanz. Herald added subscribers: aprantl, mgorny. When using `LLVM_EXTERNALIZE_DEBUGINFO` in LLDB, the default dSYM location for the shared library in LLDB.framework is inside the framework bundle. With `LLVM_EXTERNALIZE_DEBUGINFO_OUTP

[Lldb-commits] [PATCH] D55128: [CMake] Store path to vendor-specific headers in clang-headers target property

sgraenitz created this revision. sgraenitz added reviewers: aprantl, JDevlieghere, davide, friss, dexonsmith. Herald added a subscriber: mgorny. LLDB.framework wants a copy these headers. With this change LLDB can easily glob for the list of files: get_target_property(clang_include_dir clang-h

[Lldb-commits] [PATCH] D55316: [CMake] Add support for NO_INSTALL_RPATH argument in llvm_add_library()

sgraenitz created this revision. sgraenitz added reviewers: aprantl, JDevlieghere, davide, friss. Herald added a subscriber: mgorny. Allow clients to suppress setup of default RPATHs in designated library targets. This is used in LLDB when emitting liblldb as a framework bundle, which itself doe

[Lldb-commits] [PATCH] D55084: [CMake] Add RPATHS parameter to llvm_add_executable/library

sgraenitz abandoned this revision. sgraenitz added a comment. More requirements for RPATH handling in LLDB came up. We will do it manually over there instead of adding support in LLVM. Added D55316 to avoid the need for reverting default settings. Repository:

[Lldb-commits] [PATCH] D55317: [CMake] Aggregate options for LLDB in LLDBConfig.cmake

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, aprantl, xiaobai. Herald added subscribers: mgorny, srhines. In preparation for LLDB.framework changes, collect options for LLDB in LLDBConfig.cmake (used for both, standalone and in-tree builds). https://reviews.llvm.org

[Lldb-commits] [PATCH] D55319: [CMake] Proposal: Prefer LLDB_VERSION over plist value in EmbedAppleVersion.cmake

sgraenitz created this revision. sgraenitz added reviewers: aprantl, friss. Herald added a subscriber: mgorny. LLDB_VERSION works analogous to CLANG_VERSION, with the exception that it includes the optional LLDB_VERSION_SUFFIX. Thus it should be equal to LLDB_VERSION_STRING and we could use it i

[Lldb-commits] [PATCH] D55320: [CMake] Move debugserver options to separate debugserverConfig.cmake

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, aprantl, xiaobai. Herald added a subscriber: mgorny. One place for debugserver options, analog to LLDBConfig for LLDB options (see D55317 ). It was discussed in earlier reviews already, e.g

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, JDevlieghere, aprantl, davide, beanz. Herald added a subscriber: mgorny. Add features to LLDB CMake builds that have so far only been available in Xcode. Clean up a few inconveniences and prepare further improvements. Options:

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, JDevlieghere, aprantl, clayborg. Herald added subscribers: mgorny, ki.stfu. If we build LLDB.framework, dependant tools need appropriate RPATHs in both locations, the build-tree (for testing) and the install-tree (for deployment

[Lldb-commits] [PATCH] D55319: [CMake] Proposal: Prefer LLDB_VERSION over plist value in EmbedAppleVersion.cmake

sgraenitz added a comment. In order to reduce the risk of breaking the Xcode build, I use a separate `resources/LLDB-Info.plist.in` (https://reviews.llvm.org/D55328#change-SBZDFQxftWtU) for the framework. I did not yet change which plist is used here, but yes writing the correct version would

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

sgraenitz created this revision. sgraenitz added reviewers: JDevlieghere, aprantl, stella.stamenova, beanz, zturner. Herald added a subscriber: mgorny. Simplify SWIG invocation and handling of generated files. The `swig_wrapper` target can generate `LLDBWrapPython.cpp` and `lldb.py` in its own

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz marked an inline comment as done. sgraenitz added a comment. I am still running some remaining tests, but please let me know what you think about it in the meantime. In case you want to try this patch yourself, please checkout together with the related revisions (see Stack). ===

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: CMakeLists.txt:143 -DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/scripts/finishSwigWrapperClasses.py -DEPENDS ${LLDB_PYTHON_TARGET_DIR}/lldb.py COMMENT "Python script sym-link

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 176949. sgraenitz added a comment. Avoid conflicts: updating diff for recent changes on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55013/new/ https://reviews.llvm.org/D55013 Files: cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfi

[Lldb-commits] [PATCH] D55320: [CMake] Move debugserver options to separate debugserverConfig.cmake

sgraenitz updated this revision to Diff 176950. sgraenitz added a comment. Avoid conflicts: updating diff for recent changes on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55320/new/ https://reviews.llvm.org/D55320 Files: cmake/modules/debugserverConfig.cmake tools/debugse

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 176954. sgraenitz added a comment. Avoid conflicts: updating diff for recent changes on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 Files: CMakeLists.txt cmake/modules/AddLLDB.cmake cmake/

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

sgraenitz updated this revision to Diff 176956. sgraenitz added a comment. Avoid conflicts: updating diff for recent changes on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55330/new/ https://reviews.llvm.org/D55330 Files: cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfi

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

sgraenitz updated this revision to Diff 176957. sgraenitz added a comment. Avoid conflicts: updating diff for recent changes on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55332/new/ https://reviews.llvm.org/D55332 Files: CMakeLists.txt scripts/CMakeLists.txt source/API/

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 176998. sgraenitz added a comment. Copy Clang headers to LLDB.framework without an intermediate staging directory. This approach seems much simpler and it avoids errors from an ordering issue at configuration time (preventing Clang headers from being copie

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

sgraenitz updated this revision to Diff 177003. sgraenitz marked an inline comment as not done. sgraenitz added a comment. LLDB.framework requires an in-tree build CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 Files: CMakeLists.txt cmake/m

[Lldb-commits] [PATCH] D55316: [CMake] Add support for NO_INSTALL_RPATH argument in llvm_add_library()

sgraenitz updated this revision to Diff 177142. sgraenitz added a comment. Add short comment for NO_INSTALL_RPATH parameter to function description Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55316/new/ https://reviews.llvm.org/D55316 Files: cmake/modules/Add

[Lldb-commits] [PATCH] D55316: [CMake] Add support for NO_INSTALL_RPATH argument in llvm_add_library()

sgraenitz marked 2 inline comments as done. sgraenitz added inline comments. Comment at: cmake/modules/AddLLVM.cmake:458 + if(NOT ARG_NO_INSTALL_RPATH) +if(ARG_MODULE OR ARG_SHARED) aprantl wrote: > Any kind of comment that we could add here that explains

  1   2   3   4   5   6   >