sgraenitz added inline comments.
================ Comment at: tools/debugserver/CMakeLists.txt:18 + + option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) + set(LLDB_CODESIGN_IDENTITY lldb_codesign CACHE STRING ---------------- JDevlieghere wrote: > sgraenitz wrote: > > JDevlieghere wrote: > > > Why do we need to define this option again for the debugserver? Why can't > > > it use the one from LLDBConfig.cmake? > > In a debugserver standalone build we don't `include(LLDBConfig)`. It makes > > sense to me, because there is not much to configure when only building the > > debugserver. > Makes sense. Maybe we could put this in the top level CMakeLists.txt? This is the top level CMakeLists.txt for standalone debugserver :) See my previous comment about testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55013/new/ https://reviews.llvm.org/D55013 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
