sivachandra added a subscriber: sivachandra.
sivachandra added a comment.
Also, this patch has changes in clang. There should be a clang reviewer I think
[unless I am unaware something here.]
http://reviews.llvm.org/D13350
___
lldb-commits mailing
sivachandra added a comment.
I suppose you should first post a separate self contained clang patch to the
clang list. After landing it in clang, you should post an LLDB specific patch
here.
About its correctness, I cannot comment on the clang changes. Commenting on the
LLDB changes are probabl
sivachandra added a comment.
I will use an example to explain the problem that this patch is trying to solve.
class.h:
class C
{
public:
C () {
c = 0;
}
virtual int method();
private:
int c;
};
class.cpp:
#include "class.h"
int
C::meth
sivachandra updated this revision to Diff 36805.
sivachandra added a comment.
Rebase.
http://reviews.llvm.org/D13224
Files:
source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
test/lang/cpp/limit-debug-info/Makefile
test/lang/cpp/limit-debug-info/TestWithLimitDebugInfo.py
test/lang/
Author: sivachandra
Date: Wed Oct 7 17:11:52 2015
New Revision: 249629
URL: http://llvm.org/viewvc/llvm-project?rev=249629&view=rev
Log:
[DWARFASTParserClang] Strengthen incomplete type handling.
Summary: This change fixes pr24916. As associated test has been added.
Reviewers: clayborg
Subscri
sivachandra updated this revision to Diff 36818.
sivachandra added a comment.
Rebase.
http://reviews.llvm.org/D12809
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/CompilerDeclContext.h
include/lldb/Symbol/SymbolFile.h
include/lldb/Symbol/TypeSystem.h
include/lldb/Ta
sivachandra added a comment.
Another friendly ping.
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This breaks 2 tests on linux:
Failing Tests (2)
FAIL: LLDB (suite) :: TestMiBreak.py
FAIL: LLDB (suite) :: TestSettings.py
On Thu, Oct 8, 2015 at 4:07 PM, Sean Callanan via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: spyffe
> Date: Thu Oct 8 18:07:53 2015
> New Revision: 249769
sivachandra created this revision.
sivachandra added a reviewer: mohit.bhakkad.
sivachandra added a subscriber: lldb-commits.
On x86, we only have 4 watchpoint registers.
http://reviews.llvm.org/D13608
Files:
test/functionalities/watchpoint/watchpoint_on_vectors/TestValueOfVectorVariable.py
sivachandra added a comment.
I am not very familiar with the watchpoint logic. I think it is not smart
enough (yet) to figure that a vector of 16 elements which are 2 bytes each can
be watched using the 4 watchpoint registers on x86. I could be wrong, in which
case I would be glad to accept sug
sivachandra added a comment.
I am going to push this to get the bots back to green.
http://reviews.llvm.org/D13608
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sivachandra
Date: Fri Oct 9 18:05:28 2015
New Revision: 249916
URL: http://llvm.org/viewvc/llvm-project?rev=249916&view=rev
Log:
[TestValueOfVectorVariable] Reduce the vector size to 4.
Summary: On x86, we only have 4 watchpoint registers.
Reviewers: mohit.bhakkad
Subscribers: lldb-com
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249916: [TestValueOfVectorVariable] Reduce the vector size
to 4. (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D13608?vs=36994&id=37006#toc
Repository:
rL LLVM
http://r
sivachandra created this revision.
sivachandra added a reviewer: granata.enrico.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D13678
Files:
examples/synthetic/gnu_libstdcpp.py
Index: examples/synthetic/gnu_libstdcpp.py
==
sivachandra added a comment.
How can there be loops in an std::list?
1. If the implementation is flawed.
2. If someone messes with its implementation.
Should we protect for such cases at all? If #1, don't use that library in the
first place. If #2, that is an unsupported use case :)
http://re
sivachandra added a comment.
Is eliminating the size limits alone acceptable then?
http://reviews.llvm.org/D13678
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sivachandra created this revision.
sivachandra added a reviewer: granata.enrico.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D13682
Files:
examples/synthetic/gnu_libstdcpp.py
Index: examples/synthetic/gnu_libstdcpp.py
==
sivachandra abandoned this revision.
sivachandra added a comment.
Abandoning this in favor of http://reviews.llvm.org/D13682. It was easy to
create a new diff than to edit the existing one.
http://reviews.llvm.org/D13678
___
lldb-commits mailing li
Author: sivachandra
Date: Mon Oct 12 19:05:42 2015
New Revision: 250131
URL: http://llvm.org/viewvc/llvm-project?rev=250131&view=rev
Log:
[libstdc++ data-formatters] Remove size limits.
Reviewers: granata.enrico
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13682
Mo
sivachandra added a comment.
Ping. I have few follow up changes over whatever goes in here. Would greatly
appreciate if someone can make a decision on this, or advice on how to take
this forward.
http://reviews.llvm.org/D12809
___
lldb-commits mai
sivachandra created this revision.
sivachandra added reviewers: clayborg, granata.enrico.
sivachandra added a subscriber: lldb-commits.
Along with this, support for an optional Python synthetic child provider
method "has_child_at_index" has also been added. These have been added
with the following
sivachandra added a comment.
If the general idea in this patch is OK, I will update it with tests.
http://reviews.llvm.org/D13778
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sivachandra added a comment.
As I mentioned in the first post, this is the use case:
Synthetic child providers currently have a method "has_children" and
"get_num_children". While the former is good enough to know if there are
children, it does not give any insight into how many children there ar
sivachandra added a comment.
Yes, we would like to use this is specific synthetic providers. It will not be
used by any part of LLDB internally.
http://reviews.llvm.org/D13778
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
sivachandra added a comment.
Ah, we want this exposed in the SBValue API. What I mean't in the earlier
message was that no other part of LLDB will functionally depend/lookup/expect
this "feature".
http://reviews.llvm.org/D13778
___
lldb-commits ma
On Thu, Oct 15, 2015 at 11:59 AM, Enrico Granata
wrote:
> granata.enrico added a comment.
>
> So, if I understand this correctly, this HasChildAtIndex() API returns a
> three-state int:
>
> 1 == yes I do
> 0 == no I do not
> -1 == maybe, can't tell
>
> When would you ever run into the -1 case? It
sivachandra abandoned this revision.
sivachandra added a comment.
This was from the time when I did not have commit access. sbest committed this
for me separately.
http://reviews.llvm.org/D6122
___
lldb-commits mailing list
lldb-commits@lists.llvm.
sivachandra added a comment.
I did consider the option of adding a new method GetNumChildren (uint32_t max =
UINT32_MAX). This if fine from SBValue point of view. But from a the scripted
synthetic provider point of view, I am not sure there is an easy/clean way of
checking whether the num_child
sivachandra added a comment.
Ah, I did not notice PyCallable::GetNumArguments before you drew my attention
to it. It seems to be using internals of PyCodeObject. When I said "no
easy/clean way", I was talking about avoiding such a usage. If that is
acceptable, I am fine with it. I will modify t
sivachandra added a comment.
I did this experiment before setting off:
class A
{
public:
int method();
int method(int a = 10);
};
int
A::method()
{
return 10;
}
int
A::method(int a)
{
return a + 10;
}
int
main()
{
A a;
return a.method
sivachandra added a comment.
There could be an error reading the k-th element for k < n.In which case, we
will wrongly conclude that there are only k-1 elements.
http://reviews.llvm.org/D13778
___
lldb-commits mailing list
lldb-commits@lists.llvm.o
sivachandra added a comment.
When such an error occurs, it is unlikely to be an lldb bug, or data-formatter
bug. One can come up with a data structure for which reading a child element
would require complete debug info, but reading the # of child elements need not
require complete debug info (t
sivachandra updated this revision to Diff 37630.
sivachandra added a comment.
Address comments.
http://reviews.llvm.org/D13778
Files:
include/lldb/API/SBValue.h
include/lldb/Core/ValueObject.h
include/lldb/Core/ValueObjectCast.h
include/lldb/Core/ValueObjectChild.h
include/lldb/Core/V
sivachandra created this revision.
sivachandra added a reviewer: clayborg.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D13877
Files:
source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
Index: source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
sivachandra added a comment.
Putting this in as obvious. It fixes the build on Linux and Windows.
http://reviews.llvm.org/D13877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sivachandra
Date: Mon Oct 19 16:43:07 2015
New Revision: 250740
URL: http://llvm.org/viewvc/llvm-project?rev=250740&view=rev
Log:
[PlatformDarwin.cpp] Include for std::once_flag.
Reviewers: clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13877
Modifi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250740: [PlatformDarwin.cpp] Include for
std::once_flag. (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D13877?vs=37796&id=37797#toc
Repository:
rL LLVM
http://reviews.
sivachandra added a comment.
Pinging to ensure that it did not get lost in the title change.
http://reviews.llvm.org/D13778
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sivachandra created this revision.
sivachandra added reviewers: zturner, spyffe.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D13882
Files:
test/functionalities/completion/TestCompletion.py
test/functionalities/data-formatter/dump_dynamic/main.cpp
Index: test/functio
sivachandra added a comment.
I am going to put this in to get the bots back to green.
http://reviews.llvm.org/D13882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250782: Adjust TestCompletion.py and TestDumpDynamic.py
after recent changes. (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D13882?vs=37819&id=37822#toc
Repository:
rL L
Author: sivachandra
Date: Mon Oct 19 20:03:18 2015
New Revision: 250782
URL: http://llvm.org/viewvc/llvm-project?rev=250782&view=rev
Log:
Adjust TestCompletion.py and TestDumpDynamic.py after recent changes.
Reviewers: zturner, spyffe
Subscribers: lldb-commits
Differential Revision: http://revi
sivachandra updated this revision to Diff 37937.
sivachandra added a comment.
Add tests.
http://reviews.llvm.org/D13778
Files:
include/lldb/API/SBValue.h
include/lldb/Core/ValueObject.h
include/lldb/Core/ValueObjectCast.h
include/lldb/Core/ValueObjectChild.h
include/lldb/Core/ValueObj
This breaks the build because of two things:
1. The function GetLanguagesSupportingREPLs is declared static in
Language.cpp, but Language.h has it declared as a static method.
2. There is a declaration for a static method
GetREPLEnumerateSupportedLanguagesCallbackAtIndex in PluginManager,
but no d
sivachandra created this revision.
sivachandra added a reviewer: spyffe.
sivachandra added a subscriber: lldb-commits.
This reverts commit babd6dd74e316b1fcd9d171d7d8c83845d51a487.
http://reviews.llvm.org/D13952
Files:
include/lldb/Core/PluginManager.h
include/lldb/Target/Language.h
includ
Author: sivachandra
Date: Wed Oct 21 13:58:01 2015
New Revision: 250927
URL: http://llvm.org/viewvc/llvm-project?rev=250927&view=rev
Log:
Revert "Made the REPL choose a default language if only one REPL can be chosen."
Summary: This reverts commit babd6dd74e316b1fcd9d171d7d8c83845d51a487.
Review
sivachandra added a comment.
I am going to put this in to fix the build.
http://reviews.llvm.org/D13952
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250927: Revert "Made the REPL choose a default language if
only one REPL can be chosen." (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D13952?vs=38033&id=38034#toc
Reposit
Author: sivachandra
Date: Wed Oct 21 14:28:08 2015
New Revision: 250930
URL: http://llvm.org/viewvc/llvm-project?rev=250930&view=rev
Log:
[SBValue] Add a method GetNumChildren(uint32_t max)
Summary:
Along with this, support for an optional argument to the "num_children"
method of a Python synthet
sivachandra added a subscriber: sivachandra.
sivachandra added a comment.
If this fixes the windows build, can you please commit it ASAP?
Repository:
rL LLVM
http://reviews.llvm.org/D13968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
sivachandra created this revision.
sivachandra added a reviewer: zturner.
sivachandra added a subscriber: lldb-commits.
"from __future__ import print_function" was added to the test file but
not to the embedded interpreter. This change uses file.write instead to
avoid all problems with print.
htt
sivachandra updated this revision to Diff 38265.
sivachandra added a comment.
Put back the import of print_function from __future__.
http://reviews.llvm.org/D14029
Files:
test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
Index:
test/functionalities/breakpoint/break
Author: sivachandra
Date: Fri Oct 23 16:38:04 2015
New Revision: 251150
URL: http://llvm.org/viewvc/llvm-project?rev=251150&view=rev
Log:
[TestBreakpointCommand] Fix after r251121
Summary:
"from __future__ import print_function" was added to the test file but
not to the embedded interpreter. This
sivachandra created this revision.
sivachandra added a reviewer: zturner.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D14784
Files:
packages/Python/lldbsuite/test/functionalities/thread/exit_during_step/TestExitDuringStep.py
Index:
packages/Python/lldbsuite/test/fun
Author: sivachandra
Date: Wed Nov 18 15:22:29 2015
New Revision: 253505
URL: http://llvm.org/viewvc/llvm-project?rev=253505&view=rev
Log:
[TestExitDuringStep] Adjust after a recent type map change.
Reviewers: zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D1478
sivachandra created this revision.
sivachandra added reviewers: emaste, krytarowski.
sivachandra added a subscriber: lldb-commits.
This reverts commit 2354cd73101e58540b8b39783df462d06023309f as it
introduced a bunch regressions on the linux bot.
http://reviews.llvm.org/D14844
Files:
source/In
Author: sivachandra
Date: Thu Nov 19 16:58:48 2015
New Revision: 253615
URL: http://llvm.org/viewvc/llvm-project?rev=253615&view=rev
Log:
Revert "Plug-in PlatformNetBSD initializer and terminator"
Summary:
This reverts commit 2354cd73101e58540b8b39783df462d06023309f as it
introduced a bunch regre
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253615: Revert "Plug-in PlatformNetBSD initializer and
terminator" (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D14844?vs=40708&id=40710#toc
Repository:
rL LLVM
http:/
This make the test TestVectorTypesFormatting, which is annotated with
@skipIf(compiler='gcc'), run when using GCC:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8661/steps/test5/logs/stdio
On Thu, Nov 19, 2015 at 4:11 PM, Adrian McCarthy via lldb-commits
wrote:
> Author:
sivachandra added a comment.
Actually, I do not have time today to do a better job with digging and have to
resort to reverting.
Repository:
rL LLVM
http://reviews.llvm.org/D14844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://
sivachandra created this revision.
sivachandra added a reviewer: amccarth.
sivachandra added a subscriber: lldb-commits.
This reverts commit 251965377bdfb6227eea42c12a792c059e4e8a4b
as a test marked "skipIf(compiler='gcc')" runs when testing with GCC.
http://reviews.llvm.org/D14852
Files:
pack
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253631: Revert "Make skipIf support the not_in function."
(authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D14852?vs=40728&id=40729#toc
Repository:
rL LLVM
http://reviews.
Author: sivachandra
Date: Thu Nov 19 19:54:24 2015
New Revision: 253631
URL: http://llvm.org/viewvc/llvm-project?rev=253631&view=rev
Log:
Revert "Make skipIf support the not_in function."
Summary:
This reverts commit 251965377bdfb6227eea42c12a792c059e4e8a4b
as a test marked "skipIf(compiler='gcc'
I think this introduces more regressions while not addressing the
original one:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8688
On Fri, Nov 20, 2015 at 10:14 AM, Adrian McCarthy via lldb-commits
wrote:
> Author: amccarth
> Date: Fri Nov 20 12:14:24 2015
> New Revisio
sivachandra created this revision.
sivachandra added reviewers: amccarth, zturner.
sivachandra added a subscriber: lldb-commits.
This reverts commit 70dca28976ee8137acce2cc203dd394f4d761276.
http://reviews.llvm.org/D14881
Files:
packages/Python/lldbsuite/test/lldbtest.py
Index: packages/Pytho
sivachandra added a comment.
Reverting as this introduces more regressions.
http://reviews.llvm.org/D14881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sivachandra
Date: Fri Nov 20 14:30:36 2015
New Revision: 253704
URL: http://llvm.org/viewvc/llvm-project?rev=253704&view=rev
Log:
Revert "Make skipIf support the not_in function (second attempt)."
Summary: This reverts commit 70dca28976ee8137acce2cc203dd394f4d761276.
Reviewers: amccarth,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253704: Revert "Make skipIf support the not_in function
(second attempt)." (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D14881?vs=40813&id=40815#toc
Repository:
rL LLVM
sivachandra updated this revision to Diff 41706.
sivachandra added a comment.
Rebased and updated to take in DWO changes.
http://reviews.llvm.org/D12809
Files:
include/lldb/Symbol/ClangASTContext.h
include/lldb/Symbol/CompilerDeclContext.h
include/lldb/Symbol/GoASTContext.h
include/lldb
sivachandra added a comment.
PTaL
I finally got time to work on this. I have now rebased it and updated it take
in DWO changes.
I understand this change only enhances debug experience when GCC is used as the
DWARF producer (the targeted functionality already works as expected when the
producer
sivachandra added a comment.
A test for this already exists: TestCallStdStringFunction.py
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sivachandra added a comment.
@dawn: Thanks for accepting the patch. I guess I still need to wait for
sign-off/comments from a CODE_OWNER.
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org
sivachandra created this revision.
sivachandra added reviewers: clayborg, tberghammer, spyffe.
sivachandra added a subscriber: lldb-commits.
DWARF 5 proposes a reinvented .debug_macro section. This change follows
that spec.
Currently, only GCC produces the .debug_macro section and hence
the added
sivachandra added a comment.
The dwo_test_method fails for the added test as I think there is some GCC bug
with the combination of -gsplit-dwarf and -g3.
http://reviews.llvm.org/D15437
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
sivachandra added a comment.
I should also mention that I did not implement the complete spec as I do not
know of any producer which produces all the flavors of the new spec.
http://reviews.llvm.org/D15437
___
lldb-commits mailing list
lldb-commits
sivachandra updated this revision to Diff 42563.
sivachandra marked 11 inline comments as done.
sivachandra added a comment.
Address comments.
http://reviews.llvm.org/D15437
Files:
include/lldb/Symbol/CompileUnit.h
include/lldb/Symbol/DebugMacros.h
include/lldb/Symbol/SymbolFile.h
inclu
sivachandra added a comment.
I have addressed all the comments (with changes or my own comments).
About the problem with dwo, I have sent a mail to the GCC guys asking for
guidance. Will fix it when I get clarity on that.
And yes, it would definitely be good if clang can also produce .debug_mac
sivachandra added a comment.
The spec says that, for a given compile unit, the macro entries in the debug
info will be in the order in which the compiler processes them. Hence, at line
5 in your example, all these are relevant:
#define FOO puts <<< from foo.h
#undef FOO <<< from foo.h
#de
sivachandra updated this revision to Diff 42614.
sivachandra added a comment.
Use file names.
http://reviews.llvm.org/D15437
Files:
include/lldb/Symbol/CompileUnit.h
include/lldb/Symbol/DebugMacros.h
include/lldb/Symbol/SymbolFile.h
include/lldb/Symbol/SymbolVendor.h
include/lldb/lldb
sivachandra added a comment.
PTAL. I have now covered the case I missed. Added test for that as well.
http://reviews.llvm.org/D15437
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
sivachandra updated this revision to Diff 42754.
sivachandra marked 2 inline comments as done.
sivachandra added a comment.
Remove storing of an unused data structure.
http://reviews.llvm.org/D15437
Files:
include/lldb/Symbol/CompileUnit.h
include/lldb/Symbol/DebugMacros.h
include/lldb/Sy
sivachandra updated this revision to Diff 42758.
sivachandra added a comment.
Use std::unordered_map instead of std::map.
http://reviews.llvm.org/D15437
Files:
include/lldb/Symbol/CompileUnit.h
include/lldb/Symbol/DebugMacros.h
include/lldb/Symbol/SymbolFile.h
include/lldb/Symbol/Symbol
sivachandra added a comment.
PTAL
http://reviews.llvm.org/D15437
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
I believe zturner already fixed this. However, there is a problem with
his original change itself; will bring it up in a different thread.
On Mon, Dec 14, 2015 at 1:49 PM, Todd Fiala via lldb-commits
wrote:
> Author: tfiala
> Date: Mon Dec 14 15:49:39 2015
> New Revision: 255549
>
> URL: http://l
On Mon, Dec 14, 2015 at 10:49 AM, Zachary Turner via lldb-commits
wrote:
> Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=255525&r1=255524&r2=255525&view=diff
>
Looks like, though that particular test was "fixed", zturner's change
triggered a whole bunch of other failures:
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/9446
On Mon, Dec 14, 2015 at 1:56 PM, Siva Chandra wrote:
> I believe zturner already fixed this. However, there
Previously, self.debug_info was under different functions
(dwarf_test_method, dwo_test_method etc.). Now, they are all under
test_method. Even I am equally ignorant about the Python nuances here.
On Mon, Dec 14, 2015 at 2:04 PM, Zachary Turner wrote:
> The previous code was just an unrolled loop
On Mon, Dec 14, 2015 at 2:15 PM, Zachary Turner wrote:
> Diff looks like this:
>
> -@dwarf_test
> -@wraps(attrvalue)
> -def dwarf_test_method(self, attrvalue=attrvalue):
> -self.debug_info = "dwarf"
> -return a
This change looks very innocent, but:
On Mon, Dec 14, 2015 at 1:26 PM, Zachary Turner via lldb-commits
wrote:
> URL:
> http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=255542&r1=255541&r2=255542&view=diff
>
sivachandra created this revision.
sivachandra added a reviewer: zturner.
sivachandra added a subscriber: lldb-commits.
http://reviews.llvm.org/D15511
Files:
packages/Python/lldbsuite/test/lldbtest.py
Index: packages/Python/lldbsuite/test/lldbtest.py
===
sivachandra added a comment.
I went ahead and committed this.
Repository:
rL LLVM
http://reviews.llvm.org/D15511
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sivachandra
Date: Mon Dec 14 18:26:52 2015
New Revision: 255584
URL: http://llvm.org/viewvc/llvm-project?rev=255584&view=rev
Log:
Make few adjustments after r255542.
Reviewers: zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D15511
Modified:
lldb/tr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255584: Make few adjustments after r255542. (authored by
sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D15511?vs=42796&id=42802#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1551
On Mon, Dec 14, 2015 at 4:50 PM, Kamil Rytarowski via lldb-commits
wrote:
> Author: kamil
> Date: Mon Dec 14 18:50:19 2015
> New Revision: 255592
>
> Added:
> lldb/trunk/source/Plugins/Process/Utility/NetBSDSignals.cpp
> lldb/trunk/source/Plugins/Process/Utility/NetBSDSignals.h
Should the
Ah, yes! Thank you.
On Mon, Dec 14, 2015 at 6:41 PM, Jim Ingham wrote:
> I think Jason already did (r255597).
>
> Jim
>
>> On Dec 14, 2015, at 6:35 PM, Siva Chandra via lldb-commits
>> wrote:
>>
>> On Mon, Dec 14, 2015 at 4:50 PM, Kamil Rytarowski via lldb-
On Mon, Dec 14, 2015 at 6:42 PM, Zachary Turner wrote:
> zturner added inline comments.
>
>
> Comment at: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py:622
> @@ -621,3 +621,3 @@
> return list_or_lambda(value)
> -elif isinstance(list_or_lambda, list):
> -
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255729: Read macro info from .debug_macro section and use it
for expression evaluation. (authored by sivachandra).
Changed prior to commit:
http://reviews.llvm.org/D15437?vs=42758&id=42938#toc
Reposito
Author: sivachandra
Date: Tue Dec 15 18:22:08 2015
New Revision: 255729
URL: http://llvm.org/viewvc/llvm-project?rev=255729&view=rev
Log:
Read macro info from .debug_macro section and use it for expression evaluation.
Summary:
DWARF 5 proposes a reinvented .debug_macro section. This change follow
On Tue, Dec 15, 2015 at 4:22 PM, Siva Chandra via lldb-commits
wrote:
> Author: sivachandra
> Date: Tue Dec 15 18:22:08 2015
> New Revision: 255729
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255729&view=rev
> Log:
> Read macro info from .debug_macro section
sivachandra created this revision.
sivachandra added a reviewer: granata.enrico.
sivachandra added a subscriber: lldb-commits.
Also xfailed for GCC as there is an problem with debug info generation.
http://reviews.llvm.org/D15657
Files:
packages/Python/lldbsuite/test/lang/cpp/auto/Makefile
p
1 - 100 of 223 matches
Mail list logo
