[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, asmith, labath. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, mgorny. This patch introduces the simple `PDBNameParser`. It is needed for parsing names of PDB symbols cor

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

labath added a comment. In https://reviews.llvm.org/D52139#1243170, @teemperor wrote: > Anyway, the actual issue is related Python 3: Arch Linux (and probably > some other distributions that "already" upgraded to Python 3 as > default) will launch Python 3 when the test script calls `python ...

[Lldb-commits] [PATCH] D52468: [PDB] Treat `char`, `signed char` and `unsigned char` as three different types

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: asmith, zturner, labath. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. `char`, `signed char` and `unsigned char` are three different types, and they are mangled differently: v

[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

labath added a comment. I think you should look at CPlusPlusLanguage::MethodName. It already contains a parser (in fact, two of them) of c++ names, and I think it should be easy to extend it to do what you want. Repository: rLLDB LLDB https://reviews.llvm.org/D52461 _

[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

clayborg added a comment. In https://reviews.llvm.org/D48393#1244426, @JDevlieghere wrote: > Thanks for the information, Greg! > > In https://reviews.llvm.org/D48393#1243588, @clayborg wrote: > > > A little background might help here: The lldb_private::Module lock is used > > to prevent multiple

[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

clayborg added a comment. In https://reviews.llvm.org/D48393#1244649, @labath wrote: > I agree with Greg that it would be best to restrict things such that there is > only one instance of parsing going on at any given time for a single module. > I think this was pretty much the state we reached

[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

clayborg added a comment. In https://reviews.llvm.org/D52461#1244813, @labath wrote: > I think you should look at CPlusPlusLanguage::MethodName. It already contains > a parser (in fact, two of them) of c++ names, and I think it should be easy > to extend it to do what you want. I agree with P

[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

aleksandr.urakov added a comment. Ok, I'll look into that, thanks! Repository: rLLDB LLDB https://reviews.llvm.org/D52461 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

apolyakov created this revision. apolyakov added reviewers: teemperor, labath, tatyana-krasnukha, aprantl. Herald added a subscriber: ki.stfu. This patch fixes hanging of the test in case of using python3, changes callback function that will be called if the timer ends; Also, the test didn't work

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov added a comment. Thanks Pavel, I fixed it here https://reviews.llvm.org/D52498. Repository: rL LLVM https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

apolyakov updated this revision to Diff 166919. apolyakov added a comment. Removed the shebang line since we call the script via `python ...` so that line doesn't matter. https://reviews.llvm.org/D52498 Files: lit/tools/lldb-mi/target/inputs/target-select-so-path.py Index: lit/tools/lldb-m

[Lldb-commits] [PATCH] D52501: [PDB] Restore the calling convention from PDB

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: clayborg, zturner, labath, asmith. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. This patch implements restoring of the calling convention from PDB. It is necessary for expressio

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

tatyana-krasnukha added a comment. `pass_fds` parameter was added in Python 3.7. With version 3.6 the test fails with a `TypeError`. https://reviews.llvm.org/D52498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

teemperor added a comment. Hmmm, maybe I mixing up something here, but the docs state `pass_fds` was added in 3.2: > New in version 3.2: The pass_fds parameter was added. https://reviews.llvm.org/D52498 _

[Lldb-commits] [PATCH] D52501: [PDB] Restore the calling convention from PDB

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good as long as all the test suite bots are happy. Repository: rLLDB LLDB https://reviews.llvm.org/D52501 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

tatyana-krasnukha added a comment. It seems I ran into an unrelated issue like this . If the revision works for others, you may ignore this. https://reviews.llvm.org/D52498 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

apolyakov updated this revision to Diff 166936. apolyakov added a comment. Changed python version required to use 'pass_fds' argument to 3.2. I tested this patch with python 2.7 and 3.5. https://reviews.llvm.org/D52498 Files: lit/tools/lldb-mi/target/inputs/target-select-so-path.py Index: l

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

tatyana-krasnukha added a comment. Forget that the test calls default python, not which was passed to cmake. So, it is enough to replace (3,0) pair with (3,2) to fix. Comment at: lit/tools/lldb-mi/target/inputs/target-select-so-path.py:11 +kwargs = {} +if sys.version_info >= (

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

tatyana-krasnukha added a comment. Now works with Python 3.1 too. LGTM. https://reviews.llvm.org/D52498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51859: [NFC] Turn "load dependent files" boolean into an enum

brooks added a comment. Also broke the FreeBSD build: /usr/local/poudriere/ports/brooks/devel/llvm-devel/work/llvm-b418c2351b1fdf6faf6 a2d010d804e895ef49932/tools/lldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.c pp:338:50: error: cannot initialize a parameter of type 'lldb_private::L

[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

friss added a comment. In https://reviews.llvm.org/D48393#1245049, @clayborg wrote: > In https://reviews.llvm.org/D48393#1244649, @labath wrote: > > > I agree with Greg that it would be best to restrict things such that there > > is only one instance of parsing going on at any given time for a s

[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

clayborg added a comment. In https://reviews.llvm.org/D48393#1245342, @friss wrote: > In https://reviews.llvm.org/D48393#1245049, @clayborg wrote: > > > In https://reviews.llvm.org/D48393#1244649, @labath wrote: > > > > > I agree with Greg that it would be best to restrict things such that > > >

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

tatyana-krasnukha added inline comments. Comment at: lit/tools/lldb-mi/target/target-select-so-path.test:4 +# RUN: %cc -o %t %p/inputs/main.c -g +# RUN: python %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s + Could you run the same python that

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

apolyakov updated this revision to Diff 166953. apolyakov edited the summary of this revision. apolyakov added a comment. Changed the test to use `%python` variable instead of `python` https://reviews.llvm.org/D52498 Files: lit/tools/lldb-mi/target/inputs/target-select-so-path.py lit/tools/

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

apolyakov marked an inline comment as done. apolyakov added inline comments. Comment at: lit/tools/lldb-mi/target/target-select-so-path.test:4 +# RUN: %cc -o %t %p/inputs/main.c -g +# RUN: python %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s +

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Looks good and fixes the tests for me, so I think this is good to go. Thanks for the patch! https://reviews.llvm.org/D52498 ___ lldb-commi

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

labath accepted this revision. labath added a comment. LGTM. (BTW, python 3.1's EOL was 6 years ago) https://reviews.llvm.org/D52498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [PATCH] D52516: [lldbinline] Set directory attribute on test-specific classes

vsk created this revision. vsk added reviewers: labath, jingham, JDevlieghere. Herald added subscribers: eraman, aprantl. Set the "mydir" attribute of an inline test on the test-specific class, instead of on the base InlineTest class. This makes it possible to run dotest.py on a directory contain

[Lldb-commits] [PATCH] D52516: [lldbinline] Set directory attribute on test-specific classes

davide accepted this revision. davide added a comment. LGTM. https://reviews.llvm.org/D52516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52516: [lldbinline] Set directory attribute on test-specific classes

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ooh, nice catch. This must have been fun to debug. https://reviews.llvm.org/D52516 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz updated this revision to Diff 166985. sgraenitz added a comment. Revert check_hi_lo_pc and comment out call to AddOSOARanges() for now https://reviews.llvm.org/D52375 Files: include/lldb/Symbol/Symtab.h source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWAR

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:431 const size_t num_ranges = -die->GetAttributeAddressRanges(dwarf, this, ranges, false); +die->GetAttributeAddressRanges(dwarf, this, ranges, check_hi_lo_pc); if

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB343033: [lldb-mi] Fix bugs in target-select-so-path.test (authored by apolyakov, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D52498 Files: lit/tools/lldb-mi/target/inputs/targ

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:425 const DWARFDebugInfoEntry *die = GetUnitDIEPtrOnly(); const dw_offset_t cu_offset = GetOffset(); Following from inline comment below, you can abort if this CU is

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

vsk updated this revision to Diff 167038. vsk added a comment. The bug I thought I saw in CallEdge::GetReturnPCAddress turned out to be an issue I introduced in dsymutil. It's not correct for dsymutil to relocate the return PC value in TAG_call_site entries, because the correct section slide of

[Lldb-commits] [PATCH] D52532: Pull GetSoftwareBreakpointPCOffset into base class

labath created this revision. labath added reviewers: krytarowski, zturner. This function encodes the knowledge of whether the PC points to the breakpoint instruction of the one following it after the breakpoint is "hit". This behavior mainly(*) depends on the architecture and not on the OS, so it

[Lldb-commits] [PATCH] D52532: Pull GetSoftwareBreakpointPCOffset into base class

krytarowski added a comment. I was wondering whether we want to normalize this inside the kernel and always advance the Program Counter.. but it's easier to manage it in userland. https://reviews.llvm.org/D52532 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D52501: [PDB] Restore the calling convention from PDB

aleksandr.urakov updated this revision to Diff 167081. aleksandr.urakov added a comment. Thanks! I just have extracted the test cases in a separate test and have specified `-m32` key, so the test can run also on 64-bit machines. https://reviews.llvm.org/D52501 Files: include/lldb/Symbol/Cla

[Lldb-commits] [PATCH] D52501: [PDB] Restore the calling convention from PDB

This revision was automatically updated to reflect the committed changes. Closed by commit rL343084: [PDB] Restore the calling convention from PDB (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52501?vs=

[Lldb-commits] [PATCH] D52543: [DWARFSymbolFile] Adds the module lock to all virtual methods from SymbolFile

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, labath, friss. JDevlieghere added a project: LLDB. Herald added a subscriber: aprantl. This patch adds locking to all the virtual entry-points in DWARFSymbolFile to prevent corruption of its data structures as a result of

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz updated this revision to Diff 167109. sgraenitz marked an inline comment as done. sgraenitz added a comment. Skip AddOSOARanges() if the OSO debug map entry has multiple compile units. https://reviews.llvm.org/D52375 Files: include/lldb/Symbol/Symtab.h source/Plugins/SymbolFile/DW

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:439 +die->GetAttributeAddressRanges(dwarf, this, ranges, check_hi_lo_pc); + if (num_ranges > 0) { clayborg wrote: > Empty CUs won't have any children. Easy to

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

aprantl added inline comments. Comment at: lldb/source/Target/StackFrameList.cpp:331 +dfs(next_callee); +if (ambiguous) + return; On what path can this happen? Aren't all paths that set `ambiguous=true` returning immediately? =

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

vsk updated this revision to Diff 167148. vsk marked an inline comment as done. vsk added a comment. - Use std::make_shared(...), instead of StackFrameSP(new ...). https://reviews.llvm.org/D50478 Files: lldb/include/lldb/API/SBFrame.h lldb/include/lldb/Core/FormatEntity.h lldb/include/lld

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

vsk added inline comments. Comment at: lldb/source/Target/StackFrameList.cpp:331 +dfs(next_callee); +if (ambiguous) + return; aprantl wrote: > On what path can this happen? Aren't all paths that set `ambiguous=true` > returning immediate

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

vsk added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:431 const size_t num_ranges = -die->GetAttributeAddressRanges(dwarf, this, ranges, false); +die->GetAttributeAddressRanges(dwarf, this, ranges, check_hi_lo_pc); if (num_

[Lldb-commits] [PATCH] D52561: Refactor ClangUserExpression::GetLanguageForExpr

teemperor created this revision. teemperor added a reviewer: xbolva00. Herald added a subscriber: lldb-commits. The `ClangUserExpression::GetLanguageForExpr` method is currently a big source of sadness, as it's name implies that it's an accessor method, but it actually is also initializing some v

[Lldb-commits] [PATCH] D52543: [DWARFSymbolFile] Adds the module lock to all virtual methods from SymbolFile

clayborg added a comment. It is the SymbolVendor's job to do the locking. And in many cases it already is. I stopped with inlined comments after a few comments as it would apply to this entire patch. It would be great if we can replace all of the locations where you added lock guards with lldb

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:1531 + if (m_compile_unit_infos.size() > 1) +return 0; + sgraenitz wrote: > Skipping AddOSOARanges() here. > Could you leave an in-source comment explain

[Lldb-commits] [PATCH] D52543: [DWARFSymbolFile] Adds the module lock to all virtual methods from SymbolFile

JDevlieghere added a comment. In https://reviews.llvm.org/D52543#1246877, @clayborg wrote: > It is the SymbolVendor's job to do the locking. And in many cases it already > is. I stopped with inlined comments after a few comments as it would apply to > this entire patch. Thanks Greg. Honestly

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

vsk added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:1531 + if (m_compile_unit_infos.size() > 1) +return 0; + sgraenitz wrote: > sgraenitz wrote: > > Skipping AddOSOARanges() here. > > Could you leave an in-sourc

[Lldb-commits] [PATCH] D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, zturner, jingham. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, JDevlieghere. As a follow-up to https://reviews.llvm.org/D49017. Repository: rLLDB LLDB https://r

[Lldb-commits] [PATCH] D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Good stuff! Repository: rLLDB LLDB https://reviews.llvm.org/D52572 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

[Lldb-commits] [PATCH] D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef

zturner added a subscriber: tatyana-krasnukha. zturner added a comment. It would be nice if You could replace the logic that iterates these arrays. We no longer need to terminate on a sentinel nullptr entry and can now use range based for loop Repository: rLLDB LLDB https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:468 // situation. Check the line tables and build the arange table from this. SymbolContext sc; sc.comp_unit = dwarf->GetCompUnitForDWARFCompUnit(this); @cla

[Lldb-commits] [PATCH] D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef

tatyana-krasnukha added a comment. Hmm... There is no such logic left, isn't it? If you mean iterating OptionValueProperties::m_properties vector, I can replace cycles with range based for loop, but this doesn't seem to be related to these changes. Repository: rLLDB LLDB https://reviews.llv

[Lldb-commits] [PATCH] D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef

zturner added a comment. You might be right, I’m on mobile so hard for me to review. I saw a bunch of nullptr so assumed it was still using sentinel values for iterating. If not, ignore my suggestion Repository: rLLDB LLDB https://reviews.llvm.org/D52572 ___

[Lldb-commits] [PATCH] D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef

tatyana-krasnukha added a comment. It seems you are speaking about OptionDefinition, not PropertyDefinition. I was going to create a separate revision for it. Should I add OptionDefinition related changes to here? Repository: rLLDB LLDB https://reviews.llvm.org/D52572 ___

[Lldb-commits] [PATCH] D52572: Replace pointer to C-array of PropertyDefinition with llvm::ArrayRef

zturner added a comment. No, separate revision is fine. Thanks! Repository: rLLDB LLDB https://reviews.llvm.org/D52572 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

xbolva00 added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:179 + if (!m_die_array.empty()) { +lldbassert(!m_first_die || m_first_die == m_die_array.front()); +m_first_die = m_die_array.front(); @jankratochvil is

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

xbolva00 added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:179 + if (!m_die_array.empty()) { +lldbassert(!m_first_die || m_first_die == m_die_array.front()); +m_first_die = m_die_array.front(); xbolva00 wrote: >

[Lldb-commits] [PATCH] D52561: Refactor ClangUserExpression::GetLanguageForExpr

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. looks fine, thanks :) Repository: rLLDB LLDB https://reviews.llvm.org/D52561 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D52543: [DWARFSymbolFile] Adds the module lock to all virtual methods from SymbolFile

JDevlieghere added a comment. My first observations: - We call `ResolveTypeUID` without going through the symbol vendor (similar to `GetDeclContextForUID` in the stack trace). This is easy to fix, just add locking to these functions. - The module in the symbol vendor is different from the one i

[Lldb-commits] [PATCH] D52543: [DWARFSymbolFile] Adds the module lock to all virtual methods from SymbolFile

JDevlieghere updated this revision to Diff 167248. JDevlieghere added a comment. - Add assertions per Greg's suggestion. https://reviews.llvm.org/D52543 Files: include/lldb/Symbol/SymbolFile.h source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp source/Symbol/SymbolFile.cpp Index: source/

[Lldb-commits] [PATCH] D52543: [DWARFSymbolFile] Adds the module lock to all virtual methods from SymbolFile

xbolva00 added inline comments. Comment at: source/Symbol/SymbolFile.cpp:160 + // guarantee correctness. + assert(std::async( + std::launch::async, lldbassert? https://reviews.llvm.org/D52543 ___ lldb

[Lldb-commits] [PATCH] D52561: Refactor ClangUserExpression::GetLanguageForExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB343191: Refactor ClangUserExpression::GetLanguageForExpr (authored by teemperor, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D52561 Files: source/Plugins/ExpressionParser/Clan

[Lldb-commits] [PATCH] D52604: Clean-up usage of OptionDefinition arrays

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, zturner. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. Removed unused static arrays from headers, removed sentinel entry from OptionDefinition array in Driver.cpp. Repositor

[Lldb-commits] [PATCH] D52604: Clean-up usage of OptionDefinition arrays

tatyana-krasnukha added inline comments. Comment at: tools/driver/Driver.cpp:71 typedef struct { uint32_t usage_mask; // Used to mark options that can be used together. If (1 This type is duplicated here to not break the encapsulation of lldb's private t

[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

jankratochvil added a comment. @xbolva00 As you gave no reprodudcer it would be good to know how those two `DWARFDebugInfoEntry`s differ. Without that I can look at it more only next week - travelling. Repository: rL LLVM https://reviews.llvm.org/D46810 __

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar updated this revision to Diff 167287. grimar added a comment. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. - Addressed review comments. https://reviews.llvm.org/D52403 Files: include/lldb/lldb-enumerations.h lit/Breakpoint/Inputs/single-file-spli

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz updated this revision to Diff 167335. sgraenitz added a comment. Add test for breakpoint resolution in DWARF debug map, exercising different LTO and line-tables-only combinations https://reviews.llvm.org/D52375 Files: include/lldb/Symbol/Symtab.h packages/Python/lldbsuite/test/ma

[Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

aleksandr.urakov created this revision. aleksandr.urakov added reviewers: zturner, asmith, stella.stamenova, labath. aleksandr.urakov added a project: LLDB. Herald added subscribers: lldb-commits, teemperor, abidh. This patch adds a basic implementation of `DoAllocateMemory` and `DoDeallocateMemo

[Lldb-commits] [PATCH] D52604: Clean-up usage of OptionDefinition arrays

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: tools/driver/Driver.cpp:71 typedef struct { uint32_t usage_mask; // Used to mark options that can be used together. If (1 tatyana

[Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

aleksandr.urakov updated this revision to Diff 167338. aleksandr.urakov added a comment. Clang-format patch. https://reviews.llvm.org/D52618 Files: lit/Expr/TestIRMemoryMap.test lit/Expr/TestIRMemoryMapWindows.test source/Plugins/Process/Windows/Common/ProcessWindows.cpp source/Plugins/

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a few fixes. Looking good. Comment at: include/lldb/lldb-enumerations.h:643-660 + eSectionTypeDWARFDebugAbbrevDwo, eSectionTypeDWARFDebugAddr, eSect

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

clayborg added inline comments. Comment at: source/Symbol/Symtab.cpp:520 + return false; +} + This function is still pretty specific. Any comments on my above inlined comment? https://reviews.llvm.org/D52375 ___

[Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

clayborg added a comment. We really should be making a lldb-server that works on windows instead of making a native windows process plug-in that only works on windows. That will allow remote debugging to windows machines instead of requiring a local connection. It will also allows debug session

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Symbol/Symtab.cpp:520 + return false; +} + clayborg wrote: > This function is still pretty specific. Any comments on my above inlined > comment? Yes absolutely, but the same holds for most functions around her

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good then as long as all tests pass on Darwin. https://reviews.llvm.org/D52375 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:468 // situation. Check the line tables and build the arange table from this. SymbolContext sc; sc.comp_unit = dwarf->GetCompUnitForDWARFCompUnit(this); sgra

[Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

aleksandr.urakov added a comment. I didn't know about such a priority, thanks... But in this case `lldb-server` also must be able to allocate, read and write in a debuggee. Doesn't it use the process plugin for that? Or somehow duplicates this functionality? I have made some work on expressions

[Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

zturner added a subscriber: aleksandr.urakov. zturner added a comment. It requires a lot of work (nobody has started porting it). lldb-server exists on other platforms but it basically needs a full port to Windows. It doesn’t use the same process plugin, but it would instead use a different plugin

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:13 +# Set inputs empty, if not passed from the Python script. +CFLAGS ?= +LDFLAGS ?= This is a noop. You can remove it without affecting anything. ==

[Lldb-commits] [PATCH] D52626: [lldb] Remove an assertion in RichManglingContext::GetBufferRef() hit when debugging a native x86 Windows process

asmith created this revision. asmith added reviewers: aleksandr.urakov, zturner, lldb-commits. Herald added a subscriber: erik.pilkington. A RichManglingContext constructed with an invalid demangled name or with a demangled function name without any context will have an empty context. This trigg

[Lldb-commits] [PATCH] D52627: [lldb] Start a new line for the next output if there are no symbols in the current symtab

asmith created this revision. asmith added reviewers: zturner, aleksandr.urakov, lldb-commits. Repository: rLLDB LLDB https://reviews.llvm.org/D52627 Files: source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp source/Plugins/ExpressionParser/Clang/ClangUserExpression.h source/Sy

[Lldb-commits] [PATCH] D52468: [PDB] Treat `char`, `signed char` and `unsigned char` as three different types

asmith accepted this revision. asmith added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB https://reviews.llvm.org/D52468 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:22 +# Everything goes as .o files directly to the linker +C_SOURCES := + dexonsmith wrote: > aprantl wrote: > > same here, just remove it > I haven't read the ful

[Lldb-commits] [PATCH] D52468: [PDB] Treat `char`, `signed char` and `unsigned char` as three different types

zturner accepted this revision. zturner added a comment. Can you change the description of the patch before submitting it? It's hard to understand why the change does what the description says it does, because the description mentions 3 types of chars but the patch only handles 1. I would jus

[Lldb-commits] [PATCH] D52627: [lldb] Start a new line for the next output if there are no symbols in the current symtab

zturner added a comment. Couple of options: 1. Can you give an example of before/after output? 2. Is the `size_t` change related? 3. Can you use -U99 in the future when generating patches? Repository: rLLDB LLDB https://reviews.llvm.org/D52627 _

[Lldb-commits] [PATCH] D52627: [lldb] Start a new line for the next output if there are no symbols in the current symtab

zturner added a comment. s/options/comments/ Repository: rLLDB LLDB https://reviews.llvm.org/D52627 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52626: [lldb] Remove an assertion in RichManglingContext::GetBufferRef() hit when debugging a native x86 Windows process

zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. BTW, I wrote a demangler for Windows ABI that should be 100% complete modulo bugs and can generate an AST that RichManglingContext should use. So it would be interesting if someone decided

[Lldb-commits] [PATCH] D52468: [PDB] Treat `char`, `signed char` and `unsigned char` as three different types

aleksandr.urakov added a comment. Yes, sure! Thanks all! Repository: rLLDB LLDB https://reviews.llvm.org/D52468 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52468: [PDB] Treat `char`, `signed char` and `unsigned char` as three different types

This revision was automatically updated to reflect the committed changes. Closed by commit rL343298: [PDB] Handle `char` as a builtin type (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52468?vs=166876&i

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar added inline comments. Comment at: include/lldb/lldb-enumerations.h:643-660 + eSectionTypeDWARFDebugAbbrevDwo, eSectionTypeDWARFDebugAddr, eSectionTypeDWARFDebugAranges, eSectionTypeDWARFDebugCuIndex, eSectionTypeDWARFDebugFrame, eSectionTypeDWARFDebugInfo,

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar updated this revision to Diff 167440. grimar marked an inline comment as done. grimar added a comment. - Addressed review comments. https://reviews.llvm.org/D52403 Files: include/lldb/lldb-enumerations.h lit/Breakpoint/Inputs/single-file-split-dwarf.o.yaml lit/Breakpoint/Inputs/sin

[Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

aleksandr.urakov added a comment. Thanks for explanations! Unfortunately I can't promise that I'll begin porting `lldb-server` on Windows in the nearest future. I've looked at my working copy, and there are only two small changes related to `ProcessWindows` plugin (but they are not related to

[Lldb-commits] [PATCH] D52604: Clean-up usage of OptionDefinition arrays

tatyana-krasnukha updated this revision to Diff 167475. tatyana-krasnukha added a comment. Modifies Driver::ParseArgs checks Repository: rLLDB LLDB https://reviews.llvm.org/D52604 Files: include/lldb/Target/Platform.h source/Commands/CommandObjectDisassemble.h source/Commands/CommandOb

[Lldb-commits] [PATCH] D52604: Clean-up usage of OptionDefinition arrays

tatyana-krasnukha added inline comments. Comment at: tools/driver/Driver.cpp:581-585 + if (g_num_options == 0) { if (argc > 1) error.SetErrorStringWithFormat("invalid number of options"); return error; } clayborg wrote: > Do we even need this

[Lldb-commits] [PATCH] D52651: Add functionality to export settings

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, jingham, teemperor. JDevlieghere added a project: LLDB. For the reproducer feature I need to be able to export and import the current LLDB configuration. To realize this I've extended the existing functionality to print

[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

aleksandr.urakov added a reviewer: clayborg. aleksandr.urakov added a comment. In https://reviews.llvm.org/D52461#1245058, @clayborg wrote: > Try to use and extend CPlusPlusLanguage::MethodName as needed. I believe it > was recently backed by a new clang parser that knows how to chop up C++ > d

<    5   6   7   8   9   10   11   12   13   14   >