[Lldb-commits] [lldb] r306669 - Make scripts/analyze-project-deps.py executable

Author: labath Date: Thu Jun 29 06:02:15 2017 New Revision: 306669 URL: http://llvm.org/viewvc/llvm-project?rev=306669&view=rev Log: Make scripts/analyze-project-deps.py executable Modified: lldb/trunk/scripts/analyze-project-deps.py (contents, props changed) Modified: lldb/trunk/scripts/a

[Lldb-commits] [lldb] r306682 - Move Timer and TraceOptions from Core to Utility

Author: labath Date: Thu Jun 29 07:32:17 2017 New Revision: 306682 URL: http://llvm.org/viewvc/llvm-project?rev=306682&view=rev Log: Move Timer and TraceOptions from Core to Utility Summary: The classes have no dependencies, and they are used both by lldb and lldb-server, so it makes sense for th

[Lldb-commits] [lldb] r306683 - Android.rules: build x86 tests with -mstackrealign

Author: labath Date: Thu Jun 29 07:32:23 2017 New Revision: 306683 URL: http://llvm.org/viewvc/llvm-project?rev=306683&view=rev Log: Android.rules: build x86 tests with -mstackrealign All android builds systems have switched to -mstackrealign for building x86 binaries, so follow their cue with ou

[Lldb-commits] [lldb] r306686 - Fix Mac build for the Timer move

Author: labath Date: Thu Jun 29 08:24:38 2017 New Revision: 306686 URL: http://llvm.org/viewvc/llvm-project?rev=306686&view=rev Log: Fix Mac build for the Timer move Modified: lldb/trunk/source/Host/macosx/Symbols.cpp lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp M

[Lldb-commits] [lldb] r306693 - Speculative fix for windows build broken by r306668

Author: labath Date: Thu Jun 29 09:15:42 2017 New Revision: 306693 URL: http://llvm.org/viewvc/llvm-project?rev=306693&view=rev Log: Speculative fix for windows build broken by r306668 Modified: lldb/trunk/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp Modified: lldb/trunk/unittests/SymbolF

[Lldb-commits] [lldb] r306802 - Fix a cmake typo to unbreak windows unit tests

Author: labath Date: Fri Jun 30 00:54:35 2017 New Revision: 306802 URL: http://llvm.org/viewvc/llvm-project?rev=306802&view=rev Log: Fix a cmake typo to unbreak windows unit tests Modified: lldb/trunk/unittests/SymbolFile/PDB/CMakeLists.txt Modified: lldb/trunk/unittests/SymbolFile/PDB/CMake

[Lldb-commits] [lldb] r306817 - Remove dead Core/StreamFile includes

Author: labath Date: Fri Jun 30 04:31:13 2017 New Revision: 306817 URL: http://llvm.org/viewvc/llvm-project?rev=306817&view=rev Log: Remove dead Core/StreamFile includes Modified: lldb/trunk/source/Host/freebsd/Host.cpp lldb/trunk/source/Host/macosx/Host.mm lldb/trunk/source/Host/netb

[Lldb-commits] [lldb] r307009 - Use llvm::sys::RetryAfterSignal instead of a manual while errno!=EINTR loop

Author: labath Date: Mon Jul 3 02:25:55 2017 New Revision: 307009 URL: http://llvm.org/viewvc/llvm-project?rev=307009&view=rev Log: Use llvm::sys::RetryAfterSignal instead of a manual while errno!=EINTR loop Reviewers: zturner, eugene, krytarowski Subscribers: emaste, mgorny, lldb-commits Diff

[Lldb-commits] [lldb] r307018 - Fix typo/unbreak windows build broken by r307009

Author: labath Date: Mon Jul 3 04:01:49 2017 New Revision: 307018 URL: http://llvm.org/viewvc/llvm-project?rev=307018&view=rev Log: Fix typo/unbreak windows build broken by r307009 Modified: lldb/trunk/source/Host/common/File.cpp Modified: lldb/trunk/source/Host/common/File.cpp URL: http:/

[Lldb-commits] [lldb] r307072 - Update lldb architecture docs

Author: labath Date: Tue Jul 4 05:29:34 2017 New Revision: 307072 URL: http://llvm.org/viewvc/llvm-project?rev=307072&view=rev Log: Update lldb architecture docs Summary: Due to recent refactors, the descriptions of various modules were wildly out of date. With this patch, I am not trying to leg

[Lldb-commits] [lldb] r307071 - Fix some warnings in ProcessorTraceTest.cpp

Author: labath Date: Tue Jul 4 05:29:30 2017 New Revision: 307071 URL: http://llvm.org/viewvc/llvm-project?rev=307071&view=rev Log: Fix some warnings in ProcessorTraceTest.cpp Modified: lldb/trunk/unittests/Process/Linux/ProcessorTraceTest.cpp Modified: lldb/trunk/unittests/Process/Linux/Pr

[Lldb-commits] [lldb] r307160 - Fix "process load" on new android targets

Author: labath Date: Wed Jul 5 07:54:41 2017 New Revision: 307160 URL: http://llvm.org/viewvc/llvm-project?rev=307160&view=rev Log: Fix "process load" on new android targets Summary: On older android targets, we needed a dlopen rename workaround to get "process load" working. Since API 26 this i

[Lldb-commits] [lldb] r307161 - Fix assorted compiler warnings (mismatched signedness and printf specifiers)

Author: labath Date: Wed Jul 5 07:54:46 2017 New Revision: 307161 URL: http://llvm.org/viewvc/llvm-project?rev=307161&view=rev Log: Fix assorted compiler warnings (mismatched signedness and printf specifiers) Modified: lldb/trunk/source/Commands/CommandObjectThread.cpp lldb/trunk/source/

[Lldb-commits] [lldb] r307253 - Fix a copy-paste error in r307161

Author: labath Date: Thu Jul 6 04:43:25 2017 New Revision: 307253 URL: http://llvm.org/viewvc/llvm-project?rev=307253&view=rev Log: Fix a copy-paste error in r307161 Modified: lldb/trunk/tools/lldb-server/lldb-platform.cpp Modified: lldb/trunk/tools/lldb-server/lldb-platform.cpp URL: http:

[Lldb-commits] [lldb] r307252 - Revert "Android.rules: build x86 tests with -mstackrealign"

Author: labath Date: Thu Jul 6 04:43:20 2017 New Revision: 307252 URL: http://llvm.org/viewvc/llvm-project?rev=307252&view=rev Log: Revert "Android.rules: build x86 tests with -mstackrealign" Starting with android ndk r15, clang much more tests are affected by the -mstackrealign bugl (now nearly

Re: [Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

On 6 July 2017 at 18:40, Bruno Rosa via Phabricator wrote: > brunoalr added a comment. > > In https://reviews.llvm.org/D35065#800877, @krytarowski wrote: > >> What are the build failures? > > > > > [2397/3183] Building CXX object > tools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/CMakeFiles/l

[Lldb-commits] [lldb] r307390 - Add a NativeProcessProtocol Factory class

Author: labath Date: Fri Jul 7 04:02:19 2017 New Revision: 307390 URL: http://llvm.org/viewvc/llvm-project?rev=307390&view=rev Log: Add a NativeProcessProtocol Factory class Summary: This replaces the static functions used for creating NativeProcessProtocol instances with a factory pattern, and

[Lldb-commits] [lldb] r307391 - Disable TestGoASTContext

Author: labath Date: Fri Jul 7 04:02:28 2017 New Revision: 307391 URL: http://llvm.org/viewvc/llvm-project?rev=307391&view=rev Log: Disable TestGoASTContext it fails with go 1.8 and we don't seem to have a maintainer of that functionality. Modified: lldb/trunk/packages/Python/lldbsuite/test

[Lldb-commits] [lldb] r307632 - [LLDB][ppc64le] Rename enums in AuxVector

Author: labath Date: Tue Jul 11 01:39:44 2017 New Revision: 307632 URL: http://llvm.org/viewvc/llvm-project?rev=307632&view=rev Log: [LLDB][ppc64le] Rename enums in AuxVector Summary: On linux on ppc64le some of the enums in AuxVector have the same name as macros defined in the system. Reviewers

[Lldb-commits] [lldb] r307636 - NativeProcessLinux: Fix some compiler warnings

Author: labath Date: Tue Jul 11 02:03:38 2017 New Revision: 307636 URL: http://llvm.org/viewvc/llvm-project?rev=307636&view=rev Log: NativeProcessLinux: Fix some compiler warnings Modified: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/trunk/source/Plu

[Lldb-commits] [lldb] r307644 - NativeProcessLinux: Fix handling of raise(SIGTRAP)

Author: labath Date: Tue Jul 11 03:38:40 2017 New Revision: 307644 URL: http://llvm.org/viewvc/llvm-project?rev=307644&view=rev Log: NativeProcessLinux: Fix handling of raise(SIGTRAP) In NativeProcessLinux::MonitorSIGTRAP we were asserting that the si_code value is one of the codes we know about.

Re: [Lldb-commits] [lldb] r247852 - Add an OperatingSystem plugin to support goroutines

Hi Jason, I believe Ryan is no longer working for google. Since the go plugin was his effort, I think that unfortunately leaves our go support without a maintainer. (Unless he happens to be reading this from a personal email). I have also recently disabled one of the go tests because it was failin

[Lldb-commits] [lldb] r308282 - Remove shared pointer from NativeProcessProtocol

Author: labath Date: Tue Jul 18 02:24:48 2017 New Revision: 308282 URL: http://llvm.org/viewvc/llvm-project?rev=308282&view=rev Log: Remove shared pointer from NativeProcessProtocol Summary: The usage of shared_from_this forces us to separate construction and initialization phases, because shared

[Lldb-commits] [lldb] r308292 - Fix linux arm and mips builds broken by r308282

Author: labath Date: Tue Jul 18 03:42:36 2017 New Revision: 308292 URL: http://llvm.org/viewvc/llvm-project?rev=308292&view=rev Log: Fix linux arm and mips builds broken by r308282 Modified: lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp lldb/trunk/source/Pl

[Lldb-commits] [lldb] r308304 - Clean up lldb-types.h

Author: labath Date: Tue Jul 18 06:14:01 2017 New Revision: 308304 URL: http://llvm.org/viewvc/llvm-project?rev=308304&view=rev Log: Clean up lldb-types.h Summary: It defined a couple of types (condition_t) which we don't use anymore, as we have c++11 goodies now. I remove these definitions. Als

[Lldb-commits] [lldb] r308307 - Fix NetBSD/FreeBSD build after r308304

Author: labath Date: Tue Jul 18 07:03:47 2017 New Revision: 308307 URL: http://llvm.org/viewvc/llvm-project?rev=308307&view=rev Log: Fix NetBSD/FreeBSD build after r308304 Modified: lldb/trunk/source/Host/common/Host.cpp lldb/trunk/source/Host/common/MainLoop.cpp lldb/trunk/source/Hos

[Lldb-commits] [lldb] r308732 - XFail TestWithModuleDebugging on linux (bug 33875)

Author: labath Date: Fri Jul 21 05:51:37 2017 New Revision: 308732 URL: http://llvm.org/viewvc/llvm-project?rev=308732&view=rev Log: XFail TestWithModuleDebugging on linux (bug 33875) Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/gmodules/TestWithModuleDebugging.py Modified:

Re: [Lldb-commits] [PATCH] D38938: Logging: provide a way to safely disable logging in a forked process

On 15 October 2017 at 23:04, Zachary Turner wrote: > Doesn’t DisableAllLogChannels acquire a scoped lock? If so wouldn’t it just > release at the end of the function? The thing is, it is unable to acquire the lock in the first place, because the mutex is already "locked". So, the sequence of eve

Re: [Lldb-commits] [PATCH] D38938: Logging: provide a way to safely disable logging in a forked process

On 15 October 2017 at 23:59, Zachary Turner wrote: > what are we using fork for, out of curiosity? It seems pretty hard to make > this work. Logging isn’t the only thing in the program that might be > holding a mutex, so it seems like this could still happen. > > Seems like mixing fork and mutex

[Lldb-commits] [lldb] r316007 - Remove shared_pointer from NativeThreadProtocol

Author: labath Date: Tue Oct 17 08:52:16 2017 New Revision: 316007 URL: http://llvm.org/viewvc/llvm-project?rev=316007&view=rev Log: Remove shared_pointer from NativeThreadProtocol Summary: The NativeThread class is useless without the containing process (and in some places it is already assuming

[Lldb-commits] [lldb] r316010 - lldb-server tests: Add support for testing debugserver

Author: labath Date: Tue Oct 17 09:28:28 2017 New Revision: 316010 URL: http://llvm.org/viewvc/llvm-project?rev=316010&view=rev Log: lldb-server tests: Add support for testing debugserver Summary: This adds support for running the lldb-server test suite (currently consisting of only one test) aga

[Lldb-commits] [lldb] r316038 - Silence some "implicit conversion of string literal" warnings

Author: labath Date: Tue Oct 17 14:52:29 2017 New Revision: 316038 URL: http://llvm.org/viewvc/llvm-project?rev=316038&view=rev Log: Silence some "implicit conversion of string literal" warnings Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp lldb/trunk/sourc

[Lldb-commits] [lldb] r316106 - lldb-server tests: Fix undefined behavior

Author: labath Date: Wed Oct 18 11:52:16 2017 New Revision: 316106 URL: http://llvm.org/viewvc/llvm-project?rev=316106&view=rev Log: lldb-server tests: Fix undefined behavior We were creating a StringRef pointing to a temporary string. Problem manifested itself when running the test on osx. Modi

[Lldb-commits] [lldb] r316173 - Logging: Make sure logging machinery is in a consistent state after forking

Author: labath Date: Thu Oct 19 10:40:51 2017 New Revision: 316173 URL: http://llvm.org/viewvc/llvm-project?rev=316173&view=rev Log: Logging: Make sure logging machinery is in a consistent state after forking Summary: We had a bug where if we had forked (in the ProcessLauncherPosixFork) while ano

[Lldb-commits] [lldb] r316231 - Revert "Logging: Make sure logging machinery is in a consistent state after forking"

Author: labath Date: Fri Oct 20 12:44:53 2017 New Revision: 316231 URL: http://llvm.org/viewvc/llvm-project?rev=316231&view=rev Log: Revert "Logging: Make sure logging machinery is in a consistent state after forking" The pthread_atfork trick breaks on android, because pthread_rwlock_unlock dete

[Lldb-commits] [lldb] r316244 - lldb-server tests: Propagate environment variables (pr34192)

Author: labath Date: Fri Oct 20 15:39:18 2017 New Revision: 316244 URL: http://llvm.org/viewvc/llvm-project?rev=316244&view=rev Log: lldb-server tests: Propagate environment variables (pr34192) Summary: Without this, the launching of the test inferior may fail if it depends on some component of t

[Lldb-commits] [lldb] r316368 - Logging: Disable logging after fork()

Author: labath Date: Mon Oct 23 12:41:17 2017 New Revision: 316368 URL: http://llvm.org/viewvc/llvm-project?rev=316368&view=rev Log: Logging: Disable logging after fork() Summary: We had a bug where if we had forked (in the ProcessLauncherPosixFork) while another thread was writing a log message,

[Lldb-commits] [lldb] r316391 - Use ipv4 localhost address in lldb-server tests

Author: labath Date: Mon Oct 23 16:15:37 2017 New Revision: 316391 URL: http://llvm.org/viewvc/llvm-project?rev=316391&view=rev Log: Use ipv4 localhost address in lldb-server tests Since the ipv6 patch, we've experienced occasional flakyness in lldb-server tests. This was due to the fact that lld

[Lldb-commits] [lldb] r316451 - Revert "[lldbtests] Handle errors instead of crashing."

Author: labath Date: Tue Oct 24 09:07:50 2017 New Revision: 316451 URL: http://llvm.org/viewvc/llvm-project?rev=316451&view=rev Log: Revert "[lldbtests] Handle errors instead of crashing." The commit breaks the case where you specify just a filename to the compiler. Previously, it would look up t

Re: [Lldb-commits] [PATCH] D39215: Default to using in-tree clang for building test executables

On 24 October 2017 at 08:58, Ted Woodward via Phabricator wrote: > ted added a comment. > > We build lldb, clang and tools for Hexagon only, and call them hexagon-lldb, > hexagon-clang, etc. The test infrastructure is smart enough to pick up > hexagon-lldb-mi if we tell it to run with hexagon-ll

Re: [Lldb-commits] [lldb] r316451 - Revert "[lldbtests] Handle errors instead of crashing."

The breaking build is this one: < http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/14775> The blame email was sent (I know because I got it, as I also had a commit in the same build). Is it possible you overlooked it? ``` def is_exe(fpath): if not os.path.exists(fpath):

[Lldb-commits] [lldb] r316609 - Move StopInfoOverride callback to the new architecture plugin

Author: labath Date: Wed Oct 25 14:05:31 2017 New Revision: 316609 URL: http://llvm.org/viewvc/llvm-project?rev=316609&view=rev Log: Move StopInfoOverride callback to the new architecture plugin This creates a new Architecture plugin and moves the stop info override callback to this place. The mo

[Lldb-commits] [lldb] r316629 - Makefile.rules: move CFLAGS_EXTRAS to the end of compile line

Author: labath Date: Wed Oct 25 16:56:17 2017 New Revision: 316629 URL: http://llvm.org/viewvc/llvm-project?rev=316629&view=rev Log: Makefile.rules: move CFLAGS_EXTRAS to the end of compile line This makes sure that any options specified there override generic compiler options. This fixes TestBr

[Lldb-commits] [lldb] r316688 - Fix TestMinidump for r316673

Author: labath Date: Thu Oct 26 12:08:34 2017 New Revision: 316688 URL: http://llvm.org/viewvc/llvm-project?rev=316688&view=rev Log: Fix TestMinidump for r316673 The test was asserting that we can only find one frame in the minidump. Now that we have the default unwind plan from the ABI plugin, w

Re: [Lldb-commits] [PATCH] D39215: Default to using in-tree clang for building test executables

I haven't put this in yet. I was still waiting for a reaction from Zachary about the two cmake vars, as he felt pretty strongly about unifying to one. (I didn't want to do that as I would have to write code for transforming /usr/bin/arm-linux-gnu-gcc-4.7 (and likes) into /usr/bin/arm-linux-gnu-g++-

[Lldb-commits] [lldb] r316728 - Default to using in-tree clang for building test executables

Author: labath Date: Thu Oct 26 19:24:04 2017 New Revision: 316728 URL: http://llvm.org/viewvc/llvm-project?rev=316728&view=rev Log: Default to using in-tree clang for building test executables Summary: Using the in-tree clang should be the default test configuration as that is the one compiler t

[Lldb-commits] [lldb] r316740 - Fix a use-after-free in lldb-server

Author: labath Date: Thu Oct 26 21:53:24 2017 New Revision: 316740 URL: http://llvm.org/viewvc/llvm-project?rev=316740&view=rev Log: Fix a use-after-free in lldb-server UriParser::Parse is returning a StringRef pointing the the parsed string, but we were calling it with a temporary string. Change

[Lldb-commits] [lldb] r316772 - Add specific ppc64le hardware watchpoint handler

Author: labath Date: Fri Oct 27 10:02:32 2017 New Revision: 316772 URL: http://llvm.org/viewvc/llvm-project?rev=316772&view=rev Log: Add specific ppc64le hardware watchpoint handler Summary: Add hardware watchpoint funcionality for ppc64le Reviewers: clayborg, zturner Reviewed By: clayborg Sub

[Lldb-commits] [lldb] r316915 - MainLoop: work around an android libc bug

Author: labath Date: Mon Oct 30 09:00:13 2017 New Revision: 316915 URL: http://llvm.org/viewvc/llvm-project?rev=316915&view=rev Log: MainLoop: work around an android libc bug Versions of android before kitkat implemented pselect non-atomically, which caused flakyness, as we were relying on it ato

[Lldb-commits] [lldb] r316919 - Fix windows build broken in r316915

Author: labath Date: Mon Oct 30 09:21:18 2017 New Revision: 316919 URL: http://llvm.org/viewvc/llvm-project?rev=316919&view=rev Log: Fix windows build broken in r316915 I accidentally left a linux-specific include in generic code. Modified: lldb/trunk/source/Host/common/MainLoop.cpp Modifie

[Lldb-commits] [lldb] r316982 - Split makefile for TestTopLevelExprs

Author: labath Date: Tue Oct 31 03:01:30 2017 New Revision: 316982 URL: http://llvm.org/viewvc/llvm-project?rev=316982&view=rev Log: Split makefile for TestTopLevelExprs this test was using a single makefile to build two executables. This setup, although not supported by Makefile.rules, happened

[Lldb-commits] [lldb] r316985 - Android.rules: build with "unified android headers"

Author: labath Date: Tue Oct 31 03:33:03 2017 New Revision: 316985 URL: http://llvm.org/viewvc/llvm-project?rev=316985&view=rev Log: Android.rules: build with "unified android headers" Unified headers will be the only way to build applications in NDK r16, and it also works with NDK r15. This als

[Lldb-commits] [lldb] r316987 - Invert ArchSpec<->Platform dependency

Author: labath Date: Tue Oct 31 03:56:03 2017 New Revision: 316987 URL: http://llvm.org/viewvc/llvm-project?rev=316987&view=rev Log: Invert ArchSpec<->Platform dependency Summary: ArchSpec::SetTriple was taking a Platform as an argument, and used it to fill in missing pieces of the specified trip

[Lldb-commits] [lldb] r316990 - Fix mac build broken in r316987

Author: labath Date: Tue Oct 31 04:48:33 2017 New Revision: 316990 URL: http://llvm.org/viewvc/llvm-project?rev=316990&view=rev Log: Fix mac build broken in r316987 Forgot one occurence of ArchSpec::SetTriple in mac-specific code. Modified: lldb/trunk/source/Plugins/Process/mach-core/Process

[Lldb-commits] [lldb] r316992 - Add data formatter for libc++'s forward_list

Author: labath Date: Tue Oct 31 05:27:43 2017 New Revision: 316992 URL: http://llvm.org/viewvc/llvm-project?rev=316992&view=rev Log: Add data formatter for libc++'s forward_list Summary: This adds a data formatter for the implementation of forward_list in libc++. I've refactored the existing std:

[Lldb-commits] [lldb] r316993 - Increase AdbClient read timeout

Author: labath Date: Tue Oct 31 05:27:46 2017 New Revision: 316993 URL: http://llvm.org/viewvc/llvm-project?rev=316993&view=rev Log: Increase AdbClient read timeout The previous value was not sufficient for Pixel 2 phones. One would have hoped that the newer phones are faster, but that does not s

[Lldb-commits] [lldb] r316997 - Fix LLVM_LINK_LLVM_DYLIB build (pr35053)

Author: labath Date: Tue Oct 31 06:23:19 2017 New Revision: 316997 URL: http://llvm.org/viewvc/llvm-project?rev=316997&view=rev Log: Fix LLVM_LINK_LLVM_DYLIB build (pr35053) Summary: r316368 broke this build when it introduced a reference to a pthread function to the Utility module. This caused c

Re: [Lldb-commits] [lldb] r316740 - Fix a use-after-free in lldb-server

On 31 October 2017 at 15:12, Zachary Turner via lldb-commits wrote: > The takeaway from this example is nothing we don't already know. We need > better test coverage. Actually, this was caught by a test (pretty much all of them), but only when building with libc++, as the code was "safe" with lib

[Lldb-commits] [lldb] r317004 - Add a "watchpoint" test category and annotate tests appropriately

Author: labath Date: Tue Oct 31 08:27:19 2017 New Revision: 317004 URL: http://llvm.org/viewvc/llvm-project?rev=317004&view=rev Log: Add a "watchpoint" test category and annotate tests appropriately Most of the watchpoint tests are organized into subtrees, so we can use the file-based .categories

Re: [Lldb-commits] [lldb] r316740 - Fix a use-after-free in lldb-server

libstdc++-4.8 I think the newest versions have a conformant implementation, but I don't know the full details (I know it was a complicated change because of the need to maintain binary compatibility). Our android tests are now runinng lldb-server built with libc++ (which is how I found the bug).

[Lldb-commits] [lldb] r317093 - Remove uint32_t assignment operator from Status

Author: labath Date: Wed Nov 1 08:00:58 2017 New Revision: 317093 URL: http://llvm.org/viewvc/llvm-project?rev=317093&view=rev Log: Remove uint32_t assignment operator from Status Summary: It is not presently used, and it's quite dangerous to use -- it assumes the integer is an osx kern_return_t

[Lldb-commits] [lldb] r317095 - Add data formatter for libc++ std::tuple

Author: labath Date: Wed Nov 1 08:19:52 2017 New Revision: 317095 URL: http://llvm.org/viewvc/llvm-project?rev=317095&view=rev Log: Add data formatter for libc++ std::tuple Reviewers: jingham, EricWF Subscribers: srhines, eugene, lldb-commits, mgorny Differential Revision: https://reviews.llvm

[Lldb-commits] [lldb] r317099 - Add data formatter for libc++ std::queue

Author: labath Date: Wed Nov 1 08:52:08 2017 New Revision: 317099 URL: http://llvm.org/viewvc/llvm-project?rev=317099&view=rev Log: Add data formatter for libc++ std::queue Summary: std::queue is just a fancy wrapper around another container, so all we need to do is to delegate to the it. Revie

[Lldb-commits] [lldb] r317130 - dotest: consistently call finalize_build_dictionary in debug info variants

Author: labath Date: Wed Nov 1 15:01:03 2017 New Revision: 317130 URL: http://llvm.org/viewvc/llvm-project?rev=317130&view=rev Log: dotest: consistently call finalize_build_dictionary in debug info variants dwarf&dwo versions were doing it, but gmodules and dsym weren't. All this function does r

[Lldb-commits] [lldb] r317270 - Fix some warnings found by ToT clang

Author: labath Date: Thu Nov 2 14:35:26 2017 New Revision: 317270 URL: http://llvm.org/viewvc/llvm-project?rev=317270&view=rev Log: Fix some warnings found by ToT clang These fall into two categories: - unused variables - (uint8_t *)NULL + X -- changed to reinterpret_cast(X) Modified: lldb/

[Lldb-commits] [lldb] r317276 - Remove android watchpoint xfails

Author: labath Date: Thu Nov 2 15:12:55 2017 New Revision: 317276 URL: http://llvm.org/viewvc/llvm-project?rev=317276&view=rev Log: Remove android watchpoint xfails Now that the wathpoint tests have their own category, we can easily skip them on devices which don't have watchpoint support. There

[Lldb-commits] [lldb] r317277 - Remove getCategories mechanism of specifying test categories

Author: labath Date: Thu Nov 2 15:13:09 2017 New Revision: 317277 URL: http://llvm.org/viewvc/llvm-project?rev=317277&view=rev Log: Remove getCategories mechanism of specifying test categories Summary: This mechanism was mostly redundant with the file-based .categories mechanism, and it was inte

[Lldb-commits] [lldb] r350742 - ELF: create "container" sections from PT_LOAD segments

Author: labath Date: Wed Jan 9 08:50:45 2019 New Revision: 350742 URL: http://llvm.org/viewvc/llvm-project?rev=350742&view=rev Log: ELF: create "container" sections from PT_LOAD segments Summary: This is the result of the discussion in D55356, where it was suggested as a solution to representing

[Lldb-commits] [lldb] r350802 - Add a verbose mode to "image dump line-table" and use it to write a .debug_line test

Author: labath Date: Thu Jan 10 01:16:00 2019 New Revision: 350802 URL: http://llvm.org/viewvc/llvm-project?rev=350802&view=rev Log: Add a verbose mode to "image dump line-table" and use it to write a .debug_line test Summary: The motivation for this is being able to write tests for the upcoming

[Lldb-commits] [lldb] r350804 - Implement ObjectFileELF::GetBaseAddress

Author: labath Date: Thu Jan 10 01:32:31 2019 New Revision: 350804 URL: http://llvm.org/viewvc/llvm-project?rev=350804&view=rev Log: Implement ObjectFileELF::GetBaseAddress Summary: The concept of a base address was already present in the implementation (it's needed for computing section load add

[Lldb-commits] [lldb] r350810 - Revert "Add a verbose mode to "image dump line-table" and use it to write a .debug_line test"

Author: labath Date: Thu Jan 10 02:23:27 2019 New Revision: 350810 URL: http://llvm.org/viewvc/llvm-project?rev=350810&view=rev Log: Revert "Add a verbose mode to "image dump line-table" and use it to write a .debug_line test" This reverts commit r350802 because the test fails on windows. This h

[Lldb-commits] [lldb] r350809 - PECOFF: Fix section name computation

Author: labath Date: Thu Jan 10 02:23:19 2019 New Revision: 350809 URL: http://llvm.org/viewvc/llvm-project?rev=350809&view=rev Log: PECOFF: Fix section name computation If a section name is exactly 8 bytes long (or has been truncated to 8 bytes), it will not contain the terminating nul character

[Lldb-commits] [lldb] r350834 - Fix compilation error on 32-bit architectures introduced in r350511

Author: labath Date: Thu Jan 10 07:53:20 2019 New Revision: 350834 URL: http://llvm.org/viewvc/llvm-project?rev=350834&view=rev Log: Fix compilation error on 32-bit architectures introduced in r350511 The issue was a narrowing conversion when converting from uint64_t to a size_t. Modified: l

[Lldb-commits] [lldb] r350923 - ELF: Fix base address computation code for files generated by yaml2obj

Author: labath Date: Fri Jan 11 02:18:40 2019 New Revision: 350923 URL: http://llvm.org/viewvc/llvm-project?rev=350923&view=rev Log: ELF: Fix base address computation code for files generated by yaml2obj The code was assuming that the elf file will have a PT_LOAD segment starting from the first b

[Lldb-commits] [lldb] r350924 - Introduce SymbolFileBreakpad and use it to fill symtab

Author: labath Date: Fri Jan 11 03:17:51 2019 New Revision: 350924 URL: http://llvm.org/viewvc/llvm-project?rev=350924&view=rev Log: Introduce SymbolFileBreakpad and use it to fill symtab Summary: This commit adds the glue code necessary to integrate the SymbolFileBreakpad into the plugin system.

[Lldb-commits] [lldb] r350947 - Attempt to fix PDB tests broken by r350924

Author: labath Date: Fri Jan 11 10:24:17 2019 New Revision: 350947 URL: http://llvm.org/viewvc/llvm-project?rev=350947&view=rev Log: Attempt to fix PDB tests broken by r350924 The patch added the symbol plugin name to the lldb-test output. Update the tests to account for that. Modified: lldb

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

Hi Adrian, Zachary, this commit breaks the SymbolFile/NativePDB/function-types-builtins.cpp test . This is due do a slight behavioral change where previously this function would consider a value 0 from GetByteSize to be fail

[Lldb-commits] [lldb] r351327 - Revert "Simplify Value::GetValueByteSize()"

Author: labath Date: Wed Jan 16 04:19:22 2019 New Revision: 351327 URL: http://llvm.org/viewvc/llvm-project?rev=351327&view=rev Log: Revert "Simplify Value::GetValueByteSize()" This reverts commit r351250 because it breaks the SymbolFile/NativePDB/function-types-builtins.cpp. Modified: lldb/

[Lldb-commits] [lldb] r351328 - DWARF: Add some support for non-native directory separators

Author: labath Date: Wed Jan 16 04:30:41 2019 New Revision: 351328 URL: http://llvm.org/viewvc/llvm-project?rev=351328&view=rev Log: DWARF: Add some support for non-native directory separators Summary: If we opened a file which was produced on system with different path syntax, we would parse the

[Lldb-commits] [lldb] r351331 - TestClangASTContext: Rewrite an if-else chain into a switch

Author: labath Date: Wed Jan 16 04:43:01 2019 New Revision: 351331 URL: http://llvm.org/viewvc/llvm-project?rev=351331&view=rev Log: TestClangASTContext: Rewrite an if-else chain into a switch This avoids the "ambiguous else" warning, which comes from within the EXPECT_TRUE macro. Modified:

[Lldb-commits] [lldb] r351330 - Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()

Author: labath Date: Wed Jan 16 04:42:57 2019 New Revision: 351330 URL: http://llvm.org/viewvc/llvm-project?rev=351330&view=rev Log: Teach the default symbol vendor to respect module.GetSymbolFileFileSpec() Summary: Adding a breakpad symbol file to an existing MachO module with "target symbols ad

[Lldb-commits] [lldb] r351353 - Revert "Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()"

Author: labath Date: Wed Jan 16 08:09:13 2019 New Revision: 351353 URL: http://llvm.org/viewvc/llvm-project?rev=351353&view=rev Log: Revert "Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()" This reverts commit r351330 due to failures on MacOS bots. Removed: lldb/tr

Re: [Lldb-commits] [PATCH] D56589: Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()

On 16/01/2019 17:07, Adrian Prantl via Phabricator wrote: aprantl added a comment. Looks like this test is failing on green dragon: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/17221/consoleFull#-97272088254eaf0-7326-4999-85b0-388101f2d404 Ooops. I reverted this in r351353. I'll i

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

On 16/01/2019 17:38, Adrian Prantl wrote: On Darwin I'm getting an also very misleading (lldb) target var ref (void (&)(bool)) ref = 0x00010920 (&::ref = ) Wait, no. I reverted the wrong patch:-( I get vs . I assume that's what's happening on Windows, too. If that's the case I should

[Lldb-commits] [lldb] r351359 - Fix dir-separator-no-comp-dir-relative-name.s test added in r351328

Author: labath Date: Wed Jan 16 09:39:06 2019 New Revision: 351359 URL: http://llvm.org/viewvc/llvm-project?rev=351359&view=rev Log: Fix dir-separator-no-comp-dir-relative-name.s test added in r351328 In this test we have deliberately removed all information which may hint at the correct path sty

Re: [Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

On 16/01/2019 18:16, Stella Stamenova via Phabricator wrote: stella.stamenova added a comment. The Windows Buildbot is failing because of one of the tests (SymbolFile/DWARF/dir-separator-no-comp-dir-relative-name.s) added in this change. You can see the failure here: http://lab.llvm.org:8011/

[Lldb-commits] [lldb] r351435 - Recommit "Add a verbose mode to "image dump line-table" and use it to write a .debug_line test"

Author: labath Date: Thu Jan 17 05:11:04 2019 New Revision: 351435 URL: http://llvm.org/viewvc/llvm-project?rev=351435&view=rev Log: Recommit "Add a verbose mode to "image dump line-table" and use it to write a .debug_line test" This reapplies r350802, which was reverted because of issues with p

[Lldb-commits] [lldb] r351447 - Recommit "Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()"

Author: labath Date: Thu Jan 17 07:07:35 2019 New Revision: 351447 URL: http://llvm.org/viewvc/llvm-project?rev=351447&view=rev Log: Recommit "Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()" This reapplies commit r351330, which was reverted due to a failing test on mac

[Lldb-commits] [lldb] r351541 - Breakpad: Extract parsing code into a separate file

Author: labath Date: Fri Jan 18 02:37:04 2019 New Revision: 351541 URL: http://llvm.org/viewvc/llvm-project?rev=351541&view=rev Log: Breakpad: Extract parsing code into a separate file Summary: This centralizes parsing of breakpad records, which was previously spread out over ObjectFileBreakpad a

[Lldb-commits] [lldb] r351781 - breakpad: Add FUNC records to the symtab

Author: labath Date: Mon Jan 21 20:56:31 2019 New Revision: 351781 URL: http://llvm.org/viewvc/llvm-project?rev=351781&view=rev Log: breakpad: Add FUNC records to the symtab This patch extends SymbolFileBreakpad::AddSymbols to include the symbols from the FUNC records too. These symbols come from

[Lldb-commits] [lldb] r352021 - BreakpadRecords: Address post-commit feedback

Author: labath Date: Wed Jan 23 20:17:59 2019 New Revision: 352021 URL: http://llvm.org/viewvc/llvm-project?rev=352021&view=rev Log: BreakpadRecords: Address post-commit feedback Summary: This addresses the issues raised in D56844. It removes the accessors from the breakpad record structures by m

[Lldb-commits] [lldb] r352507 - BreakpadRecords: Add parsing code for FILE and LINE records

Author: labath Date: Tue Jan 29 07:39:27 2019 New Revision: 352507 URL: http://llvm.org/viewvc/llvm-project?rev=352507&view=rev Log: BreakpadRecords: Add parsing code for FILE and LINE records The two records aren't used by anything yet, but this part can be separated out easily, so I am comittin

[Lldb-commits] [lldb] r353047 - Move FileAction, ProcessInfo and ProcessLaunchInfo from Target to Host

Author: labath Date: Mon Feb 4 06:28:08 2019 New Revision: 353047 URL: http://llvm.org/viewvc/llvm-project?rev=353047&view=rev Log: Move FileAction, ProcessInfo and ProcessLaunchInfo from Target to Host Summary: These classes describe the details of the process we are about to launch, and so the

[Lldb-commits] [lldb] r353049 - Fixes for the ProcessLaunchInfo move

Author: labath Date: Mon Feb 4 07:03:06 2019 New Revision: 353049 URL: http://llvm.org/viewvc/llvm-project?rev=353049&view=rev Log: Fixes for the ProcessLaunchInfo move Modified: lldb/trunk/source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.h lldb/trunk/sourc

[Lldb-commits] [lldb] r353404 - SymbolFileBreakpad: Add line table support

Author: labath Date: Thu Feb 7 05:42:32 2019 New Revision: 353404 URL: http://llvm.org/viewvc/llvm-project?rev=353404&view=rev Log: SymbolFileBreakpad: Add line table support Summary: This patch teaches SymbolFileBreakpad to parse the line information in breakpad files and present it to lldb. T

[Lldb-commits] [lldb] r353405 - Fix some warnings introduced in r353324 (ReproducerInstrumentation patch)

Author: labath Date: Thu Feb 7 05:51:38 2019 New Revision: 353405 URL: http://llvm.org/viewvc/llvm-project?rev=353405&view=rev Log: Fix some warnings introduced in r353324 (ReproducerInstrumentation patch) GetIndexForObjectImpl generated a bunch of "conversion casts away constness warnings". Cha

[Lldb-commits] [lldb] r353406 - use_lldb_suite.py: Fix potential infinite loop

Author: labath Date: Thu Feb 7 06:03:43 2019 New Revision: 353406 URL: http://llvm.org/viewvc/llvm-project?rev=353406&view=rev Log: use_lldb_suite.py: Fix potential infinite loop The loop searching for use_lldb_suite_root had a bug where if the marker file happened to be missing, it would enter

[Lldb-commits] [lldb] r353410 - Breakpad: temporarily XFAIL line-table tests

Author: labath Date: Thu Feb 7 06:47:12 2019 New Revision: 353410 URL: http://llvm.org/viewvc/llvm-project?rev=353410&view=rev Log: Breakpad: temporarily XFAIL line-table tests The tests are failing on windows because the paths in the symbol file are parsed using the host path style. I'm working

[Lldb-commits] [lldb] r353419 - Fix incorrect log messages in NativeProcessLinux (pr40588)

Author: labath Date: Thu Feb 7 07:56:35 2019 New Revision: 353419 URL: http://llvm.org/viewvc/llvm-project?rev=353419&view=rev Log: Fix incorrect log messages in NativeProcessLinux (pr40588) The "signal" argument was removed from the MonitorCallback function, but not from the log statements with

[Lldb-commits] [lldb] r353420 - Fix signed/unsigned mismatches in ProcessInfoTest.cpp

Author: labath Date: Thu Feb 7 07:56:40 2019 New Revision: 353420 URL: http://llvm.org/viewvc/llvm-project?rev=353420&view=rev Log: Fix signed/unsigned mismatches in ProcessInfoTest.cpp Modified: lldb/trunk/unittests/Host/ProcessInfoTest.cpp Modified: lldb/trunk/unittests/Host/ProcessInfoTe

<    2   3   4   5   6   7   8   9   10   11   >