[Lldb-commits] [lldb] r331882 - Fix Windows build for the Predicate.h refactor in r331880

2018-05-09 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed May 9 07:49:43 2018 New Revision: 331882 URL: http://llvm.org/viewvc/llvm-project?rev=331882&view=rev Log: Fix Windows build for the Predicate.h refactor in r331880 Modified: lldb/trunk/source/Plugins/Process/Windows/Common/DebuggerThread.cpp Modified: lldb/trunk/so

[Lldb-commits] [lldb] r298061 - Speculative build fix for FreeBSD

2017-03-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Mar 17 05:09:56 2017 New Revision: 298061 URL: http://llvm.org/viewvc/llvm-project?rev=298061&view=rev Log: Speculative build fix for FreeBSD broken by r298058. Modified: lldb/trunk/source/Plugins/Process/FreeBSD/FreeBSDThread.cpp Modified: lldb/trunk/source/Plugins

[Lldb-commits] [lldb] r298063 - One more attempt to fix FreeBSD

2017-03-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Mar 17 05:30:42 2017 New Revision: 298063 URL: http://llvm.org/viewvc/llvm-project?rev=298063&view=rev Log: One more attempt to fix FreeBSD It seems sysctl.h is not self-contained, as I get missing symbols in the header itself now. I am going to include all files that the

[Lldb-commits] [lldb] r298066 - Move GetAuxvData from Host to relevant process plugins

2017-03-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Mar 17 06:08:40 2017 New Revision: 298066 URL: http://llvm.org/viewvc/llvm-project?rev=298066&view=rev Log: Move GetAuxvData from Host to relevant process plugins Summary: GetAuxvData was causing dependencies from host to target and linux process modules. It also does not

[Lldb-commits] [lldb] r298069 - Fix FreeBSD build broken by r298066

2017-03-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Mar 17 06:33:57 2017 New Revision: 298069 URL: http://llvm.org/viewvc/llvm-project?rev=298069&view=rev Log: Fix FreeBSD build broken by r298066 Modified: lldb/trunk/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp Modified: lldb/trunk/source/Plugins/Process/FreeBSD/

[Lldb-commits] [lldb] r298261 - Fix remote test suite directory creation

2017-03-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Mar 20 11:07:17 2017 New Revision: 298261 URL: http://llvm.org/viewvc/llvm-project?rev=298261&view=rev Log: Fix remote test suite directory creation r298203 make SBPlatform::MakeDirectory less recursive, which breaks the test suite creation of test directory hierarchy cre

Re: [Lldb-commits] [PATCH] D31129: Remove remaining platform specific code from FileSpec

2017-03-20 Thread Pavel Labath via lldb-commits
Aha, I see that now. What do you think about creating a test-only module that both unit tests can depend on? The llvm folder-globbing means we would have to put it in a subfolder (unittests/Utility/lib ?), which makes is somewhat annoying, but I still think that's better than having the test code i

[Lldb-commits] [lldb] r298375 - Replace std::ofstream with llvm::raw_fd_ostream

2017-03-21 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Mar 21 08:49:50 2017 New Revision: 298375 URL: http://llvm.org/viewvc/llvm-project?rev=298375&view=rev Log: Replace std::ofstream with llvm::raw_fd_ostream Summary: ofstream does not handle paths with non-ascii characters correctly on windows, so I am switching these to l

[Lldb-commits] [lldb] r298374 - Remove ProcFileReader

2017-03-21 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Mar 21 08:49:45 2017 New Revision: 298374 URL: http://llvm.org/viewvc/llvm-project?rev=298374&view=rev Log: Remove ProcFileReader This removes the last usage of ProcFileReader from NativeProcessLinux and then deletes the class itself. Removed: lldb/trunk/source/Plugi

[Lldb-commits] [lldb] r298509 - Revert "Delete the remainder of platform specific code in FileSpec."

2017-03-22 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 22 09:04:43 2017 New Revision: 298509 URL: http://llvm.org/viewvc/llvm-project?rev=298509&view=rev Log: Revert "Delete the remainder of platform specific code in FileSpec." This reverts commit r298465 as it breaks TestLLVM.TestHomeDirectory.test_tilde_home_directory.

[Lldb-commits] [lldb] r299028 - Centralize libc++ test skipping logic

2017-03-29 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Mar 29 16:01:14 2017 New Revision: 299028 URL: http://llvm.org/viewvc/llvm-project?rev=299028&view=rev Log: Centralize libc++ test skipping logic Summary: This aims to replace the different decorators we've had on each libc++ test with a single solution. Each libc++ will

[Lldb-commits] [lldb] r299588 - Annotate some more libc++ tests with the new category

2017-04-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 5 15:34:26 2017 New Revision: 299588 URL: http://llvm.org/viewvc/llvm-project?rev=299588&view=rev Log: Annotate some more libc++ tests with the new category This makes sure we are able to run them properly on android. Modified: lldb/trunk/packages/Python/lldbsu

[Lldb-commits] [lldb] r299933 - Remove Plugins/Process/POSIX from include_directories

2017-04-11 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Apr 11 07:26:25 2017 New Revision: 299933 URL: http://llvm.org/viewvc/llvm-project?rev=299933&view=rev Log: Remove Plugins/Process/POSIX from include_directories Summary: The files there can always be referred to using their full path, which is what most of the code has b

[Lldb-commits] [lldb] r299934 - Add missing annotation to TestDataFormatterUnordered

2017-04-11 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Apr 11 07:26:33 2017 New Revision: 299934 URL: http://llvm.org/viewvc/llvm-project?rev=299934&view=rev Log: Add missing annotation to TestDataFormatterUnordered Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libc

[Lldb-commits] [lldb] r300046 - Fix TestGuessLanguage for gcc

2017-04-12 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 12 05:13:50 2017 New Revision: 300046 URL: http://llvm.org/viewvc/llvm-project?rev=300046&view=rev Log: Fix TestGuessLanguage for gcc gcc emits DW_LANG_C89 even if we specify -std=c99 during compilation. Since this isn't an lldb bug, but just the way the compiler happ

[Lldb-commits] [lldb] r300045 - Android.rules: setup correct objcopy path

2017-04-12 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 12 05:13:47 2017 New Revision: 300045 URL: http://llvm.org/viewvc/llvm-project?rev=300045&view=rev Log: Android.rules: setup correct objcopy path This fixes a couple of tests when using android clang as a compiler. Modified: lldb/trunk/packages/Python/lldbsuite/t

[Lldb-commits] [lldb] r300047 - Fix libc++ vector data formatter (bug #32553)

2017-04-12 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 12 05:59:24 2017 New Revision: 300047 URL: http://llvm.org/viewvc/llvm-project?rev=300047&view=rev Log: Fix libc++ vector data formatter (bug #32553) Summary: The iteration list through the available data formatters was undefined, which meant that the vector formatter

[Lldb-commits] [lldb] r300048 - Fix TestCppIncompleteTypes for android/clang

2017-04-12 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 12 05:59:34 2017 New Revision: 300048 URL: http://llvm.org/viewvc/llvm-project?rev=300048&view=rev Log: Fix TestCppIncompleteTypes for android/clang LDFLAGS contains some .a files. If it is specified before the relevant object files, undefined symbol errors occur. Mo

[Lldb-commits] [lldb] r300054 - Add libc++ category to the remaining libc++ data formatters

2017-04-12 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 12 07:32:58 2017 New Revision: 300054 URL: http://llvm.org/viewvc/llvm-project?rev=300054&view=rev Log: Add libc++ category to the remaining libc++ data formatters Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-s

Re: [Lldb-commits] [PATCH] D32087: Modify GDBRemoteCommunication::ScopedTimeout to not ever decrease a timeout

2017-04-18 Thread Pavel Labath via lldb-commits
0 means 0 here. For the time being, we don't have a way to specify infinite gdb timeout. On 15 April 2017 at 15:45, Zachary Turner wrote: > Does 0 mean infinite here? If so are the newly introduced semantics here > still correct? > On Sat, Apr 15, 2017 at 3:34 AM Pavel Labath via Phabricator via

[Lldb-commits] [lldb] r300669 - Revert yesterdays IPv6 patches

2017-04-19 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 19 05:13:22 2017 New Revision: 300669 URL: http://llvm.org/viewvc/llvm-project?rev=300669&view=rev Log: Revert yesterdays IPv6 patches The break the linux bots (and probably any other machine which would run the test suite in a massively parallel way). The problem is

[Lldb-commits] [lldb] r300670 - Fix TestRegisterVariables for clang/arm

2017-04-19 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Apr 19 05:13:29 2017 New Revision: 300670 URL: http://llvm.org/viewvc/llvm-project?rev=300670&view=rev Log: Fix TestRegisterVariables for clang/arm Clang rejects __attribute__((regparm)) when targetting arm. The default calling convention passes arguments in registers any

[Lldb-commits] [lldb] r300833 - Add libc++ category the three more tests

2017-04-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Apr 20 06:27:58 2017 New Revision: 300833 URL: http://llvm.org/viewvc/llvm-project?rev=300833&view=rev Log: Add libc++ category the three more tests I thought my previous commit got the last ones but somehow I missed these. This also resurrects TestDataFormatterLibcxxSet,

[Lldb-commits] [lldb] r300834 - Make TestStaticVariables XFAIL more specific

2017-04-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Apr 20 06:28:07 2017 New Revision: 300834 URL: http://llvm.org/viewvc/llvm-project?rev=300834&view=rev Log: Make TestStaticVariables XFAIL more specific The test fails because an older clang did not emit the required debug info (I am not sure when this got added, but clan

[Lldb-commits] [lldb] r300837 - Skip TestLibCxxAtomic with gcc

2017-04-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Apr 20 07:30:30 2017 New Revision: 300837 URL: http://llvm.org/viewvc/llvm-project?rev=300837&view=rev Log: Skip TestLibCxxAtomic with gcc older versions of libc++ (still used on some linux systems) are not compatible with gcc. Modified: lldb/trunk/packages/Python/l

[Lldb-commits] [lldb] r300836 - Recompute ArchSpec core after MergeFrom

2017-04-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Apr 20 07:30:18 2017 New Revision: 300836 URL: http://llvm.org/viewvc/llvm-project?rev=300836&view=rev Log: Recompute ArchSpec core after MergeFrom Summary: MergeFrom was updating the architecture if the target triple did not have it set. However, it was leaving the core

Re: [Lldb-commits] [lldb] r300902 - Add an example command to toggle between disassembly-only and source mode.

2017-04-21 Thread Pavel Labath via lldb-commits
This is cool, I just did some assembly debugging yesterday, and wished it was easier :) On 20 April 2017 at 22:51, Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: jingham > Date: Thu Apr 20 16:51:27 2017 > New Revision: 300902 > > URL: http://llvm.org/viewvc/llvm-proje

[Lldb-commits] [lldb] r301168 - Add more arguments to SocketAddress::GetAddressInfo

2017-04-24 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Apr 24 04:39:56 2017 New Revision: 301168 URL: http://llvm.org/viewvc/llvm-project?rev=301168&view=rev Log: Add more arguments to SocketAddress::GetAddressInfo Summary: the reason for this is two-fold: - getaddrinfo without the extra arguments will return the same (networ

[Lldb-commits] [lldb] r301179 - Fix the new SocketAddressTest on Windows

2017-04-24 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Apr 24 08:34:35 2017 New Revision: 301179 URL: http://llvm.org/viewvc/llvm-project?rev=301179&view=rev Log: Fix the new SocketAddressTest on Windows we need to call WSAStartup before we can use getaddrinfo. Modified: lldb/trunk/unittests/Host/SocketAddressTest.cpp M

[Lldb-commits] [lldb] r301186 - Update two android XFAILS

2017-04-24 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Apr 24 10:23:21 2017 New Revision: 301186 URL: http://llvm.org/viewvc/llvm-project?rev=301186&view=rev Log: Update two android XFAILS - XFAIL on TestNoreturnUnwind on all architectures - TestStaticVariables fails with clang-3.8 as well Modified: lldb/trunk/packages/

Re: [Lldb-commits] [PATCH] D32434: ObjectFileELF: Fix symbol lookup in bss section

2017-04-25 Thread Pavel Labath via lldb-commits
On 24 April 2017 at 23:16, Zachary Turner wrote: > I suppose that's a reasonable concern. I also didn't notice that this was > a unittest, I assumed it was a lit test. > > If that's the case, is there any way to use llvm/Object to construct a > minimal ELF file in memory with a hardcoded symbol

[Lldb-commits] [lldb] r301306 - Remove the home-grown android toolchain file and all references to it

2017-04-25 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Apr 25 07:58:49 2017 New Revision: 301306 URL: http://llvm.org/viewvc/llvm-project?rev=301306&view=rev Log: Remove the home-grown android toolchain file and all references to it Summary: The toolchain file has been deprecated in favor of the "official" toolchain file pres

[Lldb-commits] [lldb] r301524 - Fix build for clang r301507

2017-04-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Apr 27 03:49:19 2017 New Revision: 301524 URL: http://llvm.org/viewvc/llvm-project?rev=301524&view=rev Log: Fix build for clang r301507 LangStandard::lang_opencl -> LangStandard::lang_opencl10 Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/tru

[Lldb-commits] [lldb] r301534 - TCPSocket: add back support for "*" address

2017-04-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Apr 27 06:32:25 2017 New Revision: 301534 URL: http://llvm.org/viewvc/llvm-project?rev=301534&view=rev Log: TCPSocket: add back support for "*" address before r301492, we could specify "*:1234" as an address to lldb-server and it would interpret that as "any". I am not su

[Lldb-commits] [lldb] r301636 - Resurrect pselect MainLoop implementation

2017-04-28 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Apr 28 05:26:06 2017 New Revision: 301636 URL: http://llvm.org/viewvc/llvm-project?rev=301636&view=rev Log: Resurrect pselect MainLoop implementation Summary: It turns out that even though ppoll is available on all the android devices we support, it does not seem to be wo

[Lldb-commits] [lldb] r301642 - Remove lock from ConstString::GetLength

2017-04-28 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Apr 28 07:08:28 2017 New Revision: 301642 URL: http://llvm.org/viewvc/llvm-project?rev=301642&view=rev Log: Remove lock from ConstString::GetLength Summary: ConstStrings are immutable, so there is no need to grab even a reader lock in order to read the length field. Rev

[Lldb-commits] [lldb] r301903 - Remove unused code related to CPlusPlusLanguage::FindEquivalentNames

2017-05-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue May 2 04:00:52 2017 New Revision: 301903 URL: http://llvm.org/viewvc/llvm-project?rev=301903&view=rev Log: Remove unused code related to CPlusPlusLanguage::FindEquivalentNames Summary: It is simply unused, and the header for it is private, so there should be no external

[Lldb-commits] [lldb] r301908 - Change UniqueCStringMap to use ConstString as the key

2017-05-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue May 2 05:17:30 2017 New Revision: 301908 URL: http://llvm.org/viewvc/llvm-project?rev=301908&view=rev Log: Change UniqueCStringMap to use ConstString as the key Summary: UniqueCStringMap "sorts" the entries for fast lookup, but really it only cares about uniqueness. Co

[Lldb-commits] [lldb] r301917 - ObjectFileELF: Fix symbol lookup in bss section

2017-05-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue May 2 07:40:31 2017 New Revision: 301917 URL: http://llvm.org/viewvc/llvm-project?rev=301917&view=rev Log: ObjectFileELF: Fix symbol lookup in bss section Summary: If we have symbol information in a separate file, we need to be very careful about presenting a unified sec

[Lldb-commits] [lldb] r301918 - Android.rules: set "ar" path correctly

2017-05-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue May 2 08:14:45 2017 New Revision: 301918 URL: http://llvm.org/viewvc/llvm-project?rev=301918&view=rev Log: Android.rules: set "ar" path correctly Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Android.rules Modified: lldb/trunk/packages/Python/lldbsuite/te

Re: [Lldb-commits] [PATCH] Fix Ubuntu build break with gcc 5.4

2017-05-03 Thread Pavel Labath via lldb-commits
This doesn't make things any worse, but a better solution would be to figure out why cmake has not detected ppoll(2) support, as lldb on linux is useless without the signal polling stuff. If your system does have ppoll, but we're not detecting it, we will have to fix detection code. On the off chan

Re: [Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

2017-05-03 Thread Pavel Labath via lldb-commits
On 3 May 2017 at 07:41, vignesh balu wrote: > you mean like this "exe = os.path.join('./newdir/','proc_attach')". I can't probably something like: os.path.join('.', 'newdir', 'proc_attach') ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

Re: [Lldb-commits] [PATCH] Fix Ubuntu build break with gcc 5.4

2017-05-03 Thread Pavel Labath via lldb-commits
It seems xiangzhai has already "cranked up a review" :) (D32787), so moving the discussion there. On 3 May 2017 at 09:57, Pavel Labath wrote: > This doesn't make things any worse, but a better solution would be to > figure out why cmake has not detected ppoll(2) support, as lldb on > linux is use

[Lldb-commits] [lldb] r302008 - Check for lack of C++ context first when demangling

2017-05-03 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed May 3 05:00:00 2017 New Revision: 302008 URL: http://llvm.org/viewvc/llvm-project?rev=302008&view=rev Log: Check for lack of C++ context first when demangling Summary: It seems that if we have no context, then it can't possibly be a method. Check that first. Reviewers

[Lldb-commits] [lldb] r302013 - Windows fix for TestConflictingDefinition makefile

2017-05-03 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed May 3 06:27:35 2017 New Revision: 302013 URL: http://llvm.org/viewvc/llvm-project?rev=302013&view=rev Log: Windows fix for TestConflictingDefinition makefile gnuwin32 rm does not like wildcards that match nothing even if we specify -f (probably because the wildcard expan

[Lldb-commits] [lldb] r302133 - MainLoop: Add unit tests

2017-05-04 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu May 4 05:11:33 2017 New Revision: 302133 URL: http://llvm.org/viewvc/llvm-project?rev=302133&view=rev Log: MainLoop: Add unit tests Summary: This adds a couple of unit tests to the MainLoop class. To get the kqueue based version of the signal handling passing, I needed t

[Lldb-commits] [lldb] r302220 - ABISysV_arm64: compute return value for large vectors correctly

2017-05-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri May 5 05:50:02 2017 New Revision: 302220 URL: http://llvm.org/viewvc/llvm-project?rev=302220&view=rev Log: ABISysV_arm64: compute return value for large vectors correctly Summary: Arm64 Procedure Call Standard specifies than only vectors up to 16 bytes are stored in v0 (

[Lldb-commits] [lldb] r302223 - Add TaskMap for iterating a function over a set of integers

2017-05-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri May 5 06:16:59 2017 New Revision: 302223 URL: http://llvm.org/viewvc/llvm-project?rev=302223&view=rev Log: Add TaskMap for iterating a function over a set of integers Summary: Many parallel tasks just want to iterate over all the possible numbers from 0 to N-1. Rather

[Lldb-commits] [lldb] r302225 - Fix segfault resulting from empty print prompt

2017-05-05 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri May 5 06:51:21 2017 New Revision: 302225 URL: http://llvm.org/viewvc/llvm-project?rev=302225&view=rev Log: Fix segfault resulting from empty print prompt Summary: I have found a way to segfault lldb in 7 keystrokes! Steps to reproduce: 1) Launch lldb 2) Type `print` and

[Lldb-commits] [lldb] r303058 - Remove an expensive lock from Timer

2017-05-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon May 15 08:02:37 2017 New Revision: 303058 URL: http://llvm.org/viewvc/llvm-project?rev=303058&view=rev Log: Remove an expensive lock from Timer The Timer destructor would grab a global mutex in order to update execution time. Add a class to define a category once, statica

[Lldb-commits] [lldb] r303061 - Fix darwin build for r303058

2017-05-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon May 15 08:41:38 2017 New Revision: 303061 URL: http://llvm.org/viewvc/llvm-project?rev=303061&view=rev Log: Fix darwin build for r303058 Modified: lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp Modified: lldb/trunk/source/Plugins/SymbolVendor/Ma

[Lldb-commits] [lldb] r303076 - Disable a test in TestReturnValue on arm64 linux

2017-05-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon May 15 11:25:28 2017 New Revision: 303076 URL: http://llvm.org/viewvc/llvm-project?rev=303076&view=rev Log: Disable a test in TestReturnValue on arm64 linux as described in pr33042, we cannot reliably retrieve the return value on arm64 in cases it is returned via x8 point

[Lldb-commits] [lldb] r303160 - Skip TestWatchedVarHitWhenInScope on android arm because it triggers a kernel bug

2017-05-16 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue May 16 06:58:18 2017 New Revision: 303160 URL: http://llvm.org/viewvc/llvm-project?rev=303160&view=rev Log: Skip TestWatchedVarHitWhenInScope on android arm because it triggers a kernel bug Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/watchpoi

[Lldb-commits] [lldb] r303248 - Make TestConflictingSymbol run on non-darwin targets

2017-05-17 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed May 17 06:47:44 2017 New Revision: 303248 URL: http://llvm.org/viewvc/llvm-project?rev=303248&view=rev Log: Make TestConflictingSymbol run on non-darwin targets For remote targets we need to call registerSharedLibrariesWithTarget to make sure they are installed alongside

[Lldb-commits] [lldb] r303348 - Add Status -- llvm::Error glue

2017-05-18 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu May 18 07:46:50 2017 New Revision: 303348 URL: http://llvm.org/viewvc/llvm-project?rev=303348&view=rev Log: Add Status -- llvm::Error glue Summary: This adds functions to convert between llvm::Error and Status classes. Posix errors in Status are represented as llvm::ECErr

[Lldb-commits] [lldb] r303553 - Fix incorrect Status -> Error rename in IOHandler

2017-05-22 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon May 22 09:13:38 2017 New Revision: 303553 URL: http://llvm.org/viewvc/llvm-project?rev=303553&view=rev Log: Fix incorrect Status -> Error rename in IOHandler Change 302872 was a massive rename of the Error class to Status. The change included an incorrect rename of the "

[Lldb-commits] [lldb] r303627 - Add support for new (3.0.11+) swigs

2017-05-23 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue May 23 05:55:17 2017 New Revision: 303627 URL: http://llvm.org/viewvc/llvm-project?rev=303627&view=rev Log: Add support for new (3.0.11+) swigs Summary: A change in swig 3.0.9 has caused it to generate modules incompatible with us using them as __init__.py (bug #769). Swi

[Lldb-commits] [lldb] r303732 - RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false

2017-05-24 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed May 24 04:46:48 2017 New Revision: 303732 URL: http://llvm.org/viewvc/llvm-project?rev=303732&view=rev Log: RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false Summary: The function had logic to handle the case when the expression terminated while we were trying

[Lldb-commits] [lldb] r303740 - Revert "RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false"

2017-05-24 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed May 24 06:57:28 2017 New Revision: 303740 URL: http://llvm.org/viewvc/llvm-project?rev=303740&view=rev Log: Revert "RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false" This reverts commit r303732, as it introduces a regression in TestLoadUnload on android. Mod

[Lldb-commits] [lldb] r303848 - Recommit "RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false"

2017-05-25 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu May 25 05:50:06 2017 New Revision: 303848 URL: http://llvm.org/viewvc/llvm-project?rev=303848&view=rev Log: Recommit "RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false" This is a resubmit of r303732, which was reverted due to a regression. The original patch

[Lldb-commits] [lldb] r303854 - Revert "Fix FDE indexing while scan debug_info section."

2017-05-25 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu May 25 08:13:12 2017 New Revision: 303854 URL: http://llvm.org/viewvc/llvm-project?rev=303854&view=rev Log: Revert "Fix FDE indexing while scan debug_info section." This reverts commit r303847 as it introduces a number of regressions. Investigation has showed that we are

Re: [Lldb-commits] [PATCH] D33504: Fix FDE indexing while scan debug_info section

2017-05-25 Thread Pavel Labath via lldb-commits
+lldb-commits Yes, that is certainly a viable approach. If there is a subset of dwarf that we are capable of parsing correctly then it would be great to enable that. On 25 May 2017 at 16:46, Tatyana Krasnukha wrote: > This binary uses DWARF 4, that introduces two additional fields in CIE - > ad

Re: [Lldb-commits] [PATCH] D33504: Fix FDE indexing while scan debug_info section

2017-05-26 Thread Pavel Labath via lldb-commits
and a > DWARF 4 .debug_frame section. (And it didn't change in DWARF 5, either!) > --paulr > >> -Original Message- >> From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf >> Of Pavel Labath via lldb-commits >> Sent: Thursday, May 25

[Lldb-commits] [lldb] r303988 - Fix 32-bit builds

2017-05-26 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri May 26 08:53:39 2017 New Revision: 303988 URL: http://llvm.org/viewvc/llvm-project?rev=303988&view=rev Log: Fix 32-bit builds r303972 used GetValueForKeyAsInteger with mismatched types (e.g. instantiating with uint64_t, but passing a size_t argument), which manifested its

Re: [Lldb-commits] [PATCH] D33426: Introduce new command: thread backtrace unique

2017-06-01 Thread Pavel Labath via lldb-commits
Woops, my bad. I was hoping that "resume" was to "StepInstruction", which does have an immediate action, but i did not check what it actually does. In this case, we could probably just use "StepOut" for the test case, as it should have the same effect - advance the thread until it reaches the next

[Lldb-commits] [lldb] r304405 - cmake: Enable process_vm_readv detection on android

2017-06-01 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jun 1 06:20:17 2017 New Revision: 304405 URL: http://llvm.org/viewvc/llvm-project?rev=304405&view=rev Log: cmake: Enable process_vm_readv detection on android Only android and linux can have this function as far as I am aware, but it seems cleaner to enable this code for

[Lldb-commits] [lldb] r304544 - cmake: Put PROCESS_VM_READV detection results into Config.h

2017-06-02 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Jun 2 07:29:08 2017 New Revision: 304544 URL: http://llvm.org/viewvc/llvm-project?rev=304544&view=rev Log: cmake: Put PROCESS_VM_READV detection results into Config.h Reviewers: beanz, eugene Subscribers: mgorny, lldb-commits Differential Revision: https://reviews.llvm

Re: [Lldb-commits] [PATCH] D33831: Add temp_failure_retry helper function

2017-06-02 Thread Pavel Labath via lldb-commits
I've wondered about that as well.. I've seen a couple of places where this could be useful, but not nearly as many as in lldb. I'll let you be the judge of that. On 2 June 2017 at 15:43, Zachary Turner wrote: > I wonder if this should go in LLVM? > > On Fri, Jun 2, 2017 at 7:35 AM Pavel Labath vi

Re: [Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.

2017-06-06 Thread Pavel Labath via lldb-commits
I think the discussion has veered of from the "lldb-server testing" topic into the more murky "general testing" waters. I'll put my thoughts on those first, and then get back to lldb-server test plans. On 31 May 2017 at 18:37, Zachary Turner via Phabricator wrote: > What *would* help would be to

[Lldb-commits] [lldb] r304793 - New framework for lldb client-server communication tests.

2017-06-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 6 08:40:18 2017 New Revision: 304793 URL: http://llvm.org/viewvc/llvm-project?rev=304793&view=rev Log: New framework for lldb client-server communication tests. Summary: This is a new C++ test framework based on Google Test, and one working example test. The intentio

[Lldb-commits] [lldb] r304794 - Remove unused variables. NFC

2017-06-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 6 08:40:21 2017 New Revision: 304794 URL: http://llvm.org/viewvc/llvm-project?rev=304794&view=rev Log: Remove unused variables. NFC Modified: lldb/trunk/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp Modified: lldb/trunk/unittests/Process/gdb

[Lldb-commits] [lldb] r304795 - replace uses of strerror with llvm::sys::StrError

2017-06-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 6 09:06:17 2017 New Revision: 304795 URL: http://llvm.org/viewvc/llvm-project?rev=304795&view=rev Log: replace uses of strerror with llvm::sys::StrError strerror is not thread-safe. llvm's StrError tries hard to retrieve the string in a thread-safe way and falls back

[Lldb-commits] [lldb] r304796 - Fix assorted compiler warnings. NFC

2017-06-06 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 6 09:06:22 2017 New Revision: 304796 URL: http://llvm.org/viewvc/llvm-project?rev=304796&view=rev Log: Fix assorted compiler warnings. NFC Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV1.cpp lldb/trunk/source/Plug

Re: [Lldb-commits] [PATCH] D32022: Fix backtrace of noreturn functions situated at the end of a module

2017-06-07 Thread Pavel Labath via lldb-commits
On 6 June 2017 at 18:41, Jim Ingham wrote: > This is WWDC week. We’ll try to find time to take a look at this, but > silence may mean preoccupation more than anything else… > I was not trying to imply it means anything else than that. However, after two months of inactivity, I was running out o

[Lldb-commits] [lldb] r304924 - Switch TaskMapOverInt to llvm::function_ref

2017-06-07 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Jun 7 11:28:08 2017 New Revision: 304924 URL: http://llvm.org/viewvc/llvm-project?rev=304924&view=rev Log: Switch TaskMapOverInt to llvm::function_ref The function does not persist the callback, so using a lighter-weight asbtraction seems appropriate. Also tweak the sig

[Lldb-commits] [lldb] r304976 - Fix backtrace of noreturn functions situated at the end of a module

2017-06-08 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jun 8 08:26:35 2017 New Revision: 304976 URL: http://llvm.org/viewvc/llvm-project?rev=304976&view=rev Log: Fix backtrace of noreturn functions situated at the end of a module Summary: When a call instruction is the last instruction in a function, the backtrace PC will po

[Lldb-commits] [lldb] r305062 - Skip TestNoreturnUnwind on linux+clang+arm

2017-06-09 Thread Pavel Labath via lldb-commits
Author: labath Date: Fri Jun 9 03:33:59 2017 New Revision: 305062 URL: http://llvm.org/viewvc/llvm-project?rev=305062&view=rev Log: Skip TestNoreturnUnwind on linux+clang+arm I was over-eager to unable this test in r304976. It still fails in this combination, at there does not seem to be anythin

[Lldb-commits] [lldb] r305197 - Introduce new command: thread backtrace unique

2017-06-12 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Jun 12 11:25:24 2017 New Revision: 305197 URL: http://llvm.org/viewvc/llvm-project?rev=305197&view=rev Log: Introduce new command: thread backtrace unique This patch introduces a new thread backtrace command "unique". The command is based off of "thread backtrace all" but

[Lldb-commits] [lldb] r305286 - Mark TestCallThatRestarts as flaky on android

2017-06-13 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 13 06:13:11 2017 New Revision: 305286 URL: http://llvm.org/viewvc/llvm-project?rev=305286&view=rev Log: Mark TestCallThatRestarts as flaky on android This test started being flaky since r303848 (RunThreadPlan: Fix halting logic in IgnoreBreakpoints = false). I am not

[Lldb-commits] [lldb] r305461 - [swig] Improve the native module import logic

2017-06-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jun 15 06:23:22 2017 New Revision: 305461 URL: http://llvm.org/viewvc/llvm-project?rev=305461&view=rev Log: [swig] Improve the native module import logic The simple module import logic was not sufficient for our distribution model of lldb, which is without the _lldb.pyd f

[Lldb-commits] [lldb] r305462 - Add llvm::Error assignment operator to Status class

2017-06-15 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jun 15 06:23:26 2017 New Revision: 305462 URL: http://llvm.org/viewvc/llvm-project?rev=305462&view=rev Log: Add llvm::Error assignment operator to Status class This enables writing "status = std::move(some_llvm_error)". Modified: lldb/trunk/include/lldb/Utility/Statu

[Lldb-commits] [lldb] r305686 - Delete ProcessLauncherPosix

2017-06-19 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Jun 19 07:26:22 2017 New Revision: 305686 URL: http://llvm.org/viewvc/llvm-project?rev=305686&view=rev Log: Delete ProcessLauncherPosix Summary: ProcessLauncherPosix was using posix_spawn for launching the process, but this function is not available on all platforms we su

[Lldb-commits] [lldb] r305687 - Tweak SysV_arm64 function entry unwind plan

2017-06-19 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Jun 19 07:39:34 2017 New Revision: 305687 URL: http://llvm.org/viewvc/llvm-project?rev=305687&view=rev Log: Tweak SysV_arm64 function entry unwind plan Summary: The motivation for this is to make sure the first row of the plan compares equal to the first row of a generic

[Lldb-commits] [lldb] r305689 - Add pretty-printer for wait(2) statuses and modernize the code handling them

2017-06-19 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Jun 19 07:47:50 2017 New Revision: 305689 URL: http://llvm.org/viewvc/llvm-project?rev=305689&view=rev Log: Add pretty-printer for wait(2) statuses and modernize the code handling them Summary: A number of places were trying to decode the result of wait(). Add a simple ut

[Lldb-commits] [lldb] r305779 - Remove home-grown thread-local storage wrappers

2017-06-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 20 03:11:43 2017 New Revision: 305779 URL: http://llvm.org/viewvc/llvm-project?rev=305779&view=rev Log: Remove home-grown thread-local storage wrappers Summary: Use c++11 thread_local variables instead. As far as I am aware, they are supported by all compilers/targets

[Lldb-commits] [lldb] r305778 - ProcessLauncherPosixFork: Fetch errno early

2017-06-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 20 03:11:37 2017 New Revision: 305778 URL: http://llvm.org/viewvc/llvm-project?rev=305778&view=rev Log: ProcessLauncherPosixFork: Fetch errno early I was seeing some unlikely errno values here. I am not sure if this will help, but it nontheless seems like a good idea

[Lldb-commits] [lldb] r305780 - [linux] Change the way we load vdso pseudo-module

2017-06-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 20 03:11:47 2017 New Revision: 305780 URL: http://llvm.org/viewvc/llvm-project?rev=305780&view=rev Log: [linux] Change the way we load vdso pseudo-module Summary: This is basically a revert of D16107 and parts of D10800, which were trying to get vdso loading working.

[Lldb-commits] [lldb] r305789 - Delete a lot of empty directories in test/

2017-06-20 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 20 06:23:36 2017 New Revision: 305789 URL: http://llvm.org/viewvc/llvm-project?rev=305789&view=rev Log: Delete a lot of empty directories in test/ The files in those directories have been moved to packages/Python/lldbsuite/test quite a while ago. However, the director

Re: [Lldb-commits] [PATCH] D34400: Move Connection from Core to Host

2017-06-20 Thread Pavel Labath via lldb-commits
On 20 June 2017 at 14:28, Zachary Turner wrote: > I had actually been considering going the other way. Moving connection and > all implementations to Utility. Host is a big contributor to the dependency > problems, so putting more stuff in seems like the wrong direction. Well, I'd say that Core i

Re: [Lldb-commits] [PATCH] D34400: Move Connection from Core to Host

2017-06-20 Thread Pavel Labath via lldb-commits
On 20 June 2017 at 16:47, Zachary Turner wrote: > I do think at some point we will need to break up Host, but whether the best > way is to move stuff into Utility or to somewhere else is an open question. > Host also depends on Target, Symbol, process plugins, and various other > things. So we wil

[Lldb-commits] [lldb] r306013 - Simplify the gdb-remote unit tests

2017-06-22 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jun 22 10:54:21 2017 New Revision: 306013 URL: http://llvm.org/viewvc/llvm-project?rev=306013&view=rev Log: Simplify the gdb-remote unit tests Instead of every test creating a client-server combo, do that in the SetUp method of the test fixture. This also means that we ca

[Lldb-commits] [lldb] r306278 - Shorten sanitizer plugin names

2017-06-26 Thread Pavel Labath via lldb-commits
Author: labath Date: Mon Jun 26 01:13:22 2017 New Revision: 306278 URL: http://llvm.org/viewvc/llvm-project?rev=306278&view=rev Log: Shorten sanitizer plugin names Summary: The new UndefinedBehaviorSanitizer plugin was breaking file path length limits, because it's (fairly long name) appears mult

[Lldb-commits] [lldb] r306391 - Move Connection and IOObject interfaces to Utility module

2017-06-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 27 03:33:14 2017 New Revision: 306391 URL: http://llvm.org/viewvc/llvm-project?rev=306391&view=rev Log: Move Connection and IOObject interfaces to Utility module Summary: These interfaces have no dependencies, so it makes sense for them to be in the lowest level modul

[Lldb-commits] [lldb] r306394 - Move StructuredData from Core to Utility

2017-06-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 27 03:45:31 2017 New Revision: 306394 URL: http://llvm.org/viewvc/llvm-project?rev=306394&view=rev Log: Move StructuredData from Core to Utility Summary: It had a dependency on StringConvert and file reading code, which is not in Utility. I've replaced that code by eq

[Lldb-commits] [lldb] r306397 - Add debug_frame section support

2017-06-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 27 04:16:26 2017 New Revision: 306397 URL: http://llvm.org/viewvc/llvm-project?rev=306397&view=rev Log: Add debug_frame section support Summary: This is a beefed-up version of D33504, which adds support for dwarf 4 debug_frame section format. The main difference here

[Lldb-commits] [lldb] r306400 - Fix windows build for the Connection move

2017-06-27 Thread Pavel Labath via lldb-commits
Author: labath Date: Tue Jun 27 04:45:32 2017 New Revision: 306400 URL: http://llvm.org/viewvc/llvm-project?rev=306400&view=rev Log: Fix windows build for the Connection move Modified: lldb/trunk/include/lldb/Host/windows/ConnectionGenericFileWindows.h Modified: lldb/trunk/include/lldb/Host/

[Lldb-commits] [lldb] r306521 - [DWARFCallFrameInfo] Add Type enum to differentiate eh/debug_frame sections

2017-06-28 Thread Pavel Labath via lldb-commits
Author: labath Date: Wed Jun 28 02:09:19 2017 New Revision: 306521 URL: http://llvm.org/viewvc/llvm-project?rev=306521&view=rev Log: [DWARFCallFrameInfo] Add Type enum to differentiate eh/debug_frame sections Summary: instead of using a boolean to differentiate between the two section types, use

Re: [Lldb-commits] [PATCH] D34750: [UnwindAssembly/x86] Add support for "lea imm(%ebp), %esp" pattern

2017-06-29 Thread Pavel Labath via lldb-commits
On 28 June 2017 at 15:16, Scott Smith wrote: > x86_64 stacks are supposed to be naturally 16-byte aligned. Maybe try a > 32-byte AVX instruction and see if the compiler aligns to a 32-byte > boundary? > I was able to generate the "andq $-16, %rsp" part of the pattern. The trick was that the comp

[Lldb-commits] [lldb] r306666 - [UnwindAssembly/x86] Add support for "lea imm(%ebp), %esp" pattern

2017-06-29 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jun 29 05:40:13 2017 New Revision: 30 URL: http://llvm.org/viewvc/llvm-project?rev=30&view=rev Log: [UnwindAssembly/x86] Add support for "lea imm(%ebp), %esp" pattern Summary: The instruction pattern: and $-16, %esp sub $imm, %esp ... lea imm(%ebp), %esp appears

[Lldb-commits] [lldb] r306668 - [unittests] Add a helper function for getting an input file

2017-06-29 Thread Pavel Labath via lldb-commits
Author: labath Date: Thu Jun 29 06:02:11 2017 New Revision: 306668 URL: http://llvm.org/viewvc/llvm-project?rev=306668&view=rev Log: [unittests] Add a helper function for getting an input file Summary: Fetching an input file required about five lines of code, and this was repeated in multiple uni

<    1   2   3   4   5   6   7   8   9   10   >