[Lldb-commits] [lldb] r320704 - Remove stderr message from GDBRemoteCommunicationServerLLGS

Author: labath Date: Thu Dec 14 06:56:29 2017 New Revision: 320704 URL: http://llvm.org/viewvc/llvm-project?rev=320704&view=rev Log: Remove stderr message from GDBRemoteCommunicationServerLLGS A similar error message is printed again in lldb-gdbserver.cpp, so the user will see the message twice.

[Lldb-commits] [lldb] r320705 - ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion

Author: labath Date: Thu Dec 14 06:56:45 2017 New Revision: 320705 URL: http://llvm.org/viewvc/llvm-project?rev=320705&view=rev Log: ObjectFile: remove ReadSectionData/MemoryMapSectionData mutual recursion Summary: These two functions were calling each other, while handling different branches of

[Lldb-commits] [lldb] r320809 - llgs-tests: Make addition of new tests easier

Author: labath Date: Fri Dec 15 05:56:22 2017 New Revision: 320809 URL: http://llvm.org/viewvc/llvm-project?rev=320809&view=rev Log: llgs-tests: Make addition of new tests easier Summary: Adding a new test would require one to duplicate a significant part of the existing test that we have. This a

[Lldb-commits] [lldb] r320813 - ObjectFileELF: Add support for compressed sections

Author: labath Date: Fri Dec 15 06:23:58 2017 New Revision: 320813 URL: http://llvm.org/viewvc/llvm-project?rev=320813&view=rev Log: ObjectFileELF: Add support for compressed sections Summary: We use the llvm decompressor to decompress SHF_COMPRESSED sections. This enables us to read data from de

[Lldb-commits] [lldb] r320816 - Fix 32-bit builds broken by 320813

Author: labath Date: Fri Dec 15 06:39:12 2017 New Revision: 320816 URL: http://llvm.org/viewvc/llvm-project?rev=320816&view=rev Log: Fix 32-bit builds broken by 320813 cast to size_t to avoid narrowing error. Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Modified: lld

[Lldb-commits] [lldb] r320820 - llgs-tests: Add support for "exit" stop-reply packets

Author: labath Date: Fri Dec 15 07:19:45 2017 New Revision: 320820 URL: http://llvm.org/viewvc/llvm-project?rev=320820&view=rev Log: llgs-tests: Add support for "exit" stop-reply packets Summary: This makes StopReply class abstract, so that we can represent different types of stop replies such as

[Lldb-commits] [lldb] r320961 - NPL: Clean up handling of inferior exit

Author: labath Date: Mon Dec 18 01:44:29 2017 New Revision: 320961 URL: http://llvm.org/viewvc/llvm-project?rev=320961&view=rev Log: NPL: Clean up handling of inferior exit Summary: lldb-server was sending the "exit" packet (W??) twice. This happened because it was handling both the pre-exit (PTR

[Lldb-commits] [lldb] r320967 - Add LLVMObject dependency to our ObjectFileELF plugin

Author: labath Date: Mon Dec 18 02:51:03 2017 New Revision: 320967 URL: http://llvm.org/viewvc/llvm-project?rev=320967&view=rev Log: Add LLVMObject dependency to our ObjectFileELF plugin Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/CMakeLists.txt Modified: lldb/trunk/source/Plugins/Obj

[Lldb-commits] [lldb] r320966 - Reduce x86 register context boilerplate.

Author: labath Date: Mon Dec 18 02:50:59 2017 New Revision: 320966 URL: http://llvm.org/viewvc/llvm-project?rev=320966&view=rev Log: Reduce x86 register context boilerplate. Summary: The x86 FPR struct was defined as a struct containing a union between two members: XSAVE and FXSAVE. This patch ma

[Lldb-commits] [lldb] r320969 - Fix FreeBSD build broken by r320966

Author: labath Date: Mon Dec 18 03:05:28 2017 New Revision: 320969 URL: http://llvm.org/viewvc/llvm-project?rev=320969&view=rev Log: Fix FreeBSD build broken by r320966 Modified: lldb/trunk/source/Plugins/Process/FreeBSD/RegisterContextPOSIXProcessMonitor_x86.cpp Modified: lldb/trunk/sourc

[Lldb-commits] [lldb] r320985 - Fix regression in jModulesInfo packet handling

Author: labath Date: Mon Dec 18 06:31:44 2017 New Revision: 320985 URL: http://llvm.org/viewvc/llvm-project?rev=320985&view=rev Log: Fix regression in jModulesInfo packet handling The recent UUID cleanups exposed a bug in the parsing code for the jModulesInfo response, which was passing wrong val

[Lldb-commits] [lldb] r320984 - llgs: Propagate the environment when launching the inferior from command line

Author: labath Date: Mon Dec 18 06:31:39 2017 New Revision: 320984 URL: http://llvm.org/viewvc/llvm-project?rev=320984&view=rev Log: llgs: Propagate the environment when launching the inferior from command line Summary: We were failing to propagate the environment when lldb-server was started wit

[Lldb-commits] [lldb] r321255 - Make sure DataBufferLLVM contents are writable

Author: labath Date: Thu Dec 21 02:54:30 2017 New Revision: 321255 URL: http://llvm.org/viewvc/llvm-project?rev=321255&view=rev Log: Make sure DataBufferLLVM contents are writable Summary: We sometimes need to write to the object file we've mapped into memory, generally to apply relocations to de

[Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

Author: labath Date: Thu Dec 21 06:40:03 2017 New Revision: 321271 URL: http://llvm.org/viewvc/llvm-project?rev=321271&view=rev Log: Work around test failures on red-hat linux Two tests were failing because the debugger was picking up multiply defined internal symbols from the system libraries. T

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

wrote: > Thank you Pavel. > I was really nervous about making this change but I agree it's for the best. > > Thanks, > > -- > Davide > > On Thu, Dec 21, 2017 at 3:40 PM, Pavel Labath via lldb-commits > wrote: >> Author: labath >> Date: Thu Dec 21 06:40:

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

December 2017 at 14:55, Davide Italiano wrote: >>> Thank you Pavel. >>> I was really nervous about making this change but I agree it's for the best. >>> >>> Thanks, >>> >>> -- >>> Davide >>> >>> On Thu, Dec 21, 2017 at

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

On 21 December 2017 at 15:17, Pavel Labath wrote: > Right now I'm looking at two (ignoring the debug-info multiplication): > TestExprs2.py and TestTopLevelExprs.py > TestExprs2 is encountering ambiguity when looking up the "environ" > symbol (the dynamic linker contains an extra copy). I think I k

[Lldb-commits] [lldb] r321277 - Make one more test redhat-compatible

Author: labath Date: Thu Dec 21 07:52:59 2017 New Revision: 321277 URL: http://llvm.org/viewvc/llvm-project?rev=321277&view=rev Log: Make one more test redhat-compatible This test was also using "a" in an expression. Modified: lldb/trunk/packages/Python/lldbsuite/test/expression_command/top

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

That's great, thanks for the explanation. I'll look into that. On 21 December 2017 at 16:34, Greg Clayton wrote: > > On Dec 21, 2017, at 7:24 AM, Pavel Labath via lldb-commits > wrote: > > On 21 December 2017 at 15:17, Pavel Labath wrote: > > Right now I'

[Lldb-commits] [lldb] r321353 - Enable TestReadMemCString on non-darwin targets

Author: labath Date: Fri Dec 22 02:26:59 2017 New Revision: 321353 URL: http://llvm.org/viewvc/llvm-project?rev=321353&view=rev Log: Enable TestReadMemCString on non-darwin targets The test works fine on linux, and I believe other targets should not have an issue with as well. If they do, we can

[Lldb-commits] [lldb] r321355 - debugserver: Propagate environment in launch-mode (pr35671)

Author: labath Date: Fri Dec 22 03:09:21 2017 New Revision: 321355 URL: http://llvm.org/viewvc/llvm-project?rev=321355&view=rev Log: debugserver: Propagate environment in launch-mode (pr35671) Summary: Make sure we propagate environment when starting debugserver with a pre-loaded inferior. AFAIK,

Re: [Lldb-commits] [PATCH] D39283: [lldb-dev] Update LLDB test cases for 'inlineStepping'

On 4 January 2018 at 09:00, Carlos Alberto Enciso via Phabricator via lldb-commits wrote: > CarlosAlbertoEnciso added a comment. > > I have some issues running the LLDB Test Suite in 32-bit and 64-bit mode. > > From the LLDB documentation: > > https://lldb.llvm.org/test.html > > It is possible t

Re: [Lldb-commits] [lldb] r321856 - [ArchSpec] Don't consider Unknown MachO64 as invalid.

The inheritance trick can be useful sometimes, but I don't think it's a good way to write tests in general (and it should not be necessary for this patch). I assume you ran into this while working on a real-world bug. How were the relevant ArchSpecs constructed there? The class is fairly simple, s

[Lldb-commits] [lldb] r322075 - TestConflictingSymbols: simplify test by using run_break_set_by_source_regexp

Author: labath Date: Tue Jan 9 05:22:22 2018 New Revision: 322075 URL: http://llvm.org/viewvc/llvm-project?rev=322075&view=rev Log: TestConflictingSymbols: simplify test by using run_break_set_by_source_regexp follow-up to r321271 based on post-commit feedback by Jim Ingham. Modified: lldb

Re: [Lldb-commits] [lldb] r321856 - [ArchSpec] Don't consider Unknown MachO64 as invalid.

On 9 January 2018 at 15:26, Davide Italiano wrote: > On Tue, Jan 9, 2018 at 5:02 AM, Pavel Labath wrote: >> The inheritance trick can be useful sometimes, but I don't think it's >> a good way to write tests in general (and it should not be necessary >> for this patch). >> >> I assume you ran into

[Lldb-commits] [lldb] r322167 - [dotest] Remove crashinfo hook

Author: labath Date: Wed Jan 10 02:18:47 2018 New Revision: 322167 URL: http://llvm.org/viewvc/llvm-project?rev=322167&view=rev Log: [dotest] Remove crashinfo hook Summary: This used to be important when all tests were run in a single process, but that has no longer been the case for a while. Fur

[Lldb-commits] [lldb] r322174 - Add Utility/Environment class for handling... environments

Author: labath Date: Wed Jan 10 03:57:31 2018 New Revision: 322174 URL: http://llvm.org/viewvc/llvm-project?rev=322174&view=rev Log: Add Utility/Environment class for handling... environments Summary: There was some confusion in the code about how to represent process environment. Most of the cod

[Lldb-commits] [lldb] r322176 - Fix windows and freebsd builds for r322174 (Environment)

Author: labath Date: Wed Jan 10 04:25:48 2018 New Revision: 322176 URL: http://llvm.org/viewvc/llvm-project?rev=322176&view=rev Log: Fix windows and freebsd builds for r322174 (Environment) Modified: lldb/trunk/source/Host/windows/ProcessLauncherWindows.cpp lldb/trunk/source/Plugins/Proce

[Lldb-commits] [lldb] r322187 - Another attempt to fix FreeBsd build

Author: labath Date: Wed Jan 10 05:53:40 2018 New Revision: 322187 URL: http://llvm.org/viewvc/llvm-project?rev=322187&view=rev Log: Another attempt to fix FreeBsd build the previous fix did not work because of different const qualifications on the envp pointer. This should resolve that (and rem

[Lldb-commits] [lldb] r322188 - Add empty() function to the Environment class

Author: labath Date: Wed Jan 10 06:17:40 2018 New Revision: 322188 URL: http://llvm.org/viewvc/llvm-project?rev=322188&view=rev Log: Add empty() function to the Environment class Needed to make the previous Freebsd fix work. Modified: lldb/trunk/include/lldb/Utility/Environment.h Modified:

[Lldb-commits] [lldb] r322190 - Handle O reply packets during qRcmd

Author: labath Date: Wed Jan 10 06:39:08 2018 New Revision: 322190 URL: http://llvm.org/viewvc/llvm-project?rev=322190&view=rev Log: Handle O reply packets during qRcmd Summary: Gdb servers like openocd may send many $O reply packets for the client to output during a qRcmd command sequence. Cur

Re: [Lldb-commits] [PATCH] D40283: lldb: Use the DWARF linkage name when importing C++ methods

On 10 January 2018 at 22:51, Greg Clayton wrote: > The right solution seems to be adding some sort of custom GNU ABI tag to the > DWARF. I know that won't help with existing binaries, but it sounds too > expensive to set the ASM name for everything. > What makes you think it will be expensive?

[Lldb-commits] [lldb] r322271 - Make the bundle folders in the find-app-in-bundle test non-empty

Author: labath Date: Thu Jan 11 04:21:58 2018 New Revision: 322271 URL: http://llvm.org/viewvc/llvm-project?rev=322271&view=rev Log: Make the bundle folders in the find-app-in-bundle test non-empty git will not create empty folders, which makes this test fail if the repo is checked out with git.

[Lldb-commits] [lldb] r322273 - Remove leftover empty folders

Author: labath Date: Thu Jan 11 04:57:23 2018 New Revision: 322273 URL: http://llvm.org/viewvc/llvm-project?rev=322273&view=rev Log: Remove leftover empty folders These were created by moving stuff around with git. After committing the move back to svn, the folders holding the original files rema

Re: [Lldb-commits] [PATCH] D41902: Remove Platform references from the Host module

Thanks for adding the test Jim. I have confirmed that it passes with this patch applied (because the bundle is resolved during target creating, not launching). However, this did make me aware of the fact that this patch removed the bundle resolution logic from the launcher itself, so I'm going to

Re: [Lldb-commits] [PATCH] D41902: Remove Platform references from the Host module

On 11 January 2018 at 16:04, Greg Clayton wrote: > >> On Jan 11, 2018, at 5:12 AM, Pavel Labath wrote: >> >> Thanks for adding the test Jim. I have confirmed that it passes with >> this patch applied (because the bundle is resolved during target >> creating, not launching). >> >> However, this di

Re: [Lldb-commits] [PATCH] D41902: Remove Platform references from the Host module

On 11 January 2018 at 16:22, Greg Clayton wrote: > >> On Jan 11, 2018, at 8:10 AM, Pavel Labath wrote: >> >> On 11 January 2018 at 16:04, Greg Clayton wrote: >>> On Jan 11, 2018, at 5:12 AM, Pavel Labath wrote: Thanks for adding the test Jim. I have confirmed that it passes with

[Lldb-commits] [lldb] r322472 - Fix HostInfoBase::ComputeSharedLibraryDirectory comment

Author: labath Date: Mon Jan 15 01:56:00 2018 New Revision: 322472 URL: http://llvm.org/viewvc/llvm-project?rev=322472&view=rev Log: Fix HostInfoBase::ComputeSharedLibraryDirectory comment The comment seems to indicate that this function would return the "bin" directory on linux. I've verified th

[Lldb-commits] [lldb] r322476 - Fix NetBSD build for llvm r322475

Author: labath Date: Mon Jan 15 03:32:43 2018 New Revision: 322476 URL: http://llvm.org/viewvc/llvm-project?rev=322476&view=rev Log: Fix NetBSD build for llvm r322475 Modified: lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp Modified: lldb/trunk/source/Plugins/Process/NetBSD

[Lldb-commits] [lldb] r322477 - One more attempt to fix NetBSD build

Author: labath Date: Mon Jan 15 03:50:05 2018 New Revision: 322477 URL: http://llvm.org/viewvc/llvm-project?rev=322477&view=rev Log: One more attempt to fix NetBSD build Modified: lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp Modified: lldb/trunk/source/Plugins/Process/Net

[Lldb-commits] [lldb] r322653 - Simplify some LogTest tests

Author: labath Date: Wed Jan 17 05:46:06 2018 New Revision: 322653 URL: http://llvm.org/viewvc/llvm-project?rev=322653&view=rev Log: Simplify some LogTest tests This removes boilerplate for setting up a log channel and capturing the output from some of the tests. I do this by moving the setup cod

[Lldb-commits] [lldb] r322664 - Fix assertion in ObjectFileELF

Author: labath Date: Wed Jan 17 06:40:25 2018 New Revision: 322664 URL: http://llvm.org/viewvc/llvm-project?rev=322664&view=rev Log: Fix assertion in ObjectFileELF In D40616 I (mistakenly) assumed that logging an llvm::Error would clear it. This of course is only true if logging is actually enabl

[Lldb-commits] [lldb] r322666 - [lldb][PPC64] Fixed long double variables dump

Author: labath Date: Wed Jan 17 07:11:20 2018 New Revision: 322666 URL: http://llvm.org/viewvc/llvm-project?rev=322666&view=rev Log: [lldb][PPC64] Fixed long double variables dump Summary: LLDB's DumpDataExtractor was not prepared to handle PowerPC's long double type: PPCDoubleDouble. As it is

[Lldb-commits] [lldb] r322834 - Fix logging test on windows

Author: labath Date: Thu Jan 18 03:15:50 2018 New Revision: 322834 URL: http://llvm.org/viewvc/llvm-project?rev=322834&view=rev Log: Fix logging test on windows Refactor in r322653 broke the logging test on windows because MSVC uses a fully qualified name as the value of __FUNCTION__, which is no

Re: [Lldb-commits] [PATCH] D41902: Remove Platform references from the Host module

On 11 January 2018 at 22:42, Davide Italiano wrote: > The test Jim committed broke the public bots, so I went ahead and reverted it. > > > Committing to https://llvm.org/svn/llvm-project/lldb/trunk ... > commit 87eb2de0885d646e71d5848c1fa699b784bf5d2b > Author: Davide Italiano > Date: Thu Jan 1

[Lldb-commits] [lldb] r322935 - Remove Platform references from the Host module

Author: labath Date: Fri Jan 19 03:10:54 2018 New Revision: 322935 URL: http://llvm.org/viewvc/llvm-project?rev=322935&view=rev Log: Remove Platform references from the Host module Summary: These were used by Host::LaunchProcess to "resolve" the executable it was about to launch. The only parts o

[Lldb-commits] [lldb] r323086 - Fix TestTargetSymbolsAddCommand [getBuildArtifact refactor]

Author: labath Date: Mon Jan 22 01:55:30 2018 New Revision: 323086 URL: http://llvm.org/viewvc/llvm-project?rev=323086&view=rev Log: Fix TestTargetSymbolsAddCommand [getBuildArtifact refactor] Modified: lldb/trunk/packages/Python/lldbsuite/test/linux/add-symbols/TestTargetSymbolsAddCommand.p

[Lldb-commits] [lldb] r323100 - Add SysV Abi for PPC64le

Author: labath Date: Mon Jan 22 03:27:43 2018 New Revision: 323100 URL: http://llvm.org/viewvc/llvm-project?rev=323100&view=rev Log: Add SysV Abi for PPC64le Summary: This patch implements the ABI Plugin for PPC64le. It was based on the ABI for PPC64. It also enables LLDB to evaluate expressions

[Lldb-commits] [lldb] r323102 - Revert "[SymbolFilePDB] Fix null array access when parsing the type of a function without any arguments, i.e. 'int main()' and add support to test it"

Author: labath Date: Mon Jan 22 03:51:56 2018 New Revision: 323102 URL: http://llvm.org/viewvc/llvm-project?rev=323102&view=rev Log: Revert "[SymbolFilePDB] Fix null array access when parsing the type of a function without any arguments, i.e. 'int main()' and add support to test it" This reverts

Re: [Lldb-commits] [PATCH] D42195: [lldb] Generic base for testing gdb-remote behavior

On 22 January 2018 at 22:06, Jim Ingham wrote: > > >> On Jan 22, 2018, at 3:10 AM, Pavel Labath via Phabricator >> wrote: >> >> labath added subscribers: krytarowski, jingham, davide. >> labath added a comment. >> >> In https://reviews.llvm.org/D42195#982035, @owenpshaw wrote: >> >>> - Added yam

[Lldb-commits] [lldb] r323340 - Remove unused includes from the Host module

Author: labath Date: Wed Jan 24 08:40:22 2018 New Revision: 323340 URL: http://llvm.org/viewvc/llvm-project?rev=323340&view=rev Log: Remove unused includes from the Host module Modified: lldb/trunk/source/Host/common/Symbols.cpp lldb/trunk/source/Host/freebsd/Host.cpp lldb/trunk/sourc

[Lldb-commits] [lldb] r323520 - Fix linux fallout from c++ gmodules enable

Author: labath Date: Fri Jan 26 03:40:59 2018 New Revision: 323520 URL: http://llvm.org/viewvc/llvm-project?rev=323520&view=rev Log: Fix linux fallout from c++ gmodules enable TestLibcxxListLoop - fails because the evil "define private public" trick does not work with gmodules. The purpose of t

[Lldb-commits] [lldb] r323537 - gmodules XFAIL two more tests that only fail for android (pr36109)

Author: labath Date: Fri Jan 26 08:05:46 2018 New Revision: 323537 URL: http://llvm.org/viewvc/llvm-project?rev=323537&view=rev Log: gmodules XFAIL two more tests that only fail for android (pr36109) Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-form

[Lldb-commits] [lldb] r323636 - [lldb] Generic base for testing gdb-remote behavior

Author: labath Date: Mon Jan 29 02:02:40 2018 New Revision: 323636 URL: http://llvm.org/viewvc/llvm-project?rev=323636&view=rev Log: [lldb] Generic base for testing gdb-remote behavior Summary: Adds new utilities that make it easier to write test cases for lldb acting as a client over a gdb-remo

[Lldb-commits] [lldb] r323637 - Remove ObjectFile usage from HostLinux::GetProcessInfo

Author: labath Date: Mon Jan 29 02:46:00 2018 New Revision: 323637 URL: http://llvm.org/viewvc/llvm-project?rev=323637&view=rev Log: Remove ObjectFile usage from HostLinux::GetProcessInfo Summary: The ObjectFile class was used to determine the architecture of a running process by inspecting it's

[Lldb-commits] [lldb] r323639 - Fix NetBsd build broken by r323637

Author: labath Date: Mon Jan 29 03:10:21 2018 New Revision: 323639 URL: http://llvm.org/viewvc/llvm-project?rev=323639&view=rev Log: Fix NetBsd build broken by r323637 Modified: lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp Modified: lldb/trunk/source/Plugins/Process/NetBS

Re: [Lldb-commits] [lldb] r322339 - When parsing the target.xml register file, if no architecture has

The budding gdb-client test suite might be an option for this. On 29 January 2018 at 18:17, Jason Molenda via lldb-commits wrote: > > >> On Jan 28, 2018, at 9:59 PM, Davide Italiano wrote: >> >> On Thu, Jan 11, 2018 at 5:26 PM, Davide Italiano >> wrote: >>> On

[Lldb-commits] [lldb] r323736 - Skip TestWithModuleDebugging on i386 linux (pr36146)

Author: labath Date: Tue Jan 30 01:39:22 2018 New Revision: 323736 URL: http://llvm.org/viewvc/llvm-project?rev=323736&view=rev Log: Skip TestWithModuleDebugging on i386 linux (pr36146) It fails due to an assertion (if these are enabled). Modified: lldb/trunk/packages/Python/lldbsuite/test/

[Lldb-commits] [lldb] r323744 - Fix TestGDBRemoteClient on windows

Author: labath Date: Tue Jan 30 02:41:46 2018 New Revision: 323744 URL: http://llvm.org/viewvc/llvm-project?rev=323744&view=rev Log: Fix TestGDBRemoteClient on windows The logic was incorrect because on windows, we need to look for yaml2obj.EXE. I implement the search in terms of distutils.spawn.

[Lldb-commits] [lldb] r323753 - Add LLDB_LOG_ERROR macro

Author: labath Date: Tue Jan 30 04:19:34 2018 New Revision: 323753 URL: http://llvm.org/viewvc/llvm-project?rev=323753&view=rev Log: Add LLDB_LOG_ERROR macro Summary: The difference between this and regular LLDB_LOG is that this one clears the error object unconditionally. This was inspired by t

[Lldb-commits] [lldb] r323763 - One more TestGDBRemoteClient/windows fix

Author: labath Date: Tue Jan 30 06:33:54 2018 New Revision: 323763 URL: http://llvm.org/viewvc/llvm-project?rev=323763&view=rev Log: One more TestGDBRemoteClient/windows fix We also need to be .EXE-aware when searching for the clang binary. Modified: lldb/trunk/packages/Python/lldbsuite/test

[Lldb-commits] [lldb] r323855 - Fix TestTargetSymbolsAddCommand makefile

Author: labath Date: Wed Jan 31 01:14:12 2018 New Revision: 323855 URL: http://llvm.org/viewvc/llvm-project?rev=323855&view=rev Log: Fix TestTargetSymbolsAddCommand makefile We started passing the "all" target to make, which rendered the "localall" trick in this Makefile inoperable. I implement

[Lldb-commits] [lldb] r323884 - Fix TestMixedDwarfBinary.py

Author: labath Date: Wed Jan 31 08:23:24 2018 New Revision: 323884 URL: http://llvm.org/viewvc/llvm-project?rev=323884&view=rev Log: Fix TestMixedDwarfBinary.py As of yesterday, tests need to use self.getBuildArtifact() to get the built executable. Modified: lldb/trunk/packages/Python/lldbs

[Lldb-commits] [lldb] r323953 - mock_gdb_server: rectify ack handling code

Author: labath Date: Thu Feb 1 03:29:06 2018 New Revision: 323953 URL: http://llvm.org/viewvc/llvm-project?rev=323953&view=rev Log: mock_gdb_server: rectify ack handling code The mock server was sending acks back in response to spurious acks from the client, but the client was not prepared to ha

[Lldb-commits] [lldb] r323974 - Extend windows->android XFAIL on TestLoadUnload

Author: labath Date: Thu Feb 1 07:35:55 2018 New Revision: 323974 URL: http://llvm.org/viewvc/llvm-project?rev=323974&view=rev Log: Extend windows->android XFAIL on TestLoadUnload This fails regardless of the android architecture or compiler used. The important bit is the mismatch in path separa

Re: [Lldb-commits] [PATCH] D42443: [SymbolFilePDB] Add support for function symbols

Well... it would be *very*-nice-to-have thing. I would very much love to be able to run at least one pdb test from linux. (So, I'm not opposing this in any way, just pointing out what needs to happen). On 1 February 2018 at 18:35, Zachary Turner wrote: > Yea good point. We can probably punt on th

Re: [Lldb-commits] [PATCH] D42210: Re-enable logging on the child side of a fork() in lldb-server platform mode

Hi Jason, Thanks for the heads up. I look forward to getting rid of fork() there, but there is one thing that's not clear to me. You say that TCPSocket::Accept() calls CloseListenSockets().. I see don't see anything like that in the current code, and I know for a fact that we are able to handle mu

[Lldb-commits] [lldb] r324226 - [dotest] make debug info variant accessible in setUp()

Author: labath Date: Mon Feb 5 03:30:46 2018 New Revision: 324226 URL: http://llvm.org/viewvc/llvm-project?rev=324226&view=rev Log: [dotest] make debug info variant accessible in setUp() Summary: This changes the way we store the debug info variant to make it available earlier in the test bringu

[Lldb-commits] [lldb] r324230 - TestLinuxCore -- add a check for thread name

Author: labath Date: Mon Feb 5 04:34:09 2018 New Revision: 324230 URL: http://llvm.org/viewvc/llvm-project?rev=324230&view=rev Log: TestLinuxCore -- add a check for thread name We've had a bug (fixed by https://reviews.llvm.org/D42828) where the thread name was being read incorrectly. Add a test

[Lldb-commits] [lldb] r324236 - Skip TestTargetSymbolsSepDebugSymlink on remote targets

Author: labath Date: Mon Feb 5 06:07:44 2018 New Revision: 324236 URL: http://llvm.org/viewvc/llvm-project?rev=324236&view=rev Log: Skip TestTargetSymbolsSepDebugSymlink on remote targets Currently, our behavior when installing symlinks on the remote target is broken (pr36237). Modified: l

[Lldb-commits] [lldb] r324254 - Fix parsing of object files with "early" section headers

Author: labath Date: Mon Feb 5 09:25:40 2018 New Revision: 324254 URL: http://llvm.org/viewvc/llvm-project?rev=324254&view=rev Log: Fix parsing of object files with "early" section headers ObjectFileELF::GetModuleSpecifications contained a lot of tip-toing code which was trying to avoid loading

[Lldb-commits] [lldb] r324256 - Add a comment explaining how the input for GetModuleSpecifications_EarlySectionHeaders was generated

Author: labath Date: Mon Feb 5 10:03:02 2018 New Revision: 324256 URL: http://llvm.org/viewvc/llvm-project?rev=324256&view=rev Log: Add a comment explaining how the input for GetModuleSpecifications_EarlySectionHeaders was generated Davide pointed out this would be useful if the file ever needs

Re: [Lldb-commits] [lldb] r324254 - Fix parsing of object files with "early" section headers

that I had to fix a completely unrelated bug to do that got me upset. I'll have to be more careful next time. On 5 February 2018 at 17:42, Davide Italiano wrote: > On Mon, Feb 5, 2018 at 9:25 AM, Pavel Labath via lldb-commits > wrote: >> Author: labath >> Date: Mon Feb

Re: [Lldb-commits] [PATCH] D42210: Re-enable logging on the child side of a fork() in lldb-server platform mode

Right I see. Thanks for the explanation. I feel this is a good time to bring up again my idea for implementing gdb-server connections in a port-forwarder-friendly way. It's described at , so I am not going to repeat the details h

[Lldb-commits] [lldb] r324472 - Remove function DW_DSC_value_to_name

Author: labath Date: Wed Feb 7 03:13:21 2018 New Revision: 324472 URL: http://llvm.org/viewvc/llvm-project?rev=324472&view=rev Log: Remove function DW_DSC_value_to_name It is unused, and the underlying llvm function has been removed as well. Modified: lldb/trunk/source/Plugins/SymbolFile/DW

[Lldb-commits] [lldb] r324590 - Rewrite the flaky test_restart_bug test in a more deterministic way

Author: labath Date: Thu Feb 8 02:37:23 2018 New Revision: 324590 URL: http://llvm.org/viewvc/llvm-project?rev=324590&view=rev Log: Rewrite the flaky test_restart_bug test in a more deterministic way Summary: The test was trying to reproduce a bug in handling of two concurrent events, which was

[Lldb-commits] [lldb] r324722 - llgs-test: Parse and store register info recieved from lldb-server

Author: labath Date: Fri Feb 9 01:40:03 2018 New Revision: 324722 URL: http://llvm.org/viewvc/llvm-project?rev=324722&view=rev Log: llgs-test: Parse and store register info recieved from lldb-server Summary: Right now the test client is not parsing register values correctly, which is manifesting

[Lldb-commits] [lldb] r324730 - Fix some warnings in SymbolFilePDB.cpp

Author: labath Date: Fri Feb 9 03:37:01 2018 New Revision: 324730 URL: http://llvm.org/viewvc/llvm-project?rev=324730&view=rev Log: Fix some warnings in SymbolFilePDB.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/

[Lldb-commits] [lldb] r324870 - Skip TestTargetXMLArch on non-darwin OSs

Author: labath Date: Mon Feb 12 01:46:06 2018 New Revision: 324870 URL: http://llvm.org/viewvc/llvm-project?rev=324870&view=rev Log: Skip TestTargetXMLArch on non-darwin OSs This test uses XML packets, but libxml is an optional dependency of lldb, and this test fails if it is not present. I'm le

Re: [Lldb-commits] [lldb] r324743 - [Testsuite] Remove leak tests, it's not useful anymore.

I think you misunderstood the purpose the purpose of this test. The test was there to make sure that *lldb* does not leak file descriptors into the inferior (when I wrote it a couple of years ago, we were leaking about half a dozen of them). The python version check was added there just because we

Re: [Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

First, I want to apologise for derailing the tab completion review. However, now that the cat's out of the bag, let me elaborate on what I meant. For example, this is how a typical instruction emulation test looks right now: TEST_F(Testx86AssemblyInspectionEngine, TestSimp

[Lldb-commits] [lldb] r325137 - Remove vestigial remnants of the test crash info hook

Author: labath Date: Wed Feb 14 08:08:26 2018 New Revision: 325137 URL: http://llvm.org/viewvc/llvm-project?rev=325137&view=rev Log: Remove vestigial remnants of the test crash info hook Modified: lldb/trunk/packages/Python/lldbsuite/test/configuration.py lldb/trunk/packages/Python/lldbsu

[Lldb-commits] [lldb] r325250 - @skipIfRemote TestTargetXMLArch

Author: labath Date: Thu Feb 15 07:24:32 2018 New Revision: 325250 URL: http://llvm.org/viewvc/llvm-project?rev=325250&view=rev Log: @skipIfRemote TestTargetXMLArch The test does not actually connect to any remote targets. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/

Re: [Lldb-commits] [lldb] r324792 - Add test case for x86_64 architecture recognition in the

This test was failing when run against a "remote" target (at least android, but possibly others). I've skipped it because it's not really applicable to the remote test suite, but I did notice something you may want to know about while investigating: The test verifies that the target triple is dedu

[Lldb-commits] [lldb] r325322 - [dosep] Run tests in a more parallel fashion

Author: labath Date: Fri Feb 16 01:21:11 2018 New Revision: 325322 URL: http://llvm.org/viewvc/llvm-project?rev=325322&view=rev Log: [dosep] Run tests in a more parallel fashion Summary: Due to in-tree builds, we were parallelizing the tests at the directory level. Now that the tests are built ou

[Lldb-commits] [lldb] r325324 - [lldb][PPC64] Fixed vector and struct return value

Author: labath Date: Fri Feb 16 01:29:41 2018 New Revision: 325324 URL: http://llvm.org/viewvc/llvm-project?rev=325324&view=rev Log: [lldb][PPC64] Fixed vector and struct return value Summary: The PowerPC64 ABI plugin was modified to: - properly handle vector type return values - implement suppo

[Lldb-commits] [lldb] r325334 - Fix paralelization of remote tests

Author: labath Date: Fri Feb 16 03:39:38 2018 New Revision: 325334 URL: http://llvm.org/viewvc/llvm-project?rev=325334&view=rev Log: Fix paralelization of remote tests Since we now can run multiple tests from the same directory at once, we need to include the test name in the remote test director

[Lldb-commits] [lldb] r325340 - Shorten socket names in TestPlatformProcessConnect

Author: labath Date: Fri Feb 16 04:57:35 2018 New Revision: 325340 URL: http://llvm.org/viewvc/llvm-project?rev=325340&view=rev Log: Shorten socket names in TestPlatformProcessConnect The test was generating long unix socket names, and the addition of a new folder in the previous patch pushed it

[Lldb-commits] [lldb] r325495 - Make gdb-client tests generate binaries in the build tree

Author: labath Date: Mon Feb 19 05:53:12 2018 New Revision: 325495 URL: http://llvm.org/viewvc/llvm-project?rev=325495&view=rev Log: Make gdb-client tests generate binaries in the build tree These were missed in the great refactor because they were added concurrently with it. Since we started run

[Lldb-commits] [lldb] r325504 - Add SBDebugger::GetBuildConfiguration and use it to skip an XML test

Author: labath Date: Mon Feb 19 07:06:28 2018 New Revision: 325504 URL: http://llvm.org/viewvc/llvm-project?rev=325504&view=rev Log: Add SBDebugger::GetBuildConfiguration and use it to skip an XML test Summary: This adds a SBDebugger::GetBuildConfiguration static function, which returns a SBStruc

[Lldb-commits] [lldb] r325511 - Fix TestStopReplyContainsThreadPcs on 32-bit x86 (pr36013)

Author: labath Date: Mon Feb 19 07:42:48 2018 New Revision: 325511 URL: http://llvm.org/viewvc/llvm-project?rev=325511&view=rev Log: Fix TestStopReplyContainsThreadPcs on 32-bit x86 (pr36013) Summary: The issue was that we were parsing the registers into 64-bit integers and the calling swapByteOr

[Lldb-commits] [lldb] r325519 - Two more dosep-paralellization fallout fixes

Author: labath Date: Mon Feb 19 09:23:13 2018 New Revision: 325519 URL: http://llvm.org/viewvc/llvm-project?rev=325519&view=rev Log: Two more dosep-paralellization fallout fixes The first issue is about the flaky test rerun logic. This was grouping tests by subdir and passing them into walk_and_i

[Lldb-commits] [lldb] r325570 - Avoid dirtying the source tree in breakpoint command tests

Author: labath Date: Tue Feb 20 02:24:37 2018 New Revision: 325570 URL: http://llvm.org/viewvc/llvm-project?rev=325570&view=rev Log: Avoid dirtying the source tree in breakpoint command tests Summary: The paralelization patch exposed a bunch of cases where we were still touching the source tree (

[Lldb-commits] [lldb] r325690 - Fix a couple of more tests to not create files in the source tree

Author: labath Date: Wed Feb 21 07:33:53 2018 New Revision: 325690 URL: http://llvm.org/viewvc/llvm-project?rev=325690&view=rev Log: Fix a couple of more tests to not create files in the source tree Summary: These were not being flaky, but they're still making the tree dirty. These tests were us

[Lldb-commits] [lldb] r325701 - llgs-tests: Fix r325511 for debugserver

Author: labath Date: Wed Feb 21 09:38:38 2018 New Revision: 325701 URL: http://llvm.org/viewvc/llvm-project?rev=325701&view=rev Log: llgs-tests: Fix r325511 for debugserver Debugserver sends the thread-pcs field with leading zeroes omitted. Teach parseRegisterValue to pad these as necessary. Mod

[Lldb-commits] [lldb] r325702 - Fix remote tests broken by r325690

Author: labath Date: Wed Feb 21 09:55:22 2018 New Revision: 325702 URL: http://llvm.org/viewvc/llvm-project?rev=325702&view=rev Log: Fix remote tests broken by r325690 The patch added an extra argument to the append_to_process_working_directory function. I have somehow missed updating this test,

[Lldb-commits] [lldb] r325728 - [LLDB][PPC64] Fixed next blocked forever at same line

Author: labath Date: Wed Feb 21 13:56:18 2018 New Revision: 325728 URL: http://llvm.org/viewvc/llvm-project?rev=325728&view=rev Log: [LLDB][PPC64] Fixed next blocked forever at same line Summary: The PC corresponding to the breakpoint was being calculated wrongly, which was causing LLDB to never

[Lldb-commits] [lldb] r325927 - Replace HashStringUsingDJB with llvm::djbHash

Author: labath Date: Fri Feb 23 09:49:26 2018 New Revision: 325927 URL: http://llvm.org/viewvc/llvm-project?rev=325927&view=rev Log: Replace HashStringUsingDJB with llvm::djbHash Summary: The llvm function is equivalent to this one. Where possible I tried to replace const char* with llvm::StringR

Re: [Lldb-commits] [PATCH] D43686: Add "lldb-test breakpoint" command and convert the case-sensitivity test to use it

On 23 February 2018 at 11:24, Jim Ingham wrote: > To be fair, you could probably have made the dotest.py version of the test > close to as fast by not running a process. The old test was testing that we > got a location for the breakpoint AND hit it. The latter was probably > overkill. But t

[Lldb-commits] [lldb] r326112 - Add "lldb-test breakpoint" command and convert the case-sensitivity test to use it

Author: labath Date: Mon Feb 26 10:50:16 2018 New Revision: 326112 URL: http://llvm.org/viewvc/llvm-project?rev=326112&view=rev Log: Add "lldb-test breakpoint" command and convert the case-sensitivity test to use it Summary: The command takes two input arguments: a module to use as a debug targe

<    1   2   3   4   5   6   7   8   9   10   >