labath added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:488
+ELFNote note = ELFNote();
+note.Parse(segment, &offset);
+
clayborg wrote:
> Do we need to check anything after parsing a note here to ensure it parsed?
> C
labath added inline comments.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:735
/// (see ELFNote structure)
/// 3) A Thread Context in a core file usually described by 3 NOTE entries.
///a) NT_PRSTATUS - Register context
krytarowski wrot
labath updated this revision to Diff 123898.
labath added a comment.
Update comments.
https://reviews.llvm.org/D40311
Files:
source/Plugins/Process/elf-core/ProcessElfCore.cpp
source/Plugins/Process/elf-core/ProcessElfCore.h
source/Plugins/Process/elf-core/ThreadElfCore.cpp
source/Plugi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL318903: elf-core: Split up parsing code into os-specific
functions (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D40311
Files:
lldb/trunk/source/Plugins/Process/elf-core/Process
labath updated this revision to Diff 124064.
labath added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: mgorny.
This is a slight deviation from the initial approach. What I've done here is
that I've kept the register set indices in an os-specific form. I've
labath created this revision.
New linux kernels (on systems that support the XSAVES instruction) will
not update the inferior registers unless the corresponding flag in the
XSAVE header is set. Normally this flag will be set in our image of the
XSAVE area (since we obtained it from the kernel), bu
labath added a comment.
I am only commenting on the c++14 stuff. I think all of the things you need
here are available to us already through various llvm utilities. See inline
comments for details.
For the "meat" of this patchset, I think clayborg is the only one who can do a
proper review of
labath added a comment.
The thing to be aware of with this testing strategy is that you will probably
be the only person who will be able to run these tests and verify dwz
functionality. If you don't setup a buildbot testing this then other developers
will never even know if they have broken an
labath added a comment.
On 28 November 2017 at 06:12, Zachary Turner via lldb-commits
wrote:
> yaml2core would be an excellent idea for a tool.
An (elf) core file is an elf file, with metadata in the elf program headers, so
I think this would naturally fit into yaml2obj. Unfortunately, yaml2o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319161: Fix floating point register write on new x86 linux
kernels (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D40434
Files:
lldb/trunk/packages/Python/lldbsuite/test/functio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319162: elf-core: Convert remaining register context to use
register set maps (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D40133
Files:
lldb/trunk/source/Plugins/Process/elf-c
labath created this revision.
Herald added a subscriber: mehdi_amini.
Variable::GetValuesForVariableExpressionPath was passing an
uninitialised value for the final_task_on_target argument. On my
compiler/optimization level combo, the final_task_on_target happened to
contain "dereference" in some c
labath added a comment.
Looks good, thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D40587
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath created this revision.
llvm::APSInt(0) asserts because it creates an int with bit-width 0 and
not (as I thought) a value 0.
Theoretically it should be sufficient to change this to APSInt(1), as
the intention there was that the value of the first argument should be
ignored if the type is in
labath created this revision.
Herald added subscribers: aprantl, mgorny, emaste.
We use the llvm decompressor to decompress SHF_COMPRESSED sections. This enables
us to read data from debug info sections, which are sometimes compressed,
particuarly in the split-dwarf case. This functionality is on
labath marked an inline comment as done.
labath added inline comments.
Comment at: include/lldb/Symbol/CompilerType.h:294
+ struct IntegralTemplateArgument;
+
clayborg wrote:
> Can't you just define the type right here?
Unfortunately, I can't because it contai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319414: Fix assertion in ClangASTContext (authored by
labath).
Changed prior to commit:
https://reviews.llvm.org/D40615?vs=124781&id=124890#toc
Repository:
rL LLVM
https://reviews.llvm.org/D40615
F
labath added a comment.
I feel this is reimplementing llvm-readobj, but maybe that's appropriate as we
are reimplementing object file readers as well (my original patch wouldn't be
necessary if we were using the llvm object library). Minor comments below, but
I actually quite like this approach
labath updated this revision to Diff 124926.
labath added a comment.
This rewrites the test in terms on the new lldb-test utility. It should be
applied on top of https://reviews.llvm.org/D40636.
While doing that, I noticed a discrepancy in the data presented by the object
file interface -- for G
labath added a comment.
In https://reviews.llvm.org/D40475#940226, @jankratochvil wrote:
> > you will probably be the only person who will be able to run these tests
> > and verify dwz functionality.
>
> OK; really nobody runs RHEL/CentOS/Fedora? :-)
There aren't that many lldb developers... I
labath added inline comments.
Comment at: lit/Modules/compressed-sections.yaml:1
+# REQUIRES: zlib
+# RUN: yaml2obj %s > %t
It's right here. (I'm open to suggestions where to place it).
https://reviews.llvm.org/D40616
labath marked 2 inline comments as done.
labath added inline comments.
Comment at: lit/Modules/compressed-sections.yaml:1
+# REQUIRES: zlib
+# RUN: yaml2obj %s > %t
zturner wrote:
> labath wrote:
> > It's right here. (I'm open to suggestions where to place it).
>
labath updated this revision to Diff 125110.
labath added a comment.
Rebase on master and update the test.
https://reviews.llvm.org/D40616
Files:
lit/CMakeLists.txt
lit/Modules/compressed-sections.yaml
lit/Modules/lit.local.cfg
lit/lit.cfg
lit/lit.site.cfg.in
source/Plugins/ObjectFi
labath created this revision.
Herald added subscribers: JDevlieghere, krytarowski, aprantl, emaste.
This flag is on by default for darwin and freebsd, but off for linux.
Without it, clang will sometimes not emit debug info for types like
std::string. Whether it does this, and which tests will fail
labath added inline comments.
Comment at: lit/Modules/compressed-sections.yaml:20
+ - Name:.bogus
+# CHECK-NOT: .bogus
+Type:SHT_PROGBITS
zturner wrote:
> labath wrote:
> > zturner wrote:
> > > You should probably put this as the very
labath added a comment.
If the "excuse" for not following llvm here is that these structs mirror apple
headers, should we restrict these warnings only to the relevant files (e.g.
everything in `source/Plugins/Language/ObjC`)?
I don't particularly care about whether we do, but I wanted to throw
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319653: Makefile.rules: compile all tests with
-fno-limit-debug-info (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D40717
Files:
lldb/trunk/packages/Python/lldbsuite/test/expre
labath accepted this revision.
labath added a comment.
In https://reviews.llvm.org/D40757#944293, @vsk wrote:
> I'd like to make this a narrower change as well, but unfortunately, I haven't
> found a way to add in extra CXX flags through the add_library or
> llvm_add_library utilities. Somebody
labath added a comment.
Jim, could you have a quick look at this?
thanks.
https://reviews.llvm.org/D40557
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath accepted this revision.
labath added a comment.
Cool. Thanks.
https://reviews.llvm.org/D40757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320021: Variable: Fix usage of uninitialised value (authored
by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D40557
Files:
lldb/trunk/source/Symbol/Variable.cpp
Index: lldb/trunk/source/S
labath created this revision.
For ptys (at least on Linux), the end-of-file (closing of the slave FD)
is signalled by the POLLHUP flag. We were ignoring this flag, which
meant that when this happened, we would spin in a loop, continuously
calling poll(2) and not making any progress.
This makes su
labath added a comment.
Darwin uses a kqueue-based implementation of this, so it definitely won't
*break* anything, although I'd appreciate it if you can check whether the test
passes there. My cursory reading of the kqueue man page makes me believe it
should not be affected by this.
https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320345: MainLoop: avoid infinite loop when pty slave gets
closed (authored by labath).
Repository:
rL LLVM
https://reviews.llvm.org/D41008
Files:
lldb/trunk/source/Host/common/MainLoop.cpp
lldb/tr
labath created this revision.
Herald added a subscriber: mgorny.
Adding a new test would require one to duplicate a significant part of
the existing test that we have. This attempts to reduce that by moving
some part of that code to the test fixture. The StandardStartupTest
fixture automatically s
labath created this revision.
This makes StopReply class abstract, so that we can represent different
types of stop replies such as StopReplyStop and StopReplyExit (there
should also be a StopReplySignal, but I don't need that right now so I
haven't implemented it yet).
This prepares the ground f
labath created this revision.
lldb-server was sending the "exit" packet (W??) twice. This happened
because it was handling both the pre-exit (PTRACE_EVENT_EXIT) and
post-exit (WIFEXITED) as exit events. We had some code which was trying
to detect when we've already sent the exit packet, but this s
labath created this revision.
Herald added a subscriber: mgorny.
We were failing to propagate the environment when lldb-server was
started with a pre-loaded process
(e.g.: lldb-server gdbserver -- inferior --inferior_args)
This patch makes sure the environment is propagated. Instead of adding a
n
labath added a comment.
In https://reviews.llvm.org/D41069#951208, @clayborg wrote:
> Is the lldb_private::Process we have an exit status in the class itself. The
> first person to set the exit status wins and no one can set it twice. Doesn't
> look like what we are doing here. I am not able to
labath updated this revision to Diff 126389.
labath added a comment.
apply clang-format
https://reviews.llvm.org/D41069
Files:
source/Plugins/Process/Linux/NativeProcessLinux.cpp
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
unittests/tools/lldb-server/tests/TestC
labath added a comment.
@davide: Any thoughts on `.yaml` as a test file suffix?
@clayborg: What do you think about my comment about GetFileSize() of compressed
sections
In https://reviews.llvm.org/D40616#940408, @labath wrote:
> This rewrites the test in terms on the new lldb-test utility. It
labath added a comment.
In https://reviews.llvm.org/D40616#951324, @clayborg wrote:
> I think GetFileSize() should remain the number of bytes of the section on
> disk and we should add new API if we need to figure out the decompressed
> size. Or maybe when we get bytes from a compressed section
labath added a comment.
In https://reviews.llvm.org/D40616#952432, @clayborg wrote:
> Does that sound right?
Yes, I'll get on it.
https://reviews.llvm.org/D40616
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
labath added inline comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h:46
- //--
- /// Specify the program to launch and its arguments.
- ///
- /// @param[in] args
- //
labath created this revision.
labath added a reviewer: clayborg.
Herald added subscribers: JDevlieghere, emaste.
These two functions were calling each other, while handling different
branches of the if(IsInMemory()). I am assuming this had a reason at
some point in the past, but right now it's jus
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320705: ObjectFile: remove
ReadSectionData/MemoryMapSectionData mutual recursion (authored by labath,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41169?vs=126723&id=126949#toc
R
labath updated this revision to Diff 126975.
labath added a comment.
The version where Section::GetFileSize reports the on-disk (compressed) size. I
also like the idea of renaming Section::GetByteSize to something more
descriptive, and I'll make a follow-up patch to do that.
https://reviews.llvm
labath created this revision.
labath added reviewers: clayborg, krytarowski.
Herald added a subscriber: emaste.
The x86 FPR struct (which does not store just floating point registers)
was defined as a struct containing a union between two members: XSAVE
and FXSAVE. The initial layout of these two
labath added a comment.
In https://reviews.llvm.org/D41245#955462, @krytarowski wrote:
> Personally I prefer the original code as it looks easier to implement FSAVE.
Maybe we could delete at least one layer then (make FPR a union which contains
fxsave and xsave members)?
Also, I am curious: i
labath updated this revision to Diff 127111.
labath added a comment.
New version. This one keeps the fxsave/xsave distinction, but it makes FPR a
union directly, so it saves us one level of indirection.
https://reviews.llvm.org/D41245
Files:
source/Plugins/Process/Linux/NativeRegisterContextL
labath added a comment.
In https://reviews.llvm.org/D41245#97, @krytarowski wrote:
> Maybe reuse FPR for FXSAVE/FSAVE and add next to it XSAVE/XSAVE_OPT.
I am not sure what you mean by that, but I don't think it can work that way, as
xsave area already contains a copy of the fpu registers,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320809: llgs-tests: Make addition of new tests easier
(authored by labath, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41066
Files:
lldb/trunk/unittests/tools/lldb-server/CMakeList
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320813: ObjectFileELF: Add support for compressed sections
(authored by labath, committed by ).
Changed prior to commit:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320820: llgs-tests: Add support for "exit"
stop-reply packets (authored by labath, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41067
Files:
lldb/trunk/include/lldb/Host/Host.h
ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320961: NPL: Clean up handling of inferior exit (authored by
labath, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41069
Files:
lldb/trunk/source/Plugins/Process/Linux/NativeProcessL
labath added inline comments.
Comment at: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3496
+
+ auto Decompressor = llvm::object::Decompressor::create(
+ section->GetName().GetStringRef(),
tzik wrote:
> This adds new dependency to LLVM Object
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320966: Reduce x86 register context boilerplate. (authored
by labath, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41245
Files:
lldb/trunk/source/Plugins/Process/Linux/NativeRegiste
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320984: llgs: Propagate the environment when launching the
inferior from command line (authored by labath, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41070?vs=126367&id=127349#to
labath created this revision.
labath added reviewers: jasonmolenda, clayborg.
Herald added a subscriber: JDevlieghere.
Make sure we propagate environment when starting debugserver with a pre-loaded
inferior. AFAIK, RNBRunLoopLaunchInferior is only called in pre-loaded inferior
scenario, so we can
labath updated this revision to Diff 127358.
labath added a comment.
re-clang-format the patch
https://reviews.llvm.org/D41352
Files:
tools/debugserver/source/debugserver.cpp
unittests/tools/lldb-server/tests/LLGSTest.cpp
Index: unittests/tools/lldb-server/tests/LLGSTest.cpp
=
labath created this revision.
labath added reviewers: zturner, davide, jingham, clayborg.
Herald added subscribers: mgorny, emaste.
There was some confusion in the code about how to represent process
environment. Most of the code (ab)used the Args class for this purpose,
but some of it used a more
labath marked an inline comment as done.
labath added inline comments.
Comment at: include/lldb/Utility/Environment.h:70-72
+ std::pair insert(llvm::StringRef KeyEqValue) {
+return insert(KeyEqValue.split('='));
+ }
zturner wrote:
> Why'd you decide to go w
labath updated this revision to Diff 127384.
labath added a comment.
re-clang-format the patch
https://reviews.llvm.org/D41359
Files:
include/lldb/API/SBLaunchInfo.h
include/lldb/Host/Host.h
include/lldb/Interpreter/Args.h
include/lldb/Target/Platform.h
include/lldb/Target/ProcessInfo
labath added a comment.
In https://reviews.llvm.org/D41352#958549, @clayborg wrote:
> We already have an option for this named "--forward-env". It might be better
> to fix this by adding the "--forward-env" argument to the debugserver launch
> during testing? When we launch through LLDB, it for
labath added inline comments.
Comment at: include/lldb/Target/Platform.h:636
- virtual size_t GetEnvironment(StringList &environment);
+ virtual Environment GetEnvironment();
clayborg wrote:
> Do we want to return by value? Not a const reference?
This objec
labath added a comment.
In https://reviews.llvm.org/D41352#959051, @jasonmolenda wrote:
> I guess I don't have an opinion on this one. The correct way to pass
> environment variables to the inferior is through
> SBLaunchInfo::SetEnvironmentEntries or in cmd line lldb, process launch -v
> ENV=
labath updated this revision to Diff 127500.
labath added a comment.
It took a while, but we've finally landed an llvm::WritableMemoryBuffer class.
This patch now becomes simple, as all I need to do is use that instead of the
MemoryBuffer class.
Well.. almost. The new class does not have the null
labath updated this revision to Diff 127681.
labath added a comment.
Herald added a subscriber: mgorny.
New version: Make sure we respect variables set by --env and that they are not
overridden by --forward-env (the last part relies on the fact that in the
presence of multiply-defined environment
labath updated this revision to Diff 127687.
labath added a comment.
Add the suggested MapFileData function
https://reviews.llvm.org/D40079
Files:
include/lldb/Interpreter/OptionValueFileSpec.h
include/lldb/Symbol/ObjectFile.h
include/lldb/Target/Target.h
include/lldb/Utility/DataBuffer
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321255: Make sure DataBufferLLVM contents are writable
(authored by labath, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D40079
Files:
lldb/trunk/include/lldb/Interpreter/OptionValue
labath added inline comments.
Comment at: tools/debugserver/source/debugserver.cpp:1426
+for (i = 0; (env_entry = host_env[i]) != NULL; ++i)
+ remote->Context().PushEnvironment(env_entry);
+ }
clayborg wrote:
> We need to check if the env var is already
labath updated this revision to Diff 127898.
labath added a comment.
Add PushEnvironmentIfNeeded to avoid creating duplicate entries in the
environment.
https://reviews.llvm.org/D41352
Files:
tools/debugserver/source/RNBContext.cpp
tools/debugserver/source/RNBContext.h
tools/debugserver/
labath added a comment.
This is making the windows unit tests fail:
http://lab.llvm.org:8011/builders/lldb-windows7-android/builds/7378/steps/run%20unit%20tests/logs/stdio.
If I understand correctly, this changes FindTypes to **not** search by regex.
If that's the case, then the `SymbolFilePDBTe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321355: debugserver: Propagate environment in launch-mode
(pr35671) (authored by labath, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41352
Files:
lldb/trunk/tools/debugserver/sourc
labath added a comment.
Maybe we could just change the lit script to use the value of
`LLVM_ENABLE_ZLIB` as the trigger? That should work in both standalone and
non-standalone builds (and it seems more clean -- I'm not sure why llvm does
not do the same)?
https://reviews.llvm.org/D41725
__
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm, thanks.
https://reviews.llvm.org/D41726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
labath added a comment.
Is the only difference between ppc64 and ppc64le ABIs in the endianness of the
values?
If so, could we make one unified ABI which takes the endianness as an argument
(in the constructor, or as a template argument, or deduces it from target
endiannes, ...) ?
https://rev
labath added a comment.
The ProcessGdbRemote part is not really testable in it's current form, but for
the rest, you should be able to write a gdbremoteclient unittest (see
unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp).
Comment at: source/Plugins/Process/
labath added a comment.
In https://reviews.llvm.org/D41725#969183, @mgorny wrote:
> Maybe we could. I presumed people are using the separate variables for some
> reason. We'd have to check that it's properly sanitized when building in-tree
> and given to cmake though.
I would expect that reas
labath added a comment.
In https://reviews.llvm.org/D41725#969189, @mgorny wrote:
> That said, is there a reason for LLDB to use zlib directly instead of using
> the LLVM support compression library?
We aren't using zlib directly. We only need to know whether llvm was configured
with zlib sup
labath added a comment.
In https://reviews.llvm.org/D41702#969294, @hfinkel wrote:
> In https://reviews.llvm.org/D41702#969179, @labath wrote:
>
> > Is the only difference between ppc64 and ppc64le ABIs in the endianness of
> > the values?
> > If so, could we make one unified ABI which takes th
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I think this makes the code hard to read. A much better approach would be to
use `Expected` + factory function pattern. So you would have something like:
Expected> LLVMCDisassemble
labath added a comment.
In https://reviews.llvm.org/D41725#969388, @mgorny wrote:
> I was talking of:
>
> source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
> source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
Ah, right. These uses were introduced before we develop
labath added a comment.
In https://reviews.llvm.org/D41584#970945, @tatyana-krasnukha wrote:
> Thank you, Pavel.
> Would you mind if I move LLVMCDisassembler declaration in .cpp also? It
> looks like perfect candidate for pimpl.
Yes, that sounds like a good idea.
> And... doesn't Disassemble
labath added subscribers: jhibbits, emaste.
labath added a comment.
In https://reviews.llvm.org/D41702#970887, @alexandreyy wrote:
> Thanks, @labath .
> The ABI plugin for PPC64be is not working: https://reviews.llvm.org/D5988 .
> It was implemented based on the x86_64 plugin and needs to be fi
labath added subscribers: emaste, krytarowski, ted.
labath added a comment.
I'm adding some people with non-linux non-x86/arm targets who use this plugin
for more visibility. I have a couple of small comments, but in general, I am
happy with this.
Comment at:
packages/Python
labath created this revision.
labath added reviewers: jingham, clayborg, davide.
This used to be important when all tests were run in a single process,
but that has no longer been the case for a while. Furthermore, this hook fails
to build on new mac versions for several people, and it's not clear
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322167: [dotest] Remove crashinfo hook (authored by labath,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41871?vs=129102&id=129224#toc
Rep
labath accepted this revision.
labath added a comment.
Looks good to me. Just make sure to respond to all of Greg's comments as well.
Comment at: source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp:989-1003
+DisassemblerLLVMC::MCDisasmToolset::MCDisasmToolset(
+std::uniq
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
looks good, thanks.
https://reviews.llvm.org/D41533
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
labath added a comment.
In https://reviews.llvm.org/D41702#971076, @jhibbits wrote:
> > @emaste, @jhibbits: do you know what's the state of ppc64 lldb support in
> > freebsd?
>
> It's broken because LLDB doesn't yet handle function descriptors, and I
> haven't yet made the effort (ENOTIME) to f
This revision was automatically updated to reflect the committed changes.
labath marked an inline comment as done.
Closed by commit rL322171: [zorg] Enable assertions on the linux lldb bot
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322174: Add Utility/Environment class for handling...
environments (authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41359?
labath created this revision.
labath added reviewers: jingham, clayborg.
Herald added a subscriber: emaste.
These were used by Host::LaunchProcess to "resolve" the executable it
was about to launch. The only parts of Platform::ResolveExecutable, which
seem to be relevant here are the FileSpec::Res
This revision was automatically updated to reflect the committed changes.
Closed by commit rL322190: Handle O reply packets during qRcmd (authored by
labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41745?vs=128991&id=129273#toc
labath added a comment.
Committed as r322190. I've changed one more std::function to function_ref and
re-clang-formatted the patch.
Repository:
rL LLVM
https://reviews.llvm.org/D41745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
labath updated this revision to Diff 129435.
labath added a comment.
Add back bundle resolution to the mac launcher
https://reviews.llvm.org/D41902
Files:
source/Host/common/MonitoringProcessLauncher.cpp
source/Host/freebsd/Host.cpp
source/Host/macosx/Host.mm
source/Host/netbsd/Host.cpp
labath added a comment.
In https://reviews.llvm.org/D41962#973827, @craig.topper wrote:
> I don't know what platforms this needs to support. But __builtin_cpu_support
> only works when compiled with clang or gcc. And it requires compiler-rt or
> libgcc. I don't know if that's guaranteed to exis
labath added inline comments.
Comment at:
Python/lldbsuite/test/expression_command/call-overridden-method/Makefile:10
+ CFLAGS_EXTRAS += -fno-limit-debug-info
+endif
+
no-limit-debug-info handling has recently been centralized into Makefile.rules.
This block h
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
Thank you for looking at this @chmeee. @alexandreyy, could you update this
plugin to handle big-endian as well, and then delete the old plugin?
https://reviews.llvm.org/D41702
__
601 - 700 of 6408 matches
Mail list logo
