labath added inline comments.
================ Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:735 /// (see ELFNote structure) /// 3) A Thread Context in a core file usually described by 3 NOTE entries. /// a) NT_PRSTATUS - Register context ---------------- krytarowski wrote: > Can we label it as SVR4-style (Linux, FreeBSD, Solaris)? Alternatively move > it to other place in order to describe Linux and FreeBSD separately (NetBSD > an OpenBSD can be skipped now). Yeah, I was wondering what to do with that comment -- it is so vague it is nearly useless. I agree we should move the core file description to the individual OS's parsing functions. I've written a description of the linux notes. Freebsd ones seem pretty similar, but don't know enough about them to say if the description applies to them as well. https://reviews.llvm.org/D40311 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
