[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

thakis added a comment. Reduced repro at https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c7 Scrolling up, it looks like this was reverted yesterday already. I'm confused why this wasn't reverted yesterday; all work I did in bisecting and creducing was a duplicate of what happened

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

thakis added a comment. This makes clang crash, repro at https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c4 I'll revert for now. I'm also seeing timeouts and use-after-frees on other bots; maybe they're related (or maybe not). CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

thakis added a comment. In both gcc and clang, -Wmisleading-indentation is part of -Wall as far as I can tell: https://godbolt.org/z/Msaz6Kb6T In which build configuration does this change have an effect? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

thakis added a comment. We can add flags for omitting access specifiers etc if it's critical for lldb. Or maybe we can just change the test that caused the revert. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68134/new/ https://reviews.llvm.org/D68134 ___

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

thakis added a comment. This fails on Windows: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/5779/steps/test-check-llvm-unit-check-clang-unit/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/ https://reviews

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

thakis added a comment. Nice! This makes https://bugs.llvm.org/show_bug.cgi?id=42524#c3 easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 ___ lldb-commits

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

thakis added inline comments. Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:737 TagTypeNode *Demangler::parseTagUniqueName(StringView &MangledName) { + if (!MangledName.consumeFront(".?A")) { kwk wrote: > Why not change the return type to `llvm::Expecte

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. Hello, in a bit of a https://xkcd.com/1172/ moment this breaks the chromium/android build. We have a list of "resources" (strings, bitmaps, etc) that we list in an XML file which then generates a header with lots of "IDR_foo" constants. As it turns out, now all of these

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. That problem only seems to happen when (thin) lto is enabled. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54747/new/ https://reviews.llvm.org/D54747 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

thakis added a comment. Add a test that fails without the code change and that passes with it. I don't know under which conditions this change is needed, so I apologize that I can't make a more concrete suggestion. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. This breaking both debug info in thinlto builds and fmodules-debuginfo is probably enough to revert and go back to the drawing board. I suppose we don't have any debug info quality tests that use thinlto? Repository: rL LLVM CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. Thanks for the revert! > So I'm going to revert this to unbreak the Chromium/Android build, and then > we can think some more about how we can get the size win without the breakage. I think by now the Chromium/Android build is a red herring. This drops debug info from t

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. echristo's comments on the mail thread for this didn't make it to phab. I apologize for repeating more or less everything he said, I had looked on phab before reading email. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54747/new/ https:/

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. For posterity, https://bugs.chromium.org/p/chromium/issues/detail?id=960881#c31 has the explanation for what exactly was happening in the Chromium/Android build. It's a bit different from rnk's example since no cross-TU imports are happening. It likely explains why rnk c

[Lldb-commits] [PATCH] D80173: Give microsoftDemangle() an outparam for how many input bytes were consumed.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc1c3655bfd6: Give microsoftDemangle() an outparam for how many input bytes were consumed. (authored by thakis). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to com

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

thakis added a comment. There's still one failing test on Windows after the fix attempt: http://45.33.8.238/win/3052/step_6.txt Please take a look and revert if it's not an easy fix. (And please watch bots after committing stuff.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

thakis added a comment. A very late follow-up to my question in D37272 :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72855/new/ https://reviews.llvm.org/D72855 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

thakis created this revision. thakis added a reviewer: rnk. Herald added a subscriber: mgorny. Herald added a project: LLVM. thakis added a comment. A very late follow-up to my question in D37272 :) When LLVM_APPEND_VC_REV=OFF is set, the current git hash is no

[Lldb-commits] [PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb5fafb23cc2: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well. (authored by thakis). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

<    1   2