thakis added inline comments.
================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:737
TagTypeNode *Demangler::parseTagUniqueName(StringView &MangledName) {
+ if (!MangledName.consumeFront(".?A")) {
----------------
kwk wrote:
> Why not change the return type to `llvm::Expected<TagTypeNode>`? Then you
> have one return value that is either an error (when return value evaluates to
> `false`) or the value. On top of just a boolean `Error` variable you then can
> also use the return value to store error texts if you need them. Now, I don't
> know if the `Error` member is used anywhere else.
Error is not a parameter, it's class-level state that's used pervasively in
this file.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60963/new/
https://reviews.llvm.org/D60963
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
