[Lldb-commits] [PATCH] D60022: [Process] Fix WriteMemory return value

mib updated this revision to Diff 192954. mib added a comment. Remove TraceOn and XMLSupport Check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60022/new/ https://reviews.llvm.org/D60022 Files: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestWriteMemory.py so

[Lldb-commits] [PATCH] D60022: [Process] Fix WriteMemory return value

This revision was automatically updated to reflect the committed changes. Closed by commit rL357420: [Process] Fix WriteMemory return value (authored by mib, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D60092: [Process] Use early returns in Process::WriteMemory (NFC)

mib added a comment. LGTM! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60092/new/ https://reviews.llvm.org/D60092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [PATCH] D60092: [Process] Use early returns in Process::WriteMemory (NFC)

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60092/new/ https://reviews.llvm.org/D60092 ___ lldb-commits mail

[Lldb-commits] [PATCH] D154649: [lldb] Fix dead lock issue when loading modules in Scripted Process

mib created this revision. mib added reviewers: jingham, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch attempts to fix a dead lock when loading modules in a Scripted Process. This is

[Lldb-commits] [PATCH] D154649: [lldb] Fix dead lock issue when loading modules in Scripted Process

This revision was automatically updated to reflect the committed changes. Closed by commit rG1f5f4169c427: [lldb] Fix dead lock issue when loading modules in Scripted Process (authored by mib). Changed prior to commit: https://reviews.llvm.org/D154649?vs=537846&id=537887#toc Repository: rG L

[Lldb-commits] [PATCH] D154542: Further refinements on reporting interruption in lldb

mib added a comment. LGTM! Thanks Jim! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154542/new/ https://reviews.llvm.org/D154542 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D154752: runCmd should print the command before running it in case of crashes

mib accepted this revision. mib added a comment. Yep, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154752/new/ https://reviews.llvm.org/D154752 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D153735: [lldb][TargetGetModuleCallback] Implement Python interface

mib added a comment. LGTM with @clayborg comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://reviews.llvm.org/D153735 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D155129: [lldb] Move CommandOverrideCallbackWithResult to lldb_private namespace

mib accepted this revision. mib added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155129/new/ https://reviews.llvm.org/D155129 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

mib created this revision. mib added reviewers: jingham, JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds the ability to pass native types from the script interpreter to

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/bindings/python/python-typemaps.swig:108 +} else { + $1 = $input; +} bulbazord wrote: > Do we actually have to do any conversions here? Like to turn it into

[Lldb-commits] [PATCH] D155653: [lldb][NFCI] Add some missing SB class forward declarations

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155653/new/ https://reviews.llvm.org/D155653 ___ lldb

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

mib updated this revision to Diff 542217. mib marked 10 inline comments as done. mib edited the summary of this revision. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155161/new/ https://reviews.llvm.org/D155161 Files: lldb/bindings/

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

mib added a comment. In D155161#4516564 , @bulbazord wrote: > I'm good with this approach. One thing to note is that this change is > explicitly **ABI breaking**. Specifically this change removes > `lldb::ScriptedObject` so `SBProcess::GetScriptedImplem

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

mib updated this revision to Diff 543101. mib edited the summary of this revision. mib added a comment. Address @JDevlieghere & @bulbazord comments: - Add `SBScriptObject` with PIMPL CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155161/new/ https://reviews.llvm.org/D155161 Files: ll

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

mib updated this revision to Diff 543122. mib marked 3 inline comments as done. mib added a comment. Address @JDevlieghere last comments. - Use `unique_ptr` instead of `shared_ptr` for PIMPL - Add missing new line after instrumentation macros - Move `ScriptObject` from `Utility` to `Interpreter`

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

This revision was automatically updated to reflect the committed changes. Closed by commit rG57bd882343f8: [lldb] Convert script native types to StructuredData counterpart (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155161/new/

[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

mib added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156270/new/ https://reviews.llvm.org/D156270 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

mib added inline comments. Comment at: lldb/include/lldb/Utility/AppleUuidCompatibility.h:15 // uuid_t is guaranteed to always be a 16-byte array typedef unsigned char uuid_t[16]; #endif // utility_UUID_COMPATIBILITY_H May be this could be moved to `lldb-types

[Lldb-commits] [PATCH] D156919: [lldb/crashlog] Make register output match lldb ordering in legacy mode

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the way we dump the registers from the legacy crashlog command to make

[Lldb-commits] [PATCH] D156919: [lldb/crashlog] Make register output match lldb ordering in legacy mode

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:104 +registers_info = None +if self.arch: +if "x86_64" == self.arch: bulbazord wrote: > Is there a reason to do a

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D157022: Fix the NSIndexSet formatter for macOS Sonoma

mib added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:294 + // This is the bitfield case. The bitfield is a uint64_t: + count = process_sp->ReadUnsignedIntegerFromMemory( + valobj_addr + 2 * ptr_size, 8, 0, error);

[Lldb-commits] [PATCH] D156919: [lldb/crashlog] Make register output match lldb ordering in legacy mode

mib updated this revision to Diff 547010. mib marked an inline comment as done. mib added a comment. Address feedback & reformat CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156919/new/ https://reviews.llvm.org/D156919 Files: lldb/examples/python/crashlog.py Index: lldb/examples/py

[Lldb-commits] [PATCH] D157043: [lldb/crashlog] Make TextCrashLogParser more resilient to new lines

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch changes the parsing logic for the legacy crash report format to avoid interrup

[Lldb-commits] [PATCH] D157044: [lldb/crashlog] Fix sticky image parsing logic

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. Prior to this patch, when a user loaded multiple crash report in lldb, they could get in

[Lldb-commits] [PATCH] D157137: [lldb/crashlog] Skip images with empty path and 0 UUID from loading

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch skips images with an empty path or a 0 UUID from loading as a SymbolFileJSON.

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

mib added a comment. Shouldn't this be next to the other `Stream` class in `lldbUtility` ? Comment at: lldb/include/lldb/Host/StreamFile.h:12 #include "lldb/Host/File.h" #include "lldb/Utility/Stream.h" Do we really need this header ? We could forward decla

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

mib added inline comments. Comment at: lldb/include/lldb/Host/StreamFile.h:12 #include "lldb/Host/File.h" #include "lldb/Utility/Stream.h" bulbazord wrote: > mib wrote: > > Do we really need this header ? We could forward declare FileSP do avoid > > having t

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

mib accepted this revision. mib added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Host/StreamFile.h:12 #include "lldb/Host/File.h" #include "lldb/Utility/Stream.h" bulbazord wrote: > mib wrote: > > bulbazord

[Lldb-commits] [PATCH] D157556: Replace the singleton "ShadowListener" with a primary and N secondary listeners

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with some comments :) Comment at: lldb/source/Target/Process.cpp:372 +const int Process::g_all_event_bits = eBroadcastBitStateChanged + | eBroa

[Lldb-commits] [PATCH] D157662: [lldb][NFCI] Change parameter type in Process::SetExitStatus

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Sounds reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157662/new/ https://reviews.llvm.org/D157662 ___

[Lldb-commits] [PATCH] D157759: [lldb] Remove use of __future__ in python

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Although we should make sure no one is still using Python 2 downstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157759/new/ https://reviews

[Lldb-commits] [PATCH] D157137: [lldb/crashlog] Skip images with empty path and 0 UUID from loading

mib updated this revision to Diff 549560. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157137/new/ https://reviews.llvm.org/D157137 Files: lldb/examples/python/symbolication.py Index: lldb/examples/python/symbolication.py =

[Lldb-commits] [PATCH] D157043: [lldb/crashlog] Make TextCrashLogParser more resilient to new lines

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f75c4d01eff: [lldb/crashlog] Make TextCrashLogParser more resilient to new lines (authored by mib). Changed prior to commit: https://reviews.llvm.org/D157043?vs=547013&id=549578#toc Repository: rG L

[Lldb-commits] [PATCH] D156919: [lldb/crashlog] Make register output match lldb ordering in legacy mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGf043e66e9883: [lldb/crashlog] Make register output match lldb ordering in legacy mode (authored by mib). Changed prior to commit: https://reviews.llvm.org/D156919?vs=547010&id=549577#toc Repository:

[Lldb-commits] [PATCH] D157137: [lldb/crashlog] Skip images with empty path and 0 UUID from loading

This revision was automatically updated to reflect the committed changes. Closed by commit rG706e875da3a2: [lldb/crashlog] Skip images with empty path and 0 UUID from loading (authored by mib). Changed prior to commit: https://reviews.llvm.org/D157137?vs=549560&id=549580#toc Repository: rG L

[Lldb-commits] [PATCH] D157044: [lldb/crashlog] Fix sticky image parsing logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75bed9655a54: [lldb/crashlog] Fix sticky image parsing logic (authored by mib). Changed prior to commit: https://reviews.llvm.org/D157044?vs=54701

[Lldb-commits] [PATCH] D157849: [lldb/crashlog] Replace deprecated optparse by argparse (NFC)

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added subscribers: lldb-commits, wangpc. This patch replace the deprecated `optparse` module used for the `crashlog`& `save

[Lldb-commits] [PATCH] D157850: [lldb/crashlog] Fix module loading for crashed thread behaviour

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. Before 27f27d15f , the `cras

[Lldb-commits] [PATCH] D157851: [lldb/crashlog] Add support for Last Exception Backtrace

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds support to the "Last Exception Backtrace" to the `crashlog` command. Thi

[Lldb-commits] [PATCH] D157852: [lldb/crashlog] Skip non-crashed threads in batch mode

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. When using the `crashlog` command in batch mode, most users only care about the crashed t

[Lldb-commits] [PATCH] D157043: [lldb/crashlog] Make TextCrashLogParser more resilient to new lines

mib added a comment. In D157043#4582385 , @JDevlieghere wrote: > Test? I'll do it in a follow-up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157043/new/ https://reviews.llvm.org/D157043 _

[Lldb-commits] [PATCH] D157851: [lldb/crashlog] Add support for Last Exception Backtrace

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:800-806 +thread = self.crashlog.Thread( +len(self.crashlog.threads), True, self.crashlog.process_arch +) +thread.queue = "Application Specific Backtrace" +for backt

[Lldb-commits] [PATCH] D158022: [lldb] Print an actionable error message when sphinx_automodapi is not installed

mib added a comment. We should really add a `requirements.txt` file with all the dependencies. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158022/new/ https://reviews.llvm.org/D158022 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

mib added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:806 + target.GetArchitecture(), + ConstString()); }

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

mib accepted this revision. mib added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158043/new/ https://reviews.llvm.org/D158043 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D157850: [lldb/crashlog] Fix module loading for crashed thread behaviour

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21a597c31cb8: [lldb/crashlog] Fix module loading for crashed thread behaviour (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D157849: [lldb/crashlog] Replace deprecated optparse by argparse (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGeef5eadbe617: [lldb/crashlog] Replace deprecated optparse by argparse (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157849/new/ htt

[Lldb-commits] [PATCH] D157851: [lldb/crashlog] Add support for Last Exception Backtrace

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c4f0d81f47c: [lldb/crashlog] Add support for Last Exception Backtrace (authored by mib). Changed prior to commit: https://reviews.llvm.org/D157851?vs=549854&id=551613#toc Repository: rG LLVM Github

[Lldb-commits] [PATCH] D157852: [lldb/crashlog] Skip non-crashed threads in batch mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a44eedb842d: [lldb/crashlog] Skip non-crashed threads in batch mode (authored by mib). Changed prior to commit: https://reviews.llvm.org/D157852?vs=549855&id=551615#toc Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D157043: [lldb/crashlog] Make TextCrashLogParser more resilient to new lines

mib closed this revision. mib added a comment. In D157043#4584339 , @mib wrote: > In D157043#4582385 , @JDevlieghere > wrote: > >> Test? > > I'll do it in a follow-up. 7602641

[Lldb-commits] [PATCH] D158452: [lldb/crashlog] Fix python version requirement issue

mib created this revision. mib added reviewers: JDevlieghere, kastiglione, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. In 21a597c

[Lldb-commits] [PATCH] D158452: [lldb/crashlog] Fix python version requirement issue

This revision was automatically updated to reflect the committed changes. Closed by commit rG446abb5125f7: [lldb/crashlog] Fix python version requirement issue (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158452/new/ https://revi

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

mib updated this revision to Diff 552871. mib added a comment. Revert deletions to `formatting.rst` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158323/new/ https://reviews.llvm.org/D158323 Files: lldb/docs/_static/lldb.css lldb/docs/conf.py lldb/docs/resources/build.rst lldb/

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

mib added a comment. Given we didn't receive more feedback on this, I'll land it now. If there are other comments, we can address those after the fact. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158323/new/ https://reviews.llvm.org/D158323 __

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

This revision was automatically updated to reflect the committed changes. Closed by commit rGeea887406498: [lldb/infra] Revamp lldb.llvm.org (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158323/new/ https://reviews.llvm.org/D15832

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

mib added subscribers: tonic, gkistanova. mib added a comment. In D158323#4614373 , @aaron.ballman wrote: > In D158323#4613878 , @mib wrote: > >> Given we didn't receive more feedback on this, I'll land it now. I

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

mib added a comment. In D158323#4614469 , @aaron.ballman wrote: > In D158323#4614446 , @mib wrote: > >> In D158323#4614373 , >> @aaron.ballman wrote: >> >>> In D158323#4

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

mib added a comment. Given that the bot is still red, I've reverted the patch in dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158323/ne

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

mib created this revision. mib added reviewers: JDevlieghere, jingham, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. As we're consolidating and streamlining the various scripting affordances of ll

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a2552a1419d: [lldb/infra] Revamp lldb.llvm.org (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158323/new/ https://reviews.llvm.org/D15832

[Lldb-commits] [PATCH] D159017: [lldb/docs] Silence warnings when generating website

mib created this revision. mib added reviewers: JDevlieghere, bulbazord, gkistanova. mib added a project: LLDB. Herald added a subscriber: Michael137. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch does various things to sile

[Lldb-commits] [PATCH] D159017: [lldb/docs] Silence warnings when generating website

mib updated this revision to Diff 554102. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159017/new/ https://reviews.llvm.org/D159017 Files: lldb/bindings/interface/SBAddressExtensions.i lldb/bindings/interface/SBAttachInfoExtensions.i lldb/bindings/interface/SBBlockExtensions.i l

[Lldb-commits] [PATCH] D159017: [lldb/docs] Silence warnings when generating website

mib added inline comments. Comment at: lldb/docs/conf.py:46 autodoc_default_options = { "special-members": "__int__, __len__, __hex__, __oct__, __iter__", } @JDevlieghere AFAIK, if we want to silence the warnings, we should disable generating special memb

[Lldb-commits] [PATCH] D159017: [lldb/docs] Silence warnings when generating website

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0731d5b61ba: Re-land "[lldb/docs] Silence warnings when generating website" (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159017/new/ ht

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

mib added a comment. In D158833#4625775 , @bulbazord wrote: > Re-organizing the paths seems okay to me, especially since this is going to > grow further. I think the header guards are going to need some adjustment > though. TBH, I didn't even know they

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

mib updated this revision to Diff 554991. mib marked an inline comment as done. mib added a comment. Address @bulbazord comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158833/new/ https://reviews.llvm.org/D158833 Files: lldb/include/lldb/Interpreter/Interfaces/ScriptedInterfa

[Lldb-commits] [PATCH] D159310: [lldb] Move template python files to separate directory

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch moves the template files for the various scripting affordances to a separate d

[Lldb-commits] [PATCH] D159314: [lldb] Introduce OperatingSystem{, Python}Interface and make us it

mib created this revision. mib added reviewers: JDevlieghere, jingham, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch aims to consolidate the OperatingSystem scripting affordance by intro

[Lldb-commits] [PATCH] D159315: [lldb] Add OperatingSystem base class to the lldb python module

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduce an `OperatingSystem` base implementation in the `lldb` python module

[Lldb-commits] [PATCH] D159315: [lldb] Add OperatingSystem base class to the lldb python module

mib added a comment. In D159315#4633227 , @hawkinsw wrote: > I hope that some comments are helpful! The documentation that you added is > tremendously helpful -- I know how documentation is sometimes a thankless > task, so I will say what everyone is th

[Lldb-commits] [PATCH] D159315: [lldb] Add OperatingSystem base class to the lldb python module

mib updated this revision to Diff 555397. mib added a reviewer: hawkinsw. mib added a comment. Address @hawkinsw feedbacks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159315/new/ https://reviews.llvm.org/D159315 Files: lldb/bindings/python/CMakeLists.txt lldb/examples/python/tem

lldb-commits@lists.llvm.org

mib accepted this revision. mib added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159387/new/ https://reviews.llvm.org/D159387 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

mib updated this revision to Diff 392178. mib marked an inline comment as done. mib edited the summary of this revision. mib added a comment. Add invalid Scripted Thread test, addressing @JDevlieghere comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114923/new/ https://reviews.llv

[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcaea440a11e4: [lldb/plugins] Add arm64(e) support to ScriptedProcess (authored by mib). Changed prior to commit: https://reviews.llvm.org/D114923?

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial location at function start

mib created this revision. mib requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It can happen that a line entry reports that some source code is located at line 0. In DWARF, line 0 is a special location which indicates that code has no 1-1 m

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial location at function start

mib updated this revision to Diff 392622. mib added reviewers: aprantl, jingham. Herald added a subscriber: JDevlieghere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115313/new/ https://reviews.llvm.org/D115313 Files: lldb/source/Target/StackFra

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial location at function start

mib added a subscriber: DavidSpickett. mib added a comment. In D115313#3178578 , @dblaikie wrote: > Side note: The src_file is not to be trusted/used either - once line 0 is > specified, nothing else in that line entry is valid. LLVM lets the previous >

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib updated this revision to Diff 392834. mib retitled this revision from "[lldb/Target] Slide source display for artificial location at function start" to "[lldb/Target] Slide source display for artificial locations at function start". mib added a comment. Change warning to specify function nam

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/source/Target/StackFrame.cpp:1898 have_source = true; - // TODO: Give here a one time warning if source file is missing. + if (!num_lines || !m_sc.line_entry.line || +

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib updated this revision to Diff 392915. mib marked an inline comment as done. mib added a comment. Address @jingham feedbacks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115313/new/ https://reviews.llvm.org/D115313 Files: lldb/source/Target/StackFrame.cpp lldb/test/API/source-

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib updated this revision to Diff 392943. mib added a comment. Update the condition for printing the warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115313/new/ https://reviews.llvm.org/D115313 Files: lldb/source/Target/StackFrame.cpp l

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib updated this revision to Diff 392947. mib added a comment. Dropping the `LLDB_INVALID_LINE_NUMBER` check as it should only occur when we have no debug info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115313/new/ https://reviews.llvm.org/D115

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib updated this revision to Diff 392949. mib marked an inline comment as done. mib added a comment. Address @JDevlieghere comment regarding test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115313/new/ https://reviews.llvm.org/D115313 Files: lldb/source/Target/StackFrame.cpp lld

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

This revision was automatically updated to reflect the committed changes. Closed by commit rGedf410e48f5b: [lldb/Target] Slide source display for artificial locations at function start (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D115461: [lldb/Target] Refine source display warning for artificial locations (NFC)

mib created this revision. mib added a reviewer: aprantl. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. mib requested review of this revision. Herald added a subscriber: lldb-commits. This is a post-review update for D115313 , to rephrase so

[Lldb-commits] [PATCH] D115461: [lldb/Target] Refine source display warning for artificial locations (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG20db8e07f9d5: [lldb/Target] Refine source display warning for artificial locations (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib added a comment. In D115313#3182258 , @DavidSpickett wrote: >> Thanks for clarifying @DavidSpickett ! I'll change the warning accordingly. > > Too many Davids :) 😅😅 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D115652: [lldb/API] Add SetDataWithOwnership method to SBData

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a subscriber: yaxunl. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new method to SBData: SetDataWithOwnership. Instead of referencing t

[Lldb-commits] [PATCH] D115654: [lldb/plugin] Fix heap-use-after-free in ScriptedProcess::ReadMemory

mib created this revision. mib added reviewers: JDevlieghere, aprantl. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This commit should fix a heap-use-after-free bug that was caught by the sanitizer bot. The issue is that we were readin

[Lldb-commits] [PATCH] D115652: [lldb/API] Add SetDataWithOwnership method to SBData

This revision was automatically updated to reflect the committed changes. Closed by commit rG72e25978f93f: [lldb/API] Add SetDataWithOwnership method to SBData (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115652/new/ https://revi

[Lldb-commits] [PATCH] D115654: [lldb/plugin] Fix heap-use-after-free in ScriptedProcess::ReadMemory

This revision was automatically updated to reflect the committed changes. Closed by commit rGef74c8002ae8: [lldb/plugin] Fix heap-use-after-free in ScriptedProcess::ReadMemory (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115654/ne

[Lldb-commits] [PATCH] D115736: [lldb] (Semi-automatically) format .swig files

mib accepted this revision. mib added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115736/new/ https://reviews.llvm.org/D115736 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D115925: [lldb/python] Fix (some) dangling pointers in our glue code

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Thanks for fixing this! LGTM beside a small nit. Comment at: lldb/test/API/commands/command/script/TestCommandScript.py:172 +self.runCmd("command script add -f persistence.

[Lldb-commits] [PATCH] D116162: [lldb/python] Fix dangling Event and CommandReturnObject references

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. This patch looks good to me, however, may be it would be good to have a `IsInitialized`/ `IsCleared` method for all SB-types to make sure the object hasn't been cleared after going out-of-scope ? I

[Lldb-commits] [PATCH] D116162: [lldb/python] Fix dangling Event and CommandReturnObject references

mib added a comment. In D116162#3211322 , @labath wrote: > This isn't a feature I would want advertise too broadly, or add special APIs > to support it. The way I see it, if a user needs to check if an object has > been cleared, something has gone wrong

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

mib added a comment. In D100810#3186066 , @Ericson2314 wrote: > I tried again without lld in the list of enable projects, in case it that > made a difference to force it to use ld64 more, but it still worked. Hi @Ericson2314, I tried reproducing the fa

[Lldb-commits] [PATCH] D117065: [lldb/Plugins] Fix ScriptedInterface object ptr use-after-free

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLVM. mib requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch replaces all the ScriptedInterface object instance shared pointer by a raw pointer. The

  1   2   3   4   5   6   7   8   9   10   >