This revision was automatically updated to reflect the committed changes.
lemo marked an inline comment as done.
Closed by commit rL331394: Use the UUID from the minidump's CodeView
Record for placeholder modules (authored by lemo, committed by ).
Herald added a subscriber: llvm-commits.
Changed
lemo added a comment.
Thanks everyone. I don't have commit permissions, can someone please commit
this on my behalf?
Repository:
rL LLVM
https://reviews.llvm.org/D37527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.
lemo created this revision.
The main change is to avoid setting the process state as running when debugging
core/minidumps (details in the bug).
Also included a few small, related fixes around how the errors propagate in
this case.
https://reviews.llvm.org/D37651
Files:
include/lldb/Target
lemo added a comment.
Thanks everyone for the feedback.
I see a common question is why doesn't DoResume() fail-fast itself, or why
don't the callers propagate the error. It's a good question, since the
knowledge if a subclass can resume or not is almost codified in there. The
problem is that t
lemo updated this revision to Diff 114890.
lemo added a reviewer: markmentovai.
lemo added a comment.
Revised patch based on the review feedback: I looked into updating the running
state after everything else succeeds, but it proved a bit awkward since 1)
TrySetRunning() can fail and 2) if we ch
lemo updated this revision to Diff 115068.
lemo marked an inline comment as done.
lemo added a comment.
Adding test coverage
https://reviews.llvm.org/D37651
Files:
include/lldb/Target/Process.h
packages/Python/lldbsuite/test/functionalities/postmortem/elf-core/TestLinuxCore.py
packages/
lemo added a comment.
@Jim: Good point, I created this bug to track this as you suggested:
Bug 34594 - Revisit the failure path for Process::Resume() to avoid leaking
Stopped->Running->Stopped events
https://reviews.llvm.org/D37651
___
lldb-commits
lemo created this revision.
Herald added a subscriber: ki.stfu.
The core of this change is the new CommandInterpreter::m_command_state, which
models the state transitions for interactive commands, including an
"interrupted" state transition.
In general, command interruption requires cooperation
lemo created this revision.
Herald added a subscriber: ki.stfu.
1. Fix a data race (g_interrupt_sent flag usage was not thread safe, signals
can be handled on arbitrary threads)
2. exit() is not signal-safe, replaced it with the signal-safe equivalent
_exit()
https://reviews.llvm.org/D37926
F
lemo updated this revision to Diff 115476.
lemo added a comment.
Split the SIGINT handles fixes into a stanalone patch
https://reviews.llvm.org/D37923
Files:
include/lldb/Core/IOHandler.h
include/lldb/Interpreter/CommandInterpreter.h
source/Commands/CommandObjectTarget.cpp
source/Interp
lemo added inline comments.
Comment at: source/Commands/CommandObjectTarget.cpp:2058
+ break;
+}
num_dumped++;
amccarth wrote:
> Many LLVM developers prefer to omit the braces when the body of the
> control-flow statement is
lemo added inline comments.
Comment at: source/Interpreter/CommandInterpreter.cpp:2713
+ for (; chunk_size < size; ++chunk_size) {
+assert(data[chunk_size] != '\0');
+if (data[chunk_size] == '\n') {
amccarth wrote:
> Should we be that trustin
lemo updated this revision to Diff 115516.
lemo edited the summary of this revision.
lemo added a comment.
Incorporating CR feedback.
https://reviews.llvm.org/D37923
Files:
include/lldb/Core/IOHandler.h
include/lldb/Interpreter/CommandInterpreter.h
source/Commands/CommandObjectTarget.cpp
lemo added inline comments.
Comment at: source/Interpreter/CommandInterpreter.cpp:2708-2710
+const char *data = str.data();
+size_t size = str.size();
+while (size > 0 && !WasInterrupted()) {
lemo wrote:
> clayborg wrote:
> > Since we are using "llvm:
lemo added inline comments.
Comment at: source/Interpreter/CommandInterpreter.cpp:2708-2710
+const char *data = str.data();
+size_t size = str.size();
+while (size > 0 && !WasInterrupted()) {
lemo wrote:
> lemo wrote:
> > clayborg wrote:
> > > Since w
lemo updated this revision to Diff 115732.
lemo added a comment.
Fixed the FreeBSD/Windows break : the intention was to keep
Process::WillResume() and Process::DoResume() "in-sync", but this had the
unfortunate consequence of breaking Process sub-classes which don't override
WillResume().
The
lemo added a comment.
Ping? Are there any more open questions or unresolved comments or is this good
to be checked in?
Thanks!
https://reviews.llvm.org/D37923
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
lemo updated this revision to Diff 116074.
lemo added a comment.
1. Added SB APIs (SBCommandInterpreter::WasInterrupted()). This allows python
commands to query for interrupt requests.
2. I talked offline with Zach and decided that the line_iterator would require
more tinkering to get it to wor
lemo created this revision.
Herald added a subscriber: mgorny.
Neither LLDB_CONFIGURATION_DEBUG nor LLDB_CONFIGURATION_RELEASE were ever set
in the CMake LLDB project.
Also cleaned up a questionable #ifdef in SharingPtr.h, removing all the
references to LLDB_CONFIGURATION_BUILD_AND_INTEGRATION
lemo added a comment.
Good point, I wouldn't be surprised if that was the case at some point, but
right now the main llvm CMakeLists.txt has this:
...
if (NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)
message(STATUS "No build type selected, default to Debug")
set(CMAKE_BUILD_TYPE
lemo updated this revision to Diff 117704.
lemo added a comment.
Changed how CMAKE_BUILD_TYPE is tested to ensure we default to
LLDB_CONFIGURATION_DEBUG.
https://reviews.llvm.org/D38552
Files:
CMakeLists.txt
include/lldb/Utility/SharingPtr.h
Index: include/lldb/Utility/SharingPtr.h
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rL314929: LLDB cmake fix: define LLDB_CONFIGURATION_xxx based
on the build type (authored by lemo).
Changed prior to commit:
https://reviews.llvm.org/D38552?vs=117704&id=117730#toc
Repository:
rL LLVM
lemo updated this revision to Diff 117900.
lemo edited the summary of this revision.
lemo added a comment.
Updating the original changes to handle reentrant calls to
CommandInterpreter::IOHandlerInputComplete().
- This fixes bug #34758
- Also enhanced the existing test case for "command source"
This revision was automatically updated to reflect the committed changes.
Closed by commit rL315037: Implement interactive command interruption (authored
by lemo).
Changed prior to commit:
https://reviews.llvm.org/D37923?vs=117900&id=117936#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
lemo added inline comments.
Comment at: packages/Python/lldbsuite/test/dotest.py:56
+sys.exit(-1)
return os.path.isfile(fpath) and os.access(fpath, os.X_OK)
minor: can we print quotes around fpath? (this usually helps in messages to
avoid confusion
lemo added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:626
+// a series of namespaces.
+// FIXME: do this.
+CVSymbol global = m_index.ReadSymbolRecord(uid.asGlobalSym());
leftover comment?
lemo added a comment.
Looks good. A few questions/suggestions inline.
Comment at: lldb/trunk/source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:74
+ static_assert(sizeof(data) == 20, "");
+ // The textual module id encoding should be between 33 and 40 bytes long,
+ // de
lemo accepted this revision.
lemo added a comment.
This revision is now accepted and ready to land.
Looks good - the all-zero UUID case is a bit unfortunate but it seems we have
to handle it (like Greg suggested)
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.c
lemo accepted this revision.
lemo added a comment.
This revision is now accepted and ready to land.
The latest version looks good to me. Please update the description (it still
says it uses the one CU per symbols file)
Comment at: include/lldb/Core/FileSpecList.h:72
+ /// Mov
lemo accepted this revision.
lemo added a comment.
Looks good - a few comments inline.
Comment at: include/lldb/Core/Module.h:178
+module_sp->m_file = module_sp->m_objfile_sp->GetFileSpec();
+return std::move(module_sp);
}
nit: return std::move(x) is
101 - 130 of 130 matches
Mail list logo
