lemo accepted this revision.
lemo added a comment.
This revision is now accepted and ready to land.
Looks good - the all-zero UUID case is a bit unfortunate but it seems we have
to handle it (like Greg suggested)
================
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:69
+ llvm::StringRef chunk = str.take_front(hex_digits<T>());
+ uintmax_t t;
+ if (!to_integer(chunk, t, 16))
----------------
= 0; ?
================
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.h:48
class ModuleRecord : public Record {
public:
----------------
coding-convention-wise: should these definitions use struct instead of class?
================
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.h:59
-bool operator==(const ModuleRecord &L, const ModuleRecord &R);
+bool operator==(const ModuleRecord &L, const ModuleRecord &R) {
+ return L.OS == R.OS && L.Arch == R.Arch && L.ID == R.ID;
----------------
const method qualifier?
================
Comment at: source/Plugins/ObjectFile/Breakpad/BreakpadRecords.h:72
inline bool operator==(const InfoRecord &L, const InfoRecord &R) {
+ return L.ID == R.ID;
----------------
ditto
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57037/new/
https://reviews.llvm.org/D57037
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
