https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From 8e5e67ff640aa0ff14b1a0bd0110b88c539ccfe8 Mon Sep 17 00:00:00 2001
From: taalhaataahir0102 <23100...@lums.edu.pk>
Date: Wed, 11 Oct 2023 14:27:15 +0500
Subject: [PATCH 1/3] colorization
---
lldb/include/ll
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From a15d0cdc0330fe811ce65dc4d62374fd12304cef Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH] [lldb] colorize symbols in image lookup
https://github.com/junior-jl created
https://github.com/llvm/llvm-project/pull/73173
## Overview
This pull request addresses the issue
[#68035](https://github.com/llvm/llvm-project/issues/68035), where an
inconsistency in the order of "Process launched" and "Process stopped" messages
occurs
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH] [lldb] colorize symbols in image lookup
junior-jl wrote:
Hi @emaste, I've updated the commit message. When squashing the commits, the
commit message defaulted to the names of the previous commits. I've added a
brief description of the contribution – please let me know if this needs any
adjustments.
https://github.com/llvm/llvm-proj
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
junior-jl wrote:
> When you're doing these updates, remember that the PR's message is the one
> used for the final merge. You can update both if you like, but the PR message
> wins.
(for llvm-project that is, this is a per-repository setting)
I was Googling about this now. Thank you for the cl
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/73173
From e451fe7a466f90557c301f0775d65caaa8955a8c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Wed, 22 Nov 2023 18:26:14 -0300
Subject: [PATCH 1/2] [lldb] correct inconsistent order of
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -282,6 +280,8 @@ class CommandObjectProcessLaunch : public
CommandObjectProcessLaunchOrAttach {
exe_module_sp->GetFileSpec().GetPath().c_str(), archname);
}
result.SetStatus(eReturnStatusSuccessFinishResult);
+if (!data.empty())
---
@@ -265,8 +265,6 @@ class CommandObjectProcessLaunch : public
CommandObjectProcessLaunchOrAttach {
process_sp->SyncIOHandler(0, std::chrono::seconds(2));
llvm::StringRef data = stream.GetString();
junior-jl wrote:
Done! Yes, as you expected,
junior-jl wrote:
> I was about to tell you about the `process launch -m` shortcut, then I
> realised you added that yourself :) (I'm using it all the time now)
Haha, that's great to know! 🥹
> This is actually good news then, we already have test coverage. Please
> re-order the expected output
junior-jl wrote:
> Also could you include a bit more explanation of the problem in the commit
> message. The issue is great, but it'll save someone a few clicks if you just
> include a sentence or two more in the commit message.
I added more information. Now that you taught me that the PR desc
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
junior-jl wrote:
> Opinions differ on what goes in a commit message but this seems fine to me,
> I'd just remove the sub-headings. My usual rule is that folks can choose not
> to read it if they don't want to, include as much information as you would
> want to see if you yourself had to come b
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/2] [lldb] colorize symbols in image look
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/2] [lldb] colorize symbols in image look
@@ -1618,12 +1621,15 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
if (symbol->ValueIsAddress()) {
DumpAddress(
interpreter.GetExecutionContext().GetBestExecutionContextScope(),
- symbol->GetAddressRef(),
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/7] [lldb] colorize symbols in image look
@@ -246,8 +246,8 @@ class Address {
/// \see Address::DumpStyle
bool Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style,
DumpStyle fallback_style = DumpStyleInvalid,
-uint32_t addr_byte_size = UINT32_MAX,
-bool all_ranges =
@@ -1593,6 +1595,7 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
return 0;
SymbolContext sc;
+ bool use_color = interpreter.GetDebugger().GetUseColor();
junior-jl wrote:
Done.
https://github.com/llvm/llvm-project/pull/69422
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
@@ -246,8 +246,8 @@ class Address {
/// \see Address::DumpStyle
bool Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style,
DumpStyle fallback_style = DumpStyleInvalid,
-uint32_t addr_byte_size = UINT32_MAX,
-bool all_ranges =
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
@@ -231,6 +231,25 @@ class Stream {
/// The string to be output to the stream.
size_t PutCString(llvm::StringRef cstr);
+ /// Output a C string to the stream with color highlighting.
+ ///
+ /// Print a C string \a text to the stream, applying red color highlighting
@@ -246,8 +246,8 @@ class Address {
/// \see Address::DumpStyle
bool Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style,
DumpStyle fallback_style = DumpStyleInvalid,
-uint32_t addr_byte_size = UINT32_MAX,
-bool all_ranges =
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/8] [lldb] colorize symbols in image look
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text);
+return;
+
junior-jl wrote:
Addressed @JDevlieghere suggestions.
- A new debugger option was created for custom colors.
- The test needed some adaptation and we added a new case to test for other
color option.
- The `SymbolContext` situtation is working as discussed with David: no color
when there is no
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/9] [lldb] colorize symbols in image look
junior-jl wrote:
In the last commit:
- Added the conditions `prefix.empty()` and `suffix.empty()` to the 'no color'
path.
- Added missing arguments to `PutCStringColorHighlighted` call in
`SymbolContext` (line 177).
I had to copy the same statements from line 99 here. Is it better if I declar
junior-jl wrote:
> You could do:
s->PutCStringColorHighlighted(symbol->GetName().GetStringRef(), pattern,
target_sp ? target_sp->GetDebugger().GetRegexMatchAnsiPrefix() :
"",
target_sp ? target_sp->GetDebugger().GetRegexMatchAnsiSuffix() :
"");
I
junior-jl wrote:
> If the prefix and suffix are empty. Not prefix or suffix is empty.
I tried this now and I guess it's not correct. For example, if I have a prefix
(red color) and no suffix, the text does not go back to normal and will be
forever red. Or am I doing something wrong?
> Or rath
junior-jl wrote:
> I tried this now and I guess it's not correct. For example, if I have a
> prefix (red color) and no suffix, the text does not go back to normal and
> will be forever red. Or am I doing something wrong?
 and no suffix, the text does not go back to normal and
> > will be forever red. Or am I doing something wrong?
>
> This is expected. We don't expect many people to do this but if
https://github.com/junior-jl created
https://github.com/llvm/llvm-project/pull/76112
Follow-up to #69422.
This commit builds upon the previous contribution that introduced symbol
colorization in the image lookup command when using regex. In response to
feedback from reviewers, this follow-up
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/76112
From b2d254fabcaacb849ba48e342c62abf7ecd9779a Mon Sep 17 00:00:00 2001
From: taalhaataahir0102 <23100...@lums.edu.pk>
Date: Wed, 13 Dec 2023 15:12:29 +0500
Subject: [PATCH 1/5] Using struct for transfering patte
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/76112
From b2d254fabcaacb849ba48e342c62abf7ecd9779a Mon Sep 17 00:00:00 2001
From: taalhaataahir0102 <23100...@lums.edu.pk>
Date: Wed, 13 Dec 2023 15:12:29 +0500
Subject: [PATCH 1/6] Using struct for transfering patte
https://github.com/junior-jl created
https://github.com/llvm/llvm-project/pull/67019
## Description
This pull request adds a new `start` command to LLDB, allowing users to launch
a process and pause execution at either the `main` function or the first
instruction.
## Motivation
The `start` co
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 21 Sep 2023 11:12:58 -0300
Subject: [PATCH 1/2] [lldb] add command start
---
lldb/
junior-jl wrote:
Thank you for the explanation here and in Discourse. I added the option
`stop-at-main` to `process launch`.
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
junior-jl wrote:
This might be a dumb question, but I committed the implementation as an option
as the second commit thinking you would/could discard my first commit. Is that
possible? What would be the best way to correct this?
https://github.com/llvm/llvm-project/pull/67019
_
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl unresolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 21 Sep 2023 11:12:58 -0300
Subject: [PATCH 1/3] [lldb] add command start
---
lldb/
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 21 Sep 2023 11:12:58 -0300
Subject: [PATCH 1/4] [lldb] add command start
---
lldb/
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntry);
break;
-
+ case 'm': // Stop at main function
+ {
+TargetSP target_sp =
+execution_context
junior-jl wrote:
Thank you @bulbazord & @clayborg for the step-by-step, it was really helpful. I
reverted the first commit, removed the shell modification you mentioned and the
created breakpoint is now one-shot, @jimingham.
https://github.com/llvm/llvm-project/pull/67019
_
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntry);
break;
-
+ case 'm': // Stop at main function
+ {
+TargetSP target_sp =
+execution_context
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntry);
break;
-
+ case 'm': // Stop at main function
+ {
+TargetSP target_sp =
+execution_context
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntry);
break;
-
+ case 'm': // Stop at main function
+ {
+TargetSP target_sp =
+execution_context
@@ -675,6 +675,8 @@ let Command = "platform shell" in {
let Command = "process launch" in {
def process_launch_stop_at_entry : Option<"stop-at-entry", "s">,
Desc<"Stop at the entry point of the program when launching a process.">;
+ def process_launch_stop_at_main : Opti
@@ -38,7 +38,18 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntry);
break;
-
+ case 'm': // Stop at main function
+ {
+TargetSP target_sp =
+execution_context
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 21 Sep 2023 11:12:58 -0300
Subject: [PATCH 1/5] [lldb] add command start
---
lldb/
junior-jl wrote:
This is the case in the current commit. I was trying to implement this with
SmallSet and const char* to use the overload you mentioned, Jim, but I was
having trouble with it, specially because I needed to hard code a 'max number
of languages'. So I used the overload that takes
junior-jl wrote:
Also, I just noticed that `clang-format` did some minor changes to
`Language.h`. Please, let me know if I need to revert those.
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 21 Sep 2023 11:12:58 -0300
Subject: [PATCH 1/6] [lldb] add command start
---
lldb/
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 21 Sep 2023 11:12:58 -0300
Subject: [PATCH 1/7] [lldb] add command start
---
lldb/
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,7 +39,36 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntry);
break;
-
+ case 'm': // Stop at user entry point
+ {
+TargetSP target_sp =
+execution_cont
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
junior-jl wrote:
What are your thoughts on creating an alias for `process launch
--stop-at-user-entry` such as the intended `start` (or `begin`, or even `run
-m`).
Also, if I wanted to do that, the only change would be an `AddAlias` in
`CommandInterpreter.cpp`? Or there's something else?
ht
junior-jl wrote:
I understand, thank you, Jim.
Is there anything else I should change in this PR?
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
@@ -38,7 +39,37 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntry);
break;
-
+ case 'm': // Stop at user entry point
+ {
+TargetSP target_sp =
+execution_cont
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 21 Sep 2023 11:12:58 -0300
Subject: [PATCH 1/8] [lldb] add command start
---
lldb/
junior-jl wrote:
In this last commit, I changed the comments style and used @Michael137
suggestion by declaring a `llvm::SetVector` instead of a temporary `std::set`.
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-c
@@ -38,7 +39,37 @@ Status CommandOptionsProcessLaunch::SetOptionValue(
case 's': // Stop at program entry point
launch_info.GetFlags().Set(eLaunchFlagStopAtEntry);
break;
-
+ case 'm': // Stop at user entry point
+ {
+TargetSP target_sp =
+execution_cont
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
junior-jl wrote:
Hi, @medismailben. I changed the code with your suggestions. Can you take a
look if the early exits are correct before I commit, please?
```cpp
case 'm': // Stop at user entry point
{
TargetSP target_sp =
execution_context ? execution_context->GetTargetSP() : Targ
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 11270775865a8415e00b4d899703f84717344967 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 21 Sep 2023 11:12:58 -0300
Subject: [PATCH 1/9] [lldb] add command start
---
lldb/
https://github.com/junior-jl resolved
https://github.com/llvm/llvm-project/pull/67019
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/67019
From 9130096419bd3211af0163ec28ba9471de398d47 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 21 Sep 2023 11:12:58 -0300
Subject: [PATCH 1/9] [lldb] add command start
---
lldb/
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/76112
From fb2383f3e6e2124e4f14e8e0f6a04df4bed15f65 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Thu, 18 Jan 2024 20:03:25 -0300
Subject: [PATCH] refactor PutCStringColorHighlight | add
@@ -23,6 +23,16 @@
namespace lldb_private {
+struct Information {
junior-jl wrote:
Done.
I was thinking: should we add a default constructor?
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits maili
@@ -1609,6 +1612,11 @@ static uint32_t LookupSymbolInModule(CommandInterpreter
&interpreter,
}
if (num_matches > 0) {
+llvm::StringRef ansi_prefix =
+interpreter.GetDebugger().GetRegexMatchAnsiPrefix();
+llvm::StringRef ansi_suffix =
+interpreter.G
@@ -262,14 +263,12 @@ void Symbol::GetDescription(Stream *s,
lldb::DescriptionLevel level,
}
if (ConstString demangled = m_mangled.GetDemangledName()) {
s->PutCString(", name=\"");
-s->PutCStringColorHighlighted(demangled.GetStringRef(), pattern,
-
@@ -72,23 +72,21 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
-void Stream::PutCStringColorHighlighted(llvm::StringRef text,
-llvm::StringRef pattern,
-llvm::String
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/76112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 163 matches
Mail list logo
