================
@@ -246,8 +246,8 @@ class Address {
/// \see Address::DumpStyle
bool Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style,
DumpStyle fallback_style = DumpStyleInvalid,
- uint32_t addr_byte_size = UINT32_MAX,
- bool all_ranges = false) const;
+ uint32_t addr_byte_size = UINT32_MAX, bool all_ranges = false,
+ const char *pattern = nullptr) const;
----------------
junior-jl wrote:
> Tbf I had to look up nullopt, I don't see it much.
I search this as well. Actually, I never used `std::optional` before.
> Can you post the error message(s)? Don't need to update the PR, just describe
> how you're constructing and passing it, that'll likely be enough.
Okay. I'll update the PR with the recent changes and will try to replicate the
error and post here.
> It may be caused by this https://godbolt.org/z/414Kzd18Y because llvm::Regex
> deletes the copy constructor. This is I think because it contains state about
> the matching. I think I should be able to move an llvm::Regex though but I
> haven't been able to get that to work either.
This is interesting. I believe this is similar to the error we were getting.
https://github.com/llvm/llvm-project/pull/69422
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
