[Lldb-commits] [PATCH] D121305: [lldb/gdb-remote] Remove ancient debugserver workaround

JDevlieghere added a comment. In D121305#3370357 , @labath wrote: > In D121305#3370337 , @JDevlieghere > wrote: > >> Assuming this isn't relevant anymore > > I was hoping you would be able to tell me that. :P Ha

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1624 + if (!m_broadcaster.EventTypeHasListeners(Debugger::eBroadcastBitProgress)) { +listener_sp->StartListeningForEvents(&m_broadcaster, labath wrote: > labath wrote: > > Why is

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere added a comment. To summarize: I will remove the check because this doesn't matter for VSCode/Xcode because they don't use the default event loop and for those clients who might care about this, they should use the setting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D121316: [lldb/Plugin] Test that a scripted process blueprint can be loaded for the dSYM

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121316/new/ https://reviews.llvm.org/D121316 ___

[Lldb-commits] [PATCH] D121348: Don't try to get memory returns for ABIMacOSX_arm64

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGMT with the SysV ABI updated as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121348/new/ https://reviews.llvm.org/D121348

[Lldb-commits] [PATCH] D121442: [lldb] Don't overwrite the host arch (from qHostInfo) with the process arch (from qProcessInfo)

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, labath, mgorny. Herald added a project: All. JDevlieghere requested review of this revision. Don't overwrite the host architecture (obtained from qHostInfo in GDBRemoteCommunicationClient::GetHostInfo) with the proces

[Lldb-commits] [PATCH] D121443: [lldb] Add a getter for the process' system architecture

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, labath, jingham. Herald added a project: All. JDevlieghere requested review of this revision. This patch adds a getter for the process' system architecture. I went with `Process::GetSystemArchitecture` to match `Platf

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, friss, labath. Herald added a project: All. JDevlieghere requested review of this revision. This patch is another attempt to fix platform selection on Apple Silicon. It partially undoes D117340

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere updated this revision to Diff 414590. JDevlieghere added a comment. Include TargetConditionals.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h lldb/source/Plugins/P

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere added a comment. In D121444#3374854 , @labath wrote: >> I wish I could make this distinction in the platform, but you need a >> connected process to do this. > > Basically, what you're saying is that the ArchSpec alone is not sufficient to

[Lldb-commits] [PATCH] D121443: [lldb] Add a getter for the process' system architecture

JDevlieghere updated this revision to Diff 414678. JDevlieghere added a comment. - Only return the host architecture in NativeProcessWindows CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121443/new/ https://reviews.llvm.org/D121443 Files: lldb/include/lldb/Target/Process.h lldb/sou

[Lldb-commits] [PATCH] D121442: [lldb] Don't overwrite the host arch (from qHostInfo) with the process arch (from qProcessInfo)

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ef07e5ffe59: [lldb] Don't overwrite the host arch with the process arch (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D121443: [lldb] Add a getter for the process' system architecture

JDevlieghere updated this revision to Diff 414702. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121443/new/ https://reviews.llvm.org/D121443 Files: lldb/include/lldb/Target/Process.h lldb/source/Plugins/Process/Windows/Common/ProcessWin

[Lldb-commits] [PATCH] D121443: [lldb] Add a getter for the process' system architecture

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp:236 +ArchSpec NativeProcessWindows::GetSystemArchitecture() override; +return HostInfo::GetArchitecture(); +} tschuett wrote: > two spaces? I thin

[Lldb-commits] [PATCH] D121443: [lldb] Add a getter for the process' system architecture

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68099b1d5c2c: [lldb] Add a getter for the process' system architecture (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LL

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere added a comment. In D121444#3375701 , @labath wrote: > In D121444#3375445 , @JDevlieghere > wrote: > >> In D121444#3374854 , @labath wrote: >> I wish I

[Lldb-commits] [PATCH] D121484: [lldb] Plumb host architecture through platform selection

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a subscriber: emaste. Herald added a project: All. JDevlieghere requested review of this revision. Plumb host architecture through platform selection in preparation for D121444

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere updated this revision to Diff 414722. JDevlieghere added a comment. Check the host architecture in PlatformMacOSX CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 Files: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp In

[Lldb-commits] [PATCH] D121480: [lldb] Move Module::FindTypes scoped timer to SymbolFileDWARFDebugMap

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121480/new/ https://reviews.llvm.org/D121480 ___

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham. Herald added a subscriber: kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. This patch introduces a small utility called `LockableStream` to protect the debugger's output

[Lldb-commits] [PATCH] D121348: Don't try to get memory returns for ABIMacOSX_arm64

JDevlieghere added inline comments. Comment at: lldb/source/API/SBTarget.cpp:1596-1597 + if (target_sp) { +std::string abi_name(target_sp->GetABIName().str()); +ConstString const_name(abi_name.c_str()); +return const_name.GetCString(); I think `Const

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

JDevlieghere updated this revision to Diff 414775. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. Rename utility class to `ThreadSafeStream`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121500/new/ https://reviews.llvm.org/D121500 Files: lldb/includ

[Lldb-commits] [PATCH] D121502: [lldb] Use the debugger's output stream for writing in HandleProgressEvent

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Use the (thread safe) output stream to write progress events to the debugger's output. https://reviews.llvm.org/D121502 Files: lldb/

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

JDevlieghere added a comment. In D121500#3376497 , @jingham wrote: > LGTM. It might be worthwhile to audit the uses of Debugger::GetErrorFile & > GetOutputFile to see which of them really should also be using the lockable > stream instead. That would

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, labath, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Report warnings and errors through events instead of printing directly the to the debugger's error stream. Diagnostic events ar

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 414801. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp lldb/source/Core/DebuggerEv

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

JDevlieghere added a comment. In D121500#3377321 , @labath wrote: > Are you sure we don't want to handle this at a higher level? The way I > understand it, the main reason for the existence of PrintAsync and > StreamAsynchronousIO machinery is to provid

[Lldb-commits] [PATCH] D121502: [lldb] Use the debugger's asynchronous output stream for writing progress events.

JDevlieghere updated this revision to Diff 414883. JDevlieghere retitled this revision from "[lldb] Use the debugger's output stream for writing in HandleProgressEvent" to "[lldb] Use the debugger's asynchronous output stream for writing progress events.". JDevlieghere edited the summary of this

[Lldb-commits] [PATCH] D121536: [lldb] Use the IOHandler's output/error stream instead of the debugger one in PrintAsync

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. I was looking into PrintAsync because Pavel brought it up in D121500 . The whole point seems to be to

[Lldb-commits] [PATCH] D121537: [lldb] Synchronize the output through the IOHandler

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a project: All. JDevlieghere requested review of this revision. Alternative to D121500 that does the locking at the IOHandler level. https://reviews.llvm.org/D121537 Files

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

JDevlieghere added a comment. In D121500#3377434 , @JDevlieghere wrote: > In D121500#3377321 , @labath wrote: > >> Are you sure we don't want to handle this at a higher level? The way I >> understand it, the mai

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 414899. JDevlieghere added a comment. Use the asynchronous error stream CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEven

[Lldb-commits] [PATCH] D121484: [lldb] Plumb host architecture through platform selection

JDevlieghere added a comment. In D121484#3378923 , @labath wrote: > I'm not sure what would be a good way to denote that the new argument > represents the architecture of the host running the debugged process, and not > the one running lldb. This isn't

[Lldb-commits] [PATCH] D121506: [lldb] Move ProgressEventData out of debugger and into its own file (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e65e79bace6: [lldb] Move ProgressEventData out of debugger and into its own file (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG

[Lldb-commits] [PATCH] D121484: [lldb] Plumb host architecture through platform selection

JDevlieghere added a comment. In D121484#3379564 , @labath wrote: > In D121484#3379532 , @JDevlieghere > wrote: > >> In D121484#3378923 , @labath wrote: >> >>> I'm not su

[Lldb-commits] [PATCH] D121536: [lldb] Use the IOHandler's output/error stream instead of the debugger one in PrintAsync

This revision was automatically updated to reflect the committed changes. Closed by commit rG2436c5703e6a: [lldb] Use the IOHandler's stream instead of the debugger's in PrintAsync (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D121502: [lldb] Use the debugger's asynchronous output stream for writing progress events.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc231deb79167: [lldb] Use the debugger's asynchronous output stream for progress events. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D121484: [lldb] Plumb host architecture through platform selection

This revision was automatically updated to reflect the committed changes. Closed by commit rGdde487e54782: [lldb] Plumb process host architecture through platform selection (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D121484?vs=414

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere updated this revision to Diff 415204. JDevlieghere added a comment. Herald added a subscriber: mgorny. Add tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 Files: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp lld

[Lldb-commits] [PATCH] D121605: [lldb/test] Make category-skipping logic "platform"-independent

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/packages/Python/lldbsuite/test/lldbplatformutil.py:125 def getPlatform(): """Returns the target platform which the tests are running

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere updated this revision to Diff 415211. JDevlieghere added a comment. Fix typo(s) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 Files: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp lldb/test/API/functionalities/gdb_re

[Lldb-commits] [PATCH] D121537: [lldb] Synchronize the output through the IOHandler

JDevlieghere updated this revision to Diff 415270. JDevlieghere added a comment. Use the IOHandler's mutex in editline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121537/new/ https://reviews.llvm.org/D121537 Files: lldb/include/lldb/Core/IOHandler.h lldb/include/lldb/Host/Editlin

[Lldb-commits] [PATCH] D121537: [lldb] Synchronize the output through the IOHandler

JDevlieghere updated this revision to Diff 415272. JDevlieghere added a comment. Update unit test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121537/new/ https://reviews.llvm.org/D121537 Files: lldb/include/lldb/Core/IOHandler.h lldb/include/lldb/Host/Editline.h lldb/include/ll

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415283. JDevlieghere added a comment. Address code review: - Decentralize tracking whether a warning/error has been emitted. - Support diagnostics that are not tied to a single debugger. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

JDevlieghere updated this revision to Diff 415284. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp lldb/source/Core/DebuggerEv

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc22c7a61b6d9: [lldb] Fix platform selection on Apple Silicon (again) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to comm

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

JDevlieghere added inline comments. Comment at: lldb/source/Core/Module.cpp:1187 + +Debugger::ReportError(std::string(strm.GetString())); + } mib wrote: > mib wrote: > > It's unrelated to this patch, but it looks like > > `Debugger::HandleDiagnosticEvent` d

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere added a comment. In D128321#3606172 , @clayborg wrote: > So it seems like we are catering to our code organization here instead of > doing the right thing and relying on the host layer. I would rather move the > log code into the host layer

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

JDevlieghere marked 6 inline comments as done. JDevlieghere added a subscriber: jingham. JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectLog.cpp:26 +static constexpr OptionEnumValueElement g_log_handler_type[] = { +{ claybo

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

JDevlieghere updated this revision to Diff 439575. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128323/new/ https://reviews.llvm.org/D128323 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/lldb-enumerations.h lldb/include/l

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

JDevlieghere added a comment. In D128480#3606598 , @clayborg wrote: > I don't have anything against this, though I still think the LogHandlers > should use the Host layer by making the LogHandler objects into real LLDB > plug-ins. But if everyone else f

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

JDevlieghere updated this revision to Diff 439577. JDevlieghere added a comment. Remove spurious "error:" strings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128480/new/ https://reviews.llvm.org/D128480 Files: lldb/include/lldb/Host/Host.h lldb/source/Core/Module.cpp lldb/sour

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere updated this revision to Diff 439583. JDevlieghere added a comment. - Move SystemLogHandler into Host - Create a new SystemLog helper function CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128321/new/ https://reviews.llvm.org/D128321 Files: lldb/include/lldb/Host/Host.h

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

JDevlieghere added a comment. In D128480#3606632 , @JDevlieghere wrote: > In D128480#3606598 , @clayborg > wrote: > >> I don't have anything against this, though I still think the LogHandlers >> should use the

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere updated this revision to Diff 439588. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128321/new/ https://reviews.llvm.org/D128321 Files: lldb/include/lldb/Host/Host.h lldb/source/Host/common/Host.cpp lldb/source/Host/macosx/objcxx/Host.mm Index: lldb/source/Host/macos

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Host/common/Host.cpp:110 +#if !defined(__APPLE__) +void Host::SystemLog(const std::string &message) { + fprintf(stderr, "%s", message.c_str()); labath wrot

[Lldb-commits] [PATCH] D128480: [lldb] Replace Host::SystemLog with Debugger::Report{Error, Warning}

This revision was automatically updated to reflect the committed changes. Closed by commit rG6879391908ca: [lldb] Replace Host::SystemLog with Debugger::Report{Error,Warning} (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D128480?vs=4

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In D128321#3607935 , @labath wrote: > In D128321#3605592 , @JDevlieghere > wrote: > >> I also considered that, but that just delays the

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

JDevlieghere added a comment. @labath Any chance I can nerd-snipe you into adding support for syslog (or whatever the modern equivalent is) on linux? :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128321/new/ https://reviews.llvm.org/D128321

[Lldb-commits] [PATCH] D128321: [lldb] Add OSLog log handler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e5d5261e2b6: [lldb] Add SystemLogHandler for emitting log messages to the system log (authored by JDevlieghere). Herald added a project: LLDB. Chan

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

JDevlieghere updated this revision to Diff 439866. JDevlieghere added a comment. Add `eLogHandlerDefault = eLogHandlerStream`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128323/new/ https://reviews.llvm.org/D128323 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/lldb-

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

JDevlieghere updated this revision to Diff 439874. JDevlieghere added a comment. Improve help and error message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128323/new/ https://reviews.llvm.org/D128323 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/lldb-enumerations.h

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mib, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Add a log dump command to dump the circular log buffer. This also adds a test for the circular log handler. https://reviews.llvm.

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Thanks for pointing that out. I blindly copied the categories logic from `Log::Disable` which uses it when computing the flags. I've omitted it for now because I think it would be weird to set the circular buffer size t

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

JDevlieghere updated this revision to Diff 439921. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128557/new/ https://reviews.llvm.org/D128557 Files: lldb/include/lldb/Host/Host.h lldb/include/lldb/Utility/Log.h lldb/source/Commands/CommandObjectLog.cpp lldb/source/Commands/Option

[Lldb-commits] [PATCH] D128323: [lldb] Add support for specifying a log handler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe265d25ca5e: [lldb] Add support for specifying a log handler (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

JDevlieghere updated this revision to Diff 440271. JDevlieghere added a comment. Print error message when dumping is not supported. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128557/new/ https://reviews.llvm.org/D128557 Files: lldb/include/lldb/Host/Host.h lldb/include/lldb/Util

[Lldb-commits] [PATCH] D128557: [lldb] Add a log dump command to dump the circular log buffer

This revision was automatically updated to reflect the committed changes. Closed by commit rG9bdb7e573427: [lldb] Add a log dump command (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128557/ne

[Lldb-commits] [PATCH] D127684: [NFC] Use `https` instead of `http` in the `LLVM.org` URLs

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. +1 on breaking this down per sub-project and creating separate patches for review. I sampled the patch and about a quarter or so of the links I tried didn't work, even b

[Lldb-commits] [PATCH] D128694: [lldb/Dataformatters] Adapt C++ std::string dataformatter for D128285

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I agree with Adrian that we should try to support both the old and new layout. Is there a way we can fall back? I think it's fine to land the patch as is to unblock the bots and ad

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

JDevlieghere added a comment. The fix looks good but I'm torn about the added logging. On the one hand it'll make finding issues like this easier in the future, but on the other hand, while this code isn't "hot", it is something where performance matters. My concern is that this will potentiall

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1839-1855 +if (log && log->GetVerbose()) { + if (data->IsFinite()) +LLDB_LOGF(log, + "%p Debugger('%llu')::HandleProgressEvent " + "(m_current_event_id

[Lldb-commits] [PATCH] D124155: [lldb] Add tests which simulate the various std::string layouts

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124155/new/ https://reviews.llvm.org/D124155 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

JDevlieghere added inline comments. Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:1186-1191 + // dyld doesn't think there is a binary at this address, + // but maybe there isn't a binary YET - let's look in memory + // for a proper mach-o header e

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1840-1841 return; -if (data->GetCompleted()) - m_current_event_id.reset(); } else { We should still reset the `m_current_event_id` here, otherwise we can get out of

[Lldb-commits] [PATCH] D128768: [lldb/Core] Fix finite progress event reporting

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128768/new/ https://reviews.llvm.org/D128768 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere created this revision. JDevlieghere added reviewers: labath, dblaikie, clayborg, aprantl, mib. Herald added a project: All. JDevlieghere requested review of this revision. Make sure we use the libc++ from the build dir. Currently, by passing `-stdlib=libc++`, we might pick up the sys

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere added a comment. In D129166#3632597 , @labath wrote: > I'm afraid this will not work on systems which do not default to libc++ > (which includes at least linux and windows), because `-stdlib=libc++` is not > "equivalent" to `-nostdlib++ -lc

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere added a comment. In D129166#3633243 , @labath wrote: > In D129166#3633116 , @JDevlieghere > wrote: > >> Thanks for the thoughtful reply Pavel. The remote tests are something we >> care about as well

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere updated this revision to Diff 442635. JDevlieghere added a comment. Herald added a subscriber: mgorny. I still have to test different configurations, but putting it up here for feedback about the general direction. This doesn't account yet for remote runs. Should be easy to detect b

[Lldb-commits] [PATCH] D111978: [lldb] Improve the error message in run_to_breakpoint_do_run

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGec48a0df9151: [lldb] Improve the error message in run_to_breakpoint_do_run (authored by JDevlieghere). Herald added a subscriber: lldb-commits. Changed prior

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

JDevlieghere updated this revision to Diff 442994. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129166/new/ https://reviews.llvm.org/D129166 Files: lldb/packages/Python/lldbsuite/test/builders/builder.py lldb/packages/Python/lldbsuite/test/configuration.py lldb/packages/Python/lld

[Lldb-commits] [PATCH] D129261: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, assuming this isn't already covered (I couldn't immediately find a test that covers string literals) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:749 +static bool mach_header_validity_test (uint32_t magic, uint32_t cputype) { + if (magic != MH_MAGIC && magic != MH_CIGAM && magic != MH

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

JDevlieghere added a comment. I went ahead and reverted your change to turn the bot green again: commit e4c5bca597a6f12e8f789a53e862387b9808ff48 (HEAD -> main, origin/main, origin/HEAD) Author: Jonas Devlieghere Date: Thu Jul 7 16:28:35 2022 -0700 Revert "[LLDB][NFC] Decouple d

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

JDevlieghere added a comment. This is breaking a bunch of tests on GreenDragon: lldb-api.functionalities/location-list-lookup.TestLocationListLookup.py lldb-api.functionalities/param_entry_vals/basic_entry_values.TestBasicEntryValues.py lldb-api.functionalities/return-value.TestReturnValue

[Lldb-commits] [PATCH] D129490: [lldb/libc++] Simplify the libc++ string formatter

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129490/new/ https://reviews.llvm.org/D129490 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D129456: [lldb] Add image dump pcm-info command

JDevlieghere added a comment. [bikeshedding] `pcm-info` seems a little odd. Do we have other command that end with `-info`? `target modules dump` already sounds like you're about to dump some kind of "info". What about just `pcm`? [/bikeshedding] Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D129166: [lldb] Make sure we use the libc++ from the build dir

This revision was automatically updated to reflect the committed changes. Closed by commit rGce233e714665: [lldb] Use the just-built libc++ for testing the LLDB data formatters (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D129166?vs

[Lldb-commits] [PATCH] D104635: [lldb] Add support for escaping fish arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bc34636a50f: [lldb] Add support for escaping fish arguments (authored by teemperor, committed by JDevlieghere). Herald added a subscriber: lldb-comm

[Lldb-commits] [PATCH] D129529: [lldb] Make the g_arguments_data constexpr and fix the static assert

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. This fixes the static assert that's meant to keep the g_arguments_data table in sync with the CommandArgumentType enumeration. Indeed, the asser

[Lldb-commits] [PATCH] D129490: [lldb/libc++] Simplify the libc++ string formatter

JDevlieghere added a comment. Looks like this broke GreenDragon: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45284/testReport/junit/lldb-api/functionalities_data-formatter_data-formatter-stl_libcxx_string/TestDataFormatterLibcxxString_py/ Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D129529: [lldb] Make the g_arguments_data constexpr and fix the static assert

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb620852d2350: [lldb] Make the g_arguments_data constexpr and fix the static assert (authored by JDevlieghere). Herald adde

[Lldb-commits] [PATCH] D129528: Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo.

JDevlieghere added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/variables/TestVSCode_variables.py:493-498 +if arch == 'x86_64': +pc_name = 'rip' +elif arch == 'x86': +pc_name = 'rip' +elif arch.startswith('arm'): +

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere added a comment. The review shows the diff with the previous iteration of the patch. Can you generate a diff with the current top-of-tree? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129377/new/ https://reviews.llvm.org/D129377 ___

[Lldb-commits] [PATCH] D129603: [lldb/crashlog] Fix interactive crashlog test

JDevlieghere added a comment. Can we use obj2yaml / yaml2obj for the binary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129603/new/ https://reviews.llvm.org/D129603 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:4-5 + set (PBM_PREFIX clang_protobuf_mutator) +elseif(${CMAKE_CURRENT_SOURCE_DIR} MATCHES "lldb") + set (PBM_PREFIX lldb_protobuf_mutator) +endif() cassanova wrote: > mib

[Lldb-commits] [PATCH] D129239: [trace] Add an option to save a compact trace bundle

JDevlieghere added inline comments. Comment at: lldb/source/Commands/CommandObjectProcess.cpp:582 } - + Target *target = m_exe_ctx.GetTargetPtr(); wallace wrote: > many formatting changes sneaked in. The actual changes are in the end of this

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

JDevlieghere added a comment. This breaks all the LLDB tests that import the std module: import-std-module/array.TestArrayFromStdModule.py import-std-module/deque-basic.TestDequeFromStdModule.py import-std-module/deque-dbg-info-content.TestDbgInfoContentDequeFromStdModule.py import-std-m

<    6   7   8   9   10   11   12   13   14   15   >